New issue
Advanced search Search tips

Issue 833411 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug



Sign in to add a comment

test_installer fails in win/asan builds

Project Member Reported by thakis@chromium.org, Apr 16 2018

Issue description

I added test_installer to the clang tot waterfall in https://chromium-review.googlesource.com/c/987913/

It fails on CrWinASan after 40 minutes without any output:

https://ci.chromium.org/buildbot/chromium.clang/CrWinAsan/455

I'll disable the test again on the asan bots, but maybe interesting to have a bug for this not working.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/5b8ece0ca2534f87fe5527f6ba5ce2c2d9969381

commit 5b8ece0ca2534f87fe5527f6ba5ce2c2d9969381
Author: Nico Weber <thakis@chromium.org>
Date: Mon Apr 16 16:12:31 2018

Remove test_installer from win/asan bots again.

They don't pass there, see first bug below.

Bug: 833411, 827082 
Change-Id: Ic0acb2c9c67b7c3d6d8019f6467418f2fe31d555
Reviewed-on: https://chromium-review.googlesource.com/1014025
Reviewed-by: Hans Wennborg <hans@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>

[modify] https://crrev.com/5b8ece0ca2534f87fe5527f6ba5ce2c2d9969381/scripts/slave/recipe_modules/chromium_tests/chromium_clang.py

Comment 2 by grt@chromium.org, Apr 18 2018

Owner: mmeade@chromium.org
Status: Assigned (was: Untriaged)
Assigning to mmeade@, who is actively working on the test these days.

Comment 3 by mmeade@chromium.org, Apr 18 2018

Owner: thakis@chromium.org
I see these in the logs:

[0414/040923:test_installer.py(450)] Config found at C:\b\c\b\CrWinAsan\src\chrome\test\mini_installer\config\config.config
[0414/040923:test_installer.py(509)] Setting --force-clean
ChromeUserLevel: no_pv -> install_chrome_user -> chrome_user_installed_not_inuse -> test_chrome_with_chromedriver_user -> chrome_user_installed_not_inuse -> uninstall_chrome_user -> clean
 ... [0414/040924:test_installer.py(136)] Verifying state no_pv
[0414/040924:test_installer.py(103)] Beginning action install_chrome_user

command timed out: 2400 seconds without output, attempting to kill

So it looks like the install step hung. There isn't any output from the test after the install step. The timeout error came from the runner. 

Unfortunately the test itself can't grab logs when it is killed. Any ideas why it would hang after 40 minutes of testing? Is there a difference in terms of the intstaller with the asan runs?

Comment 4 by mmeade@chromium.org, Apr 18 2018

I would like to leave this bug open as a tracking bug since it already has all of the info.

Comment 5 by mmeade@chromium.org, Apr 18 2018

 crbug.com/33407  is about the installer growing too large for 7z to zip up next_version_mini_installer. This one has already gotten past that point, but it seems there is something on asan that is causing these issues. 

Greg noted that it looks like either the binary grew, or just started running. 

Does anyone know if this target was running on asan before Nico enabled it?

Comment 6 by grt@chromium.org, Apr 18 2018

I don't think the two issues are the same. Is there a way to pull the built files off of somewhere? If not, you could try building locally with the same GN args to see if you can repro. From the generate_build_files step:

clang_use_chrome_plugins = false
enable_ipc_fuzzer = true
is_asan = true
is_clang = true
is_component_build = false
is_debug = false
llvm_force_head_revision = true
symbol_level = 2
target_cpu = "x86"
v8_enable_verify_heap = true

Sign in to add a comment