New issue
Advanced search Search tips

Issue 833407 link

Starred by 1 user
Status: Fixed
Owner:
thakis@chromium.org
Closed: Apr 2018
Cc:
grt@chromium.org
robertshield@chromium.org
gab@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug



Sign in to add a comment

next_version_mini_installer.exe fails on component and coverage asan bots

Project Member Reported by thakis@chromium.org, Apr 16 2018 
[0416/053407.078:ERROR:resource_updater.cc(51)] UpdateResource failed for resource "CHROME.7Z" of size 1412990790 bytes: Not enough storage is available to process this command. (0x8)
[0416/053407.079:ERROR:alternate_version_generator.cc(714)] It is common for this step to fail for very large resources, as is the case for Debug component=shared_library builds. Try with a Release or component=static_library build.



Started here:

https://ci.chromium.org/buildbot/chromium.clang/CrWinAsan%28dll%29/488
https://ci.chromium.org/buildbot/chromium.clang/CrWinAsanCov/429


Not obvious to me what triggered this. Just organic size growth? Maybe we used to not build that target? (But the bots are supposed to build all targets always, so probably not that.)


The regular asan bot is happy from a compile PoV: https://ci.chromium.org/buildbot/chromium.clang/CrWinAsan/

Comment 1 by grt@chromium.org, Apr 18 2018

Owner: mmeade@chromium.org
Status: Assigned (was: Untriaged)
Yeah, either it just recently grew too big, or we just started building it for some reason. Logdog won't show me the logs for some reason, so I can't see differences between the good and bad runs.

Quick fix would be to exclude this config in BUILD.gn and chrome/installer/mini_installer/BUILD.gn as is currently done for x86 component debug builds.

Comment 2 by mmeade@chromium.org, Apr 18 2018 

Is this a dup of crbug.com/833411?

Comment 3 by mmeade@chromium.org, Apr 18 2018 

That one is specifically referencing asan as well. It does look different, but I wonder if there is a common issue.

Comment 4 by mmeade@chromium.org, Apr 18 2018 

FYI next_version_mini_installer is being replaced with previous_version_mini_installer, but I wouldn't expect that to make a difference.

Comment 5 by grt@chromium.org, Apr 18 2018 

I don't think they're related. I think the issue here is purely that there isn't enough address space in these 32-bit builds for the resource editing to work.

Comment 6 by mmeade@chromium.org, Apr 24 2018

Owner: thakis@chromium.org
Status: Fixed (was: Assigned)
2 things here - 1) next_version_mini_installer has been replaced with previous_version_mini_installer, and 2) I think it was turned off on asan. I took a look at the most recent runs and they are not failing on this test.

Nico, can you verify?

Comment 7 by thakis@chromium.org, Apr 24 2018 

https://ci.chromium.org/buildbot/chromium.clang/CrWinAsanCov/470
https://ci.chromium.org/buildbot/chromium.clang/CrWinAsan%28dll%29/539

were the first builds where it didn't fail to compile. I don't see the prev_version_mini_installer or the asan change in there, so I can confirm it works now, but I don't know what changed to make it work.
►

Sign in to add a comment