Status bar brand-coloring doesn't match toolbar brand-coloring after transition from CCT to Opened-in-Chrome normal tab |
|||||||
Issue descriptionChrome Version: (copy from chrome://version) Android. Canary 67.0.3396.3 What steps will reproduce the problem? (1) in a normal tab, open a site with a theme color, observe status bar matching toolbar (ex: linkedin) (2) from a CCT viewing a site with a theme color (ex: medium) use the open-in-chrome menu option What is the expected result? - the status bar updates to match the toolbar brand-color/theme-color What happens instead? - the status bar keeps the color from the previously focused tab (though the toolbar updates correctly) https://screenshot.googleplex.com/QF3LOwyKgwN.png
,
Apr 27 2018
,
May 4 2018
,
Sep 17
,
Dec 6
,
Dec 19
,
Dec 20
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/34fd8835bba5d93b0cd369bd35b0e93047125fd2 commit 34fd8835bba5d93b0cd369bd35b0e93047125fd2 Author: Peter E Conn <peconn@chromium.org> Date: Thu Dec 20 16:55:42 2018 🎨 Update color when Tab is attached to new Activity. Cause TabThemeHelper#onActivityAttachmentChanged to notify listeners of a theme color change - this is so that the Tab's new Activity is notified of the Tab's theme color. Additionally, this requires adding the Tab to the TabModel slightly earlier (before the Tab is properly reattached), so that the listeners that the TabModel registers catch the theme color change. Bug: 833381 Change-Id: I721412dcfc4d9ec6d7ddacfda73b9adac644a937 Reviewed-on: https://chromium-review.googlesource.com/c/1384368 Commit-Queue: Peter Conn <peconn@chromium.org> Reviewed-by: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#618245} [modify] https://crrev.com/34fd8835bba5d93b0cd369bd35b0e93047125fd2/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java [modify] https://crrev.com/34fd8835bba5d93b0cd369bd35b0e93047125fd2/chrome/android/java/src/org/chromium/chrome/browser/tab/TabThemeColorHelper.java [modify] https://crrev.com/34fd8835bba5d93b0cd369bd35b0e93047125fd2/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/ChromeTabCreator.java
,
Dec 20
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by twelling...@chromium.org
, Apr 16 2018Labels: Hotlist-Chrome-Modern
Status: Available (was: Untriaged)