New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 833380 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 10
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 1
Type: Bug



Sign in to add a comment

Flaky tests in SitePerProcess[HighDPI]HitTestBrowserTest

Project Member Reported by sheriff-...@appspot.gserviceaccount.com, Apr 16 2018

Issue description

Filed by sheriff-o-matic@appspot.gserviceaccount.com on behalf of rhalavati@chromium.org

content_browsertests failing on chromium.memory/Linux TSan Tests

Builders failed on: 
- Linux TSan Tests: 
  https://build.chromium.org/p/chromium.memory/builders/Linux%20TSan%20Tests


 
See also  crbug.com/833043 

Comment 2 by msw@chromium.org, Apr 17 2018

Cc: alex...@chromium.org
Components: Tests>Flaky
Labels: OS-Linux
Owner: lukasza@chromium.org
Status: Assigned (was: Available)
Łukasz, does this flakiness seem related to your CL identified by Findit in  Issue 833043 ?

Linux TSan is failing content_browsertests in a SitePerProcessHighDPIHitTestBrowserTest fixture in 5 of the last 20 runs.
Cc: mcnee.ke...@gmail.com wjmaclean@chromium.org
I would say that this is unlikely, because r550287 should primarily have an effect on site-per-process mode (and I see that the TSan bot failures are in content_browsertests step, rather than in site_per_process_content_browsertests step).  OTOH, I don't think that I can rule out r550287's involvement with 100% confidence...
Cc: -mcnee.ke...@gmail.com mcnee@chromium.org
Oh, wait... what I've said in #c3 doesn't make sense - site-per-process is active because the test itself is opting in... :->
I can repro locally with:
is_tsan = true
enable_nacl = false
is_debug = false
is_component_build = true
use_goma = true
Well, I can repro something, but it goes for more than 1000 commits before r550287... sigh...

[5:5:0417/143922.897781:FATAL:sandbox_linux.cc(524)] Check failed: !promised_seccomp_bpf_would_start || seccomp_bpf_started_.
    #0 __interceptor_backtrace /b/build/slave/linux_upload_clang/build/src/third_party/llvm/compiler-rt/lib/tsan/../sanitizer_common/sanitizer_common_interceptors.inc:3980:13
    #1 base::debug::StackTrace::StackTrace(...) base/debug/stack_trace_posix.cc:808:41                                                                     
    #2 base::debug::StackTrace::StackTrace() base/debug/stack_trace.cc:199:28                                                                   
    #3 logging::LogMessage::~LogMessage() base/logging.cc:594:29                                                                           
    #4 service_manager::SandboxLinux::CheckForBrokenPromises(...) services/service_manager/sandbox/linux/sandbox_linux.cc:524:3                               
I am out of ideas of what to try next - without a local repro this will be rather difficult to fix (and reverting r550287 is undesirable [fixes load performance regression with Site Isolation] and complicated [probably won't revert cleanly due to its size]).
Cc: -rhalavati@chromium.org
Labels: -Sheriff-Chromium
Labels: Sheriff-Chromium
Still flaky.
https://uberchromegw.corp.google.com/i/chromium.memory/builders/Linux%20TSan%20Tests/builds/20426

Sometimes it's SitePerProcessHighDPIHitTestBrowserTest.CursorUpdateReceivedFromCrossSiteIframe, other times it's SitePerProcessHighDPIHitTestBrowserTest.OverlapSurfaceHitTestTest, while other times it's SitePerProcessHighDPIHitTestBrowserTest.HighDPICreateContextMenuTest
Cc: mstensho@chromium.org
Cc: -wjmaclean@chromium.org lukasza@chromium.org
Owner: wjmaclean@chromium.org
wjmaclean@, would you be able to help please?
Summary: Flaky tests in SitePerProcessHighDPIHitTestBrowserTest on chromium.memory/Linux TSan Tests (was: Flaky Test SitePerProcessHighDPIHitTestBrowserTest.CursorUpdateReceivedFromCrossSiteIframe/0 on chromium.memory/Linux TSan Tests)
 Issue 832705  has been merged into this issue.
 Issue 832657  has been merged into this issue.
 Issue 833043  has been merged into this issue.
 Issue 833044  has been merged into this issue.
 Issue 833761  has been merged into this issue.
 Issue 833763  has been merged into this issue.
 Issue 833816  has been merged into this issue.
 Issue 834157  has been merged into this issue.
 Issue 834168  has been merged into this issue.
 Issue 834472  has been merged into this issue.
Components: Internals>Sandbox>SiteIsolation
Labels: -Sheriff-Chromium
 Issue 835707  has been merged into this issue.
Cc: -mcnee@chromium.org wjmaclean@chromium.org
Owner: mcnee@chromium.org
mcnee@ - If you have some cycles, could you take a look at this and see if there's some common cause?
Labels: Type-Bug
Going to disable to make the TSAN bot greener.

On the bots, I don't see any useful info:

https://logs.chromium.org/v/?s=chromium%2Fbuildbucket%2Fcr-buildbucket.appspot.com%2F8948331802293617296%2F%2B%2Fsteps%2Fcontent_browsertests%2F0%2Flogs%2FSitePerProcessHighDPIHitTestBrowserTest.OverlapSurfaceHitTestTest__x2f_2%2F0

[ RUN      ] SitePerProcessHighDPIHitTestBrowserTest.OverlapSurfaceHitTestTest/2
Xlib:  extension "RANDR" missing on display ":99".
DevTools listening on ws://127.0.0.1:33930/devtools/browser/4eb6eb63-d6bf-4275-a963-359d1bd3ac9c
BrowserTestBase received signal: Terminated. Backtrace:
#0 0x0000016bab7c (/b/s/w/ir/out/Release/content_browsertests+0x16bab7b)
#1 0x000004c29d4a (/b/s/w/ir/out/Release/content_browsertests+0x4c29d49)
#2 0x000004b45c5f (/b/s/w/ir/out/Release/content_browsertests+0x4b45c5e)
#3 0x0000046bb994 (/b/s/w/ir/out/Release/content_browsertests+0x46bb993)
#4 0x0000016a5fa1 (/b/s/w/ir/out/Release/content_browsertests+0x16a5fa0)
...
Project Member

Comment 30 by bugdroid1@chromium.org, Apr 24 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4ff783302bcd4c8779d6ee95e2e4a036a55f9f13

commit 4ff783302bcd4c8779d6ee95e2e4a036a55f9f13
Author: Lei Zhang <thestig@chromium.org>
Date: Tue Apr 24 22:29:12 2018

Disable flaky SitePerProcessHighDPIHitTestBrowserTest on TSAN.

BUG= 833380 
TBR=mcnee@chromium.org
NOTRY=true

Change-Id: Ia38901113736af2fa923c301769282e834d531c3
Reviewed-on: https://chromium-review.googlesource.com/1026830
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553322}
[modify] https://crrev.com/4ff783302bcd4c8779d6ee95e2e4a036a55f9f13/content/browser/site_per_process_hit_test_browsertest.cc

Project Member

Comment 31 by bugdroid1@chromium.org, Apr 24 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d8bc8c2e72d5228f6bc4b30c132094de5aa6d288

commit d8bc8c2e72d5228f6bc4b30c132094de5aa6d288
Author: Lei Zhang <thestig@chromium.org>
Date: Tue Apr 24 22:48:27 2018

Revert "Disable flaky SitePerProcessHighDPIHitTestBrowserTest on TSAN."

This reverts commit 4ff783302bcd4c8779d6ee95e2e4a036a55f9f13.

Reason for revert: Broke the build.

Original change's description:
> Disable flaky SitePerProcessHighDPIHitTestBrowserTest on TSAN.
> 
> BUG= 833380 
> TBR=mcnee@chromium.org
> NOTRY=true
> 
> Change-Id: Ia38901113736af2fa923c301769282e834d531c3
> Reviewed-on: https://chromium-review.googlesource.com/1026830
> Reviewed-by: Lei Zhang <thestig@chromium.org>
> Commit-Queue: Lei Zhang <thestig@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#553322}

TBR=thestig@chromium.org,mcnee@chromium.org

Change-Id: Ic390442ee654a5ad8a8c4076843d64f461fdb6f5
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  833380 
Reviewed-on: https://chromium-review.googlesource.com/1026435
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553332}
[modify] https://crrev.com/d8bc8c2e72d5228f6bc4b30c132094de5aa6d288/content/browser/site_per_process_hit_test_browsertest.cc

Project Member

Comment 32 by bugdroid1@chromium.org, Apr 25 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/80bff43a869b6f482b3fd0f8396134e1253b5073

commit 80bff43a869b6f482b3fd0f8396134e1253b5073
Author: Lei Zhang <thestig@chromium.org>
Date: Wed Apr 25 00:14:32 2018

Disable flaky SitePerProcessHighDPIHitTestBrowserTest on TSAN.

BUG= 833380 
TBR=mcnee@chromium.org

Change-Id: I21f9aba5266d2f8c44e29c5cc3ed75ad0dd78cde
Reviewed-on: https://chromium-review.googlesource.com/1026846
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553383}
[modify] https://crrev.com/80bff43a869b6f482b3fd0f8396134e1253b5073/content/browser/site_per_process_hit_test_browsertest.cc

 Issue 839670  has been merged into this issue.
Labels: -Pri-2 Sheriff-Chromium OS-Chrome OS-Mac OS-Windows Pri-1
Summary: Flaky tests in SitePerProcess[HighDPI]HitTestBrowserTest (was: Flaky tests in SitePerProcessHighDPIHitTestBrowserTest on chromium.memory/Linux TSan Tests)
All the "SitePerProcess[HighDPI]HitTestBrowserTest.CursorUpdateReceivedFromCrossSiteIframe/*" tests are flaky across platforms:
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=content_browsertests&tests=CursorUpdateReceivedFromCrossSiteIframe
 Issue 839735  has been merged into this issue.
I'll go ahead and disable the tests.
Project Member

Comment 37 by bugdroid1@chromium.org, May 4 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/df445ea6cdafe1ac0d2d92be1b4d6eee10f60620

commit df445ea6cdafe1ac0d2d92be1b4d6eee10f60620
Author: Marc Treib <treib@chromium.org>
Date: Fri May 04 09:36:56 2018

Disable flaky CursorUpdateReceivedFromCrossSiteIframe tests

Both in SitePerProcessHitTestBrowserTest and in
SitePerProcessHighDPIHitTestBrowserTest.

TBR=mcnee@chromium.org

Bug:  833380 
Change-Id: I5469e74827a6daaff72b6c85b2095866f91b601a
Reviewed-on: https://chromium-review.googlesource.com/1043869
Reviewed-by: Marc Treib <treib@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556018}
[modify] https://crrev.com/df445ea6cdafe1ac0d2d92be1b4d6eee10f60620/content/browser/site_per_process_hit_test_browsertest.cc

Labels: -Sheriff-Chromium
Project Member

Comment 39 by bugdroid1@chromium.org, May 11 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f8365bdfac969597f1ccfcdd72091ea65ba034a5

commit f8365bdfac969597f1ccfcdd72091ea65ba034a5
Author: Tommy Martino <tmartino@chromium.org>
Date: Fri May 11 18:40:20 2018

Disabling 4 flaky tests on TSAN

Tests:
SitePerProcessHitTestBrowserTest.SurfaceHitTestPointerEventsNone
SitePerProcessHitTestBrowserTest.CreateContextMenuTest
SitePerProcessHighDPIHitTestBrowserTest.HitTestWatermark
SitePerProcessHitTestBrowserTest.InputEventRouterWheelCoalesceTest

Bug:  833380 
Change-Id: Ifb7a45569f1be2636dc3f7d79bffa4bfdaf2dce8

TBR=kenrb@chromium.org

Change-Id: Ifb7a45569f1be2636dc3f7d79bffa4bfdaf2dce8
Reviewed-on: https://chromium-review.googlesource.com/1055663
Reviewed-by: Tommy Martino <tmartino@chromium.org>
Commit-Queue: Tommy Martino <tmartino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557956}
[modify] https://crrev.com/f8365bdfac969597f1ccfcdd72091ea65ba034a5/content/browser/site_per_process_hit_test_browsertest.cc

Cc: sadrul@chromium.org lijeffrey@chromium.org
 Issue 842102  has been merged into this issue.
 Issue 842449  has been merged into this issue.
 Issue 842530  has been merged into this issue.
 Issue 842230  has been merged into this issue.
 Issue 842434  has been merged into this issue.
 Issue 842487  has been merged into this issue.
 Issue 842522  has been merged into this issue.
Project Member

Comment 42 by bugdroid1@chromium.org, May 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a6099c9bcdf63ddf0fd45efdcaaf835077ce7cbd

commit a6099c9bcdf63ddf0fd45efdcaaf835077ce7cbd
Author: Timothy Loh <timloh@chromium.org>
Date: Mon May 14 03:55:25 2018

Disable flaky SitePerProcess[HighDPI]HitTestBrowserTest tests

Disables:
- ScrollEventToOOPIF on TSAN
- OverlapSurfaceHitTestTest on Linux (was: TSAN)
- HitTestWatermark on Linux (was: TSAN)
- HitTestLayerSquashing on Linux
- CrossProcessMouseCapture on Linux

TBR=kenrb@chromium.org

Bug:  833380 
Change-Id: Ia8539488479c19e0dbeacf6bc0c16667f325ebd9
Reviewed-on: https://chromium-review.googlesource.com/1056775
Reviewed-by: Timothy Loh <timloh@chromium.org>
Commit-Queue: Timothy Loh <timloh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558187}
[modify] https://crrev.com/a6099c9bcdf63ddf0fd45efdcaaf835077ce7cbd/content/browser/site_per_process_hit_test_browsertest.cc

Comment 43 by mcnee@chromium.org, May 15 2018

Cc: kenrb@chromium.org
Hmm, I can't seem to reproduce any flakiness locally (with TSAN or otherwise).

From looking at non-TSAN flakes on the bots, it looks like there are quite a few cases of timeouts in WaitForChildFrameSurfaceReady.
Cc: jonr...@chromium.org
I've been working on a new hit testing api, which when available blocks until hit testing data is available. Otherwise it falls back to the WaitForChildFrameSurfaceReady that maybe be the source of the flakiness seen here.

In https://chromium-review.googlesource.com/c/chromium/src/+/1081998 I'm updating several callsites throughout SitePerProcess[HighDPI]HitTestBrowserTest to re-enable them on Viz.

I will also speculatively turn SitePerProcessHitTestBrowserTest.CrossProcessMouseCapture back on to see if this solves it.
Cc: sunxd@chromium.org
I'm the sheriff today and got an alert about this test failing:
SitePerProcessHitTestBrowserTest.ScrollEventToOOPIF

Build log:
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-xenial-rel/1458

Failure:
BrowserTestBase received signal: Terminated. Backtrace:
#0 0x0000035f761c base::debug::StackTrace::StackTrace()
#1 0x0000032c7b95 content::(anonymous namespace)::DumpStackTraceSignalHandler()
#2 0x7fe997bd94b0 <unknown>
#3 0x7fe997c9f74d __poll
#4 0x7fe99bdee38c <unknown>
#5 0x7fe99bdee49c g_main_context_iteration
#6 0x000003587c72 base::MessagePumpGlib::Run()
#7 0x00000359eb65 base::RunLoop::Run()
#8 0x0000032d323c content::(anonymous namespace)::SurfaceHitTestReadyNotifier::WaitForSurfaceReady()
#9 0x0000032d2f66 content::WaitForHitTestDataOrChildSurfaceReady()
#10 0x0000018f1113 content::SitePerProcessHitTestBrowserTest_ScrollEventToOOPIF_Test::RunTestOnMainThread()
#11 0x0000032c7018 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop()
#12 0x00000334b968 content::ShellBrowserMainParts::PreMainMessageLoopRun()


Looking into this more, it seems this test still fails pretty often:
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=network_service_content_browsertests&tests=ScrollEventToOOPIF

@sunxd, you recently added the kHitTestOption option for this test. Only ScrollEventToOOPIF/0 flakes (i.e., not ScrollEventToOOPIF/1 or ScrollEventToOOPIF/2). Could that hint at the underlying reason for this flakiness?
The 0 flag represents Surface hit test, while 1 and 2 are viz hit test. I think it falls into WaitForChildFrameSurfaceReady again in /0 variant (https://cs.chromium.org/chromium/src/content/public/test/hit_test_region_observer.cc?rcl=12af7d0af932cb622614ba55d1853e8091df07c4&l=140).

Hi jonross@, I think you are working on converting "WaitForChildFrameSurfaceReady" to "WaitForHitTestData", is there any plan for fixing SurfaceHitTest browser tests?
Other tests are failing with the same stack trace as in Comment #45. E.g.
SitePerProcessHitTestBrowserTest.SurfaceHitTestPointerEventsNone/0
SitePerProcessEmulatedTouchBrowserTest.EmulatedTouchPinchGoesToMainFrame/0
SitePerProcessHitTestBrowserTest.CreateContextMenuTest/0
SitePerProcessHitTestBrowserTest.BubbledScrollEventsTransformedCorrectly/0

on https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-xenial-rel
Project Member

Comment 48 by bugdroid1@chromium.org, Jul 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bc2a7e5a4dd7cc9c193e164081c8366101e0759b

commit bc2a7e5a4dd7cc9c193e164081c8366101e0759b
Author: Vasilii Sukhanov <vasilii@chromium.org>
Date: Mon Jul 09 11:07:55 2018

Disable some flaky SitePerProcessHitTestBrowserTest tests

TBR=sunxd@chromium.org

Bug:  833380 
Change-Id: I25fd69443b617035356f6973d59241af6d7206b9
Reviewed-on: https://chromium-review.googlesource.com/1128856
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573268}
[modify] https://crrev.com/bc2a7e5a4dd7cc9c193e164081c8366101e0759b/content/browser/site_per_process_hit_test_browsertest.cc

sunxd@ the conversion of "WaitForChildFrameSurfaceReady" to "WaitForHitTestData" is done.

For /0 variants it still waits for a surface to have been activated. Based on the stack trace in #45 the test is failing because the surface it wants to wait for is never activated.

If tests are currently failing in that manner we should assign to whomever wrote those tests to take a look as to why that's the case.
Project Member

Comment 50 by bugdroid1@chromium.org, Jul 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3e031a4fd51a2eefc216a0f80f4bb139e1812b6c

commit 3e031a4fd51a2eefc216a0f80f4bb139e1812b6c
Author: Kim Paulhamus <kpaulhamus@chromium.org>
Date: Thu Jul 12 19:35:44 2018

Disable flaky SitePerProcessHitTestBrowserTest

[OverlapSurfaceHitTestTest]

TBR=sunxd@chromium.org

Bug:  833380 
Change-Id: I7991db84dd9201e59089f08a536bcab00b23d379
Reviewed-on: https://chromium-review.googlesource.com/1135648
Commit-Queue: Kim Paulhamus <kpaulhamus@chromium.org>
Reviewed-by: Kim Paulhamus <kpaulhamus@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574679}
[modify] https://crrev.com/3e031a4fd51a2eefc216a0f80f4bb139e1812b6c/content/browser/site_per_process_hit_test_browsertest.cc

Cc: xidac...@chromium.org xiaoche...@chromium.org
 Issue 864009  has been merged into this issue.

Comment 52 Deleted

Project Member

Comment 54 by bugdroid1@chromium.org, Jul 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a2a407b36112cb535436119021819169dc0a5e52

commit a2a407b36112cb535436119021819169dc0a5e52
Author: Xiaocheng Hu <xiaochengh@chromium.org>
Date: Mon Jul 16 19:27:09 2018

Disable SitePerProcessEmulatedTouchBrowserTest.EmulatedGestureScrollBubbles on Chrome OS

Bug:  833380 
Change-Id: Idc4d24382205ba47b23da686b2b607ca3de0c031
Tbr: kenrb@chromium.org
NoTry: True
Reviewed-on: https://chromium-review.googlesource.com/1138415
Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575382}
[modify] https://crrev.com/a2a407b36112cb535436119021819169dc0a5e52/content/browser/site_per_process_hit_test_browsertest.cc

3 tests are flaky on ChromeOS:

SitePerProcessHitTestBrowserTest.SurfaceHitTestTest/0
SitePerProcessHitTestBrowserTest.CancelWheelScrollBubblingOnWheelTargetDeletion/0
SitePerProcessHitTestBrowserTest.ScrollEventToOOPIF/0

Build log:

https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-rel/10752
Project Member

Comment 56 by bugdroid1@chromium.org, Jul 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d5b59b2d9328ea716ac871a36924bef08186387f

commit d5b59b2d9328ea716ac871a36924bef08186387f
Author: Xiaocheng Hu <xiaochengh@chromium.org>
Date: Mon Jul 16 21:42:23 2018

Disable flaky SitePerProcessHitTestBrowserTest tests on ChromeOS

Bug:  833380 
Change-Id: Ibbe5e66786930313ea10bcba1988df93e91f05e3
Tbr: kenrb@chromium.org
NoTry: True
Reviewed-on: https://chromium-review.googlesource.com/1138993
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575435}
[modify] https://crrev.com/d5b59b2d9328ea716ac871a36924bef08186387f/content/browser/site_per_process_hit_test_browsertest.cc

Project Member

Comment 57 by bugdroid1@chromium.org, Jul 17

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/67b6e2147eb99d1af65faf78e774fd90e5c15a13

commit 67b6e2147eb99d1af65faf78e774fd90e5c15a13
Author: Xiaocheng Hu <xiaochengh@chromium.org>
Date: Tue Jul 17 01:49:21 2018

Disable flaky SitePerProcessHitTestBrowserTest.AsynchronousHitTestChildTimeout/0 on ChromeOS

Bug:  833380 
Change-Id: Icebd24dbe4514239ae0a627dd97dd9276f18c40d
Tbr: kenrb@chromium.org
NoTry: True
Reviewed-on: https://chromium-review.googlesource.com/1139533
Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575520}
[modify] https://crrev.com/67b6e2147eb99d1af65faf78e774fd90e5c15a13/content/browser/site_per_process_hit_test_browsertest.cc

Project Member

Comment 58 by bugdroid1@chromium.org, Jul 17

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5f15cd3ca14252872406ae35ec787a77edc8a259

commit 5f15cd3ca14252872406ae35ec787a77edc8a259
Author: Xiaocheng Hu <xiaochengh@chromium.org>
Date: Tue Jul 17 18:54:08 2018

Disable flaky SitePerProcessEmulatedTouchBrowserTest.EmulatedTouchScrollBubbles on ChromeOS

Bug:  833380 
Change-Id: I9973c37de42b89f06157b97b30458e5a77f349cc
Tbr: kenrb@chromium.org
NoTry: True
Reviewed-on: https://chromium-review.googlesource.com/1140617
Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575736}
[modify] https://crrev.com/5f15cd3ca14252872406ae35ec787a77edc8a259/content/browser/site_per_process_hit_test_browsertest.cc

Cc: riajiang@chromium.org mcnee@chromium.org chaopeng@chromium.org nzolghadr@chromium.org
 Issue 868308  has been merged into this issue.
Project Member

Comment 60 by bugdroid1@chromium.org, Jul 30

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0793f8f7f919da4d4ceba5712cd1790ab15c3532

commit 0793f8f7f919da4d4ceba5712cd1790ab15c3532
Author: Peter Boström <pbos@chromium.org>
Date: Mon Jul 30 18:35:29 2018

Disable TouchpadPinchOverOOPIF tests on Windows

SitePerProcessHitTestBrowserTest.TouchpadPinchOverOOPIF is being
reported as flaky on Windows.

Bug:  chromium:868308 ,  chromium:833380 
TBR: kenrb@chromium.org
Change-Id: I83142d0d777bbe51773eaba0ab1d191a4af0cbc5
Reviewed-on: https://chromium-review.googlesource.com/1155165
Reviewed-by: Kevin McNee <mcnee@chromium.org>
Commit-Queue: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579096}
[modify] https://crrev.com/0793f8f7f919da4d4ceba5712cd1790ab15c3532/content/browser/renderer_host/render_widget_host_input_event_router.h
[modify] https://crrev.com/0793f8f7f919da4d4ceba5712cd1790ab15c3532/content/browser/site_per_process_hit_test_browsertest.cc

Cc: sky@google.com
 Issue 868409  has been merged into this issue.
Cc: -mstensho@chromium.org
jonross@ re c49 ... the tests (at least the ones I looked at) seem to be doing something pretty benign, namely loading a page with a child frame, and then waiting for the child frame's surface to become ready, using WaitForChildFrameSurfaceReady.

If WaitForChildFrameSurfaceReady never returns, then (in my thinking) either (i) WaitForChildFrameSurfaceReady has an error, or (ii) something is preventing the child surface from activating ... these both seem to be beyond the scope of the tests themselves, and instead points at something deeper.

Or am I missing something?

I'm going to pick a test and see if I can get a repro going, and poke at it ...
wjmaclean@ nope you've identified the two possibilities which I can think of.

After seeing a recent patch (https://chromium-review.googlesource.com/c/chromium/src/+/1126598) I'm leaning towards (i), as a cached SurfaceId is being used for verification. It is possible that the SurfaceId is changing while we are blocking.

This was surfaced in a separate patch which added a delay in lifecycle updates for surfaces. So I'm not sure if this is happening here.

We could land the hit_test_region_observer.cc portion of that review to see if it helps. We could also throw a CHECK in there to verify if it is happening.


Option (ii) scares me, but if would mean the tests are identifying a bug :D


Option (iii) is that the Viz Hit Testing replacement (/1) will be default soon, and these /0 races will be gone.
Project Member

Comment 65 by bugdroid1@chromium.org, Aug 14

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a74ee65f47d1658b119d696ae15cb02ac9559eed

commit a74ee65f47d1658b119d696ae15cb02ac9559eed
Author: W. James MacLean <wjmaclean@chromium.org>
Date: Tue Aug 14 21:00:11 2018

Allow for changing surface ID in WaitForSurfaceReady

This CL is experimental, and aims to see if a changing surface id for
the root view could be at the heart of the flakey tests reference by
the associated bug.

One flakey test is re-enabled to provide some initial data.

The surface id idea is cherry-picked from kinuko@'s CL at
https://chromium-review.googlesource.com/c/chromium/src/+/1126598 .

Bug:  833380 
Change-Id: I3cda4f5214a5bf19e711f95303a6b65b4ff2410c
Reviewed-on: https://chromium-review.googlesource.com/1172723
Commit-Queue: James MacLean <wjmaclean@chromium.org>
Reviewed-by: Jonathan Ross <jonross@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583027}
[modify] https://crrev.com/a74ee65f47d1658b119d696ae15cb02ac9559eed/content/browser/site_per_process_hit_test_browsertest.cc
[modify] https://crrev.com/a74ee65f47d1658b119d696ae15cb02ac9559eed/content/public/test/hit_test_region_observer.cc

Project Member

Comment 66 by bugdroid1@chromium.org, Aug 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/de80cebff4b748c476a990fb11e69cea5efb338c

commit de80cebff4b748c476a990fb11e69cea5efb338c
Author: W. James MacLean <wjmaclean@chromium.org>
Date: Thu Aug 16 15:50:38 2018

Try re-enabling more OOPIF tests.

There have been no flakes reported on EmulatedTouchPinchGoesToMainFrame
since https://chromium-review.googlesource.com/c/chromium/src/+/1172723
went in, so let's try re-enabling some more tests.

Bug:  833380 
Change-Id: If406a6f5d7b0a88e84cad84e07d1bba547eb1baa
Reviewed-on: https://chromium-review.googlesource.com/1177843
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: James MacLean <wjmaclean@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583670}
[modify] https://crrev.com/de80cebff4b748c476a990fb11e69cea5efb338c/content/browser/site_per_process_hit_test_browsertest.cc

Project Member

Comment 67 by bugdroid1@chromium.org, Aug 23

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a4bcee53bbe1fe6d36a04f6600fbc956d23eba0e

commit a4bcee53bbe1fe6d36a04f6600fbc956d23eba0e
Author: W. James MacLean <wjmaclean@chromium.org>
Date: Thu Aug 23 19:57:19 2018

Add logging to understand test timeout.

Adds logging to
SitePerProcessEmulatedTouchBrowserTest.EmulatedTouchShowPressHasTouchID
to verify the gesture stream when the test times out.

Bug:  833380 
Change-Id: I8cf2e92a6f13aa38e3294f4511d53ce658cd62a5
Reviewed-on: https://chromium-review.googlesource.com/1187280
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Commit-Queue: James MacLean <wjmaclean@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585587}
[modify] https://crrev.com/a4bcee53bbe1fe6d36a04f6600fbc956d23eba0e/content/browser/site_per_process_hit_test_browsertest.cc

Project Member

Comment 68 by bugdroid1@chromium.org, Aug 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fe1387c3c1f19a0073c63a7a7f39c3ad48570003

commit fe1387c3c1f19a0073c63a7a7f39c3ad48570003
Author: W. James MacLean <wjmaclean@chromium.org>
Date: Fri Aug 24 22:12:13 2018

Add input event observer to generate stack trace in flakey test.

This CL temporarily adds an InputEventObserver for TouchMoves on
RenderWidgetHost to try and detect the source of spurious TouchMove
events in the Windows flakes of
SitePerProcessEmulatedTouchBrowserTest.EmulatedTouchShowPressHasTouchID.

Bug:  833380 
Change-Id: Ia3d6f75013acbbc9ed1a823c799741e2c64d2253
Reviewed-on: https://chromium-review.googlesource.com/1188876
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Commit-Queue: James MacLean <wjmaclean@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586018}
[modify] https://crrev.com/fe1387c3c1f19a0073c63a7a7f39c3ad48570003/content/browser/site_per_process_hit_test_browsertest.cc

Cc: bokan@chromium.org
Project Member

Comment 70 by bugdroid1@chromium.org, Aug 27

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b450f1f59552eca853e86712fe18fe2b38666679

commit b450f1f59552eca853e86712fe18fe2b38666679
Author: W. James MacLean <wjmaclean@chromium.org>
Date: Mon Aug 27 20:43:59 2018

Dump window, mousemove coords as part of logging.

Include coordinates for the root window and also the TouchMove
(mousemoves) as part of the debugging output.

Bug:  833380 
Change-Id: I769bdabefd1fdbaedf43ae5533e097c8da46ae8b
Reviewed-on: https://chromium-review.googlesource.com/1191084
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Commit-Queue: James MacLean <wjmaclean@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586405}
[modify] https://crrev.com/b450f1f59552eca853e86712fe18fe2b38666679/content/browser/site_per_process_hit_test_browsertest.cc

Project Member

Comment 71 by bugdroid1@chromium.org, Aug 29

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/15839197005a06213ae5b2d4fcbd1dc990c76f95

commit 15839197005a06213ae5b2d4fcbd1dc990c76f95
Author: W. James MacLean <wjmaclean@chromium.org>
Date: Wed Aug 29 17:59:19 2018

Use EventRewriter to disable system mouse events in Aura SPPHTBTs.

It seems that spurious mousemove events on Win have been creeping into
tests in this suite (e.g. a test window pops up under where the system
thinks the mouse cursor is, and generates a mouse-enter). These events
appear to be at the root of flakes for at least one, and possibly more,
tests in this hierarchy.

This CL installs a ui::EventRewriter that discards all system mouse
events in an attempt to reduce flake in the tests.

Bug:  833380 
Change-Id: I48adacad0fdf4126ea4198bfa72b336d0eb63389
Reviewed-on: https://chromium-review.googlesource.com/1194253
Commit-Queue: James MacLean <wjmaclean@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587189}
[modify] https://crrev.com/15839197005a06213ae5b2d4fcbd1dc990c76f95/content/browser/site_per_process_hit_test_browsertest.cc

Project Member

Comment 72 by bugdroid1@chromium.org, Aug 30

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/718212bc07786ae830d0cc84158d18a6dce45716

commit 718212bc07786ae830d0cc84158d18a6dce45716
Author: W. James MacLean <wjmaclean@chromium.org>
Date: Thu Aug 30 16:54:33 2018

Tentatively re-enable OverlapSurfaceHitTestTest.

A number of changes have landed recently that may eliminate the
flakieness seen in this test. This CL re-enables the test, but feel
free to revert this if the flakes continue.

Bug:  833380 
Change-Id: I79216b82cf1c14e4c857430d742ddb3933a7dcc9
Reviewed-on: https://chromium-review.googlesource.com/1196766
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Commit-Queue: James MacLean <wjmaclean@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587627}
[modify] https://crrev.com/718212bc07786ae830d0cc84158d18a6dce45716/content/browser/site_per_process_hit_test_browsertest.cc

Project Member

Comment 73 by bugdroid1@chromium.org, Sep 4

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e712d09895f9a817a54eb7b1b0fff8b4ea449595

commit e712d09895f9a817a54eb7b1b0fff8b4ea449595
Author: W. James MacLean <wjmaclean@chromium.org>
Date: Tue Sep 04 15:16:46 2018

Tentatively re-enable SitePerProcessHitTestBrowserTest.ScrollEventToOOPIF.

A number of changes have landed recently that may eliminate the
flakieness seen in this test. This CL re-enables the test, but feel
free to revert this if the flakes continue.

Bug:  833380 
Change-Id: I62db026d3163e018594018800498fed3381d76bf
Reviewed-on: https://chromium-review.googlesource.com/1203873
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Commit-Queue: James MacLean <wjmaclean@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588519}
[modify] https://crrev.com/e712d09895f9a817a54eb7b1b0fff8b4ea449595/content/browser/site_per_process_hit_test_browsertest.cc

Project Member

Comment 74 by bugdroid1@chromium.org, Sep 4

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e8aaa5ec61a503fca6be890eaf9be4c0c66d4faa

commit e8aaa5ec61a503fca6be890eaf9be4c0c66d4faa
Author: W. James MacLean <wjmaclean@chromium.org>
Date: Tue Sep 04 15:17:31 2018

Tentatively re-enable SitePerProcessHitTestBrowserTest.InputEventRouterWheelCoalesceTest.

A number of changes have landed recently that may eliminate the
flakieness seen in this test. This CL re-enables the test, but feel
free to revert this if the flakes continue.

Bug:  833380 
Change-Id: I75b32cd25228192b3244fddd714a99620f77a2ee
Reviewed-on: https://chromium-review.googlesource.com/1203874
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Commit-Queue: James MacLean <wjmaclean@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588520}
[modify] https://crrev.com/e8aaa5ec61a503fca6be890eaf9be4c0c66d4faa/content/browser/site_per_process_hit_test_browsertest.cc

Project Member

Comment 75 by bugdroid1@chromium.org, Sep 4

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e712d09895f9a817a54eb7b1b0fff8b4ea449595

commit e712d09895f9a817a54eb7b1b0fff8b4ea449595
Author: W. James MacLean <wjmaclean@chromium.org>
Date: Tue Sep 04 15:16:46 2018

Tentatively re-enable SitePerProcessHitTestBrowserTest.ScrollEventToOOPIF.

A number of changes have landed recently that may eliminate the
flakieness seen in this test. This CL re-enables the test, but feel
free to revert this if the flakes continue.

Bug:  833380 
Change-Id: I62db026d3163e018594018800498fed3381d76bf
Reviewed-on: https://chromium-review.googlesource.com/1203873
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Commit-Queue: James MacLean <wjmaclean@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588519}
[modify] https://crrev.com/e712d09895f9a817a54eb7b1b0fff8b4ea449595/content/browser/site_per_process_hit_test_browsertest.cc

Project Member

Comment 76 by bugdroid1@chromium.org, Sep 4

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e8aaa5ec61a503fca6be890eaf9be4c0c66d4faa

commit e8aaa5ec61a503fca6be890eaf9be4c0c66d4faa
Author: W. James MacLean <wjmaclean@chromium.org>
Date: Tue Sep 04 15:17:31 2018

Tentatively re-enable SitePerProcessHitTestBrowserTest.InputEventRouterWheelCoalesceTest.

A number of changes have landed recently that may eliminate the
flakieness seen in this test. This CL re-enables the test, but feel
free to revert this if the flakes continue.

Bug:  833380 
Change-Id: I75b32cd25228192b3244fddd714a99620f77a2ee
Reviewed-on: https://chromium-review.googlesource.com/1203874
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Commit-Queue: James MacLean <wjmaclean@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588520}
[modify] https://crrev.com/e8aaa5ec61a503fca6be890eaf9be4c0c66d4faa/content/browser/site_per_process_hit_test_browsertest.cc

Project Member

Comment 77 by bugdroid1@chromium.org, Sep 4

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e712d09895f9a817a54eb7b1b0fff8b4ea449595

commit e712d09895f9a817a54eb7b1b0fff8b4ea449595
Author: W. James MacLean <wjmaclean@chromium.org>
Date: Tue Sep 04 15:16:46 2018

Tentatively re-enable SitePerProcessHitTestBrowserTest.ScrollEventToOOPIF.

A number of changes have landed recently that may eliminate the
flakieness seen in this test. This CL re-enables the test, but feel
free to revert this if the flakes continue.

Bug:  833380 
Change-Id: I62db026d3163e018594018800498fed3381d76bf
Reviewed-on: https://chromium-review.googlesource.com/1203873
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Commit-Queue: James MacLean <wjmaclean@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588519}
[modify] https://crrev.com/e712d09895f9a817a54eb7b1b0fff8b4ea449595/content/browser/site_per_process_hit_test_browsertest.cc

Project Member

Comment 78 by bugdroid1@chromium.org, Sep 4

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e8aaa5ec61a503fca6be890eaf9be4c0c66d4faa

commit e8aaa5ec61a503fca6be890eaf9be4c0c66d4faa
Author: W. James MacLean <wjmaclean@chromium.org>
Date: Tue Sep 04 15:17:31 2018

Tentatively re-enable SitePerProcessHitTestBrowserTest.InputEventRouterWheelCoalesceTest.

A number of changes have landed recently that may eliminate the
flakieness seen in this test. This CL re-enables the test, but feel
free to revert this if the flakes continue.

Bug:  833380 
Change-Id: I75b32cd25228192b3244fddd714a99620f77a2ee
Reviewed-on: https://chromium-review.googlesource.com/1203874
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Commit-Queue: James MacLean <wjmaclean@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588520}
[modify] https://crrev.com/e8aaa5ec61a503fca6be890eaf9be4c0c66d4faa/content/browser/site_per_process_hit_test_browsertest.cc

Project Member

Comment 79 by bugdroid1@chromium.org, Sep 5

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3c4d3843a739cb9c3f103ad4be692a7db93b7be3

commit 3c4d3843a739cb9c3f103ad4be692a7db93b7be3
Author: W. James MacLean <wjmaclean@chromium.org>
Date: Wed Sep 05 13:45:34 2018

Tentatively re-enable HitTestWatermark & HitTestLayerSquashing.

A number of changes have landed recently that may eliminate the
flakieness seen in this test. This CL re-enables the test, but feel
free to revert this if the flakes continue.

Bug:  833380 
Change-Id: I013c87578e665cd91f111e2a1c6bb31a58cf6be1
Reviewed-on: https://chromium-review.googlesource.com/1205479
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Commit-Queue: James MacLean <wjmaclean@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588848}
[modify] https://crrev.com/3c4d3843a739cb9c3f103ad4be692a7db93b7be3/content/browser/site_per_process_hit_test_browsertest.cc

Project Member

Comment 80 by bugdroid1@chromium.org, Sep 6

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/46cef98b65ee73a1d139c2de3a599926f854cec0

commit 46cef98b65ee73a1d139c2de3a599926f854cec0
Author: W. James MacLean <wjmaclean@chromium.org>
Date: Thu Sep 06 14:52:15 2018

Tentatively re-enable SurfaceHitTestPointerEventsNone & AsynchronousHitTestChildTimeout.

A number of changes have landed recently that may eliminate the
flakieness seen in this test. This CL re-enables the test, but feel
free to revert this if the flakes continue.

Bug:  833380 
Change-Id: Id1b94654a197d77af2ffdfbfdbf13c83ac485261
Reviewed-on: https://chromium-review.googlesource.com/1209962
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Commit-Queue: James MacLean <wjmaclean@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589166}
[modify] https://crrev.com/46cef98b65ee73a1d139c2de3a599926f854cec0/content/browser/site_per_process_hit_test_browsertest.cc

Project Member

Comment 81 by bugdroid1@chromium.org, Sep 7

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d1da70df4461a98b6d0b49112df62f15671bcf6a

commit d1da70df4461a98b6d0b49112df62f15671bcf6a
Author: W. James MacLean <wjmaclean@chromium.org>
Date: Fri Sep 07 21:16:05 2018

Re-enable remaining tests for 833380.

A number of changes have landed recently that may eliminate the
flakieness seen in this test. This CL re-enables the test, but feel
free to revert this if the flakes continue.

If this CL sticks, then all tests related to this bug have been
re-enabled.

Bug:  833380 
Change-Id: I38147cf870ff11b51fa67dba1a209dfa40a7643c
Reviewed-on: https://chromium-review.googlesource.com/1213302
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Commit-Queue: James MacLean <wjmaclean@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589656}
[modify] https://crrev.com/d1da70df4461a98b6d0b49112df62f15671bcf6a/content/browser/site_per_process_hit_test_browsertest.cc

Labels: Sheriff-Chromium
Detected 3 new flakes for test/step "SitePerProcessHitTestBrowserTest.CursorUpdateReceivedFromCrossSiteIframe/0". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyVQsSBUZsYWtlIkpTaXRlUGVyUHJvY2Vzc0hpdFRlc3RCcm93c2VyVGVzdC5DdXJzb3JVcGRhdGVSZWNlaXZlZEZyb21Dcm9zc1NpdGVJZnJhbWUvMAw. This message was posted automatically by the chromium-try-flakes app. Since flakiness is ongoing, the issue was moved back into Sheriff Bug Queue (unless already there).
Detected 3 new flakes for test/step "SitePerProcessHitTestBrowserTest.CursorUpdateReceivedFromCrossSiteIframe/1". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyVQsSBUZsYWtlIkpTaXRlUGVyUHJvY2Vzc0hpdFRlc3RCcm93c2VyVGVzdC5DdXJzb3JVcGRhdGVSZWNlaXZlZEZyb21Dcm9zc1NpdGVJZnJhbWUvMQw. This message was posted automatically by the chromium-try-flakes app.
Detected 3 new flakes for test/step "SitePerProcessHitTestBrowserTest.CursorUpdateReceivedFromCrossSiteIframe/0". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyVQsSBUZsYWtlIkpTaXRlUGVyUHJvY2Vzc0hpdFRlc3RCcm93c2VyVGVzdC5DdXJzb3JVcGRhdGVSZWNlaXZlZEZyb21Dcm9zc1NpdGVJZnJhbWUvMAw. This message was posted automatically by the chromium-try-flakes app.
Detected 3 new flakes for test/step "SitePerProcessHitTestBrowserTest.CursorUpdateReceivedFromCrossSiteIframe/1". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyVQsSBUZsYWtlIkpTaXRlUGVyUHJvY2Vzc0hpdFRlc3RCcm93c2VyVGVzdC5DdXJzb3JVcGRhdGVSZWNlaXZlZEZyb21Dcm9zc1NpdGVJZnJhbWUvMQw. This message was posted automatically by the chromium-try-flakes app.
Revert of r589656 in progress @ https://chromium-review.googlesource.com/c/chromium/src/+/1216703 given the flakes resurfacing.
Owner: wjmaclean@chromium.org
Status: Fixed (was: Assigned)
I'm going to *tentatively* mark this as fixed. All the tests have been re-enabled, except for one which seems to be flaking for an unrelated reason, and so I've moved it to https://bugs.chromium.org/p/chromium/issues/detail?id=882458.

If new flakes are observed, please re-open this bug, but only if it looks like the issues already described above ... otherwise please create a new bug, and assign it to me.
Labels: -Sheriff-Chromium
Project Member

Comment 89 by bugdroid1@chromium.org, Sep 17

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f12074769721dc8cce3a1fc7c9c927b7daef56c5

commit f12074769721dc8cce3a1fc7c9c927b7daef56c5
Author: W. James MacLean <wjmaclean@chromium.org>
Date: Mon Sep 17 12:54:24 2018

Remove diagnostic code related to 833380.

This CL cleans up diagnostic code related to the associated bug.

When this lands, all tests affected by the bug should be re-enabled.

Bug:  833380 
Change-Id: I1ad8d59de132a2d1c45e45da0c5ba16e50a02a62
Reviewed-on: https://chromium-review.googlesource.com/1213362
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Commit-Queue: James MacLean <wjmaclean@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591651}
[modify] https://crrev.com/f12074769721dc8cce3a1fc7c9c927b7daef56c5/content/browser/site_per_process_hit_test_browsertest.cc

Project Member

Comment 90 by bugdroid1@chromium.org, Sep 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8d8b74adc9084e3b10538e889f4243a77ecf855a

commit 8d8b74adc9084e3b10538e889f4243a77ecf855a
Author: Kevin McNee <mcnee@chromium.org>
Date: Mon Sep 24 18:57:38 2018

Re-enable SitePerProcessHitTestBrowserTest.TouchpadPinchOverOOPIF on Windows

The work done in  crbug.com/833380  to address flakiness in
SitePerProcessHitTestBrowserTests likely resolves the source of flakiness
for this test.

Bug:  833380 
Change-Id: Idd54686f2ad3294ae9daca4faf43945dc428afb0
Reviewed-on: https://chromium-review.googlesource.com/1236835
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Commit-Queue: Kevin McNee <mcnee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593615}
[modify] https://crrev.com/8d8b74adc9084e3b10538e889f4243a77ecf855a/content/browser/renderer_host/render_widget_host_input_event_router.h
[modify] https://crrev.com/8d8b74adc9084e3b10538e889f4243a77ecf855a/content/browser/site_per_process_hit_test_browsertest.cc

Sign in to add a comment