omnibox shadow is at same depth as its caster |
||||||||
Issue descriptionOnce these two are separated the shadow will be come softened.
,
Apr 16 2018
,
Apr 17 2018
Your change meets the bar and is auto-approved for M67. Please go ahead and merge the CL to branch 3396 manually. Please contact milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a9741a3c07624404f14c5f32175335109d83e48c commit a9741a3c07624404f14c5f32175335109d83e48c Author: Ian Vollick <vollick@chromium.org> Date: Mon Apr 16 16:43:31 2018 [vr] Fix shadow offsets Gives the omnibox a soft shadow. Bug: 833375 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr Change-Id: I17b9bbf4fdd2d8830e0157ddfd6b9ef57008ecb2 Reviewed-on: https://chromium-review.googlesource.com/1014010 Commit-Queue: Christopher Grant <cjgrant@chromium.org> Reviewed-by: Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#551010} [modify] https://crrev.com/a9741a3c07624404f14c5f32175335109d83e48c/chrome/browser/vr/ui_scene_creator.cc
,
Apr 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8d870a030937d7bc3a204da9ee11cb561fbbd554 commit 8d870a030937d7bc3a204da9ee11cb561fbbd554 Author: Ian Vollick <vollick@chromium.org> Date: Tue Apr 17 18:48:13 2018 [vr] Fix shadow offsets Gives the omnibox a soft shadow. Bug: 833375 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr Change-Id: I17b9bbf4fdd2d8830e0157ddfd6b9ef57008ecb2 Reviewed-on: https://chromium-review.googlesource.com/1014010 Commit-Queue: Christopher Grant <cjgrant@chromium.org> Reviewed-by: Christopher Grant <cjgrant@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#551010}(cherry picked from commit a9741a3c07624404f14c5f32175335109d83e48c) Reviewed-on: https://chromium-review.googlesource.com/1015186 Reviewed-by: Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/branch-heads/3396@{#54} Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428} [modify] https://crrev.com/8d870a030937d7bc3a204da9ee11cb561fbbd554/chrome/browser/vr/ui_scene_creator.cc
,
Apr 18 2018
Marking this fixed on behalf of Ian.
,
May 8 2018
Verified fix on 67.3396.29 beta. Looks as expected. softened.
,
May 8 2018
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by bugdroid1@chromium.org
, Apr 16 2018