New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 833348 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug
Team-Accessibility


Sign in to add a comment

Some system UI components don't respect the display workarea when modified by the docked magnifier

Project Member Reported by rkalavakuntla@chromium.org, Apr 16 2018

Issue description

Chrome Version:67.0.3396.0/10575.3.0 dev channel Candy,Reks,Peppy
OS:Chrome OS

What steps will reproduce the problem?
(1)Recover build >>In OOBE screen,Connect to a network
(2)Enable Docked Magnifier from Accessibility
(3)Go to 'Sign into your Chromebook' screen and observe

Actual: Unable to view the Email field when entering an Email
Expected: Should be able to view the email field while entering some text

Raising this as Non-regression issue as the feature is newly implemented in M-67

Note:Issue is not seen for Linux,Windows OS

Attached the screencast for reference..



 
Actual.mp4
13.2 MB View Download
Owner: alemate@chromium.org
Status: Assigned (was: Untriaged)
The problem is that OOBE has a fixed-size window which probably doesn't respect the display's workarea (which the docked magnifier changes). alemate@ can you please take a look?
I don't know how magnifier is expected to work.

Could you suggest what we could change here?

Expected: I recommend to view the Email text field at least when entering some text
Actual:Unable to view the Email field when editing.
Magnifier changes the display's workarea [1] in the same way the shelf, and the chromevox panel do. Effectively reducing the height of the available area for windows. Windows should respect that, so instead of basing your window size on the full size of the display, you can base it on the workarea size. You can use the WorkAreaWatcherObserver [2].

[1]: https://cs.chromium.org/chromium/src/ui/display/display.h?type=cs&q=display::Display::work_area&l=120

[2]: https://cs.chromium.org/chromium/src/ui/base/work_area_watcher_observer.h?type=cs&q=Workareachange&l=17
Labels: MagnifierCrOS
Cc: leberly@chromium.org
 Issue 875949  has been merged into this issue.
Summary: Docked Magnifier not respecting display workarea; cutting off top (was: Non-Regression: Unable to view the Email field when DockMagnifier is ON)
Labels: a11y-q2-18
This is now the master bug for these issues across the UI. Relevant bugs that aren't merged yet, please consider merging: 
868625
868623
865795
865792

Blocking: 860093
Blocking: 868625
Blocking: 868623
Blocking: 865795
Blocking: 865792
Summary: Some system UI components don't respect the display workarea when modified by the docked magnifier (was: Docked Magnifier not respecting display workarea; cutting off top)
The old title is wrong. Docked magnifier changes the workarea, some other system components don't respect the modified workarea
Thanks for that update and clarification, afakhry@. Please let me know if you feel that all these bugs should be merged as dupes. Otherwise, I'll just leave this as the master blocking bug. 
Blocking: 886980
Blocking: 889334
Blocking: 890466
Cc: r...@chromium.org zalcorn@chromium.org
Owner: jdufault@chromium.org
Jacob, could you help finding owner for this?
Cc: alemate@chromium.org
alemate@ this should be easy to fix for OOBE, just listen to display::DisplayObserver::OnDisplayMetricsChanged() for DISPLAY_METRIC_WORK_AREA and update your bounds according to the current display's Display::work_area().
Blocking: 906768
Blocking: 908972
Blocking: 910796
Blocking: 910803
Labels: a11y-LoginScreen

Sign in to add a comment