Issue metadata
Sign in to add a comment
|
Non-Regression: Ubertray is not seen in docked region when docked magnifier is enabled in sign-out screen |
||||||||||||||||||||||||
Issue descriptionChrome Version: 67.0.3396.0/10575.3.0 dev channel Candy,Reks,Peppy OS:Chrome OS What steps will reproduce the problem? (1)In Sign-out screen>> Enable docked magnifier>> Now keep tabbing and observe Actual: When focus is on Ubertray, Ubertray is not seen in docked region Expected: When focus is on Ubertray, Ubertray should be seen in docked region This is a Non-Regression issue seen from M67 @Wzang: Please confirm the issue
,
Apr 17 2018
This is happening for the fullscreen magnifier as well. I'm working on a fix.
,
Apr 21 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/aabb73a1a1a00cc3af265a643fc1aa883e1e63df commit aabb73a1a1a00cc3af265a643fc1aa883e1e63df Author: Ahmed Fakhry <afakhry@google.com> Date: Sat Apr 21 00:39:43 2018 Make magnifiers respond to native Views focus change events Make the focus manager notify the focus manager delegate with focus changed events, and make the ash focus manager delegate center the viewport of the currently enabled magnifier (if any) around the center of the focused view. BUG= 833345 Change-Id: Ifc047e761bc24b58029545113a3a5ab6dbf01ef6 Reviewed-on: https://chromium-review.googlesource.com/1014680 Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by: Michael Wasserman <msw@chromium.org> Reviewed-by: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#552533} [modify] https://crrev.com/aabb73a1a1a00cc3af265a643fc1aa883e1e63df/ash/accelerators/ash_focus_manager_factory.cc [modify] https://crrev.com/aabb73a1a1a00cc3af265a643fc1aa883e1e63df/ash/accelerators/ash_focus_manager_factory.h [modify] https://crrev.com/aabb73a1a1a00cc3af265a643fc1aa883e1e63df/ash/magnifier/docked_magnifier_controller_unittest.cc [modify] https://crrev.com/aabb73a1a1a00cc3af265a643fc1aa883e1e63df/ash/magnifier/magnification_controller.cc [modify] https://crrev.com/aabb73a1a1a00cc3af265a643fc1aa883e1e63df/ash/magnifier/magnification_controller.h [modify] https://crrev.com/aabb73a1a1a00cc3af265a643fc1aa883e1e63df/ash/magnifier/magnification_controller_unittest.cc [modify] https://crrev.com/aabb73a1a1a00cc3af265a643fc1aa883e1e63df/ash/magnifier/magnifier_test_utils.cc [modify] https://crrev.com/aabb73a1a1a00cc3af265a643fc1aa883e1e63df/ash/magnifier/magnifier_test_utils.h [modify] https://crrev.com/aabb73a1a1a00cc3af265a643fc1aa883e1e63df/testing/buildbot/filters/mash.ash_unittests.filter [modify] https://crrev.com/aabb73a1a1a00cc3af265a643fc1aa883e1e63df/ui/views/focus/focus_manager.cc [modify] https://crrev.com/aabb73a1a1a00cc3af265a643fc1aa883e1e63df/ui/views/focus/focus_manager_delegate.h
,
Apr 21 2018
|
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by wzang@chromium.org
, Apr 16 2018