supersize archive failing on lld builds |
||||
Issue description
Noticed this in my nightly build:
1650 2018-04-15 22:30:48 -0400 + tools/binary_size/supersize archive out-gn/Release/apks/Monochrome.apk.size --apk-file out-gn/Release/apks/Monochrome.apk
1651 2018-04-15 22:30:50 -0400 Traceback (most recent call last):
1652 2018-04-15 22:30:50 -0400 File "tools/binary_size/libsupersize/main.py", line 114, in <module>
1653 2018-04-15 22:30:50 -0400 main()
1654 2018-04-15 22:30:50 -0400 File "tools/binary_size/libsupersize/main.py", line 110, in main
1655 2018-04-15 22:30:50 -0400 args.func(args, parser)
1656 2018-04-15 22:30:50 -0400 File "/usr/local/google/home/agrieve/ssd/git/clankium1/src/tools/binary_size/libsupersize/archive.py", line 1251, in Run
1657 2018-04-15 22:30:50 -0400 DeduceMainPaths(args, parser))
1658 2018-04-15 22:30:50 -0400 File "/usr/local/google/home/agrieve/ssd/git/clankium1/src/tools/binary_size/libsupersize/archive.py", line 1233, in DeduceMainPaths
1659 2018-04-15 22:30:50 -0400 linker_name = _DetectLinkerName(map_path)
1660 2018-04-15 22:30:50 -0400 File "/usr/local/google/home/agrieve/ssd/git/clankium1/src/tools/binary_size/libsupersize/archive.py", line 1115, in _DetectLinkerName
1661 2018-04-15 22:30:50 -0400 return linker_map_parser.DetectLinkerNameFromMapFileHeader(next(map_file))
1662 2018-04-15 22:30:50 -0400 File "/usr/local/google/home/agrieve/ssd/git/clankium1/src/tools/binary_size/libsupersize/linker_map_parser.py", line 378, in DetectLinkerNameFromMapFileHeader
1663 2018-04-15 22:30:50 -0400 raise Exception('Invalid map file.')
1664 2018-04-15 22:30:50 -0400 Exception: Invalid map file.
Looks like the linker map file format has added a new column. Guessing it broke with this roll:
1f109d9c516640dda836493b24fd033da64411ff
,
Apr 16 2018
The bot is back, but we've lost the weekend's worth of changes. Looks like there was a decent sized jump over the weekend, but at least it was in the right direction (down)! https://chromeperf.appspot.com/report?sid=d6542096534166992e063320f8e1b7128e10ed53091e865eef3b5295644e60ce&num_points=1000 https://ci.chromium.org/buildbot/chromium.perf/Android%20Builder%20Perf/?limit=200
,
Apr 16 2018
Issue 833346 has been merged into this issue.
,
Apr 16 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d4b2964ed7f539e663f57098743925294071d320 commit d4b2964ed7f539e663f57098743925294071d320 Author: Andrew Grieve <agrieve@chromium.org> Date: Mon Apr 16 18:10:52 2018 Supersize: Update to work with lld map file format change "Address" column was changed to VMA / LMA. TBR=agrieve@chromium.org, huangs NOTRY=true NOPRESUBMIT=true (cherry picked from commit dd5d5a01bc1f6a3b7d842942e88f621c673f067c) Bug: 833343 Change-Id: I2bacc49626794ae07fd9d02258e87a5620618cb1 Reviewed-on: https://chromium-review.googlesource.com/1014001 Commit-Queue: agrieve <agrieve@chromium.org> Reviewed-by: agrieve <agrieve@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#550964} Reviewed-on: https://chromium-review.googlesource.com/1014296 Cr-Commit-Position: refs/branch-heads/3397@{#4} Cr-Branched-From: dcddf51ec4ce5a464f901c1cf8fc8cc86c9f59b6-refs/heads/master@{#550857} [modify] https://crrev.com/d4b2964ed7f539e663f57098743925294071d320/tools/binary_size/libsupersize/linker_map_parser.py [modify] https://crrev.com/d4b2964ed7f539e663f57098743925294071d320/tools/binary_size/libsupersize/path_util.py
,
Apr 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dd5d5a01bc1f6a3b7d842942e88f621c673f067c commit dd5d5a01bc1f6a3b7d842942e88f621c673f067c Author: Andrew Grieve <agrieve@chromium.org> Date: Mon Apr 16 11:17:50 2018 Supersize: Update to work with lld map file format change "Address" column was changed to VMA / LMA. TBR=huangs NOTRY=true NOPRESUBMIT=true Bug: 833343 Change-Id: I2bacc49626794ae07fd9d02258e87a5620618cb1 Reviewed-on: https://chromium-review.googlesource.com/1014001 Commit-Queue: agrieve <agrieve@chromium.org> Reviewed-by: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#550964} [modify] https://crrev.com/dd5d5a01bc1f6a3b7d842942e88f621c673f067c/tools/binary_size/libsupersize/linker_map_parser.py [modify] https://crrev.com/dd5d5a01bc1f6a3b7d842942e88f621c673f067c/tools/binary_size/libsupersize/path_util.py |
||||
►
Sign in to add a comment |
||||
Comment 1 by bugdroid1@chromium.org
, Apr 16 2018