Regression: [DevTools] ColorPicker dialog gets dismissed on performing undo action using keyboard.
Reported by
dchau...@etouch.net,
Apr 16 2018
|
||||
Issue descriptionChrome Version: 68.0.3397.0 (Official Build) Revision dcddf51ec4ce5a464f901c1cf8fc8cc86c9f59b6-refs/heads/master@{#550857}32/64-bit. OS: Win(7,8,8.1,10), Mac(10.12.6, 10.13.1, 10.13.5) and Linux (14.04 LTS). What steps will reproduce the problem? 1. Launch Chrome, open ‘DevTools’ and click to open ColorPicker dialog under ‘Styles’ section. 2. Go to R/G/B/A text-box and remove the numeric value (For ex: 255) from it. 3. Now, press “Ctrl + Z” key from keyboard to undo the numeric value and observe. Actual: ColorPicker dialog gets dismissed on pressing press “Ctrl + Z” key from keyboard. Expected: ColorPicker dialog should not dismiss on pressing press “Ctrl + Z” key from keyboard. This is a regression issue, broken in M-65 series, below is manual regression range. Good build: 65.0.3323.0 (Revision: 529555) Bad build: 65.0.3324.0 (Revision: 530027) Using the per-revision bisect providing the bisect results: You are probably looking for a change made after 530005 (known good), but no later than 530006 (first known bad). CHANGELOG URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/0df2f5441276d78d86a5936f3640f34374cc89d6..ed9388054c24171adc1c1ac5e9795f1832e8f179 Suspecting: https://chromium.googlesource.com/chromium/src/+/ed9388054c24171adc1c1ac5e9795f1832e8f179 @pfeldman: Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner. NOTE: This issue is also reproducible on M-65 Stable (build # 65.0.3325.181) and M-66 Beta (build # 66.0.3359.106) and M-67 Dev (build # 67.0.3393.4) Kindly review the attached screen-cast for reference. Thank you.
,
Sep 19
,
Sep 19
,
Sep 19
Thanks for the report. This is no longer reproducible on 69.0.3497.100 or 71.0.3555.0. This was fixed in https://chromium.googlesource.com/chromium/src/+/ec3529b434fdde061f924b8e3a93f4f1a386f8c6 I'll investigate whether a good test can be added.
,
Oct 5
We still have a related bug with shortcuts: - Repeatedly type 'h' in the Color picker's RGB text input. Since the input has maxLength=4, pressing 'h' may not trigger 'input' events. In this case, DevTools fails to suppress the hide action.
,
Oct 18
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a51492da19a2a90fc44f5b0df3151e2f5c6c8346 commit a51492da19a2a90fc44f5b0df3151e2f5c6c8346 Author: Erik Luo <luoe@chromium.org> Date: Thu Oct 18 19:11:30 2018 DevTools: do not handle input key shortcuts when editing Typing 'h' in text inputs with 'maxLength' may produce key events without producing the 'input' event. This scenario leads DevTools to allow shortcut-defined actions that are normally suppressed. This CL replaces suppression logic with a simpler condition: "if a key might trigger input, and we are editing, do not run action" Bug: 833340 Change-Id: I75c5c0dd49c9f5b1624122345459438fc1d976f3 Reviewed-on: https://chromium-review.googlesource.com/c/1265837 Reviewed-by: Joel Einbinder <einbinder@chromium.org> Commit-Queue: Erik Luo <luoe@chromium.org> Cr-Commit-Position: refs/heads/master@{#600859} [modify] https://crrev.com/a51492da19a2a90fc44f5b0df3151e2f5c6c8346/third_party/blink/renderer/devtools/front_end/elements/ElementsPanel.js [modify] https://crrev.com/a51492da19a2a90fc44f5b0df3151e2f5c6c8346/third_party/blink/renderer/devtools/front_end/text_editor/CodeMirrorTextEditor.js [modify] https://crrev.com/a51492da19a2a90fc44f5b0df3151e2f5c6c8346/third_party/blink/renderer/devtools/front_end/ui/ShortcutRegistry.js
,
Oct 18
|
||||
►
Sign in to add a comment |
||||
Comment 1 by dchau...@etouch.net
, Apr 16 2018