The reason is that group IDs are hashed using a per-frame salt, but to match the spec we should use a salt per browsing session.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f400800871e08b92f669b907569b4decf1d3d65c commit f400800871e08b92f669b907569b4decf1d3d65c Author: Guido Urdaneta <guidou@chromium.org> Date: Thu May 03 10:43:04 2018 Move the media-devices group ID salt base from frame to WebContents. This is a better match for the spec, which says that group IDs are browsing-session unique, not frame-unique. This CL also reorganizes code in preparation for better support for the groupId constrainable property. Drive-by: Some minor fixes in WebRtcGetMediaDevicesBrowserTest. Bug: 833333 Change-Id: I4b7309fafc1f2c336bbe0d61f736992aa5d7f36e Reviewed-on: https://chromium-review.googlesource.com/1015560 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by: Alex Moshchuk <alexmos@chromium.org> Reviewed-by: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#555687} [modify] https://crrev.com/f400800871e08b92f669b907569b4decf1d3d65c/chrome/browser/media/webrtc/webrtc_getmediadevices_browsertest.cc [modify] https://crrev.com/f400800871e08b92f669b907569b4decf1d3d65c/content/browser/media/media_devices_util.cc [modify] https://crrev.com/f400800871e08b92f669b907569b4decf1d3d65c/content/browser/media/media_devices_util.h [modify] https://crrev.com/f400800871e08b92f669b907569b4decf1d3d65c/content/browser/renderer_host/media/audio_output_authorization_handler.cc [modify] https://crrev.com/f400800871e08b92f669b907569b4decf1d3d65c/content/browser/renderer_host/media/audio_output_authorization_handler.h [modify] https://crrev.com/f400800871e08b92f669b907569b4decf1d3d65c/content/browser/renderer_host/media/media_devices_dispatcher_host.cc [modify] https://crrev.com/f400800871e08b92f669b907569b4decf1d3d65c/content/browser/renderer_host/media/media_devices_dispatcher_host.h [modify] https://crrev.com/f400800871e08b92f669b907569b4decf1d3d65c/content/browser/renderer_host/media/media_devices_dispatcher_host_unittest.cc [modify] https://crrev.com/f400800871e08b92f669b907569b4decf1d3d65c/content/browser/renderer_host/media/media_devices_manager.cc [modify] https://crrev.com/f400800871e08b92f669b907569b4decf1d3d65c/content/browser/renderer_host/media/media_devices_manager.h [modify] https://crrev.com/f400800871e08b92f669b907569b4decf1d3d65c/content/browser/renderer_host/media/media_devices_manager_unittest.cc [modify] https://crrev.com/f400800871e08b92f669b907569b4decf1d3d65c/content/browser/renderer_host/media/media_stream_dispatcher_host.cc [modify] https://crrev.com/f400800871e08b92f669b907569b4decf1d3d65c/content/browser/renderer_host/media/media_stream_dispatcher_host.h [modify] https://crrev.com/f400800871e08b92f669b907569b4decf1d3d65c/content/browser/renderer_host/media/media_stream_dispatcher_host_unittest.cc [modify] https://crrev.com/f400800871e08b92f669b907569b4decf1d3d65c/content/browser/web_contents/web_contents_impl.cc [modify] https://crrev.com/f400800871e08b92f669b907569b4decf1d3d65c/content/browser/web_contents/web_contents_impl.h [add] https://crrev.com/f400800871e08b92f669b907569b4decf1d3d65c/third_party/WebKit/LayoutTests/fast/mediastream/MediaDevices-enumerateDevices-iframe.html [add] https://crrev.com/f400800871e08b92f669b907569b4decf1d3d65c/third_party/WebKit/LayoutTests/fast/mediastream/resources/MediaDevices-enumerateDevices-iframe-child.html
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/814d076a9365c16da0ad910244526484b6e586dd commit 814d076a9365c16da0ad910244526484b6e586dd Author: Guido Urdaneta <guidou@chromium.org> Date: Thu May 03 12:16:32 2018 Make MediaStreamManager/Dispatcher report device group ID. This change is in anticipation to add full support for the constrainable groupId property in MediaStreamTrack.getSettings() and MediaDevices.getUserMedia(). See follow-up CL: crrev.com/c/1019323 Drive-by: Fix minor whitespace/style issues. Bug: 833333 Change-Id: I821d2e34f7684dd1c0f8692e6219360cc1a77f66 Reviewed-on: https://chromium-review.googlesource.com/1021772 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by: Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#555701} [modify] https://crrev.com/814d076a9365c16da0ad910244526484b6e586dd/content/browser/renderer_host/media/media_stream_dispatcher_host.cc [modify] https://crrev.com/814d076a9365c16da0ad910244526484b6e586dd/content/browser/renderer_host/media/media_stream_dispatcher_host.h [modify] https://crrev.com/814d076a9365c16da0ad910244526484b6e586dd/content/browser/renderer_host/media/media_stream_dispatcher_host_unittest.cc [modify] https://crrev.com/814d076a9365c16da0ad910244526484b6e586dd/content/browser/renderer_host/media/media_stream_manager.cc [modify] https://crrev.com/814d076a9365c16da0ad910244526484b6e586dd/content/browser/renderer_host/media/media_stream_manager.h [modify] https://crrev.com/814d076a9365c16da0ad910244526484b6e586dd/content/browser/renderer_host/media/video_capture_unittest.cc [modify] https://crrev.com/814d076a9365c16da0ad910244526484b6e586dd/content/common/media/media_stream_param_traits.h [modify] https://crrev.com/814d076a9365c16da0ad910244526484b6e586dd/content/public/common/media_stream_request.cc [modify] https://crrev.com/814d076a9365c16da0ad910244526484b6e586dd/content/public/common/media_stream_request.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ca0aa2927a17d6ac4d82a4d7e9e3aff37d2a658d commit ca0aa2927a17d6ac4d82a4d7e9e3aff37d2a658d Author: Guido Urdaneta <guidou@chromium.org> Date: Fri May 04 18:24:49 2018 Support groupId constrainable properties in MediaDevices.getUserMedia() This CL also adds support in MediaStreamTrack.applyConstraints(). Drive-by: Minor lint fixes. Bug: 833333 Change-Id: I8636def42d9ed64c6f58777d44343e569e541bfb Reviewed-on: https://chromium-review.googlesource.com/1021570 Reviewed-by: Tom Sepez <tsepez@chromium.org> Reviewed-by: Harald Alvestrand <hta@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#556124} [modify] https://crrev.com/ca0aa2927a17d6ac4d82a4d7e9e3aff37d2a658d/content/browser/renderer_host/media/media_devices_dispatcher_host.cc [modify] https://crrev.com/ca0aa2927a17d6ac4d82a4d7e9e3aff37d2a658d/content/browser/renderer_host/media/media_devices_dispatcher_host.h [modify] https://crrev.com/ca0aa2927a17d6ac4d82a4d7e9e3aff37d2a658d/content/renderer/media/stream/apply_constraints_processor.cc [modify] https://crrev.com/ca0aa2927a17d6ac4d82a4d7e9e3aff37d2a658d/content/renderer/media/stream/media_stream_constraints_util_video_device.cc [modify] https://crrev.com/ca0aa2927a17d6ac4d82a4d7e9e3aff37d2a658d/content/renderer/media/stream/media_stream_constraints_util_video_device_unittest.cc [modify] https://crrev.com/ca0aa2927a17d6ac4d82a4d7e9e3aff37d2a658d/third_party/WebKit/LayoutTests/external/wpt/mediacapture-streams/MediaDevices-getUserMedia.https.html [add] https://crrev.com/ca0aa2927a17d6ac4d82a4d7e9e3aff37d2a658d/third_party/WebKit/LayoutTests/external/wpt/mediacapture-streams/MediaStreamTrack-applyConstraints.https.html [modify] https://crrev.com/ca0aa2927a17d6ac4d82a4d7e9e3aff37d2a658d/third_party/blink/public/platform/modules/mediastream/media_devices.mojom [modify] https://crrev.com/ca0aa2927a17d6ac4d82a4d7e9e3aff37d2a658d/third_party/blink/renderer/modules/mediastream/media_devices_test.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dabbfaf85eca64fa2134bb4b1008cf7e55f2453b commit dabbfaf85eca64fa2134bb4b1008cf7e55f2453b Author: Guido Urdaneta <guidou@chromium.org> Date: Mon May 07 14:42:52 2018 Support groupId in MediaStremTrack.getCapabilities() for video tracks Bug: 833333 Change-Id: I9154e97c07484c40a2f8308216d2c04d02fae528 Reviewed-on: https://chromium-review.googlesource.com/1021697 Reviewed-by: Jochen Eisinger <jochen@chromium.org> Reviewed-by: Harald Alvestrand <hta@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#556435} [modify] https://crrev.com/dabbfaf85eca64fa2134bb4b1008cf7e55f2453b/content/renderer/media/stream/media_stream_constraints_util.cc [modify] https://crrev.com/dabbfaf85eca64fa2134bb4b1008cf7e55f2453b/content/renderer/media/stream/media_stream_constraints_util.h [modify] https://crrev.com/dabbfaf85eca64fa2134bb4b1008cf7e55f2453b/content/renderer/media/stream/user_media_processor.cc [modify] https://crrev.com/dabbfaf85eca64fa2134bb4b1008cf7e55f2453b/third_party/WebKit/LayoutTests/external/wpt/mediacapture-streams/MediaStreamTrack-getCapabilities.https.html [modify] https://crrev.com/dabbfaf85eca64fa2134bb4b1008cf7e55f2453b/third_party/WebKit/LayoutTests/fast/mediastream/MediaStreamTrack-getCapabilities.html [modify] https://crrev.com/dabbfaf85eca64fa2134bb4b1008cf7e55f2453b/third_party/blink/public/platform/web_media_stream_source.h [modify] https://crrev.com/dabbfaf85eca64fa2134bb4b1008cf7e55f2453b/third_party/blink/renderer/modules/mediastream/media_stream_track.cc
[bulk-edit: disregard if N/A] Can the owner please set milestone to this bug if applicable?
Comment 1 by guidou@chromium.org
, Apr 16 2018