New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 833332 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Move hotword related model files to public overlay

Project Member Reported by cychiang@chromium.org, Apr 16 2018

Issue description

For example, 
The hotword model files are installed by kbl-rt5514-hotword-support.
We should move the files to public overlay so image built from public overlay can use the same UCM file as image built from private overlay.
 

Comment 1 by pbe...@chromium.org, Apr 16 2018

this means we need to move the binaries to a different storage than BCS so no special credentials are required.

Comment 2 by pbe...@chromium.org, Apr 19 2018

I'm moving the APL hotword models to localmirror. Will follow up with the kbl ones.
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 20 2018

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/overlays/overlay-coral-private/+/00d94750f576dd66b49691d449a725a870dd1e68

commit 00d94750f576dd66b49691d449a725a870dd1e68
Author: Patrick Berny <pberny@google.com>
Date: Fri Apr 20 09:48:34 2018

Project Member

Comment 4 by bugdroid1@chromium.org, Apr 20 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/23518ab0e8c55c3347ddd465f2bb46f520cb8636

commit 23518ab0e8c55c3347ddd465f2bb46f520cb8636
Author: Patrick Berny <pberny@chromium.org>
Date: Fri Apr 20 09:48:35 2018

coral: Support audio with public builds

In order to support audio on builds from public sources only, it is
necessary to build the sound topology binary from .conf using alsatplg.
Since the hotword model files can only be shared as binary, but are ok
to be fetched from a publicly accessible server instead of BCS the
media-libs/apl-hotword-support package is moved to the public overlay.

Notable known downsides of the current .conf file:
  - Speaker is too loud (i.e. use at your own risk)
  - Headset looks not to be working

This package's README.md has instructions how to integrate the original
topology binaries for full functionality and correct tuning.

BUG=chromium:833332,b:76438191
TEST=build image from external sources only and test sound on robo360.
     build image from internal source and make sure the right topology
     file gets installed onto image.
CQ-DEPEND=CL:*610814

Change-Id: I78da760da8025a5c5db5a17f021102c76b6b21f3
Signed-off-by: Harry Pan <harry.pan@intel.com>
Reviewed-on: https://chromium-review.googlesource.com/996412
Commit-Ready: Patrick Berny <pberny@chromium.org>
Tested-by: Patrick Berny <pberny@chromium.org>
Reviewed-by: Hsinyu Chao <hychao@chromium.org>
Reviewed-by: Bob Moragues <moragues@chromium.org>

[add] https://crrev.com/23518ab0e8c55c3347ddd465f2bb46f520cb8636/chipset-apl/media-libs/apl-hotword-support/Manifest
[add] https://crrev.com/23518ab0e8c55c3347ddd465f2bb46f520cb8636/chipset-apl/media-libs/apl-hotword-support/apl-hotword-support-1.0.ebuild
[add] https://crrev.com/23518ab0e8c55c3347ddd465f2bb46f520cb8636/overlay-coral/media-libs/lpe-support-topology/lpe-support-topology-0.0.1.ebuild
[add] https://crrev.com/23518ab0e8c55c3347ddd465f2bb46f520cb8636/chipset-apl/media-libs/apl-hotword-support/apl-hotword-support-1.0-r6.ebuild
[add] https://crrev.com/23518ab0e8c55c3347ddd465f2bb46f520cb8636/overlay-coral/media-libs/lpe-support-topology/files/bxt_i2s.conf
[add] https://crrev.com/23518ab0e8c55c3347ddd465f2bb46f520cb8636/overlay-coral/media-libs/lpe-support-topology/lpe-support-topology-0.0.1-r1.ebuild
[add] https://crrev.com/23518ab0e8c55c3347ddd465f2bb46f520cb8636/overlay-coral/media-libs/lpe-support-topology/README.md

Project Member

Comment 5 by bugdroid1@chromium.org, Apr 20 2018

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/overlays/chipset-apl-private/+/9b78bcf2a4779e09e12950aa30ec65d24ab6993d

commit 9b78bcf2a4779e09e12950aa30ec65d24ab6993d
Author: Patrick Berny <pberny@google.com>
Date: Fri Apr 20 09:48:36 2018

Sign in to add a comment