Issue metadata
Sign in to add a comment
|
1.6% regression in system_health.memory_desktop at 549474:549534 |
||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
Apr 16 2018
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/11e546aac40000
,
Apr 16 2018
📍 Found a significant difference after 1 commit. https://pinpoint-dot-chromeperf.appspot.com/job/11e546aac40000 [AdTracking] Include the top of the stack in AdTracker detection by jkarlin@chromium.org https://chromium.googlesource.com/chromium/src/+/bf5b0e09aa81fd00a9586d71cecf96e3e508e946 Understanding performance regressions: http://g.co/ChromePerformanceRegressions
,
Apr 16 2018
Aleksey, does an increase in desktop memory make sense to you from calling SourceLocation::Capture more often?
,
Apr 17 2018
400 Kb.. Without DevTools SourceLocation::capture should capture only top stack trace frame. We cache symbolized version of this frame and we cleanup this cache under memory pressure. I assume that per frame this cache should take not more then hundreds bytes. So even if it takes 400 bytes, it means that we cached 1000 additional frames. I am not sure what pages is loaded by this test and is it reasonable amount of frames or we leaked something else.
,
Apr 17 2018
Thanks Aleksey. The CL in question calls SourceLocation::capture each time a resource is loaded, so we'd get to the thousands very quickly. Is the v8 frame cache bounded in size?
,
Apr 24 2018
Closing as wontfix since it's a cache that will free itself under memory pressure. |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by 42576172...@developer.gserviceaccount.com
, Apr 16 2018