New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 833321 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Apr 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

1.6% regression in system_health.memory_desktop at 549474:549534

Project Member Reported by petermarshall@chromium.org, Apr 16 2018

Issue description

See the link to graphs below.
 
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, Apr 16 2018

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=833321

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=afc7b59b266f6cf824d443fc12ed09121f4d5a7af7e94aa5975452e6d08eb2dd


Bot(s) for this bug's original alert(s):

chromium-rel-win7-x64-dual
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Apr 16 2018

Cc: jkarlin@chromium.org japhet@chromium.org
Owner: jkarlin@chromium.org
Status: Assigned (was: Untriaged)
📍 Found a significant difference after 1 commit.
https://pinpoint-dot-chromeperf.appspot.com/job/11e546aac40000

[AdTracking] Include the top of the stack in AdTracker detection by jkarlin@chromium.org
https://chromium.googlesource.com/chromium/src/+/bf5b0e09aa81fd00a9586d71cecf96e3e508e946

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions
Cc: kozyatinskiy@chromium.org
Aleksey, does an increase in desktop memory make sense to you from calling SourceLocation::Capture more often?

Comment 5 by kozy@chromium.org, Apr 17 2018

400 Kb.. Without DevTools SourceLocation::capture should capture only top stack trace frame. We cache symbolized version of this frame and we cleanup this cache under memory pressure.
I assume that per frame this cache should take not more then hundreds bytes. So even if it takes 400 bytes, it means that we cached 1000 additional frames. I am not sure what pages is loaded by this test and is it reasonable amount of frames or we leaked something else.
Thanks Aleksey. The CL in question calls SourceLocation::capture each time a resource is loaded, so we'd get to the thousands very quickly. Is the v8 frame cache bounded in size? 
Status: WontFix (was: Assigned)
Closing as wontfix since it's a cache that will free itself under memory pressure.

Sign in to add a comment