New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 833303 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

12.5% regression in blink_perf.bindings at 549070:549078

Project Member Reported by toyoshim@chromium.org, Apr 16 2018

Issue description

See the link to graphs below.
 
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, Apr 16 2018

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=833303

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=fd4660801b905b649c8569b8936bbf710ed9e2b802a63c97ab245cc6fe9f965b


Bot(s) for this bug's original alert(s):

android-nexus6
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Apr 16 2018

Cc: vollick@chromium.org sky@chromium.org afdo-chr...@skia-buildbots.google.com.iam.gserviceaccount.com ddorwin@chromium.org
Owner: vollick@chromium.org
Status: Assigned (was: Untriaged)
📍 Found significant differences after each of 2 commits.
https://pinpoint-dot-chromeperf.appspot.com/job/12bc52aac40000

Roll AFDO from 67.0.3379.0_rc-r1 to 67.0.3390.0_rc-r1 by afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com
https://chromium.googlesource.com/chromium/src/+/c1e3fa4c733bf46e284e257377b5443bdb549910

[xr] Add a flag for enabling XR hit test support by vollick@chromium.org
https://chromium.googlesource.com/chromium/src/+/7aaccf95fda3415c10feaa5947f6b353045d33e3

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions
Owner: bsalomon@chromium.org
This CL adds an unused flag. I don't see how this could affect performance.

Brian, any chance this could be related to the roll?

Comment 5 by bsalo...@google.com, Apr 27 2018

Owner: g...@chromium.org
This is not actually a Skia roll but a AFDO roll. It uses the Skia autoroller (which is somewhat confusing).


Comment 6 by g...@chromium.org, Apr 27 2018

Ack; thanks.

AFDO profile rolls are known to rarely cause changes in blink benchmarks.

The general opinion when we landed AFOD was "blink regressions are great to use as an indicator when triaging a regression of a higher-level benchmark, but a few blink regressions on their own are too micro-benchmark-y and sensitive to e.g. inlining decisions to provide much signal."

With that in mind, I'm on vacation for a week after today, so I'll let this sit + see if I get any other related bugs in that time. If this is the only complaint I hear, I plan to WontFix this.

Sign in to add a comment