Issue metadata
Sign in to add a comment
|
12.5% regression in blink_perf.bindings at 549070:549078 |
||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
Apr 16 2018
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/12bc52aac40000
,
Apr 16 2018
📍 Found significant differences after each of 2 commits. https://pinpoint-dot-chromeperf.appspot.com/job/12bc52aac40000 Roll AFDO from 67.0.3379.0_rc-r1 to 67.0.3390.0_rc-r1 by afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com https://chromium.googlesource.com/chromium/src/+/c1e3fa4c733bf46e284e257377b5443bdb549910 [xr] Add a flag for enabling XR hit test support by vollick@chromium.org https://chromium.googlesource.com/chromium/src/+/7aaccf95fda3415c10feaa5947f6b353045d33e3 Understanding performance regressions: http://g.co/ChromePerformanceRegressions
,
Apr 27 2018
This CL adds an unused flag. I don't see how this could affect performance. Brian, any chance this could be related to the roll?
,
Apr 27 2018
This is not actually a Skia roll but a AFDO roll. It uses the Skia autoroller (which is somewhat confusing).
,
Apr 27 2018
Ack; thanks. AFDO profile rolls are known to rarely cause changes in blink benchmarks. The general opinion when we landed AFOD was "blink regressions are great to use as an indicator when triaging a regression of a higher-level benchmark, but a few blink regressions on their own are too micro-benchmark-y and sensitive to e.g. inlining decisions to provide much signal." With that in mind, I'm on vacation for a week after today, so I'll let this sit + see if I get any other related bugs in that time. If this is the only complaint I hear, I plan to WontFix this. |
|||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||
Comment 1 by 42576172...@developer.gserviceaccount.com
, Apr 16 2018