Issue metadata
Sign in to add a comment
|
3.7%-7.5% regression in system_health.memory_desktop at 550004:550165 |
||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
Apr 16 2018
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/169bfa46c40000
,
Apr 16 2018
📍 Found a significant difference after 1 commit. https://pinpoint-dot-chromeperf.appspot.com/job/169bfa46c40000 Reduce noise of memory metric. by ulan@chromium.org https://chromium.googlesource.com/catapult/+/64d08119f342961a5dd64049a03a50d36585899c Understanding performance regressions: http://g.co/ChromePerformanceRegressions
,
Apr 17 2018
Issue 833270 has been merged into this issue.
,
Apr 17 2018
This seems to affect mobiles too. It's surprising to me since I thought catapult was not included in mobile builds. Please double check it.
,
Apr 18 2018
toyoshim@, it is a memory metric change. It affects all platforms. Please not that this is not a real regression. The way how we measure memory is changing. The metrics that regressed on mobile are mostly private_footprint_size_avg and private_dirty_size_avg. The regression is about 500KB (V8 page size). V8 unmaps unused pages concurrently. We are now sampling memory usage immediately after GC, so there might be not enough time for unmapping. It makes sense to wait for the concurrent unmapper in GCs caused by telemetry. I will add such logic in V8.
,
Apr 19 2018
Ah, I see, that all makes sense.
,
Apr 19 2018
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/10fce9c80a6557c7e2f60bf24b61118eaa8ce0b9 commit 10fce9c80a6557c7e2f60bf24b61118eaa8ce0b9 Author: Ulan Degenbaev <ulan@chromium.org> Date: Thu Apr 19 16:13:04 2018 [heap] Do eager unmapping in CollectAllAvailableGarbage. The memory metric samples memory usage immediately after forcing GC via LowMemoryNotification. This makes the metric sensitive to the unmapper tasks timing. This patch forces eager unmapping in CollectAllAvailableGarbage. It also forces eager unmapping of non-regular chunks at the beginning of Mark-Compact to avoid accumulation of non-regular chunks. Bug: chromium:833291 , chromium:826384 Change-Id: Iddf02cd4ab8613385d033899d29525fe6ee47fdd Reviewed-on: https://chromium-review.googlesource.com/1017102 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#52696} [modify] https://crrev.com/10fce9c80a6557c7e2f60bf24b61118eaa8ce0b9/src/heap/heap.cc [modify] https://crrev.com/10fce9c80a6557c7e2f60bf24b61118eaa8ce0b9/src/heap/mark-compact.cc [modify] https://crrev.com/10fce9c80a6557c7e2f60bf24b61118eaa8ce0b9/src/heap/spaces.cc [modify] https://crrev.com/10fce9c80a6557c7e2f60bf24b61118eaa8ce0b9/src/heap/spaces.h [modify] https://crrev.com/10fce9c80a6557c7e2f60bf24b61118eaa8ce0b9/src/isolate.cc [modify] https://crrev.com/10fce9c80a6557c7e2f60bf24b61118eaa8ce0b9/test/cctest/BUILD.gn [modify] https://crrev.com/10fce9c80a6557c7e2f60bf24b61118eaa8ce0b9/test/cctest/heap/test-page-promotion.cc [modify] https://crrev.com/10fce9c80a6557c7e2f60bf24b61118eaa8ce0b9/test/cctest/heap/test-spaces.cc [add] https://crrev.com/10fce9c80a6557c7e2f60bf24b61118eaa8ce0b9/test/cctest/heap/test-unmapper.cc
,
Apr 24 2018
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/14f02199c40000
,
Apr 24 2018
📍 Found a significant difference after 1 commit. https://pinpoint-dot-chromeperf.appspot.com/job/14f02199c40000 Only show default poster when the controls attr is set by steimel@chromium.org https://chromium.googlesource.com/chromium/src/+/92619d7e8b26975354187ea6e81ac98b49da6953 Understanding performance regressions: http://g.co/ChromePerformanceRegressions
,
Apr 24 2018
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/14e0e3a9c40000
,
Apr 24 2018
📍 Found a significant difference after 1 commit. https://pinpoint-dot-chromeperf.appspot.com/job/14e0e3a9c40000 Only show default poster when the controls attr is set by steimel@chromium.org https://chromium.googlesource.com/chromium/src/+/92619d7e8b26975354187ea6e81ac98b49da6953 Understanding performance regressions: http://g.co/ChromePerformanceRegressions
,
Apr 24 2018
My CL in comment #8 fixed the noise of the private footprint metric. There are alerts are about GPU and compositor memory, which are unrelated to my CLs. steimel@, is it expected that "Only show default poster when the controls attr is set" increases GPU and compositor memory usage? Assigning to you to check and fix (or close as won't fix).
,
May 2 2018
,
May 2 2018
,
May 9 2018
steimel, beccahughes: can you clarify the answers to ulan's questions in #13?
,
May 9 2018
That CL should have a positive effect on performance so I will close as WontFix. |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by 42576172...@developer.gserviceaccount.com
, Apr 16 2018