New issue
Advanced search Search tips

Issue 833281 link

Starred by 1 user
Status: Fixed
Owner:
patricia...@chromium.org
Closed: Apr 2018
Cc:
jdonnelly@chromium.org
sgabr...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Chrome Touch: Omnibox in incognito with the popup open isn't coloured properly.

Project Member Reported by patricia...@chromium.org, Apr 16 2018 
What steps will reproduce the problem?
1. With #top-chrome-md set to Touchable, open an incognito window.
2. Type in the omnibox.

What is the expected result?
The background of the omnibox is coloured properly.

What happens instead of that?
The outside of the omnibox looks like it has a stroke on the edges except the right side.

This was caused by a bug in r550927. See attached screenshot.
Screenshot from 2018-04-16 17-15-50.png
22.6 KB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 17 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3010d2e5a2ec25630354cbe50c992d5cfb811045

commit 3010d2e5a2ec25630354cbe50c992d5cfb811045
Author: Patti <patricialor@chromium.org>
Date: Tue Apr 17 00:59:43 2018

Omnibox/Views: Fix cutout position while the omnibox popup is open in touch.

The rounded omnibox drop-down cuts out a hole for the omnibox to show through
when it's open to avoid having to teleport the LocationBarView between Widgets.
r550927 adjusted the positioning and size of the drop-down, but regressed by
positioning the cutout incorrectly. This patch re-aligns it.

Bug:  833281 
Change-Id: If95dad702b54fa44e6e8e6df4b959401510993df
Reviewed-on: https://chromium-review.googlesource.com/1013020
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Commit-Queue: Patti <patricialor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551198}
[modify] https://crrev.com/3010d2e5a2ec25630354cbe50c992d5cfb811045/chrome/browser/ui/views/omnibox/rounded_omnibox_results_frame.cc

Comment 2 by patricia...@chromium.org, Apr 18 2018

Status: Fixed (was: Started)
►

Sign in to add a comment