New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 833271 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression : 'Performance monitor' tab appears blank after reopening the devtools window.

Reported by avsha...@etouch.net, Apr 16 2018

Issue description

Chrome Version : 68.0.3397.0 (Official Build) dcddf51ec4ce5a464f901c1cf8fc8cc86c9f59b6-refs/heads/master@{#550857} 32/64-bit
OS : Windows(7,8,8.1,10)

What steps will reproduce the problem?
1. Launch chrome, open NTP and hit F12 to open devtools.
2. Press 'Esc' key (drawer opens) and open 'Performance monitor' tab.
3. Close the devtools window using 'X' button and reopen it through F12 key.
4. Observe the 'Performance monitor' tab in drawer.

Actual Result : 'Performance monitor' tab appears blank after reopening the devtools window.

Expected Result : 'Performance monitor' tab should work as expected after reopening devtools window.

This is a regression issue, broken in M-67 and will soon update remaining info.
Good Build : 67.0.3390.0
Bad Build : 67.0.3393.0
 
Actual_Result.mp4
660 KB View Download
Expected_Result.mp4
747 KB View Download

Comment 1 by avsha...@etouch.net, Apr 16 2018

Labels: RegressedIn-67 Target-67 FoundIn-67 Target-68 FoundIn-68 hasbisect OS-Mac
Owner: alph@chromium.org
Status: Assigned (was: Unconfirmed)

This is a regression issue, broken in M-67 and below is the narrow bisect info:
Good Build : 67.0.3390.0 (revision : 548637)
Bad Build : 67.0.3393.0 (revision : 549377)

(Getting 'No enough builds..' error while performing bisect with per-revision script hence providing the bisect using old script)

Narrow bisect URL : 
https://chromium.googlesource.com/chromium/src/+log/2967489d082e4175e49956f5dd5b6d50468c5f73..972d135e00d4462bcd1443ea2b17ab6ef20d746a?pretty=fuller&n=10000

Suspecting : r548979

@Alexei : Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Note : 
1. Issue is also observed in Dev build #67.0.3393.4
2. Able to reproduce issue on Mac(10.12.6, 10.13.1, 10.13.5) OS but the same issue is not observed on Linux(14.04 LTS) machine
Cc: manoranj...@chromium.org
Labels: ReleaseBlock-Stable
Adding release blocker label for this issue.Please reduce priority or remove if not the case.

Thank You!
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0eab72ec3aa68755dfb7fa1a9282a4dd0d5f945a

commit 0eab72ec3aa68755dfb7fa1a9282a4dd0d5f945a
Author: Alexei Filippov <alph@chromium.org>
Date: Wed Apr 18 03:25:32 2018

DevTools: Do not start performance monitor until model is ready.

BUG= 833271 

Change-Id: I62b0f0a598fa9caabde156609a8176ebad965e88
Reviewed-on: https://chromium-review.googlesource.com/1015536
Commit-Queue: Alexei Filippov <alph@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551568}
[modify] https://crrev.com/0eab72ec3aa68755dfb7fa1a9282a4dd0d5f945a/third_party/blink/renderer/devtools/front_end/performance_monitor/PerformanceMonitor.js

Comment 4 by avsha...@etouch.net, Apr 19 2018

Labels: TE-Verified-M68 TE-Verified-68.0.3400.0
Update : 
Retested above issue in latest Canary build #68.0.3400.0 on Windows(7,8,8.1,10) and Mac(10.12.6, 10.13.1, 10.13.5) OS and the issue is fixed. 'Performance monitor' tab is working as expected in latest build #68.0.3400.0. Kindly review an attached screen-cast.

Thank you..!
Canary_build_behaviour.mp4
642 KB View Download

Comment 5 by gov...@chromium.org, Apr 25 2018

M67 Stable promotion is coming soon. Your bug is labelled as Stable ReleaseBlock, pls make sure to land the fix and request a merge into the release branch ASAP. Thank you.


Comment 6 by alph@chromium.org, May 1 2018

Labels: Merge-Request-67
Project Member

Comment 7 by sheriffbot@chromium.org, May 1 2018

Labels: -Merge-Request-67 Merge-Review-67 Hotlist-Merge-Review
This bug requires manual review: M67 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Review-67 Merge-Approved-67
Approving merge to M67 branch 3396 based on comment #4. Please merge ASAP. Thank you.

Comment 9 by alph@chromium.org, May 2 2018

Status: Fixed (was: Assigned)
Project Member

Comment 10 by bugdroid1@chromium.org, May 2 2018

Labels: -merge-approved-67 merge-merged-3396
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6f47221b088d44155311bc7cc8c64861bd1c0066

commit 6f47221b088d44155311bc7cc8c64861bd1c0066
Author: Alexei Filippov <alph@chromium.org>
Date: Wed May 02 01:11:02 2018

DevTools: Do not start performance monitor until model is ready.

BUG= 833271 
TBR=alph@chromium.org

(cherry picked from commit 0eab72ec3aa68755dfb7fa1a9282a4dd0d5f945a)

Change-Id: I62b0f0a598fa9caabde156609a8176ebad965e88
Reviewed-on: https://chromium-review.googlesource.com/1015536
Commit-Queue: Alexei Filippov <alph@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#551568}
Reviewed-on: https://chromium-review.googlesource.com/1038790
Reviewed-by: Alexei Filippov <alph@chromium.org>
Cr-Commit-Position: refs/branch-heads/3396@{#433}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}
[modify] https://crrev.com/6f47221b088d44155311bc7cc8c64861bd1c0066/third_party/blink/renderer/devtools/front_end/performance_monitor/PerformanceMonitor.js

Labels: TE-Verified-M67 TE-Verified-67.0.3396.40
Update : 
Retested above issue in Beta build #67.0.3396.40 on Windows(7,8,8.1,10) and Mac(10.12.6,10.13.1,10.13.5) OS and the issue is fixed. 'Performance monitor' tab  work as expected after reopening devtools window. Kindly review an attached screen-cast.

Thank you..!
67.0.3396.40 _Behaviour.mov
5.2 MB View Download

Sign in to add a comment