New issue
Advanced search Search tips

Issue 833257 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 1
Type: Bug-Regression
Team-Security-UX

Blocking:
issue 814532



Sign in to add a comment

Regression:Permission overlay appears to be misplaced in fullscreen mode after clicking on USB button.

Reported by vku...@etouch.net, Apr 16 2018

Issue description

Chrome Version: 68.0.3397.0 (Official Build)Revision dcddf51ec4ce5a464f901c1cf8fc8cc86c9f59b6-refs/heads/master@{#550857} (32/64-bit)
OS:Win(7,8,8.1,10) and Linux (14.04 LTS).

What steps will reproduce the problem?
(1)Launch chrome and navigate to http://permission.site/
(2)Click on 'HTTPS' , click on wrench menu > fullscreen icon
(3)Now click on 'USB' button and observe the permission overlay

Actual: Permission overlay appears to be misplaced in fullscreen mode after clicking on USB button.

Expected: Permission overlay should appear properly in fullscreen mode after clicking on USB button.(i.e on left side)

This is a regression issue broken in 'M68' and below is the manual bisect info
Good Build: 67.0.3396.0 (Revision:550429)
Bad Build:  68.0.3397.0 (Revision:550857)

Note: 
1. Permission overlay appears to be chopped on linux OS refer screenshot.
2. Issue not seen on Mac(10.12.6, 10.13.1, 10.13.5) OS.
 
Linux OS_Actual.png
72.6 KB View Download
Actual_Result.mp4
316 KB View Download
Expected_Result.mp4
233 KB View Download

Comment 1 by vku...@etouch.net, Apr 16 2018

Labels: RegressedIn-68 Target-68 FoundIn-68 hasbisect
Owner: alancutter@chromium.org
Status: Assigned (was: Unconfirmed)
Note: Unable to narrow down the range using per-revision script as getting traceback error between this range,hence providing bisect using old script.

Narrow bisect info:

You are probably looking for a change made after 550506 (known good), but no later than 550521 (first known bad).
CHANGELOG URL:
https://chromium.googlesource.com/chromium/src/+log/a98c719c8388a1bc07357b3113242c70e97fde5b..fdada01a75db65126449561b8b7b62adb902efe8?pretty=fuller&n=30

Suspect: https://chromium.googlesource.com/chromium/src/+/f591313ca81261589199eb545ca74eee09ef4d12

@alancutter: Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.
@alancutter: Looks like intended change.Could you please take a look in to it and confirm once.

Thanks you!

Comment 3 by raymes@chromium.org, Apr 17 2018

Cc: reillyg@chromium.org
Components: Blink>USB
Status: Started (was: Assigned)
Having the permission prompt obscured in Linux fullscreen is not desired, this is a regression.
We also fail a DCHECK now if a hosted app in its own window opens a permission prompt:

[59696:59696:0417/121304.767280:FATAL:bubble_anchor_util_views.cc(42)] Check failed: !browser->SupportsWindowFeature(
Browser::FEATURE_LOCATIONBAR).                                                                                       
#0 0x7f85b66015bc base::debug::StackTrace::StackTrace()                                                              
#1 0x7f85b662af9b logging::LogMessage::~LogMessage()                                                                 
#2 0x55766953eebc bubble_anchor_util::GetPageInfoAnchorRect()                                                        
#3 0x5576695daeee PermissionPromptImpl::Show()                                                                       
#4 0x5576695d97d7 PermissionPrompt::Create()                                                                         
#5 0x557668386755 _ZN4base8internal7InvokerINS0_9BindStateIPFNSt3__110unique_ptrI16PermissionPromptNS3_14default_dele
teIS5_EEEEPN7content11WebContentsEPNS5_8DelegateEEJEEESE_E3RunEPNS0_13BindStateBaseESB_SD_                           
#6 0x557668385628 PermissionRequestManager::ShowBubble()                                                             
#7 0x5576683854e4 PermissionRequestManager::DequeueRequestsAndShowBubble()

This DCHECK needs updating.
Screenshot from WIP fix: https://chromium-review.googlesource.com/c/chromium/src/+/1013676


Screenshot from 2018-04-17 14-49-51.png
179 KB View Download
Labels: ReleaseBlock-Stable
As this a recent regression adding release blocker label for this issue.Please reduce priority or remove if not the case.

Thank You!

Comment 8 by mgiuca@chromium.org, Apr 23 2018

Blocking: 814532
Project Member

Comment 9 by bugdroid1@chromium.org, Apr 26 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/780a71ed089233d25709d37f382191e905c55b6f

commit 780a71ed089233d25709d37f382191e905c55b6f
Author: Alan Cutter <alancutter@chromium.org>
Date: Thu Apr 26 03:32:41 2018

Fix permission prompt anchoring in fullscreen when UI is hidden

This CL fixes a regression caused by https://chromium-review.googlesource.com/1004886
where permission prompts would appear partially off screen in full screen mode
on platforms where we hide the Chrome UI.

Before:
https://bugs.chromium.org/p/chromium/issues/attachment?aid=334665&signed_aid=cQIe_b4bfUZn8i-akRK_ZQ==&inline=1

After:
https://bugs.chromium.org/p/chromium/issues/attachment?aid=334829&signed_aid=cXhOlJe-_oibvrzmLtL4Bw==&inline=1

This also fixes the DCHECK in GetPageInfoAnchorRect() to be relative to
GetPageInfoAnchorView() rather than copy pasting its bail out condition.

Bug:  833257 ,  814532 
Change-Id: I6ef85ace735b0b217b3a473365791ad453cf8378
Reviewed-on: https://chromium-review.googlesource.com/1013676
Commit-Queue: Alan Cutter <alancutter@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553898}
[modify] https://crrev.com/780a71ed089233d25709d37f382191e905c55b6f/chrome/browser/ui/extensions/hosted_app_browsertest.cc
[modify] https://crrev.com/780a71ed089233d25709d37f382191e905c55b6f/chrome/browser/ui/views/bubble_anchor_util_views.cc

Status: Fixed (was: Started)
Project Member

Comment 11 by bugdroid1@chromium.org, May 2 2018

Labels: merge-merged-3396
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/054cf57f1e1d89c99445721f27150d0088de82c1

commit 054cf57f1e1d89c99445721f27150d0088de82c1
Author: Alan Cutter <alancutter@chromium.org>
Date: Wed May 02 06:39:18 2018

Fix permission prompt anchoring in fullscreen when UI is hidden

This CL fixes a regression caused by https://chromium-review.googlesource.com/1004886
where permission prompts would appear partially off screen in full screen mode
on platforms where we hide the Chrome UI.

Before:
https://bugs.chromium.org/p/chromium/issues/attachment?aid=334665&signed_aid=cQIe_b4bfUZn8i-akRK_ZQ==&inline=1

After:
https://bugs.chromium.org/p/chromium/issues/attachment?aid=334829&signed_aid=cXhOlJe-_oibvrzmLtL4Bw==&inline=1

This also fixes the DCHECK in GetPageInfoAnchorRect() to be relative to
GetPageInfoAnchorView() rather than copy pasting its bail out condition.

TBR=alancutter@chromium.org

(cherry picked from commit 780a71ed089233d25709d37f382191e905c55b6f)

Bug:  833257 ,  814532 
Change-Id: I6ef85ace735b0b217b3a473365791ad453cf8378
Reviewed-on: https://chromium-review.googlesource.com/1013676
Commit-Queue: Alan Cutter <alancutter@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#553898}
Reviewed-on: https://chromium-review.googlesource.com/1039204
Reviewed-by: Alan Cutter <alancutter@chromium.org>
Cr-Commit-Position: refs/branch-heads/3396@{#437}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}
[modify] https://crrev.com/054cf57f1e1d89c99445721f27150d0088de82c1/chrome/browser/ui/extensions/hosted_app_browsertest.cc
[modify] https://crrev.com/054cf57f1e1d89c99445721f27150d0088de82c1/chrome/browser/ui/views/bubble_anchor_util_views.cc

Sign in to add a comment