Issue metadata
Sign in to add a comment
|
Typing in edit fields results in extraneous utterances even when no typing echo selected
Reported by
nimerjaber1@gmail.com,
Apr 16 2018
|
||||||||||||||||||||||||
Issue descriptionVersion: 67.0.3390.0 Reproduction Steps: 1. Search+a+i to create a new bug report. 2. Navigate to the summary box, and make sure that notyping echo is selected. Type a bunch of text, more than one line usually does it. 3. Observe what Chromevox utters. This also happens in inbox.google.com and other places as well. Expected: Chromevox ought to honor the user-selected typing echo setting. When no echo is selected, it should not speak anything, even if a user types past a new line. Actual: It seems like once a long string is typed and typing wraps to a new line, extraneuous text is uttered. This should no be the case.
,
Sep 17
,
Sep 18
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/575612e4df5c274c8416cfd0bfe75cbb4958de7e commit 575612e4df5c274c8416cfd0bfe75cbb4958de7e Author: David Tseng <dtseng@chromium.org> Date: Tue Sep 18 19:47:25 2018 Handle text change transitions in editable text more generically - within a single line, delete all words using Ctrl+Backspace - type until a line wraps. This triggers the inclusion of a new inline text box. - delete until a wrapped line moves up one line - delete words until all words on a wrapped line are deleted In all of these cases and many others, the previous line (surrounding the previous selection) and the current line are *different* lines. In some cases, the previous line is no longer valid because the underlying data is invalid. In all other cases, the lines are both valid, but refer to two different inline text boxes. In order to get the appropriate context, this change uses the surrounding paragraph to get the right diff of the previous and current value along with the selection. This fixes: 1. deletions that happen to trigger a line change. The easiest way to reproduce this is via Ctrl+backspace inside of a long paragraph 2. insertions that trigger the addition of a new line. The easiest way to trigger this is to set typing echo to none and start typing without inserting hard line breaks (i.e. pressing enter). When a new line is inserted (soft wrap), ChromeVox used to read the new line's text (the newly wrapped word). This no longer occurs. Bug: 833252 Test: manual and chromevox_tests. Change-Id: I5095eb4714932cad050f9fc5162072f918008b20 Reviewed-on: https://chromium-review.googlesource.com/1228790 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#592153} [modify] https://crrev.com/575612e4df5c274c8416cfd0bfe75cbb4958de7e/chrome/browser/resources/chromeos/chromevox/common/editable_text_base.js [modify] https://crrev.com/575612e4df5c274c8416cfd0bfe75cbb4958de7e/chrome/browser/resources/chromeos/chromevox/cvox2/background/editing.js [modify] https://crrev.com/575612e4df5c274c8416cfd0bfe75cbb4958de7e/chrome/browser/resources/chromeos/chromevox/cvox2/background/editing_test.extjs
,
Sep 18
,
Sep 18
Thank you so much for fixing this. I look forward to it. This has been an annoyance for a while.
,
Sep 24
Issue 880168 has been merged into this issue. |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by dsexton@chromium.org
, Sep 17Status: Duplicate (was: Unconfirmed)