New issue
Advanced search Search tips

Issue 833196 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug
Proj-XR



Sign in to add a comment

WebXR 'stage' frame of reference is not well aligned with OpenVR backend

Project Member Reported by bajones@chromium.org, Apr 15 2018

Issue description

When using WebXR with a 'stage' frame of reference and the OpenVR backend, the virtual environment is sometimes not well aligned with the real one. Specifically, the floor appears in the wrong place, and the scene is rotated from the configured "forward" direction.

This is possibly the result of the room configuration not being available when the XRSession spins up and not properly syncing when the transform is updated.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 20 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ca3a73cacf2d8b8feb9e1bb463bb39d39f155831

commit ca3a73cacf2d8b8feb9e1bb463bb39d39f155831
Author: Brandon Jones <bajones@chromium.org>
Date: Fri Apr 20 03:35:21 2018

Enable non-emulated stage XRFrameOfReferences

Bug:  833196 
Change-Id: Idd47df99dc9e98b627ba1e6aead0b9a7c5e6f631
Reviewed-on: https://chromium-review.googlesource.com/1014626
Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Klaus Weidner <klausw@chromium.org>
Commit-Queue: Brandon Jones <bajones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552252}
[modify] https://crrev.com/ca3a73cacf2d8b8feb9e1bb463bb39d39f155831/third_party/WebKit/LayoutTests/xr/resources/test-constants.js
[modify] https://crrev.com/ca3a73cacf2d8b8feb9e1bb463bb39d39f155831/third_party/WebKit/LayoutTests/xr/resources/xr-device-mocking.js
[add] https://crrev.com/ca3a73cacf2d8b8feb9e1bb463bb39d39f155831/third_party/WebKit/LayoutTests/xr/xrFrameOfReference_stage_updates.html
[modify] https://crrev.com/ca3a73cacf2d8b8feb9e1bb463bb39d39f155831/third_party/blink/renderer/modules/xr/xr_device.cc
[modify] https://crrev.com/ca3a73cacf2d8b8feb9e1bb463bb39d39f155831/third_party/blink/renderer/modules/xr/xr_device.h
[modify] https://crrev.com/ca3a73cacf2d8b8feb9e1bb463bb39d39f155831/third_party/blink/renderer/modules/xr/xr_frame_of_reference.cc
[modify] https://crrev.com/ca3a73cacf2d8b8feb9e1bb463bb39d39f155831/third_party/blink/renderer/modules/xr/xr_frame_of_reference.h
[modify] https://crrev.com/ca3a73cacf2d8b8feb9e1bb463bb39d39f155831/third_party/blink/renderer/modules/xr/xr_session.cc

Labels: Merge-Request-67
Status: Fixed (was: Assigned)
Requesting merge for M67 so that desktop users get accurate positioning with the upcoming Origin Trials.
Labels: Test-Manual
Project Member

Comment 4 by sheriffbot@chromium.org, Apr 21 2018

Labels: -Merge-Request-67 Merge-Approved-67 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M67. Please go ahead and merge the CL to branch 3396 manually. Please contact milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 5 by gov...@chromium.org, Apr 21 2018

Pls merge your change to M67 branch 3396 by 1:00 PM PT, Monday (04/23) so we can pick it up next M67 Dev/Beta release. Thank you.
Project Member

Comment 6 by bugdroid1@chromium.org, Apr 22 2018

Labels: -merge-approved-67 merge-merged-3396
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/17264c23c726e297cc53d8ea201b3bd32fac164f

commit 17264c23c726e297cc53d8ea201b3bd32fac164f
Author: Brandon Jones <bajones@chromium.org>
Date: Sun Apr 22 00:33:18 2018

Enable non-emulated stage XRFrameOfReferences

Bug:  833196 
Change-Id: Idd47df99dc9e98b627ba1e6aead0b9a7c5e6f631
Reviewed-on: https://chromium-review.googlesource.com/1014626
Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Klaus Weidner <klausw@chromium.org>
Commit-Queue: Brandon Jones <bajones@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#552252}(cherry picked from commit ca3a73cacf2d8b8feb9e1bb463bb39d39f155831)
Reviewed-on: https://chromium-review.googlesource.com/1023278
Reviewed-by: Brandon Jones <bajones@chromium.org>
Cr-Commit-Position: refs/branch-heads/3396@{#196}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}
[modify] https://crrev.com/17264c23c726e297cc53d8ea201b3bd32fac164f/third_party/WebKit/LayoutTests/xr/resources/test-constants.js
[modify] https://crrev.com/17264c23c726e297cc53d8ea201b3bd32fac164f/third_party/WebKit/LayoutTests/xr/resources/xr-device-mocking.js
[add] https://crrev.com/17264c23c726e297cc53d8ea201b3bd32fac164f/third_party/WebKit/LayoutTests/xr/xrFrameOfReference_stage_updates.html
[modify] https://crrev.com/17264c23c726e297cc53d8ea201b3bd32fac164f/third_party/blink/renderer/modules/xr/xr_device.cc
[modify] https://crrev.com/17264c23c726e297cc53d8ea201b3bd32fac164f/third_party/blink/renderer/modules/xr/xr_device.h
[modify] https://crrev.com/17264c23c726e297cc53d8ea201b3bd32fac164f/third_party/blink/renderer/modules/xr/xr_frame_of_reference.cc
[modify] https://crrev.com/17264c23c726e297cc53d8ea201b3bd32fac164f/third_party/blink/renderer/modules/xr/xr_frame_of_reference.h
[modify] https://crrev.com/17264c23c726e297cc53d8ea201b3bd32fac164f/third_party/blink/renderer/modules/xr/xr_session.cc

Components: Blink>WebXR

Sign in to add a comment