"RenderProcessHostTest.KillProcessZerosAudioStreams" is flaky |
||||||||||
Issue description"RenderProcessHostTest.KillProcessZerosAudioStreams" is flaky. This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label. We have detected 6 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyPQsSBUZsYWtlIjJSZW5kZXJQcm9jZXNzSG9zdFRlc3QuS2lsbFByb2Nlc3NaZXJvc0F1ZGlvU3RyZWFtcww. Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
,
Apr 16 2018
Detected 7 new flakes for test/step "RenderProcessHostTest.KillProcessZerosAudioStreams". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyPQsSBUZsYWtlIjJSZW5kZXJQcm9jZXNzSG9zdFRlc3QuS2lsbFByb2Nlc3NaZXJvc0F1ZGlvU3RyZWFtcww. This message was posted automatically by the chromium-try-flakes app.
,
Apr 17 2018
,
Apr 17 2018
,
Apr 17 2018
Looks like this started flaking somewhere along the way. => max + olka since they've been making all the changes in this area lately. It's important that this is accurate or we may not properly background processes that don't have audio anymore.
,
Apr 17 2018
,
Apr 17 2018
Hmm, I guess the RunLoop doesn't quit fast enough here: https://cs.chromium.org/chromium/src/content/browser/renderer_host/render_process_host_browsertest.cc?l=760, so that the stream is destroyed and the count is decremented before we check it. Overall, waiting for the stream to stop to wait for it to start looks a bit shaky :). I'll think about how to do this better.
,
Apr 17 2018
,
Apr 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ef6fc42bdc561722ddb2c0fbb0eec6d2f1d568ba commit ef6fc42bdc561722ddb2c0fbb0eec6d2f1d568ba Author: Ramin Halavati <rhalavati@chromium.org> Date: Mon Apr 16 12:53:42 2018 Disable test: RenderProcessHostTest.KillProcessZerosAudioStreams Bug: 833185 Change-Id: Ic8afceca1239bc3b6f696765dcb0b93b806973da TBR: kenrb@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1013565 Reviewed-by: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#550968} [modify] https://crrev.com/ef6fc42bdc561722ddb2c0fbb0eec6d2f1d568ba/content/browser/renderer_host/render_process_host_browsertest.cc
,
Apr 19 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d7ccf99252241cd63efeaa05779ab2f02b69bb19 commit d7ccf99252241cd63efeaa05779ab2f02b69bb19 Author: Max Morin <maxmorin@chromium.org> Date: Thu Apr 19 05:55:49 2018 Fix flaky RPHTest.KillProcessZerosAudioStreams This test was flaky due to the audio stream ending too early. To fix this, I changed from waiting for the audio stream to stop to waiting for the WebContents to become audible. I also modified the test to use an endless audio source (WebAudio oscillator). This change also seems to speed the test up a bit, since we don't need to wait for the audio file to end. Bug: 833185 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I25e3a9abf24d3eac58719132340dc570192a41be Reviewed-on: https://chromium-review.googlesource.com/1016641 Reviewed-by: Dale Curtis <dalecurtis@chromium.org> Reviewed-by: Ken Buchanan <kenrb@chromium.org> Commit-Queue: Max Morin <maxmorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#551954} [modify] https://crrev.com/d7ccf99252241cd63efeaa05779ab2f02b69bb19/content/browser/renderer_host/render_process_host_browsertest.cc [add] https://crrev.com/d7ccf99252241cd63efeaa05779ab2f02b69bb19/media/test/data/webaudio_oscillator.html
,
Apr 20 2018
Looks like there haven't been any new flakes.
,
May 4 2018
Looks like there might still be some flake: https://ci.chromium.org/buildbot/tryserver.chromium.android/linux_android_rel_ng/542984
,
May 4 2018
Actually I guess that one wasn't counted as a flake since it passed w/o my patch... maybe nothing after all. https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyPQsSBUZsYWtlIjJSZW5kZXJQcm9jZXNzSG9zdFRlc3QuS2lsbFByb2Nlc3NaZXJvc0F1ZGlvU3RyZWFtcww Doesn't show anything since 4/16. Feel free to close again as fixed if you think it's invalid / some other issue.
,
May 14 2018
Hmm, yeah. I don't see any flakes. There are a bunch of strange "unknown" results on the Android bots though. Doesn't look like anything in the logs. I'll just assume that's an Android issue rather than a test issue. |
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by bugdroid1@chromium.org
, Apr 16 2018