New issue
Advanced search Search tips

Issue 833120 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Bug
Q2



Sign in to add a comment

Crash in [PopupMenuMediator navigateToPageForItem:]

Reported by marq.co...@gmail.com, Apr 15 2018

Issue description

IMPORTANT: Your crash has already been automatically reported to our crash system. Please file this bug only if you can provide more information about it.


Chrome Version: 68.0.3398.0
Operating System: iOS 11.3

UIRefeshPhase1 enabled

URL (if applicable) where crash occurred:

Can you reproduce this crash?

What steps will reproduce this crash? (If it's not reproducible, what were you doing just before the crash?)
1.
2.
3.

****DO NOT CHANGE BELOW THIS LINE****
Crash ID: crash/3182756e140b3604

 

Comment 1 by marq@chromium.org, Apr 15 2018

Cc: marq@chromium.org
Labels: -Restrict-View-EditIssue Q2 S-Navigation-Menu MS-Tools-Navigation-Menu OS-iOS Pri-1 Type-Bug
Owner: gambard@chromium.org
Status: Assigned (was: Unconfirmed)
Summary: Crash in [PopupMenuMediator navigateToPageForItem:] (was: Crash when navigating via history popup )
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/efec89ca5923c385cf3aaf1a682c8f522e0830d8

commit efec89ca5923c385cf3aaf1a682c8f522e0830d8
Author: Gauthier Ambard <gambard@chromium.org>
Date: Mon Apr 16 09:22:58 2018

Fix navigation for popup menu

This CL fixes the navigation using the popup menu.
The navigation was crashing because the command protocol is only
implemented by the legacy class.

Bug:  833120 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I31268facd31c035a4bb0ff72d6d235f9789a8d14
Reviewed-on: https://chromium-review.googlesource.com/1013977
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550953}
[modify] https://crrev.com/efec89ca5923c385cf3aaf1a682c8f522e0830d8/ios/chrome/browser/ui/popup_menu/popup_menu_mediator.mm

Status: Fixed (was: Assigned)
NextAction: 2018-04-25
Project Member

Comment 5 by bugdroid1@chromium.org, Apr 17 2018

Labels: merge-merged-testbranch
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/efec89ca5923c385cf3aaf1a682c8f522e0830d8

commit efec89ca5923c385cf3aaf1a682c8f522e0830d8
Author: Gauthier Ambard <gambard@chromium.org>
Date: Mon Apr 16 09:22:58 2018

Fix navigation for popup menu

This CL fixes the navigation using the popup menu.
The navigation was crashing because the command protocol is only
implemented by the legacy class.

Bug:  833120 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I31268facd31c035a4bb0ff72d6d235f9789a8d14
Reviewed-on: https://chromium-review.googlesource.com/1013977
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550953}
[modify] https://crrev.com/efec89ca5923c385cf3aaf1a682c8f522e0830d8/ios/chrome/browser/ui/popup_menu/popup_menu_mediator.mm

Labels: Proj-UIRefresh
The NextAction date has arrived: 2018-04-25

Comment 8 by cma...@chromium.org, Apr 25 2018

NextAction: ----

Sign in to add a comment