Saved passwords not removed when removing Google account from Pixel2 phone, and sync with another user account when added
Reported by
cassidyg...@gmail.com,
Apr 14 2018
|
|||||||||||||
Issue descriptionDevice name: Pixel2 phone From "Settings > About Chrome" Application version:65.0.3325.109 (might have been an earlier version when issue occurred) Operating system: Android 8.1.0 URLs (if applicable): Steps to reproduce: (1) Add a Google account (user1) to a Pixel 2 phone (2) Browse some sites in Chrome, and confirm your saved passwords are working (3) Remove Google account from phone. Add a different Google account (user2). Expected result: Expected the saved passwords for user1 to be removed after step 2. Actual result: When user2 browses to websites he is asked to use saved passwords from user1. When user2 looks at his saved passwords in Chrome (on phone, and on desktop), all user1 passwords have been synced to his account, and he can choose to see those passwords (including banking sites) in plain text! This happened to me with my new work phone that my boss had set up for me (he was trying the phone out before giving it to me and hadn't wiped it, but did remove his Google account). I was surprised to see this bug, given Google's security reputation, and am definitely reconsidering using the save passwords feature as a result.
,
Apr 17 2018
Tested the issue in Android and able to reproduce the issue. Similar behavior is observed since Chrome #60.0.3072.0 Steps Followed: 1. Signin to the Chrome browser and device with the same user. 2. Launched the Chrome Browser. 3. Save few passwords. 4. Navigate to device settings >> Users & accounts. 5. Remove 'Google' account. 6. Launch Chrome. 7. Tap on Chrome Settings >> Passwords. 8. Observed that under 'Passwords' sections, previously saved passwords are still displayed. Chrome versions tested: 60.0.3072.0, 65.0.3325.109(Stable), 67.0.3396.3(Canary) OS: Android 8.1.0 Android Devices: Pixel XL This seems to be a Non-Regression issue as same behavior is seen since M60. Untriaged for further input's on this issue. Please navigate to below link for log's and screen cast-- go/chrome-androidlogs/833082 Thanks!
,
Apr 19 2018
Thanks for the report and verification. Are other profile data also kept (e.g., bookmarks), or does this affect only passwords? This sounds to me like an issue with the profile data so I'm adding a few more components in the hope that someone knowledgeable about changing profiles will chime in.
,
Apr 19 2018
This does indeed sound like a problem of accounts vs. profiles. When you sign out of account A in Chrome, there are two possibilities: - If it's a managed (e.g. enterprise) account, we do wipe the data immediately. - Otherwise, we only disconnect the Sync, and still keep a local copy of the data in the Chrome profile. In the latter case, you can delete the data through Clear Browsing Data. Or, if you try to sign in to account B, we offer you to delete the data automatically to prevent merge of data between A and B. It's likely that removing an account A from a device has the same effect as just disconnecting sync for A, i.e. no data deletion happens. This might be unexpected for consumer cases already; for enterprise cases, it would be definitely unexpected. I also wonder if the warning dialog about merging data between A and B works correctly after A had been removed. cassidygentle@: Can you respond to the question in comment #3? Furthermore, did you only add a new account to Android, or also sign in to that account in Chrome?
,
Apr 19 2018
,
Apr 19 2018
I just checked, and it looks like his bookmarks were synced with my account as well. I had also signed into my account on Chrome. I don't recall seeing any message about clearing the existing local data when I did that.
,
Apr 19 2018
Thanks for the details. Then this is not specific to passwords, but a general case of merging data between two accounts being signed in to the same Chrome profile. I tried this scenario now (sign in to A, accumulate browsing data, remove A from Android, which automatically signed out Chrome as well, then sign in to B) and I still do see the dialog warning against merging the data. So this part works.
,
Apr 19 2018
...which means that the data of account A should be deleted when you go through that dialog in step (3), when signing in into account B. But as I understand after rereading #0 and #2, the expectation was that removing an account also automatically deletes the data. As I explained above, we should this for managed accounts. Were the accounts on your phone both @gmail.com, or were they managed accounts (i.e. from an enterprise domain of your company?). However, we don't do this for standard consumer accounts (@gmail.com), as we wanted to allow users to retain data after signing out. sabineb@, feuunk@ - have you considered adding an anti-cross-sync dialog on sign-out event rather than just when signing back in? The latter indeed seems insufficient in the scenario described above.
,
Apr 19 2018
As discussed offline, in order to address these use cases, we'd want to make two changes: 1. If the user goes through Chrome settings, and signs out there, add a checkbox to also clear data. 2. Make Clank listen to accounts being removed from the Android system, and pop up a notification to also delete sync data if the account was the sync account.
,
Apr 27 2018
Triage ping: Any updates on this? Is it really a P1?
,
May 14 2018
Friendly ping for sabineb@ and adjusting to P2.
,
May 14 2018
Yeah agreed that we should have a similar dialog as the one we have on desktop for when a user signs out/disconnects from Sync on Android. bsazonov@ had raised this before and created a tracking bug: https://bugs.chromium.org/p/chromium/issues/detail?id=836778 for it.
,
Jun 14 2018
--Chrome Identity automated triaging-- This bug is Assigned and has gone one month without any activity, so it is being moved to Available to indicate that it is not actively being worked on. If you are working on this bug, please mark yourself as the owner and move back to Assigned. Please see https://goo.gl/78kbny for more details. Please remove the Services>SignIn or UI>Browser>Profiles components if this bug isn't related to Chrome Identity. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 2
,
Sep 3
--Chrome Identity automated triaging-- This bug is Assigned and has gone one month without any activity, so it is being moved to Available to indicate that it is not actively being worked on. If you are working on this bug, please mark yourself as the owner and move back to Assigned. Please see https://goo.gl/78kbny for more details. Please remove the Services>SignIn or UI>Browser>Profiles components if this bug isn't related to Chrome Identity. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 3
Per #12, should this be merged into issue 836778?
,
Sep 3
This is slightly different from issue 836778, as here sync account is removed from the device, while issue 836778 mostly discusses manual sign-out from Chrome. I see two paths forward with this: 1. Wipe profile data if sync account goes away (risky, may wipe some unsynced data). 2. Show notification as proposed in #9 (user may ignore this notification and still encounter cross-sync issues). Optionally, we could also show a dialog on the next Chrome start-up (something like "Your sync account was removed from the device, would you like to wipe your data?").
,
Oct 4
--Chrome Identity automated triaging-- This bug is Assigned and has gone one month without any activity, so it is being moved to Available to indicate that it is not actively being worked on. If you are working on this bug, please mark yourself as the owner and move back to Assigned. Please see https://goo.gl/78kbny for more details. Please remove the Services>SignIn or UI>Browser>Profiles components if this bug isn't related to Chrome Identity. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Dec 17
We will discuss short-term solutions in this problem-space this week. |
|||||||||||||
►
Sign in to add a comment |
|||||||||||||
Comment 1 by pnangunoori@chromium.org
, Apr 16 2018