New issue
Advanced search Search tips

Issue 833047 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 27
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Feature
Team-Accessibility

Blocked on:
issue 875949



Sign in to add a comment

STS OOBE - STS not included as a11y feature on OOBE a11y screen

Project Member Reported by leberly@chromium.org, Apr 14 2018

Issue description

67.0.3383.0 (Official Build) dev (64-bit)
Google_Samus.6300.276.0

# Powerwash to get to OOBE
# On first screen, open the Accessibility screen
Expected: STS listed
Actual: STS not listed

Workaround: use the status bar > a11y settings to turn on the feature 

See screenshot of screen that's missing STS
 
OOBEa11ysettings.jpg
146 KB View Download
Labels: -Type-Bug M-71 Type-Feature
Maybe we can try to add this in M71.
Owner: katie@chromium.org
Status: Started (was: Available)
We should also add the docked magnifier and switch access modulo UX review to remove them from behind flags.
Blockedon: 875949
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 23

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/83a043576ee3471e2d6588d3ceb98036e7c69c94

commit 83a043576ee3471e2d6588d3ceb98036e7c69c94
Author: Katie D <katie@chromium.org>
Date: Thu Aug 23 02:56:47 2018

Adds Select-to-Speak to the accessibility OOBE screen behind flag.

The --enable-experimental-accessibility-features flag must be on
in order to see the STS option. This should be removed when a
launch bug is ready to go.

BUG:  833047 
Change-Id: I2a255009c27720834a762334e83d2360e1db2354
Reviewed-on: https://chromium-review.googlesource.com/1180089
Commit-Queue: Katie Dektar <katie@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585378}
[modify] https://crrev.com/83a043576ee3471e2d6588d3ceb98036e7c69c94/ash/system/accessibility/select_to_speak_tray.cc
[modify] https://crrev.com/83a043576ee3471e2d6588d3ceb98036e7c69c94/ash/system/accessibility/select_to_speak_tray.h
[modify] https://crrev.com/83a043576ee3471e2d6588d3ceb98036e7c69c94/chrome/app/chromeos_strings.grdp
[add] https://crrev.com/83a043576ee3471e2d6588d3ceb98036e7c69c94/chrome/app/chromeos_strings_grdp/IDS_OOBE_SELECT_TO_SPEAK_OPTION.png.sha1
[add] https://crrev.com/83a043576ee3471e2d6588d3ceb98036e7c69c94/chrome/app/chromeos_strings_grdp/IDS_SELECT_TO_SPEAK_OPTION_OFF.png.sha1
[add] https://crrev.com/83a043576ee3471e2d6588d3ceb98036e7c69c94/chrome/app/chromeos_strings_grdp/IDS_SELECT_TO_SPEAK_OPTION_ON.png.sha1
[modify] https://crrev.com/83a043576ee3471e2d6588d3ceb98036e7c69c94/chrome/browser/resources/chromeos/login/accessibility_menu.html
[modify] https://crrev.com/83a043576ee3471e2d6588d3ceb98036e7c69c94/chrome/browser/resources/chromeos/login/oobe.js
[modify] https://crrev.com/83a043576ee3471e2d6588d3ceb98036e7c69c94/chrome/browser/resources/chromeos/login/oobe_welcome.html
[modify] https://crrev.com/83a043576ee3471e2d6588d3ceb98036e7c69c94/chrome/browser/resources/chromeos/login/oobe_welcome.js
[modify] https://crrev.com/83a043576ee3471e2d6588d3ceb98036e7c69c94/chrome/browser/ui/webui/chromeos/login/core_oobe_handler.cc
[modify] https://crrev.com/83a043576ee3471e2d6588d3ceb98036e7c69c94/chrome/browser/ui/webui/chromeos/login/core_oobe_handler.h
[modify] https://crrev.com/83a043576ee3471e2d6588d3ceb98036e7c69c94/chrome/browser/ui/webui/chromeos/login/welcome_screen_handler.cc

Project Member

Comment 5 by bugdroid1@chromium.org, Aug 29

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8bae7a7e8d80d5a956adfca469ed7d5b2d90d3a9

commit 8bae7a7e8d80d5a956adfca469ed7d5b2d90d3a9
Author: Katie D <katie@chromium.org>
Date: Wed Aug 29 20:37:23 2018

Accessibility OOBE screen can be too tall with feature flag.

With --enable-experimental-accessiblity-features, too many a11y tools
are included in the OOBE screen and it flows behind the button. This
makes the accessibility tools list scroll.

Bug:  833047 
Change-Id: If5ca4ee1dea324b883e97195a6debad5f0804ed7
Reviewed-on: https://chromium-review.googlesource.com/1194982
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Commit-Queue: Katie Dektar <katie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587282}
[modify] https://crrev.com/8bae7a7e8d80d5a956adfca469ed7d5b2d90d3a9/chrome/browser/resources/chromeos/login/oobe_welcome.css
[modify] https://crrev.com/8bae7a7e8d80d5a956adfca469ed7d5b2d90d3a9/chrome/browser/resources/chromeos/login/oobe_welcome.html

Project Member

Comment 6 by bugdroid1@chromium.org, Aug 29

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5a03bde895422d9e3a78e92550966842f0e12750

commit 5a03bde895422d9e3a78e92550966842f0e12750
Author: Katie D <katie@chromium.org>
Date: Wed Aug 29 22:11:03 2018

Include the docked magnifier on the A11y OOBE screen behind a flag.

Bug:  833047 
Change-Id: I72cba5196d54e3233608189df361e6c3790b6e7a
Reviewed-on: https://chromium-review.googlesource.com/1181932
Commit-Queue: Katie Dektar <katie@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587312}
[modify] https://crrev.com/5a03bde895422d9e3a78e92550966842f0e12750/chrome/app/chromeos_strings.grdp
[add] https://crrev.com/5a03bde895422d9e3a78e92550966842f0e12750/chrome/app/chromeos_strings_grdp/IDS_OOBE_DOCKED_MAGNIFIER_OPTION.png.sha1
[modify] https://crrev.com/5a03bde895422d9e3a78e92550966842f0e12750/chrome/browser/chromeos/accessibility/accessibility_manager.h
[modify] https://crrev.com/5a03bde895422d9e3a78e92550966842f0e12750/chrome/browser/chromeos/accessibility/magnification_manager.cc
[modify] https://crrev.com/5a03bde895422d9e3a78e92550966842f0e12750/chrome/browser/chromeos/accessibility/magnification_manager.h
[modify] https://crrev.com/5a03bde895422d9e3a78e92550966842f0e12750/chrome/browser/resources/chromeos/login/accessibility_menu.html
[modify] https://crrev.com/5a03bde895422d9e3a78e92550966842f0e12750/chrome/browser/resources/chromeos/login/oobe.js
[modify] https://crrev.com/5a03bde895422d9e3a78e92550966842f0e12750/chrome/browser/resources/chromeos/login/oobe_welcome.html
[modify] https://crrev.com/5a03bde895422d9e3a78e92550966842f0e12750/chrome/browser/resources/chromeos/login/oobe_welcome.js
[modify] https://crrev.com/5a03bde895422d9e3a78e92550966842f0e12750/chrome/browser/ui/webui/chromeos/login/core_oobe_handler.cc
[modify] https://crrev.com/5a03bde895422d9e3a78e92550966842f0e12750/chrome/browser/ui/webui/chromeos/login/core_oobe_handler.h

Labels: a11y-testers
Status: Fixed (was: Started)
Status: Started (was: Fixed)
Oops, it's still behind the flag, re-opening.
Labels: -a11y-testers
Please add back on the a11y-testers label when ready, thanks!
Project Member

Comment 10 by bugdroid1@chromium.org, Sep 27

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5406e897df4c4e565abf977d7f8bf987fe97523b

commit 5406e897df4c4e565abf977d7f8bf987fe97523b
Author: Katie D <katie@chromium.org>
Date: Thu Sep 27 02:32:50 2018

Add Select-to-Speak to OOBE screen without flags.

UX approved over email.

Bug:  833047 
Change-Id: I73c5b12d98fa332aa29089d7af23bb420d659436
Reviewed-on: https://chromium-review.googlesource.com/1241995
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Reviewed-by: David Tseng <dtseng@chromium.org>
Commit-Queue: Katie Dektar <katie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594569}
[modify] https://crrev.com/5406e897df4c4e565abf977d7f8bf987fe97523b/chrome/browser/resources/chromeos/login/oobe.js
[modify] https://crrev.com/5406e897df4c4e565abf977d7f8bf987fe97523b/chrome/browser/resources/chromeos/login/oobe_welcome.html

Status: Fixed (was: Started)

Sign in to add a comment