Findit identified the culprit r550808 with confidence 70.0% in the config "chromium.memory / Linux TSan Tests"
based on the flakiness trend:

https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVyqAELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCJyY2hyb21pdW0ubWVtb3J5L0xpbnV4IFRTYW4gVGVzdHMvMjAyMzcvc2VydmljZXNfdW5pdHRlc3RzL1RXVjBjbWxqYzBOdmJHeGxZM1J2Y2xSbGMzUXVVbVZ6Y0c5dWMybDJaVzVsYzNOTlpYUnlhV009DAsSE01hc3RlckZsYWtlQW5hbHlzaXMYAQw


Automatically posted by the findit-for-me app (https://goo.gl/Ot9f7N).
Flake Analyzer is in beta.
Feedback is welcome! Please use component Tools>Test>FindIt>Flakiness

Findit identified the culprit r550808 with confidence 70.0% in the config "chromium.chromiumos / linux-chromeos-rel"
based on the flakiness trend:

https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVyrQELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCJ3Y2hyb21pdW0uY2hyb21pdW1vcy9saW51eC1jaHJvbWVvcy1yZWwvNjkwOC9zZXJ2aWNlc191bml0dGVzdHMvVFdWMGNtbGpjME52Ykd4bFkzUnZjbFJsYzNRdVVtVnpjRzl1YzJsMlpXNWxjM05OWlhSeWFXTT0MCxITTWFzdGVyRmxha2VBbmFseXNpcxgBDA


Automatically posted by the findit-for-me app (https://goo.gl/Ot9f7N).
Flake Analyzer is in beta.
Feedback is welcome! Please use component Tools>Test>FindIt>Flakiness

Findit identified the culprit r550808 with confidence 70.0% in the config "chromium.chromiumos / linux-chromeos-dbg"
based on the flakiness trend:

https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVyrQELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCJ3Y2hyb21pdW0uY2hyb21pdW1vcy9saW51eC1jaHJvbWVvcy1kYmcvNTIwMy9zZXJ2aWNlc191bml0dGVzdHMvVFdWMGNtbGpjME52Ykd4bFkzUnZjbFJsYzNRdVVtVnpjRzl1YzJsMlpXNWxjM05OWlhSeWFXTT0MCxITTWFzdGVyRmxha2VBbmFseXNpcxgBDA


Automatically posted by the findit-for-me app (https://goo.gl/Ot9f7N).
Flake Analyzer is in beta.
Feedback is welcome! Please use component Tools>Test>FindIt>Flakiness

Findit identified the culprit r550808 with confidence 70.0% in the config "chromium.memory / Mac ASan 64 Tests (1)"
based on the flakiness trend:

https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVyrQELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCJ3Y2hyb21pdW0ubWVtb3J5L01hYyBBU2FuIDY0IFRlc3RzICgxKS80MDAxOC9zZXJ2aWNlc191bml0dGVzdHMvVFdWMGNtbGpjME52Ykd4bFkzUnZjbFJsYzNRdVVtVnpjRzl1YzJsMlpXNWxjM05OWlhSeWFXTT0MCxITTWFzdGVyRmxha2VBbmFseXNpcxgBDA


Automatically posted by the findit-for-me app (https://goo.gl/Ot9f7N).
Flake Analyzer is in beta.
Feedback is welcome! Please use component Tools>Test>FindIt>Flakiness

Findit identified the culprit r550808 with confidence 70.0% in the config "chromium.memory / Linux ASan LSan Tests (1)"
based on the flakiness trend:

https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVysQELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCJ7Y2hyb21pdW0ubWVtb3J5L0xpbnV4IEFTYW4gTFNhbiBUZXN0cyAoMSkvNDQ3NjQvc2VydmljZXNfdW5pdHRlc3RzL1RXVjBjbWxqYzBOdmJHeGxZM1J2Y2xSbGMzUXVVbVZ6Y0c5dWMybDJaVzVsYzNOTlpYUnlhV009DAsSE01hc3RlckZsYWtlQW5hbHlzaXMYAQw


Automatically posted by the findit-for-me app (https://goo.gl/Ot9f7N).
Flake Analyzer is in beta.
Feedback is welcome! Please use component Tools>Test>FindIt>Flakiness

Detected 3 new flakes for test/step "MetricsCollectorTest.ResponsivenessMetric". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyNAsSBUZsYWtlIilNZXRyaWNzQ29sbGVjdG9yVGVzdC5SZXNwb25zaXZlbmVzc01ldHJpYww. This message was posted automatically by the chromium-try-flakes app.

Findit identified the culprit r550808 with confidence 70.0% in the config "tryserver.chromium.chromiumos / linux-chromeos-rel"
based on the flakiness trend:

https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVyrQELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCJ3Y2hyb21pdW0uY2hyb21pdW1vcy9saW51eC1jaHJvbWVvcy1yZWwvNjkyOS9zZXJ2aWNlc191bml0dGVzdHMvVFdWMGNtbGpjME52Ykd4bFkzUnZjbFJsYzNRdVVtVnpjRzl1YzJsMlpXNWxjM05OWlhSeWFXTT0MCxITTWFzdGVyRmxha2VBbmFseXNpcxgBDA


Automatically posted by the findit-for-me app (https://goo.gl/Ot9f7N).
Flake Analyzer is in beta.
Feedback is welcome! Please use component Tools>Test>FindIt>Flakiness

Findit identified the culprit r550808 with confidence 70.0% in the config "tryserver.chromium.linux / linux_chromium_asan_rel_ng"
based on the flakiness trend:

https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVysQELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCJ7Y2hyb21pdW0ubWVtb3J5L0xpbnV4IEFTYW4gTFNhbiBUZXN0cyAoMSkvNDQ3NzEvc2VydmljZXNfdW5pdHRlc3RzL1RXVjBjbWxqYzBOdmJHeGxZM1J2Y2xSbGMzUXVVbVZ6Y0c5dWMybDJaVzVsYzNOTlpYUnlhV009DAsSE01hc3RlckZsYWtlQW5hbHlzaXMYAQw


Automatically posted by the findit-for-me app (https://goo.gl/Ot9f7N).
Flake Analyzer is in beta.
Feedback is welcome! Please use component Tools>Test>FindIt>Flakiness

Detected 7 new flakes for test/step "MetricsCollectorTest.ResponsivenessMetric". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyNAsSBUZsYWtlIilNZXRyaWNzQ29sbGVjdG9yVGVzdC5SZXNwb25zaXZlbmVzc01ldHJpYww. This message was posted automatically by the chromium-try-flakes app.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/79ae110c23fb77f2a18ce5a9b61014b036c7d012

commit 79ae110c23fb77f2a18ce5a9b61014b036c7d012
Author: Ramin Halavati <rhalavati@chromium.org>
Date: Mon Apr 16 11:17:32 2018

Disable flaky test: MetricsCollectorTest.ResponsivenessMetric

Bug:  833028 
Change-Id: Ie4d60d122f5403f735d8f5a0d9fe45f35f1e13c5
TBR: chrisha@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/1014100
Reviewed-by: Ramin Halavati <rhalavati@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550963}
[modify] https://crrev.com/79ae110c23fb77f2a18ce5a9b61014b036c7d012/services/resource_coordinator/observers/metrics_collector_unittest.cc

Findit identified the culprit r550808 with confidence 70.0% in the config "tryserver.chromium.linux / linux_chromium_tsan_rel_ng"
based on the flakiness trend:

https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVyqAELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCJyY2hyb21pdW0ubWVtb3J5L0xpbnV4IFRTYW4gVGVzdHMvMjAyODkvc2VydmljZXNfdW5pdHRlc3RzL1RXVjBjbWxqYzBOdmJHeGxZM1J2Y2xSbGMzUXVVbVZ6Y0c5dWMybDJaVzVsYzNOTlpYUnlhV009DAsSE01hc3RlckZsYWtlQW5hbHlzaXMYAQw


Automatically posted by the findit-for-me app (https://goo.gl/Ot9f7N).
Flake Analyzer is in beta.
Feedback is welcome! Please use component Tools>Test>FindIt>Flakiness

holte@:

Some flake just started happening on a test that was previously running just fine. The find-it bot seems to want to blame this on a recent CL of yours? Can you take a quick look to see if this makes any sense?

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/79ae110c23fb77f2a18ce5a9b61014b036c7d012

commit 79ae110c23fb77f2a18ce5a9b61014b036c7d012
Author: Ramin Halavati <rhalavati@chromium.org>
Date: Mon Apr 16 11:17:32 2018

Disable flaky test: MetricsCollectorTest.ResponsivenessMetric

Bug:  833028 
Change-Id: Ie4d60d122f5403f735d8f5a0d9fe45f35f1e13c5
TBR: chrisha@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/1014100
Reviewed-by: Ramin Halavati <rhalavati@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550963}
[modify] https://crrev.com/79ae110c23fb77f2a18ce5a9b61014b036c7d012/services/resource_coordinator/observers/metrics_collector_unittest.cc

Looking at the test, I don't see any obvious reason it would be flaky because of that CL, though it is UKM related change and UKM related test failing.

Looking at the failure:
[ RUN      ] MetricsCollectorTest.ResponsivenessMetric
../../services/resource_coordinator/observers/metrics_collector_unittest.cc:377: Failure
Expected equality of these values:
  1U
    Which is: 1
  ukm_recorder.entries_count()
    Which is: 0

For which corresponds to this code:

  process_cu->SetExpectedTaskQueueingDuration(
      base::TimeDelta::FromMilliseconds(4));
  EXPECT_EQ(1U, ukm_recorder.sources_count());
  EXPECT_EQ(1U, ukm_recorder.entries_count());

So this is no entry getting recorded by process_cu->SetExpectedTaskQueueingDuration()

The only thing the other CL changed should be the values of the source Ids, which shouldn't change whether metrics get recorded.

I will look into this a little more tomorrow.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/08aa145717a77f7982492d5d0c9d2d6ea7d61092

commit 08aa145717a77f7982492d5d0c9d2d6ea7d61092
Author: Steven Holte <holte@google.com>
Date: Tue Apr 24 04:56:49 2018

Fix MetricsCollectorTest.ResponsivenessMetric

ukm::UkmRecorder::GetNewSourceID may return negative ids.

Bug:  833028 
Change-Id: If4f8c3668524baa791b9b3895f95f19d135664b3
Reviewed-on: https://chromium-review.googlesource.com/1020669
Commit-Queue: Chris Hamilton <chrisha@chromium.org>
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553000}
[modify] https://crrev.com/08aa145717a77f7982492d5d0c9d2d6ea7d61092/services/resource_coordinator/observers/metrics_collector.cc
[modify] https://crrev.com/08aa145717a77f7982492d5d0c9d2d6ea7d61092/services/resource_coordinator/observers/metrics_collector_unittest.cc