Issue metadata
Sign in to add a comment
|
TouchActionBrowserTest.PanXYAtYAreaMainThreadJanky is Flaky |
||||||||||||||||||||||||
Issue descriptionFindit has detected a flake at test TouchActionBrowserTest.PanXYAtYAreaMainThreadJanky. Culprit (100.0% confidence): https://chromium-review.googlesource.com/q/Ifabcb8356cb2526ad55313be01e24ea959ab2330 Regression range: None Analysis: https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVyvAELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKFAWNocm9taXVtLmNocm9taXVtb3MvbGludXgtY2hyb21lb3MtcmVsLzY4OTAvY29udGVudF9icm93c2VydGVzdHMvVkc5MVkyaEJZM1JwYjI1Q2NtOTNjMlZ5VkdWemRDNVFZVzVZV1VGMFdVRnlaV0ZOWVdsdVZHaHlaV0ZrU21GdWEzaz0MCxITTWFzdGVyRmxha2VBbmFseXNpcxgBDA If this result was incorrect, apply the label Findit-Incorrect-Result, mark the bug as Untriaged and the component Tools>Test>Findit>Flakiness.
,
Apr 14 2018
Findit identified the culprit r550623 with confidence 100.0% in the config "chromium.memory / Linux ASan Tests (sandboxed)" based on the flakiness trend: https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVywwELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKMAWNocm9taXVtLm1lbW9yeS9MaW51eCBBU2FuIFRlc3RzIChzYW5kYm94ZWQpLzQ1NDU5L2NvbnRlbnRfYnJvd3NlcnRlc3RzL1ZHOTFZMmhCWTNScGIyNUNjbTkzYzJWeVZHVnpkQzVRWVc1WVdVRjBXVUZ5WldGTllXbHVWR2h5WldGa1NtRnVhM2s9DAsSE01hc3RlckZsYWtlQW5hbHlzaXMYAQw Automatically posted by the findit-for-me app (https://goo.gl/Ot9f7N). Flake Analyzer is in beta. Feedback is welcome! Please use component Tools>Test>FindIt>Flakiness
,
Apr 14 2018
Findit identified the culprit r550623 with confidence 100.0% in the config "chromium.memory / Linux Chromium OS ASan LSan Tests (1)" based on the flakiness trend: https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVyzAELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKVAWNocm9taXVtLm1lbW9yeS9MaW51eCBDaHJvbWl1bSBPUyBBU2FuIExTYW4gVGVzdHMgKDEpLzI3MDI4L2NvbnRlbnRfYnJvd3NlcnRlc3RzL1ZHOTFZMmhCWTNScGIyNUNjbTkzYzJWeVZHVnpkQzVRWVc1WVdVRjBXVUZ5WldGTllXbHVWR2h5WldGa1NtRnVhM2s9DAsSE01hc3RlckZsYWtlQW5hbHlzaXMYAQw Automatically posted by the findit-for-me app (https://goo.gl/Ot9f7N). Flake Analyzer is in beta. Feedback is welcome! Please use component Tools>Test>FindIt>Flakiness
,
Apr 14 2018
Findit identified the culprit r550623 with confidence 100.0% in the config "chromium.memory / Linux ChromiumOS MSan Tests" based on the flakiness trend: https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVywQELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKKAWNocm9taXVtLm1lbW9yeS9MaW51eCBDaHJvbWl1bU9TIE1TYW4gVGVzdHMvNjcwNi9jb250ZW50X2Jyb3dzZXJ0ZXN0cy9WRzkxWTJoQlkzUnBiMjVDY205M2MyVnlWR1Z6ZEM1UVlXNVlXVUYwV1VGeVpXRk5ZV2x1VkdoeVpXRmtTbUZ1YTNrPQwLEhNNYXN0ZXJGbGFrZUFuYWx5c2lzGAEM Automatically posted by the findit-for-me app (https://goo.gl/Ot9f7N). Flake Analyzer is in beta. Feedback is welcome! Please use component Tools>Test>FindIt>Flakiness
,
Apr 14 2018
Findit identified the culprit r550623 with confidence 100.0% in the config "chromium.memory / Linux ASan LSan Tests (1)" based on the flakiness trend: https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVywAELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKJAWNocm9taXVtLm1lbW9yeS9MaW51eCBBU2FuIExTYW4gVGVzdHMgKDEpLzQ0NzQzL2NvbnRlbnRfYnJvd3NlcnRlc3RzL1ZHOTFZMmhCWTNScGIyNUNjbTkzYzJWeVZHVnpkQzVRWVc1WVdVRjBXVUZ5WldGTllXbHVWR2h5WldGa1NtRnVhM2s9DAsSE01hc3RlckZsYWtlQW5hbHlzaXMYAQw Automatically posted by the findit-for-me app (https://goo.gl/Ot9f7N). Flake Analyzer is in beta. Feedback is welcome! Please use component Tools>Test>FindIt>Flakiness
,
Apr 16 2018
,
Apr 16 2018
I have disabled this.
,
Apr 17 2018
,
Apr 23 2018
PanXYAtXAreaMainThreadJanky is now flaky on Linux
,
Apr 23 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dfd2405f874c8581a7b1d50b91d81abf961774dc commit dfd2405f874c8581a7b1d50b91d81abf961774dc Author: Xida Chen <xidachen@chromium.org> Date: Mon Apr 23 13:31:27 2018 Disable TouchActionBrowserTest.PanXYAtXAreaMainThreadJanky on linux TBR=clamy@chromium.org NOTRY=true Bug: 833015 Change-Id: I3c685c893d6a1f75f4214ea6dfc5d94254cd19eb Reviewed-on: https://chromium-review.googlesource.com/1024070 Reviewed-by: Xida Chen <xidachen@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#552678} [modify] https://crrev.com/dfd2405f874c8581a7b1d50b91d81abf961774dc/content/browser/renderer_host/input/touch_action_browsertest.cc
,
Apr 24 2018
Issue 835055 has been merged into this issue.
,
Apr 25 2018
Failed on Windows too: [ RUN ] TouchActionBrowserTest.PanXYAtXAreaMainThreadJanky DevTools listening on ws://127.0.0.1:57113/devtools/browser/08b5306e-85e9-49b2-b66e-11394703a9b8 ../../content/browser/renderer_host/input/touch_action_browsertest.cc(336): error: Expected: (expected_scroll_position_after_scroll.x() / 2) <= (scroll_left), actual: 22 vs 0 Stack trace: Backtrace: testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop [0x00000001403EF027+87] testing::internal::AssertHelper::operator= [0x00000001403EEBAE+78] content::TouchActionBrowserTest::CheckScrollOffset [0x000000013FCDA683+547] content::TouchActionBrowserTest::DoTouchScroll [0x000000013FCD9034+836] content::TouchActionBrowserTest_PanXYAtXAreaMainThreadJanky_Test::RunTestOnMainThread [0x000000013FCD9D07+119]
,
Apr 25 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/200ecd7181caf9faa0eb65a447a1a0ceb68b6c2c commit 200ecd7181caf9faa0eb65a447a1a0ceb68b6c2c Author: Lei Zhang <thestig@chromium.org> Date: Wed Apr 25 01:57:41 2018 Disable another flaky TouchActionBrowserTest on Windows. BUG= 833015 TBR=xidachen@chromium.org Change-Id: Id39f3bb6a07b16ec26911d7c70cf44d67969bcda Reviewed-on: https://chromium-review.googlesource.com/1026984 Reviewed-by: Lei Zhang <thestig@chromium.org> Reviewed-by: Xida Chen <xidachen@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#553418} [modify] https://crrev.com/200ecd7181caf9faa0eb65a447a1a0ceb68b6c2c/content/browser/renderer_host/input/touch_action_browsertest.cc
,
Jun 12 2018
,
Jun 15 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c32a3d1ec4331f10e0efbd5d979a833f8e1a57ce commit c32a3d1ec4331f10e0efbd5d979a833f8e1a57ce Author: Xida Chen <xidachen@chromium.org> Date: Fri Jun 15 16:49:51 2018 Deflake one of TouchActionBrowserTest Some of the TouchActionBrowserTests are flaky. I was recently told by sahel@ that setting speed_in_pixels_s to a very high number will ensure there is one GSU only and will prevent the flaky. This does work, at least locally. I have tried the test in this CL locally and it was flaky without this change. With this change, I have ran this test 50 times without any failure. This CL does that. Right now there are a few tests marked flaky, this CL enables one of them first. I will monitor the flakiness dashboard once this CL lands. If this does solve the problem, we will then enable more tests. Bug: 833015 Change-Id: I539703866094fb526e220c48aaf327836345b950 Reviewed-on: https://chromium-review.googlesource.com/1101464 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by: Sahel Sharifymoghaddam <sahel@chromium.org> Reviewed-by: Timothy Dresser <tdresser@chromium.org> Cr-Commit-Position: refs/heads/master@{#567692} [modify] https://crrev.com/c32a3d1ec4331f10e0efbd5d979a833f8e1a57ce/content/browser/renderer_host/input/touch_action_browsertest.cc
,
Jun 25 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a244e3d26823848b4c5f137185a9d7dc90a3bd07 commit a244e3d26823848b4c5f137185a9d7dc90a3bd07 Author: Darren Shen <shend@chromium.org> Date: Mon Jun 25 08:49:29 2018 Revert "Deflake one of TouchActionBrowserTest" This reverts commit c32a3d1ec4331f10e0efbd5d979a833f8e1a57ce. Reason for revert: introduced flake, see https://crbug.com/855979 Original change's description: > Deflake one of TouchActionBrowserTest > > Some of the TouchActionBrowserTests are flaky. I was recently told by > sahel@ that setting speed_in_pixels_s to a very high number will ensure > there is one GSU only and will prevent the flaky. This does work, at > least locally. I have tried the test in this CL locally and it was > flaky without this change. With this change, I have ran this test 50 > times without any failure. > > This CL does that. Right now there are a few tests marked flaky, this > CL enables one of them first. I will monitor the flakiness dashboard > once this CL lands. If this does solve the problem, we will then enable > more tests. > > Bug: 833015 > Change-Id: I539703866094fb526e220c48aaf327836345b950 > Reviewed-on: https://chromium-review.googlesource.com/1101464 > Commit-Queue: Xida Chen <xidachen@chromium.org> > Reviewed-by: Sahel Sharifymoghaddam <sahel@chromium.org> > Reviewed-by: Timothy Dresser <tdresser@chromium.org> > Cr-Commit-Position: refs/heads/master@{#567692} TBR=tdresser@chromium.org,xidachen@chromium.org,sahel@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 833015 Change-Id: I53852330fc0702b5e0c240afed40ef514c8a136f Reviewed-on: https://chromium-review.googlesource.com/1113217 Reviewed-by: Darren Shen <shend@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#569985} [modify] https://crrev.com/a244e3d26823848b4c5f137185a9d7dc90a3bd07/content/browser/renderer_host/input/touch_action_browsertest.cc
,
Jul 9
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/26336b9af5abe3580668f2ff0f8f354cb23adf95 commit 26336b9af5abe3580668f2ff0f8f354cb23adf95 Author: Xida Chen <xidachen@chromium.org> Date: Mon Jul 09 00:28:10 2018 Reland "Deflake one of TouchActionBrowserTest" This is a reland of c32a3d1ec4331f10e0efbd5d979a833f8e1a57ce The original CL was reverted by a sheriff here: https://chromium-review.googlesource.com/c/chromium/src/+/1113217, the tracking bug is 855979, it suspects that the original CL caused flaky in *san bots. But, the fact is that there is an un-initialized member in touch_event.h, which is the actual cause of the flakiness in *san bots, and that was fixed by this CL: https://chromium-review.googlesource.com/c/chromium/src/+/1116788 With the above fix, let's re-land this CL, otherwise this test is still flaky. Original change's description: > Deflake one of TouchActionBrowserTest > > Some of the TouchActionBrowserTests are flaky. I was recently told by > sahel@ that setting speed_in_pixels_s to a very high number will ensure > there is one GSU only and will prevent the flaky. This does work, at > least locally. I have tried the test in this CL locally and it was > flaky without this change. With this change, I have ran this test 50 > times without any failure. > > This CL does that. Right now there are a few tests marked flaky, this > CL enables one of them first. I will monitor the flakiness dashboard > once this CL lands. If this does solve the problem, we will then enable > more tests. > > Bug: 833015 > Change-Id: I539703866094fb526e220c48aaf327836345b950 > Reviewed-on: https://chromium-review.googlesource.com/1101464 > Commit-Queue: Xida Chen <xidachen@chromium.org> > Reviewed-by: Sahel Sharifymoghaddam <sahel@chromium.org> > Reviewed-by: Timothy Dresser <tdresser@chromium.org> > Cr-Commit-Position: refs/heads/master@{#567692} TBR=tdresser@chromium.org Bug: 833015 Change-Id: I8cd5a6cbec5fe4f9f13e619b001455a97935d1ee Reviewed-on: https://chromium-review.googlesource.com/1124699 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by: Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#573194} [modify] https://crrev.com/26336b9af5abe3580668f2ff0f8f354cb23adf95/content/browser/renderer_host/input/touch_action_browsertest.cc
,
Jul 11
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bd9869d20cd802e82013e812424c9b32835d4a86 commit bd9869d20cd802e82013e812424c9b32835d4a86 Author: Xida Chen <xidachen@chromium.org> Date: Wed Jul 11 18:59:42 2018 [Code health] Enable all TouchActionBrowserTests but not on Debug After we landed this CL: https://chromium-review.googlesource.com/c/chromium/src/+/1124699 which deflakes one of the TouchActionBrowserTests, the flakiness dashboard shows that all other tests are stable except on Debug bots. So this CL enables all the tests and disable them on Debug builds. TBR=tdresser@chromium.org Bug: 855979 , 833015 Change-Id: Ie9aff86f735bb6dbe2923f080cbe09f59ee4e1b1 Reviewed-on: https://chromium-review.googlesource.com/1129099 Reviewed-by: Sahel Sharify <sahel@chromium.org> Reviewed-by: Xida Chen <xidachen@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#574271} [modify] https://crrev.com/bd9869d20cd802e82013e812424c9b32835d4a86/content/browser/renderer_host/input/touch_action_browsertest.cc
,
Jul 12
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/da109c8fd1b66a54c514b3012c29ebb232c113e9 commit da109c8fd1b66a54c514b3012c29ebb232c113e9 Author: Xida Chen <xidachen@chromium.org> Date: Thu Jul 12 16:02:09 2018 [Code health] Disable TouchActionBrowserTests on Debug and *San bots These tests are flaky on Debug builds and *San bots. These tests sends synthetic gesture event and measure scroll offset. It should be fine without coverages on Debug and *San builds. TBR=sahel@chromium.org, tdresser@chromium.org Bug: 855979 , 833015 Change-Id: I009d3557454e0aab960d35fc5256ed487c2e47fe Reviewed-on: https://chromium-review.googlesource.com/1135195 Reviewed-by: Xida Chen <xidachen@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#574579} [modify] https://crrev.com/da109c8fd1b66a54c514b3012c29ebb232c113e9/content/browser/renderer_host/input/touch_action_browsertest.cc
,
Jul 15
|
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by Findit
, Apr 14 2018