New issue
Advanced search Search tips

Issue 833009 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 23
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Fix cros-chrome-sdk's path to qemu in google storage

Project Member Reported by bpastene@chromium.org, Apr 14 2018

Issue description

The cros chrome-sdk tries to download qemu-2.6.0-r2.tbz2:
https://codesearch.chromium.org/chromium/src/third_party/chromite/cli/cros/cros_chrome_sdk.py?rcl=c23684514c93ed552d280b25b1280738eb42acfc&l=87

But the latest build products contain only qemu-2.6.0-r3.tbz2: (note the -r2 vs -r3)
https://pantheon.corp.google.com/storage/browser/chromeos-prebuilt/board/amd64-host/chroot-2018.04.12.144229/packages/app-emulation

Consequently, running `cros chrome-sdk --download-vm` at head fails because the -r2 version doesn't exist.

Looks like it changed to -r3 recently in:
https://chromium.git.corp.google.com/chromiumos/overlays/chromiumos-overlay/+/d72b112cb2610405d7d949c271a7747fe0a2aedc
 
Labels: OS-Chrome
Owner: achuith@chromium.org
Status: Started (was: Untriaged)
And it would be nice if tool changes like that would verify first that the simplechrome flow still works before landing.
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/3d8009e01ff58aa6d2901749dd4eb92928298821

commit 3d8009e01ff58aa6d2901749dd4eb92928298821
Author: Achuith Bhandarkar <achuith@chromium.org>
Date: Thu Apr 19 02:55:41 2018

cros_chrome_sdk: Fix version.

Short fix for version.

More comprehensive fix in CL:1016921

BUG= chromium:833009 
TEST=manual

Change-Id: I3a9d56663e180310b1642be84b0a76eb73545dcf
Reviewed-on: https://chromium-review.googlesource.com/1016909
Commit-Ready: Ben Pastene <bpastene@chromium.org>
Tested-by: Achuith Bhandarkar <achuith@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Ben Pastene <bpastene@chromium.org>

[modify] https://crrev.com/3d8009e01ff58aa6d2901749dd4eb92928298821/cli/cros/cros_chrome_sdk.py

Project Member

Comment 4 by bugdroid1@chromium.org, Apr 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e8ec24b636b76d1c05a4bc42a48403b0d05b5a25

commit e8ec24b636b76d1c05a4bc42a48403b0d05b5a25
Author: chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Thu Apr 19 07:11:18 2018

Roll src/third_party/chromite/ 0e6f95c50..3d8009e01 (1 commit)

https://chromium.googlesource.com/chromiumos/chromite.git/+log/0e6f95c50047..3d8009e01ff5

$ git log 0e6f95c50..3d8009e01 --date=short --no-merges --format='%ad %ae %s'
2018-04-18 achuith cros_chrome_sdk: Fix version.

Created with:
  roll-dep src/third_party/chromite
BUG= chromium:833009 


The AutoRoll server is located here: https://chromite-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: I50d99a2eee00499ce10394ff9e1dbc74fada4e7d
Reviewed-on: https://chromium-review.googlesource.com/1018593
Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#551960}
[modify] https://crrev.com/e8ec24b636b76d1c05a4bc42a48403b0d05b5a25/DEPS

Comment 5 by vapier@chromium.org, May 30 2018

Cc: tikuta@chromium.org vapier@chromium.org
 Issue 847819  has been merged into this issue.

Comment 6 by vapier@chromium.org, May 30 2018

Labels: -Restrict-View-Google
Mike's suggestion for fixing this:
https://chromium-review.googlesource.com/c/chromiumos/chromite/+/1016921#message-356b750dbe09434ac6e1ceadf6d36a6ee8f2b013

i don't think this is the right approach.  the existence of an ebuild is no indication of a binpkg being (yet) available.  the PREBUILT_CONF_PATH usage is also not right.

we should be able to include the sdk version with the sysroot/toolchain details we upload as part of the Chrome sysroot generation.  with that in hand, you can easily locate the correct matching version of qemu:
(1) find qemu version in https://commondatastorage.googleapis.com/chromiumos-sdk/cros-sdk-<SDK_VER>.tar.xz.Manifest
(2) download that version from https://commondatastorage.googleapis.com/chromeos-prebuilt/host/amd64/amd64-host/chroot-<SDK_VER>/packages/app-emulation/qemu-<qemu version>.tbz2


Comment 8 by se...@chromium.org, May 31 2018

This closed the tree again, anything we can do?


Chumped this CL:
https://chromium-review.googlesource.com/c/chromiumos/chromite/+/1080236

Need to update chromite DEPS, will chump that next
Also landed this:
https://chromium-review.googlesource.com/c/chromium/src/+/1081003

I believe the bot should recover now.
Project Member

Comment 12 by bugdroid1@chromium.org, Jun 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/81e0d3d735ded0b537468ed6064aabc884a146b1

commit 81e0d3d735ded0b537468ed6064aabc884a146b1
Author: Achuith Bhandarkar <achuith@chromium.org>
Date: Fri Jun 08 16:00:16 2018

cros_chrome_sdk: Introduce QEMU_BIN_PATH

Split QEMU_BIN_KEY and QEMU_BIN_PATH. Previously, QEMU_BIN_KEY
was both the key to the disk cache, and also a partial path of the qemu
binary (app-emulation/qemu-2.6.0-r4.tbz2). We now use a string 'qemu' as the key,
and the path remains the same as before.

_GetQemuBinPath previously returned the path to the prebuilt package, and now
it returns the full path to the qemu binary.

BUG= chromium:833009 
TEST=cros chrome-sdk --download-vm

Change-Id: I048dbffeb93b46b79695855f93b5046e999ab6c0
Reviewed-on: https://chromium-review.googlesource.com/1089474
Commit-Ready: Achuith Bhandarkar <achuith@chromium.org>
Tested-by: Achuith Bhandarkar <achuith@chromium.org>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>

[modify] https://crrev.com/81e0d3d735ded0b537468ed6064aabc884a146b1/cli/cros/cros_chrome_sdk.py

Project Member

Comment 13 by bugdroid1@chromium.org, Jun 10 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/a3262ecbffe55bca7d89c90858aa800b1903a263

commit a3262ecbffe55bca7d89c90858aa800b1903a263
Author: Achuith Bhandarkar <achuith@chromium.org>
Date: Sun Jun 10 11:54:58 2018

cros_chrome_sdk: Fix qemu binary path.

Previously, we used the path in prebuilt.conf to determine the prebuilt
path in google storage. This is unnecessary - we can do a static
calculation based on the SDK version.

We also assumed a static qemu version (currently 2.6.0-r4) which broke
with every bump in the version. This CL now downloads the manifest of
the prebuilt to determine the qemu version.

BUG= chromium:833009 
TEST=cros chrome-sdk --board=amd64-generic --download-vm
CQ-DEPEND=CL:1089474

Change-Id: I3e27285055ebe2ed0981cbad18864d8be172d851
Reviewed-on: https://chromium-review.googlesource.com/1091272
Commit-Ready: Achuith Bhandarkar <achuith@chromium.org>
Tested-by: Achuith Bhandarkar <achuith@chromium.org>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/a3262ecbffe55bca7d89c90858aa800b1903a263/cli/cros/cros_chrome_sdk.py

Status: Fixed (was: Started)

Sign in to add a comment