New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 832979 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Apr 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Motion blur cursor broken

Project Member Reported by reve...@chromium.org, Apr 13 2018

Issue description

Causing GPU process to enter a crash loop.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7aca60bdff880f67372d8069f30b496b2102f065

commit 7aca60bdff880f67372d8069f30b496b2102f065
Author: David Reveman <reveman@chromium.org>
Date: Mon Apr 16 21:16:40 2018

ash: Remove UpdateCursorCompositingEnabled() call in Shell::Init.

This UpdateCursorCompositingEnabled call is happening before
the GPU process is properly initialized.

Remove it as it's not needed here. UpdateCursorCompositingEnabled
will be called later when preferences have been loaded and GPU
process is properly initialized.

Bug:  832979 
Test: chrome --ash-enable-cursor-motion-blur on Eve
Change-Id: I8603c007f1b0d201a046ffb7e84706af95c21097
Reviewed-on: https://chromium-review.googlesource.com/1013238
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: David Reveman <reveman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551118}
[modify] https://crrev.com/7aca60bdff880f67372d8069f30b496b2102f065/ash/shell.cc

Labels: Merge-Request-67
Requesting merge of this one line change to 67. While we don't typically support experimental about:flags, the severity of this issue is high enough that I think this one line fix is worth merging. If someone flips the switch for this flag without this fix, the only way to get the machine working again is through a full recovery.
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 17 2018

Labels: merge-merged-testbranch
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7aca60bdff880f67372d8069f30b496b2102f065

commit 7aca60bdff880f67372d8069f30b496b2102f065
Author: David Reveman <reveman@chromium.org>
Date: Mon Apr 16 21:16:40 2018

ash: Remove UpdateCursorCompositingEnabled() call in Shell::Init.

This UpdateCursorCompositingEnabled call is happening before
the GPU process is properly initialized.

Remove it as it's not needed here. UpdateCursorCompositingEnabled
will be called later when preferences have been loaded and GPU
process is properly initialized.

Bug:  832979 
Test: chrome --ash-enable-cursor-motion-blur on Eve
Change-Id: I8603c007f1b0d201a046ffb7e84706af95c21097
Reviewed-on: https://chromium-review.googlesource.com/1013238
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: David Reveman <reveman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551118}
[modify] https://crrev.com/7aca60bdff880f67372d8069f30b496b2102f065/ash/shell.cc

Labels: -Merge-Request-67 Merge-Approved-67
Approving merge for M67 Chrome OS
Project Member

Comment 5 by bugdroid1@chromium.org, Apr 17 2018

Labels: -merge-approved-67 merge-merged-3396
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ce5160cc5770944bcffdee04e46571653942ad48

commit ce5160cc5770944bcffdee04e46571653942ad48
Author: David Reveman <reveman@chromium.org>
Date: Tue Apr 17 20:33:59 2018

ash: Remove UpdateCursorCompositingEnabled() call in Shell::Init.

This UpdateCursorCompositingEnabled call is happening before
the GPU process is properly initialized.

Remove it as it's not needed here. UpdateCursorCompositingEnabled
will be called later when preferences have been loaded and GPU
process is properly initialized.

TBR=reveman@chromium.org

(cherry picked from commit 7aca60bdff880f67372d8069f30b496b2102f065)

Bug:  832979 
Test: chrome --ash-enable-cursor-motion-blur on Eve
Change-Id: I8603c007f1b0d201a046ffb7e84706af95c21097
Reviewed-on: https://chromium-review.googlesource.com/1013238
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: David Reveman <reveman@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#551118}
Reviewed-on: https://chromium-review.googlesource.com/1015557
Reviewed-by: David Reveman <reveman@chromium.org>
Cr-Commit-Position: refs/branch-heads/3396@{#60}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}
[modify] https://crrev.com/ce5160cc5770944bcffdee04e46571653942ad48/ash/shell.cc

Status: Fixed (was: Assigned)

Sign in to add a comment