New issue
Advanced search Search tips

Issue 832918 link

Starred by 1 user

Issue metadata

Status: Closed
Owner: ----
Closed: Jan 10
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Vast majority of requests to Tricium are Progress requests with "no results" response

Project Member Reported by qyears...@chromium.org, Apr 13 2018

Issue description

A few thoughts about this:

 - After waiting about 30 seconds for results initially, if there are no results, that means there probably won't be results; there are probably no tricium runs. The plugin could cancel the refresh cycle and just display "no results".

 - To make it easier to search the logs for real issues, we could make "no results" a 200. I'm not so sure about this though. Probably not necessary.
 
Labels: Milestone-Progress
Status: Available (was: Untriaged)
Components: Infra>Platform>Tricium
Components: -Infra>CodeAnalysis
Labels: -Tricium
Owner: qyears...@chromium.org
Status: Assigned (was: Available)
Note, I added logging for when 404 is returned, I plan to look into this later.
Project Member

Comment 5 by bugdroid1@chromium.org, Jul 31

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/gerrit-plugins/tricium/+/d5058ca70e82d6c2a3e05c11ddcebf541a4a90ec

commit d5058ca70e82d6c2a3e05c11ddcebf541a4a90ec
Author: Quinten Yearsley <qyearsley@chromium.org>
Date: Tue Jul 31 23:06:49 2018

[tricium plugin] Show Tricium results for last run before merged CL

Tricium doesn't run on CLs that are already merged, and when merging
a CL, Gerrit adds one last revision. As a result, when people view
merged CLs, the Tricium plugin tries to find progress for the last
patchset and always fails to find it. Instead, it might be useful
to show the results for the last patchset before merging.

Bug:  832918 
Change-Id: I61d313e6c2208a112b0e29f947453aecb192ccf3
Reviewed-on: https://chromium-review.googlesource.com/1157034
Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>

[modify] https://crrev.com/d5058ca70e82d6c2a3e05c11ddcebf541a4a90ec/test/tricium-view_test.html
[modify] https://crrev.com/d5058ca70e82d6c2a3e05c11ddcebf541a4a90ec/src/main/resources/static/tricium-view.js

Owner: ----
Status: Available (was: Assigned)
Labels: -Type-Feature -Milestone-Progress Type-Bug
Status: Closed (was: Available)

Sign in to add a comment