New issue
Advanced search Search tips

Issue 832910 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: ----
Type: ----



Sign in to add a comment

Update mojom connection failure error

Project Member Reported by kpaulhamus@chromium.org, Apr 13 2018

Issue description

The message right now assumes mojom::CredentialManager failed, but it could have been mojom::AuthenticatorImpl.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 20 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/10ade88a1c523c3d785bf6f0540884b7e243483c

commit 10ade88a1c523c3d785bf6f0540884b7e243483c
Author: Kim Paulhamus <kpaulhamus@chromium.org>
Date: Fri Apr 20 19:33:05 2018

Update error message in case of mojom connection failure

The message right now assumes mojom::CredentialManager failed,
but it could have been mojom::AuthenticatorImpl.

Bug:  832910 
Change-Id: Ibaca9d938ffe854ab6ee81a3aa56721991e505e6
Reviewed-on: https://chromium-review.googlesource.com/1012967
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Commit-Queue: Kim Paulhamus <kpaulhamus@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552429}
[modify] https://crrev.com/10ade88a1c523c3d785bf6f0540884b7e243483c/third_party/blink/renderer/modules/credentialmanager/credentials_container.cc

Status: Fixed (was: Started)
Labels: OS-Chrome OS-Mac OS-Windows
Requesting merge to m67. 

The current failure error prior to this CL only mentioned password manager, not webauthn, whichwass confusing to users attempting to use webauthn.
With the feature now enabled by default, this error *shouldn't* ever happen, but we want to have the right error message in case a user does disable the feature.
Labels: OS-Linux
Labels: Merge-Request-67
Project Member

Comment 6 by sheriffbot@chromium.org, Apr 24 2018

Labels: -Merge-Request-67 Merge-Approved-67 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M67. Please go ahead and merge the CL to branch 3396 manually. Please contact milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 7 by gov...@chromium.org, Apr 25 2018

Pls merge your change to M67 branch 3396 ASAP so we can pick it up for next M67 Beta release. Thank you.
Project Member

Comment 8 by bugdroid1@chromium.org, Apr 25 2018

Labels: -merge-approved-67 merge-merged-3396
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3ae6822a7ea960fee996e30f7701846a40928272

commit 3ae6822a7ea960fee996e30f7701846a40928272
Author: Kim Paulhamus <kpaulhamus@chromium.org>
Date: Wed Apr 25 00:21:24 2018

Update error message in case of mojom connection failure

The message right now assumes mojom::CredentialManager failed,
but it could have been mojom::AuthenticatorImpl.

Bug:  832910 
Change-Id: Ibaca9d938ffe854ab6ee81a3aa56721991e505e6
Reviewed-on: https://chromium-review.googlesource.com/1012967
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Commit-Queue: Kim Paulhamus <kpaulhamus@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#552429}(cherry picked from commit 10ade88a1c523c3d785bf6f0540884b7e243483c)
Reviewed-on: https://chromium-review.googlesource.com/1026436
Reviewed-by: Kim Paulhamus <kpaulhamus@chromium.org>
Cr-Commit-Position: refs/branch-heads/3396@{#276}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}
[modify] https://crrev.com/3ae6822a7ea960fee996e30f7701846a40928272/third_party/blink/renderer/modules/credentialmanager/credentials_container.cc

Sign in to add a comment