Update mojom connection failure error |
|||||||
Issue descriptionThe message right now assumes mojom::CredentialManager failed, but it could have been mojom::AuthenticatorImpl.
,
Apr 20 2018
,
Apr 23 2018
Requesting merge to m67. The current failure error prior to this CL only mentioned password manager, not webauthn, whichwass confusing to users attempting to use webauthn. With the feature now enabled by default, this error *shouldn't* ever happen, but we want to have the right error message in case a user does disable the feature.
,
Apr 23 2018
,
Apr 23 2018
,
Apr 24 2018
Your change meets the bar and is auto-approved for M67. Please go ahead and merge the CL to branch 3396 manually. Please contact milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 25 2018
Pls merge your change to M67 branch 3396 ASAP so we can pick it up for next M67 Beta release. Thank you.
,
Apr 25 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3ae6822a7ea960fee996e30f7701846a40928272 commit 3ae6822a7ea960fee996e30f7701846a40928272 Author: Kim Paulhamus <kpaulhamus@chromium.org> Date: Wed Apr 25 00:21:24 2018 Update error message in case of mojom connection failure The message right now assumes mojom::CredentialManager failed, but it could have been mojom::AuthenticatorImpl. Bug: 832910 Change-Id: Ibaca9d938ffe854ab6ee81a3aa56721991e505e6 Reviewed-on: https://chromium-review.googlesource.com/1012967 Reviewed-by: Balazs Engedy <engedy@chromium.org> Commit-Queue: Kim Paulhamus <kpaulhamus@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#552429}(cherry picked from commit 10ade88a1c523c3d785bf6f0540884b7e243483c) Reviewed-on: https://chromium-review.googlesource.com/1026436 Reviewed-by: Kim Paulhamus <kpaulhamus@chromium.org> Cr-Commit-Position: refs/branch-heads/3396@{#276} Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428} [modify] https://crrev.com/3ae6822a7ea960fee996e30f7701846a40928272/third_party/blink/renderer/modules/credentialmanager/credentials_container.cc |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by bugdroid1@chromium.org
, Apr 20 2018