PDF XFA: Combobox: On line wrap, the lines after first have the same content as the first line |
||
Issue descriptionOn an XFA enabled build: 1. Open https://www.canada.ca/content/dam/ircc/migration/ircc/english/pdf/kits/forms/imm5257e.pdf 2. Under "5. Place of Birth", open the "Country" dropdown. 3. Scroll down and select "Heard and MacDonald Islands". Yes, really. Expected: Combobox displays: " Heard and MacDonald Islands " Actual: Combobox displays: " Heard and MacDonald Heard an " See screenshot.
,
Apr 19 2018
The following revision refers to this bug: https://pdfium.googlesource.com/pdfium/+/c831580e1b4547d5fcbe74864e657c1c4ebffc12 commit c831580e1b4547d5fcbe74864e657c1c4ebffc12 Author: Henrique Nakashima <hnakashima@chromium.org> Date: Thu Apr 19 21:59:33 2018 Fix duplicated text in each line in XFA widgets. When calculating the characters to display, the run offset was not added to the offset inside the run, so characters from the first run were always used instead of from the run that the line should display. Bug: chromium:832909 Change-Id: I4d1d284894ce6ac9c7a49976aa6a6d0cf21f1382 Reviewed-on: https://pdfium-review.googlesource.com/30993 Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Reviewed-by: dsinclair <dsinclair@chromium.org> [modify] https://crrev.com/c831580e1b4547d5fcbe74864e657c1c4ebffc12/xfa/fgas/layout/cfx_txtbreak.h [modify] https://crrev.com/c831580e1b4547d5fcbe74864e657c1c4ebffc12/xfa/fde/cfde_texteditengine.cpp [modify] https://crrev.com/c831580e1b4547d5fcbe74864e657c1c4ebffc12/xfa/fgas/layout/cfx_txtbreak.cpp
,
Apr 19 2018
,
Apr 20 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/35fa35716150a4a7a222979e36b6f45e523e68c2 commit 35fa35716150a4a7a222979e36b6f45e523e68c2 Author: pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Fri Apr 20 00:42:15 2018 Roll src/third_party/pdfium/ 9914d4dc1..901f34332 (6 commits) https://pdfium.googlesource.com/pdfium.git/+log/9914d4dc1e7a..901f34332823 $ git log 9914d4dc1..901f34332 --date=short --no-merges --format='%ad %ae %s' 2018-04-19 hnakashima Caret moves after clicked char if closer to its right rect boundary. 2018-04-19 hnakashima Fix duplicated text in each line in XFA widgets. 2018-04-19 hnakashima Fix caret moving to start of edit on click after the text. 2018-04-19 thestig Add public APIs for undo / redo in forms. 2018-04-19 thestig Change SHADING_STEPS from a #define to a constant. 2018-04-19 hnakashima Fix caret not moving to click target in XFA edit. Created with: roll-dep src/third_party/pdfium BUG= chromium:832293 , chromium:832909 , chromium:832293 , chromium:764260 , chromium:832293 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I0c49fb5b7d6ee39f132bf4c8e2daf7a9740e5c39 Reviewed-on: https://chromium-review.googlesource.com/1019973 Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#552220} [modify] https://crrev.com/35fa35716150a4a7a222979e36b6f45e523e68c2/DEPS |
||
►
Sign in to add a comment |
||
Comment 1 by hnakashima@chromium.org
, Apr 19 2018