New issue
Advanced search Search tips

Issue 832907 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 3
Type: Task



Sign in to add a comment

Implementing enterprise reporting Extension

Project Member Reported by zmin@chromium.org, Apr 13 2018

Issue description

Finished CL:

Create a new extension API for enterprise browser reporting:
https://chromium-review.googlesource.com/c/chromium/src/+/976819

 
Implement a helper function that builds ChromeDesktopReportRequest.
https://chromium-review.googlesource.com/c/chromium/src/+/986946
 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4a4ca485c5152a2aab3d476a0ded31ee86a49c50

commit 4a4ca485c5152a2aab3d476a0ded31ee86a49c50
Author: Owen Min <zmin@chromium.org>
Date: Mon Apr 16 16:20:10 2018

Set timestamp of cloud policy in Enterprise reporting extension API.

Set the timestamp of last fetch time of MachineLevelUserCloudPolicy
if it's enabled.

Bug:  832907 
Change-Id: I80084e82932479b7e2ee29474f069c685d96f063
Reviewed-on: https://chromium-review.googlesource.com/1013044
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Reviewed-by: Marc-André Decoste <mad@chromium.org>
Commit-Queue: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550993}
[modify] https://crrev.com/4a4ca485c5152a2aab3d476a0ded31ee86a49c50/chrome/browser/extensions/api/enterprise_reporting_private/chrome_desktop_report_request_helper.cc
[modify] https://crrev.com/4a4ca485c5152a2aab3d476a0ded31ee86a49c50/chrome/browser/policy/chrome_browser_policy_connector.cc
[modify] https://crrev.com/4a4ca485c5152a2aab3d476a0ded31ee86a49c50/chrome/browser/policy/chrome_browser_policy_connector.h

Project Member

Comment 2 by bugdroid1@chromium.org, Apr 17 2018

Labels: merge-merged-testbranch
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4a4ca485c5152a2aab3d476a0ded31ee86a49c50

commit 4a4ca485c5152a2aab3d476a0ded31ee86a49c50
Author: Owen Min <zmin@chromium.org>
Date: Mon Apr 16 16:20:10 2018

Set timestamp of cloud policy in Enterprise reporting extension API.

Set the timestamp of last fetch time of MachineLevelUserCloudPolicy
if it's enabled.

Bug:  832907 
Change-Id: I80084e82932479b7e2ee29474f069c685d96f063
Reviewed-on: https://chromium-review.googlesource.com/1013044
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Reviewed-by: Marc-André Decoste <mad@chromium.org>
Commit-Queue: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550993}
[modify] https://crrev.com/4a4ca485c5152a2aab3d476a0ded31ee86a49c50/chrome/browser/extensions/api/enterprise_reporting_private/chrome_desktop_report_request_helper.cc
[modify] https://crrev.com/4a4ca485c5152a2aab3d476a0ded31ee86a49c50/chrome/browser/policy/chrome_browser_policy_connector.cc
[modify] https://crrev.com/4a4ca485c5152a2aab3d476a0ded31ee86a49c50/chrome/browser/policy/chrome_browser_policy_connector.h

Project Member

Comment 3 by bugdroid1@chromium.org, Apr 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f88e3e86b2159aa56082cec909bd4a11b0e82d31

commit f88e3e86b2159aa56082cec909bd4a11b0e82d31
Author: Olivier Li <olivierli@chromium.org>
Date: Fri Apr 27 13:02:52 2018

Add the profile name to ChromeUserProfileReport proto.

Add the code to populate the field in the enterprise reporting and create associated test.

Bug:  832907 
Change-Id: Ia588466539288e17a61846d9ddf675460d1774d2
Reviewed-on: https://chromium-review.googlesource.com/1015240
Reviewed-by: Owen Min <zmin@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Reviewed-by: Marc-André Decoste <mad@chromium.org>
Commit-Queue: Oliver Li <olivierli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554364}
[modify] https://crrev.com/f88e3e86b2159aa56082cec909bd4a11b0e82d31/chrome/browser/extensions/api/enterprise_reporting_private/chrome_desktop_report_request_helper.cc
[modify] https://crrev.com/f88e3e86b2159aa56082cec909bd4a11b0e82d31/chrome/browser/extensions/api/enterprise_reporting_private/chrome_desktop_report_request_helper_unittest.cc
[modify] https://crrev.com/f88e3e86b2159aa56082cec909bd4a11b0e82d31/components/policy/proto/device_management_backend.proto

Project Member

Comment 4 by bugdroid1@chromium.org, Apr 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/85dffcbf7c2ce7d9207c5489ac4d0d01f9326e3b

commit 85dffcbf7c2ce7d9207c5489ac4d0d01f9326e3b
Author: Owen Min <zmin@chromium.org>
Date: Fri Apr 27 14:32:07 2018

Update ChromePath in enterprise reporting private API.

Using base::DIR_EXE to replace DIR_APP. Because the first one does not
contain version info in the path. And it also providers a meaningful path
on Mac and Linux.

Bug:  832907 
Change-Id: I686a5c2f14b62b7f0d4789eeb88f031793d57b22
Reviewed-on: https://chromium-review.googlesource.com/1030878
Reviewed-by: Marc-André Decoste <mad@chromium.org>
Commit-Queue: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554387}
[modify] https://crrev.com/85dffcbf7c2ce7d9207c5489ac4d0d01f9326e3b/chrome/browser/extensions/api/enterprise_reporting_private/chrome_desktop_report_request_helper.cc

Comment 5 by zmin@chromium.org, Apr 30 2018

Labels: Merge-Request-67
I'd like to merge the CL http://crrev.com/85dffcbf7c2ce7d9207c5489ac4d0d01f9326e3b back to M67.

The CL resolved an important issue for token based cloud policy which will be tested by trust testers in M67.
Project Member

Comment 6 by sheriffbot@chromium.org, Apr 30 2018

Labels: -Merge-Request-67 Merge-Reject-67 Hotlist-Merge-Reject
The bug is marked as P3 or Feature. It should not be merged as M67 is in beta. 
Please contact the approriate milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 7 Deleted

Comment 8 by zmin@chromium.org, Apr 30 2018

The CL above actually fixed an issue. I'll move the merge request to  issue 838258 .
Project Member

Comment 9 by bugdroid1@chromium.org, May 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f52452e280d993517846feb53a786255e3cedf3e

commit f52452e280d993517846feb53a786255e3cedf3e
Author: Owen Min <zmin@chromium.org>
Date: Mon May 28 16:12:45 2018

Support safe browsing count in enterprise report API.

The API now accepts safe browsing warning count and safe browsing warning
click through count.

Bug:  846453 ,  832907 
Change-Id: Ied5eec64ab71f8fe3ef2cb65efd2f43bfceb3a68
Reviewed-on: https://chromium-review.googlesource.com/1072515
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Commit-Queue: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562274}
[modify] https://crrev.com/f52452e280d993517846feb53a786255e3cedf3e/chrome/browser/extensions/api/enterprise_reporting_private/chrome_desktop_report_request_helper.cc
[modify] https://crrev.com/f52452e280d993517846feb53a786255e3cedf3e/chrome/browser/extensions/api/enterprise_reporting_private/chrome_desktop_report_request_helper_unittest.cc

Project Member

Comment 10 by bugdroid1@chromium.org, May 30 2018

Labels: merge-merged-3440
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2fc760d3c84af035465535aa1bff0f490124b824

commit 2fc760d3c84af035465535aa1bff0f490124b824
Author: Owen Min <zmin@chromium.org>
Date: Wed May 30 19:22:12 2018

Merge "Support safe browsing count in enterprise report API." to 68.

The API now accepts safe browsing warning count and safe browsing warning
click through count.

Bug:  846453 ,  832907 
Change-Id: Ied5eec64ab71f8fe3ef2cb65efd2f43bfceb3a68
Reviewed-on: https://chromium-review.googlesource.com/1072515
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Commit-Queue: Owen Min <zmin@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#562274}(cherry picked from commit f52452e280d993517846feb53a786255e3cedf3e)
Reviewed-on: https://chromium-review.googlesource.com/1079727
Reviewed-by: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/branch-heads/3440@{#47}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}
[modify] https://crrev.com/2fc760d3c84af035465535aa1bff0f490124b824/chrome/browser/extensions/api/enterprise_reporting_private/chrome_desktop_report_request_helper.cc
[modify] https://crrev.com/2fc760d3c84af035465535aa1bff0f490124b824/chrome/browser/extensions/api/enterprise_reporting_private/chrome_desktop_report_request_helper_unittest.cc

Comment 11 by zmin@chromium.org, Jun 20 2018

Status: Fixed (was: Assigned)

Sign in to add a comment