[CRD iOS] UI glitch when refreshing HostSetupView |
|||||||
Issue descriptionWhat steps will reproduce the problem? (1) Open CRD iOS and sign in with an account with no host. (2) Bring the app to background. (3) Reopen the app. What is the expected result? No UI glitch. What happens instead? The FetchingView (a spinner on the center) is shown for a very short time and disappears.
,
Apr 13 2018
This only affects Chromoting and doesn't affect Chrome.
,
Apr 14 2018
Your change meets the bar and is auto-approved for M67. Please go ahead and merge the CL to branch 3396 manually. Please contact milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 16 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c18174c345fa472c9c8c0a1af72e6b08fc3d9ee2 commit c18174c345fa472c9c8c0a1af72e6b08fc3d9ee2 Author: Yuwei Huang <yuweih@chromium.org> Date: Mon Apr 16 19:51:26 2018 [CRD iOS] Fix UI glitch when refreshing host list while HostSetupView is showing Currently we don't show the FetchingView (just a spinner on the center) when refreshing host list while the host list is already shown, but we haven't done that for the HostSetupView. If the user reactivates the app from background while HostSetupView is being show, we will show the FetchingView very quick then almost immediately show the HostSetupView. Given that we already have a pull-to-refresh controll/UI for the HostSetupView, we don't need to show the FetchingView at all for HostSetupView. Bug: 832905 Change-Id: I8b4f74c3983f35612be9a565881b85b0760ba1c1 Reviewed-on: https://chromium-review.googlesource.com/1013042 Reviewed-by: Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Yuwei Huang <yuweih@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#550781}(cherry picked from commit f8085cad9c3248a134edafd5e710a006123aabb1) Reviewed-on: https://chromium-review.googlesource.com/1012790 Reviewed-by: Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/branch-heads/3396@{#24} Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428} [modify] https://crrev.com/c18174c345fa472c9c8c0a1af72e6b08fc3d9ee2/remoting/ios/app/remoting_view_controller.mm
,
Apr 16 2018
,
Apr 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f8085cad9c3248a134edafd5e710a006123aabb1 commit f8085cad9c3248a134edafd5e710a006123aabb1 Author: Yuwei Huang <yuweih@chromium.org> Date: Fri Apr 13 23:09:21 2018 [CRD iOS] Fix UI glitch when refreshing host list while HostSetupView is showing Currently we don't show the FetchingView (just a spinner on the center) when refreshing host list while the host list is already shown, but we haven't done that for the HostSetupView. If the user reactivates the app from background while HostSetupView is being show, we will show the FetchingView very quick then almost immediately show the HostSetupView. Given that we already have a pull-to-refresh controll/UI for the HostSetupView, we don't need to show the FetchingView at all for HostSetupView. Bug: 832905 Change-Id: I8b4f74c3983f35612be9a565881b85b0760ba1c1 Reviewed-on: https://chromium-review.googlesource.com/1013042 Reviewed-by: Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#550781} [modify] https://crrev.com/f8085cad9c3248a134edafd5e710a006123aabb1/remoting/ios/app/remoting_view_controller.mm
,
Jul 19
Verified Fixed in 67.0.3396.22 |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by bugdroid1@chromium.org
, Apr 13 2018