New issue
Advanced search Search tips

Issue 832893 link

Starred by 1 user
Status: Unconfirmed
Owner: ----
Cc:
hinoka@chromium.org
efoo@chromium.org
no...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Support custom manifest names.

Project Member Reported by hinoka@chromium.org, Apr 13 2018 
Milo uses the "REVISION" manifest name everywhere right now (based on buildset).  It should support custom ones, such as "UNPATCHED", "PATCHED", etc.
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 14 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-go.git/+/dd483fb689257fa7f25071546f27fb0464fb1607

commit dd483fb689257fa7f25071546f27fb0464fb1607
Author: Ryan Tseng <hinoka@google.com>
Date: Sat Apr 14 00:46:16 2018

[milo] Fix comment in proto for manifest_name

Bug: 832893
TBR: iannucci
Change-Id: I6e716aaa6d7ef168602e15a8f5693f785d38c0fa
Reviewed-on: https://chromium-review.googlesource.com/1012990
Reviewed-by: Ryan Tseng <hinoka@chromium.org>
Commit-Queue: Ryan Tseng <hinoka@chromium.org>

[modify] https://crrev.com/dd483fb689257fa7f25071546f27fb0464fb1607/milo/api/config/project.pb.go
[modify] https://crrev.com/dd483fb689257fa7f25071546f27fb0464fb1607/milo/api/config/project.proto

Comment 2 by no...@chromium.org, Apr 17 2018 

Will we still need this after buildbucket API grows blamelist support?

Comment 3 by hinoka@chromium.org, Apr 17 2018 

Yes, since this is for console indexing.
►

Sign in to add a comment