New issue
Advanced search Search tips

Issue 832888 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Feature



Sign in to add a comment

Links sent to chrome should have localhost/127.0.0.1 replaced

Project Member Reported by jkardatzke@chromium.org, Apr 13 2018

Issue description

If a url is sent to Chrome to be opened and it as either localhost or 127.0.0.1 as the address of the server; we should replace that with the hostname 'dev.local' which we are going to associate with the container IP address.  Then those links will open properly when we open them in Chrome under Chrome OS.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 20 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/7c498abb24715ef8cb730bc2f643574d9c786227

commit 7c498abb24715ef8cb730bc2f643574d9c786227
Author: Jeffrey Kardatzke <jkardatzke@google.com>
Date: Fri Apr 20 02:29:04 2018

vm_tools: Replace localhost/loopback with container IP in URLs for host

When we send a URL to the host (Chrome) to open that has either
localhost or the loopback address in it for the hostname, we should swap
that out with the IP address of the container so that URLs referencing
services running in the container will open properly in Chrome without
the user having to fix the hostname manually.

BUG= chromium:832888 
TEST=Manually tested with garcon and various URL formats
CQ-DEPEND=CL:1015768

Change-Id: Ib7867a71417f7915abc5a0d4609016e69e3ea204
Reviewed-on: https://chromium-review.googlesource.com/1017911
Commit-Ready: Jeffrey Kardatzke <jkardatzke@google.com>
Tested-by: Jeffrey Kardatzke <jkardatzke@google.com>
Reviewed-by: Chirantan Ekbote <chirantan@chromium.org>
Reviewed-by: Dylan Reid <dgreid@chromium.org>

[modify] https://crrev.com/7c498abb24715ef8cb730bc2f643574d9c786227/vm_tools/concierge/container_listener_impl.cc
[modify] https://crrev.com/7c498abb24715ef8cb730bc2f643574d9c786227/vm_tools/concierge/service.h
[modify] https://crrev.com/7c498abb24715ef8cb730bc2f643574d9c786227/vm_tools/concierge/service.cc
[modify] https://crrev.com/7c498abb24715ef8cb730bc2f643574d9c786227/vm_tools/concierge/container_listener_impl.h

Status: Fixed (was: Assigned)

Comment 3 by vapier@chromium.org, May 17 2018

Labels: -Restrict-View-Google

Sign in to add a comment