New issue
Advanced search Search tips

Issue 832887 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Enterprise reporting Extension API

Project Member Reported by zmin@chromium.org, Apr 13 2018

Issue description

Request to merge the Extension API of enterprise reporting to 67.

https://chromium-review.googlesource.com/c/chromium/src/+/976819
 

Comment 1 by zmin@chromium.org, Apr 13 2018

Labels: -Merge-Request-67
Status: (was: Assigned)
Labels: Merge-Request-67
Status: Assigned
More info: We missed the branch point because of bot flakes :(

This is safe and has no user impact. It's only for an internal enterprise extension that we'll be testing shortly with Trusted Testers.

Comment 3 by zmin@chromium.org, Apr 13 2018

Request a merge to 67 as it's a release blocker for Enterprise reporting Trust Test. The code has been covered by unit_test
Project Member

Comment 4 by sheriffbot@chromium.org, Apr 14 2018

Labels: -Merge-Request-67 Merge-Approved-67 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M67. Please go ahead and merge the CL to branch 3396 manually. Please contact milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 5 by bugdroid1@chromium.org, Apr 15 2018

Labels: -merge-approved-67 merge-merged-3396
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8e87f21281d3e0711a67c4018f23eeff70425d9c

commit 8e87f21281d3e0711a67c4018f23eeff70425d9c
Author: Owen Min <zmin@chromium.org>
Date: Sun Apr 15 00:34:57 2018

Create a new extension API for enterprise browser reporting.

It introduces new permission, IDL and skeleton of implementation.

This privacy API is used to upload browsers and devices status that
are collected by extension to the admin console.


Bug:  832887 
Change-Id: I60780d76c9e7680843acef38ce906e9cbe150025
Reviewed-on: https://chromium-review.googlesource.com/976819
Reviewed-by: Gayane Petrosyan <gayane@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Owen Min <zmin@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#550521}(cherry picked from commit fdada01a75db65126449561b8b7b62adb902efe8)
Reviewed-on: https://chromium-review.googlesource.com/1013340
Reviewed-by: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/branch-heads/3396@{#8}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}
[modify] https://crrev.com/8e87f21281d3e0711a67c4018f23eeff70425d9c/chrome/browser/extensions/BUILD.gn
[add] https://crrev.com/8e87f21281d3e0711a67c4018f23eeff70425d9c/chrome/browser/extensions/api/enterprise_reporting_private/OWNERS
[add] https://crrev.com/8e87f21281d3e0711a67c4018f23eeff70425d9c/chrome/browser/extensions/api/enterprise_reporting_private/enterprise_reporting_private_api.cc
[add] https://crrev.com/8e87f21281d3e0711a67c4018f23eeff70425d9c/chrome/browser/extensions/api/enterprise_reporting_private/enterprise_reporting_private_api.h
[add] https://crrev.com/8e87f21281d3e0711a67c4018f23eeff70425d9c/chrome/browser/extensions/api/enterprise_reporting_private/enterprise_reporting_private_unittest.cc
[modify] https://crrev.com/8e87f21281d3e0711a67c4018f23eeff70425d9c/chrome/common/extensions/api/BUILD.gn
[modify] https://crrev.com/8e87f21281d3e0711a67c4018f23eeff70425d9c/chrome/common/extensions/api/_api_features.json
[modify] https://crrev.com/8e87f21281d3e0711a67c4018f23eeff70425d9c/chrome/common/extensions/api/_permission_features.json
[add] https://crrev.com/8e87f21281d3e0711a67c4018f23eeff70425d9c/chrome/common/extensions/api/enterprise_reporting_private.idl
[modify] https://crrev.com/8e87f21281d3e0711a67c4018f23eeff70425d9c/chrome/common/extensions/permissions/chrome_api_permissions.cc
[modify] https://crrev.com/8e87f21281d3e0711a67c4018f23eeff70425d9c/chrome/common/extensions/permissions/permission_set_unittest.cc
[modify] https://crrev.com/8e87f21281d3e0711a67c4018f23eeff70425d9c/chrome/test/BUILD.gn
[modify] https://crrev.com/8e87f21281d3e0711a67c4018f23eeff70425d9c/extensions/browser/extension_function_histogram_value.h
[modify] https://crrev.com/8e87f21281d3e0711a67c4018f23eeff70425d9c/extensions/common/permissions/api_permission.h
[modify] https://crrev.com/8e87f21281d3e0711a67c4018f23eeff70425d9c/tools/metrics/histograms/enums.xml

Comment 6 by zmin@chromium.org, Apr 30 2018

Status: Verified (was: Assigned)

Sign in to add a comment