New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 832830 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , iOS , Chrome , Mac , Fuchsia
Pri: 1
Type: Bug



Sign in to add a comment

DataChannel throughput regressed in M66

Project Member Reported by deadbeef@chromium.org, Apr 13 2018

Issue description

Note that this has already been fixed: https://bugs.chromium.org/p/webrtc/issues/detail?id=9082

In M66, there was a regression noticed in a sample page that transfers data over a loopback connection: https://webrtc.github.io/samples/src/content/datachannel/datatransfer/

It went from taking 28 seconds to taking 48 seconds. This was due to a usrsctp change that resulted in packets of an unexpected size being generated, logging an error message for every packet sent: https://cs.chromium.org/chromium/src/third_party/webrtc/media/sctp/sctptransport.cc?l=908&rcl=3ef3bfc2aafa707985c9e9dcd4cfb6ccbc525628

This issue would be encountered for any application that uses data channels to send messages larger than the MTU (for example, when transferring a file or some other large piece of data that's chunked up).

Although it's pretty late for M66 changes, this has a very non-risky 1-line fix: https://webrtc-review.googlesource.com/c/src/+/66943

So I'm requesting a merge to M66.
 
Labels: -Pri-3 Pri-1
Project Member

Comment 2 by sheriffbot@chromium.org, Apr 13 2018

Labels: -Merge-Request-66 Merge-Review-66 Hotlist-Merge-Review
This bug requires manual review: We are only 3 days from stable.
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), josafat@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 3 by gov...@chromium.org, Apr 13 2018

Cc: abdulsyed@chromium.org
 deadbeef@, Pls apply appropriate OSs label. 

+ Abdul (M66 Desktop Release TPM).
Labels: -Merge-Review-66 Merge-Approved-66
Approving this merge for M66. Branch:3359
Labels: OS-Android OS-Chrome OS-Fuchsia OS-iOS OS-Linux OS-Mac OS-Windows
Labels: -Merge-Approved-66 Merge-Merged M-66
Merged: https://webrtc-review.googlesource.com/c/src/+/70000

Sign in to add a comment