polish MockQuicData APIs |
|||
Issue descriptionCurrent MockQuicData API already had a step forward from raw SequencedSocketData. However, some of its APIs are not easy to consume. For example: void AddRead(std::unique_ptr<QuicEncryptedPacket> packet); ----> adds asnyc read void AddWrite(std::unique_ptr<QuicEncryptedPacket> packet); -----> adds sync write This bug will be used to track the efforts to polish up the MockQuicData APIs.
,
Apr 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/32f2fd0ea3e1eb2ad9ac5b1e5ac22b1a150e01e7 commit 32f2fd0ea3e1eb2ad9ac5b1e5ac22b1a150e01e7 Author: Zhongyi Shi <zhongyi@chromium.org> Date: Mon Apr 16 18:23:43 2018 Change MockQuicData::AddRead() and MockQuicData::AddWrite() to take explicit IoMode. - Change the API for MockQuicData::AddRead() and MockQuicData::AddWrite() to always take explicit IoMode. - Deprecate the following methods as those are confusing to consume: MockQuicData::AddSynchronousRead() and MockQuicData::AddAsyncWrite(). Bug: 832803 Change-Id: Ie2dc096820988c47c8a75082ce2baacd1d32c3ae Reviewed-on: https://chromium-review.googlesource.com/1012700 Reviewed-by: Ryan Hamilton <rch@chromium.org> Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#551045} [modify] https://crrev.com/32f2fd0ea3e1eb2ad9ac5b1e5ac22b1a150e01e7/net/http/http_proxy_client_socket_wrapper_unittest.cc [modify] https://crrev.com/32f2fd0ea3e1eb2ad9ac5b1e5ac22b1a150e01e7/net/http/http_stream_factory_impl_job_controller_unittest.cc [modify] https://crrev.com/32f2fd0ea3e1eb2ad9ac5b1e5ac22b1a150e01e7/net/quic/chromium/mock_quic_data.cc [modify] https://crrev.com/32f2fd0ea3e1eb2ad9ac5b1e5ac22b1a150e01e7/net/quic/chromium/mock_quic_data.h [modify] https://crrev.com/32f2fd0ea3e1eb2ad9ac5b1e5ac22b1a150e01e7/net/quic/chromium/quic_chromium_client_session_test.cc [modify] https://crrev.com/32f2fd0ea3e1eb2ad9ac5b1e5ac22b1a150e01e7/net/quic/chromium/quic_network_transaction_unittest.cc [modify] https://crrev.com/32f2fd0ea3e1eb2ad9ac5b1e5ac22b1a150e01e7/net/quic/chromium/quic_proxy_client_socket_unittest.cc [modify] https://crrev.com/32f2fd0ea3e1eb2ad9ac5b1e5ac22b1a150e01e7/net/quic/chromium/quic_stream_factory_test.cc
,
Jul 30
|
|||
►
Sign in to add a comment |
|||
Comment 1 by bugdroid1@chromium.org
, Apr 16 2018