Issue metadata
Sign in to add a comment
|
"Extensions/ExtensionProtocolsTest.VerifyScriptListedAsIcon/1" unit_test is flaky on official desktop continuous Win64_trunk. |
||||||||||||||||||||||
Issue descriptionLink to builder : https://uberchromegw.corp.google.com/i/official.desktop.continuous/builders/win64%20trunk/builds/32447 Link to error log : https://logs.chromium.org/v/?s=chrome%2Fbb%2Fofficial.desktop.continuous%2Fwin64_trunk%2F32455%2F%2B%2Frecipes%2Fsteps%2Funit_tests%2F0%2Flogs%2FExtensions_ExtensionProtocolsTest.VerifyScriptListedAsIcon_1%2F0 Error : Extensions/ExtensionProtocolsTest.VerifyScriptListedAsIcon/1 (run #1): [ RUN ] Extensions/ExtensionProtocolsTest.VerifyScriptListedAsIcon/1 ../../chrome/browser/extensions/extension_protocols_unittest.cc(698): error: Expected: (base::WriteFile(file_path, content.c_str(), content.size())) != (-1), actual: -1 vs -1 ../../chrome/browser/extensions/extension_protocols_unittest.cc(706): error: Expected equality of these values: ContentVerifyJob::HASH_MISMATCH Which is: 3 observer.WaitForJobFinished() Which is: 0 [ FAILED ] Extensions/ExtensionProtocolsTest.VerifyScriptListedAsIcon/1, where GetParam() = 4-byte object <01-00 00-00> (23 ms) Suspecting CL : https://chromium.googlesource.com/chromium/src/+/1fa235b63f813db3edd77307d6c85c37ddb65606
,
Apr 16 2018
Thanks, I'll take a look and try to fix the flakiness this week.
,
Apr 17 2018
mharanczyk@opera.com sent out a fix here: https://chromium-review.googlesource.com/c/chromium/src/+/1013982 Re-assigning this bug to them.
,
Apr 18 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fef658d7a4d68db1b902c1c2c3982e83504071a2 commit fef658d7a4d68db1b902c1c2c3982e83504071a2 Author: Marek Haranczyk <mharanczyk@opera.com> Date: Wed Apr 18 17:56:51 2018 Prevent ManifestHandlerRegistry override from leaking to different tests. ContentVerifierTest was setting up override but never reseting it causing other tests that loaded extension to access invalid memory of stack allocated registry override. This is regression after crrev.com/c/957645 that causes crash or timeout in extensions_unittests. Bug: 809088, 832801 Change-Id: I45d8ee2e4e450e8d5f619e502e7a6e96c8879ef0 Reviewed-on: https://chromium-review.googlesource.com/1013982 Commit-Queue: Marek Haranczyk <mharanczyk@opera.com> Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by: proberge <proberge@chromium.org> Cr-Commit-Position: refs/heads/master@{#551738} [modify] https://crrev.com/fef658d7a4d68db1b902c1c2c3982e83504071a2/extensions/BUILD.gn [modify] https://crrev.com/fef658d7a4d68db1b902c1c2c3982e83504071a2/extensions/browser/content_verifier_unittest.cc [modify] https://crrev.com/fef658d7a4d68db1b902c1c2c3982e83504071a2/extensions/common/manifest_handler.h [modify] https://crrev.com/fef658d7a4d68db1b902c1c2c3982e83504071a2/extensions/common/manifest_handler_unittest.cc [add] https://crrev.com/fef658d7a4d68db1b902c1c2c3982e83504071a2/extensions/common/scoped_testing_manifest_handler_registry.cc [add] https://crrev.com/fef658d7a4d68db1b902c1c2c3982e83504071a2/extensions/common/scoped_testing_manifest_handler_registry.h
,
Apr 19 2018
I don't have access to your logs and on our side flakiness was in different place so I'm trusting proberge@ that my fix is relevant for your case. Closing as fixed. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by rdevlin....@chromium.org
, Apr 13 2018Owner: proberge@chromium.org
Status: Assigned (was: Untriaged)