"DirectoryTreeContextMenu/FileManagerBrowserTest.Test/10" is flaky |
||||||||
Issue description"DirectoryTreeContextMenu/FileManagerBrowserTest.Test/10" is flaky. This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label. We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyQgsSBUZsYWtlIjdEaXJlY3RvcnlUcmVlQ29udGV4dE1lbnUvRmlsZU1hbmFnZXJCcm93c2VyVGVzdC5UZXN0LzEwDA. Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
,
Apr 17 2018
Disabling: https://chromium-review.googlesource.com/c/chromium/src/+/1015003
,
Apr 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/02dcc3909d88d832e67d10b588867124610115a3 commit 02dcc3909d88d832e67d10b588867124610115a3 Author: Rune Lillesveen <futhark@chromium.org> Date: Tue Apr 17 14:48:15 2018 Disable flaky tests in file_manager_browsertest.cc TBR=fukino@chromium.org Bug: 833049 , 832192 , 833752 , 832799 , 832798 Change-Id: I7d3316f2deae4f0e415e41a95211ee1f105cdf32 Reviewed-on: https://chromium-review.googlesource.com/1015003 Reviewed-by: Rune Lillesveen <futhark@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#551331} [modify] https://crrev.com/02dcc3909d88d832e67d10b588867124610115a3/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
,
Apr 17 2018
None of DirectoryTreeContextMenu/FileManagerBrowserTest.Test* are flaking after the fix landed on http://crrev.com/551279 https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=browser_tests%20(with%20patch)&tests=DirectoryTreeContextMenu%2FFileManagerBrowserTest.Test Think the disable in #3 was done based on the data in the OP? Seems that data is out-of-date.
,
Apr 17 2018
,
Apr 17 2018
,
Apr 18 2018
Per #4, this crashing test fixed by http://crrev.com/551279. Reading patch #3 no reference to in that test, this is a stroke of luck. DirectoryTreeContextMenu/FileManagerBrowserTest.Test/10 Thus, DirectoryTreeContextMenu/FileManagerBrowserTest.Test/10 is active and just looking at the flakiness dash board, there have been no CHECK external_backend->CanHandleType(foo bar) failures in the last 24 hours. Other bots: mus_browser_tests (with patch) also looking good, no CanHandleType crashes evident anymore on the flakiness dashboard in recent runs. What is evident: right now https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyQgsSBUZsYWtlIjdEaXJlY3RvcnlUcmVlQ29udGV4dE1lbnUvRmlsZU1hbmFnZXJCcm93c2VyVGVzdC5UZXN0LzEwDA. is reporting 3 recent CanHandleType crashes for this test. Looking at the logs, they do not have the fix from http://crrev.com/551279 yet. Summary: we can chill here as the fix finds its way into our bots/systems. No more action needed on this bug for now.
,
Apr 18 2018
,
Apr 18 2018
9 hours later, still no evidence of CanHandleType crashes, looks to be fixed.
,
Apr 18 2018
Re-enabled DirectoryTreeContextMenu/FileManagerBrowserTest.Test/10 in https://crrev.com/551659
,
Apr 18 2018
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by chromium...@appspot.gserviceaccount.com
, Apr 16 2018