New issue
Advanced search Search tips

Issue 832783 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Make session restore track ends of sessions of activity, not starts

Project Member Reported by chrisha@chromium.org, Apr 13 2018

Issue description

Session restore logic is making use of LastActiveTime, which is almost what is desired but subtly wrong. This track the beginning of the last period of visibility, but we actually want to be tracking the end. Other clients use this so a new metric needs to be introduced.
 
Components: UI>Browser>Sessions
Labels: Hotlist-TooManyTabs
Like with discarding/freezing logic, we also want session restore to only track elapsed time while Chrome is in use, rather than absolute time. This allows for session restore logic to make smarter decisions.
Status: Assigned (was: Started)
It might also make sense to only advance time on a per-profile basis, so that a profile that sits in the background rarely used doesn't advance time at the same right as another profile that is actively used.
If a profile has an opened window, I think it makes sense to advance time in it while any chrome window is in-use (other profile or not). Otherwise we'll reclaim tabs from the active profile before the inactive one...

What I was saying offline is that if a profile is not loaded (or has zero windows I guess because Chrome never unloads profiles during a session). Then when it's opened weeks later, it shouldn't forgo loading its tabs solely because the rest of chrome has been in-use.

Sign in to add a comment