New issue
Advanced search Search tips

Issue 832771 link

Starred by 1 user
Status: WontFix
Owner: ----
Closed: May 2018
Cc:
beccahughes@chromium.org
chcunningham@chromium.org
mlamouri@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression

Blocking:
issue 833461


Participants' hotlists:
Modern-Media-Controls


Sign in to add a comment

10.3%-12.5% regression in media.mobile at 550166:550294

Project Member Reported by chcunningham@chromium.org, Apr 13 2018 
See the link to graphs below.
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, Apr 13 2018 

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=832771

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=62a3387664a9b6571284aba9396cd26d2f3e748807091f7e9b5a6f5a3d38c5dc


Bot(s) for this bug's original alert(s):

android-nexus6

Comment 3 by chcunningham@chromium.org, Apr 13 2018 

Ref graph flat - but only 2 data points ¯\_(ツ)_/¯
Project Member

Comment 4 by 42576172...@developer.gserviceaccount.com, Apr 13 2018

Cc: beccahughes@chromium.org mlamouri@chromium.org
Owner: beccahughes@chromium.org
Status: Assigned (was: Untriaged)
📍 Found a significant difference after 1 commit.
https://pinpoint-dot-chromeperf.appspot.com/job/1404e382c40000

Media Controls: Hide/show panel based on new curves by beccahughes@chromium.org
https://chromium.googlesource.com/chromium/src/+/2cb8f3a0e9bf4d998a6cab2acc930f115b035d05

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions

Comment 5 by beccahughes@chromium.org, Apr 16 2018

Blocking: 833461
Project Member

Comment 8 by 42576172...@developer.gserviceaccount.com, Apr 20 2018 

📍 Job complete. See results below.
https://pinpoint-dot-chromeperf.appspot.com/job/14ca90dec40000
Project Member

Comment 9 by 42576172...@developer.gserviceaccount.com, Apr 20 2018 

📍 Job complete. See results below.
https://pinpoint-dot-chromeperf.appspot.com/job/1615805ec40000
Project Member

Comment 10 by bugdroid1@chromium.org, Apr 23 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a5af34fb92573caea6a3d00d45069517711d81b9

commit a5af34fb92573caea6a3d00d45069517711d81b9
Author: Becca Hughes <beccahughes@chromium.org>
Date: Mon Apr 23 18:47:41 2018

Media Controls: Create panel listener on demand

Create the 'transitionend' event listener on the panel on demand instead
of leaving it around when we do not need it.

BUG= 832771 

Change-Id: If722535b63052a0fc6383a7b1fbcc158a8fb284c
Reviewed-on: https://chromium-review.googlesource.com/1022317
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552769}
[modify] https://crrev.com/a5af34fb92573caea6a3d00d45069517711d81b9/third_party/blink/renderer/modules/media_controls/elements/media_control_panel_element.cc
[modify] https://crrev.com/a5af34fb92573caea6a3d00d45069517711d81b9/third_party/blink/renderer/modules/media_controls/elements/media_control_panel_element.h
[modify] https://crrev.com/a5af34fb92573caea6a3d00d45069517711d81b9/third_party/blink/renderer/modules/media_controls/elements/media_control_panel_element_test.cc

Comment 11 by beccahughes@chromium.org, May 2 2018

Owner: ----

Comment 12 by beccahughes@chromium.org, May 9 2018

Status: WontFix (was: Assigned)
This CL is adding animations so we expect this CL to have a negative performance impact.
►

Sign in to add a comment