New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 832768 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Use "production_tryjob" for all production tryjobs, reguardless of the branch being built.

Project Member Reported by dgarr...@chromium.org, Apr 13 2018

Issue description

Currently we set the "production_tryjob" display label for all --production tryjobs, IF we can't find the real display label to use.

However, Legoland currently ignores builds without a master build id in a display label that uses a master builder. That means these tryjobs never appear in the UI.

Further, it seems more confusing to users to have to look in different places depending on the branch specified.

So... cros tryjob should always use "production_tryjob" display label if --production is set.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 26 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/2b380e1e9710cbeb7cc97079434c121a69b9ada5

commit 2b380e1e9710cbeb7cc97079434c121a69b9ada5
Author: Don Garrett <dgarrett@google.com>
Date: Thu Apr 26 03:16:52 2018

cros tryjob: Always use PRODUCTION_TRYJOB display label.

Using arbitrary labels for PRODUCTION_TRYJOB builds has turned out be
confusing. Always use the production tryjob display label, so they
always appear in the same place in the UI.

Also rename the constant (but NOT it's value) to better match the
usage.

BUG= chromium:832768 
TEST=run_tests

Change-Id: I699dedee516f24bc66336f25aaedcb4c19c2040a
Reviewed-on: https://chromium-review.googlesource.com/1027002
Commit-Ready: Don Garrett <dgarrett@chromium.org>
Tested-by: Don Garrett <dgarrett@chromium.org>
Reviewed-by: Jason Clinton <jclinton@chromium.org>

[modify] https://crrev.com/2b380e1e9710cbeb7cc97079434c121a69b9ada5/cli/cros/cros_tryjob_unittest.py
[modify] https://crrev.com/2b380e1e9710cbeb7cc97079434c121a69b9ada5/lib/config_lib.py
[modify] https://crrev.com/2b380e1e9710cbeb7cc97079434c121a69b9ada5/cli/cros/cros_tryjob.py

Project Member

Comment 2 by bugdroid1@chromium.org, Apr 26 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/344eacf147bf39d4754fadc5b39408840f28fdcb

commit 344eacf147bf39d4754fadc5b39408840f28fdcb
Author: chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Thu Apr 26 08:06:09 2018

Roll src/third_party/chromite/ 48a13aacf..aa6cca469 (9 commits)

https://chromium.googlesource.com/chromiumos/chromite.git/+log/48a13aacf880..aa6cca46950b

$ git log 48a13aacf..aa6cca469 --date=short --no-merges --format='%ad %ae %s'
2018-04-19 lepton cros_vm: Use a smaller virtual network.
2018-04-24 laszio afdo: refining codes
2018-04-10 dgarrett chromeos_config: TRYBOT -> SWARMING.
2018-04-24 rockot Include libmojo_core.so in Chrome deployment
2018-04-19 pberny chromeos_config: Add sign_types to meowth release
2018-04-20 achuith cros_run_vm_test: Support for fetching results.
2018-04-17 bmgordon cbuildbot: Add --previous-build-state option
2018-04-13 bmgordon build_summary: Helper class to represent build summaries
2018-04-24 dgarrett cros tryjob: Always use PRODUCTION_TRYJOB display label.

Created with:
  roll-dep src/third_party/chromite
BUG=chromium:808045,chromium:829170,chromium:None,chromium:822034,chromium:835061,chromium:829665,chromium:829665,chromium:832768


The AutoRoll server is located here: https://chromite-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: I7d1aa5c4c4bd153fd47f6d7cc7532ac35cdff73b
Reviewed-on: https://chromium-review.googlesource.com/1029771
Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#553948}
[modify] https://crrev.com/344eacf147bf39d4754fadc5b39408840f28fdcb/DEPS

Status: Fixed (was: Started)

Sign in to add a comment