Dry-run didn't start |
||||
Issue descriptionWhat steps will reproduce the problem? 1. Hit 'CQ dry run' button 2. 3. What is the expected output? I expected to see try jobs kicked off, and a +1 from me in the CL. What do you see instead? No try jobs were kicked off (so no status email was sent), and my +1 isn't registered, however the CL does list that a dry run was requested. I wonder if changing the CL description so soon after contributed, but Gerrit was also responding very slowly at the time, so maybe a time-out? See https://chromium-review.googlesource.com/c/chromium/src/+/1010263
,
Apr 13 2018
,
Jun 4 2018
,
Jun 4 2018
CQ has certainly noticed your dry run request on PS#2: https://chromium-review.googlesource.com/c/chromium/src/+/1010263#message-2c1e463260b5aeebba0726c17272656cb20c661f Then you've edited the description, which resulted in your CQ+1 vote getting dropped, so CQ system stopped after that. agable@ haven't you tried to configure Gerrit to preserve CQ vote on description edits?
,
Nov 30
I can still reproduce this issue. There was an attempted fix by setting copyAllScoresIfNoCodeChange in chromium/src: https://chromium.googlesource.com/chromium/src/+blame/refs/meta/config/project.config#14 Here's the documentation of the flag: https://gerrit-review.googlesource.com/Documentation/config-labels.html#label_copyAllScoresIfNoCodeChange I see that it mentions copying only in the context of "new patch set is uploaded", which isn't the case with editing the description in Gerrit. I think it would make sense to apply this flag at the same time though. I'll file a feature request with Gerrit for that.
,
Nov 30
Filed https://crbug.com/gerrit/10114, possibly should have just moved this bug but I suppose that will depend on the resolution. |
||||
►
Sign in to add a comment |
||||
Comment 1 by kaspern@google.com
, Apr 13 2018