New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 832733 link

Starred by 2 users
Status: Started
Owner:
no...@chromium.org
Cc:
jchin...@chromium.org
hinoka@chromium.org
█ jinjingl@chromium.org
no...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Feature

Blocked on: View detail
issue 875056
issue 917851
issue 747322
issue 843453
issue 843712
issue 843714
issue 846935
Blocking:
issue 613423



Sign in to add a comment

Deploy API v2

Project Member Reported by no...@chromium.org, Apr 13 2018 
Metabug for all the work to deploy Buildbucket API v2, so that other bugs can block on this one.
Read more: go/buildbucket-api-v2

it should be done in Q2 2018

Comment 1 by no...@chromium.org, Apr 13 2018

Blocking: 613423

Comment 2 by no...@chromium.org, Apr 30 2018

Cc: no...@chromium.org hinoka@chromium.org
 Issue 776300  has been merged into this issue.

Comment 3 by no...@chromium.org, May 8 2018

Blockedon: 840853

Comment 4 by no...@chromium.org, May 8 2018

Blockedon: -840853

Comment 5 by no...@chromium.org, May 9 2018

Status: Started (was: Assigned)

Comment 6 by no...@chromium.org, May 9 2018

Cc: jchin...@chromium.org
The initial version will be implemented in Python on top of the existing code without internal refactoring. Implementation will remain ugly until we rewrite swarmbucket in Go.

Comment 7 by no...@chromium.org, May 10 2018

Cc: jinjingl@chromium.org
jinjingl, in which order would you prefer new features to be deployed? I assume you cannot use GetBuild/SearchBuilds RPCs without real-time steps.
Project Member

Comment 8 by bugdroid1@chromium.org, May 10 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-py.git/+/55ea4528c19b8c2d20542ea33ecb7cadf8fab575

commit 55ea4528c19b8c2d20542ea33ecb7cadf8fab575
Author: Nodir Turakulov <nodir@google.com>
Date: Thu May 10 18:27:58 2018

Rename multiline_proto -> protoutil

Generalize multiline_proto package to protoutil with a goal of adding more
general purpose, protocol buffer utility functions.

Bug: 832733
Change-Id: Id2ac58377a762d67a5d2dd2fe1c9a464e101ab5a
Reviewed-on: https://chromium-review.googlesource.com/1054189
Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
Commit-Queue: Nodir Turakulov <nodir@chromium.org>

[modify] https://crrev.com/55ea4528c19b8c2d20542ea33ecb7cadf8fab575/appengine/components/components/config/common.py
[delete] https://crrev.com/55d52634d23e0bbfcd53fb42d5653a70cf094cec/appengine/components/components/multiline_proto/__init__.py
[rename] https://crrev.com/55ea4528c19b8c2d20542ea33ecb7cadf8fab575/appengine/components/components/protoutil/Makefile
[add] https://crrev.com/55ea4528c19b8c2d20542ea33ecb7cadf8fab575/appengine/components/components/protoutil/__init__.py
[rename] https://crrev.com/55ea4528c19b8c2d20542ea33ecb7cadf8fab575/appengine/components/components/protoutil/multiline_proto.py
[rename] https://crrev.com/55ea4528c19b8c2d20542ea33ecb7cadf8fab575/appengine/components/components/protoutil/multiline_proto_test.py
[rename] https://crrev.com/55ea4528c19b8c2d20542ea33ecb7cadf8fab575/appengine/components/components/protoutil/test_proto.proto
[rename] https://crrev.com/55ea4528c19b8c2d20542ea33ecb7cadf8fab575/appengine/components/components/protoutil/test_proto_pb2.py
[rename] https://crrev.com/55ea4528c19b8c2d20542ea33ecb7cadf8fab575/appengine/components/components/protoutil/test_support

Comment 10 by jinjingl@google.com, May 10 2018 

GetBuild & searcBuild would be the first ones needed. Thanks Nodir!
Project Member

Comment 11 by bugdroid1@chromium.org, May 14 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/c8f7479ef6a64c648ed882b6d622c7fba85b8975

commit c8f7479ef6a64c648ed882b6d622c7fba85b8975
Author: Nodir Turakulov <nodir@google.com>
Date: Mon May 14 19:14:02 2018

[buildbucket][v2] Implement GetBuild RPC.

Also update v2/builds.py to try to read a build number from build_address tag.

Bug: 832733
Change-Id: I69f53557ee12f160f565593b9ab9ae2f0b34395a
Reviewed-on: https://chromium-review.googlesource.com/1052922
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>

[modify] https://crrev.com/c8f7479ef6a64c648ed882b6d622c7fba85b8975/appengine/cr-buildbucket/swarming/swarming.py
[modify] https://crrev.com/c8f7479ef6a64c648ed882b6d622c7fba85b8975/appengine/cr-buildbucket/handlers.py
[modify] https://crrev.com/c8f7479ef6a64c648ed882b6d622c7fba85b8975/appengine/cr-buildbucket/access/api.py
[modify] https://crrev.com/c8f7479ef6a64c648ed882b6d622c7fba85b8975/appengine/cr-buildbucket/v2/__init__.py
[modify] https://crrev.com/c8f7479ef6a64c648ed882b6d622c7fba85b8975/appengine/cr-buildbucket/v2/builds.py
[add] https://crrev.com/c8f7479ef6a64c648ed882b6d622c7fba85b8975/appengine/cr-buildbucket/v2/api.py
[add] https://crrev.com/c8f7479ef6a64c648ed882b6d622c7fba85b8975/appengine/cr-buildbucket/v2/test/api_test.py
[modify] https://crrev.com/c8f7479ef6a64c648ed882b6d622c7fba85b8975/appengine/cr-buildbucket/service.py
[modify] https://crrev.com/c8f7479ef6a64c648ed882b6d622c7fba85b8975/appengine/cr-buildbucket/v2/test/builds_test.py
[modify] https://crrev.com/c8f7479ef6a64c648ed882b6d622c7fba85b8975/appengine/cr-buildbucket/swarming/test/swarming_test.py
[modify] https://crrev.com/c8f7479ef6a64c648ed882b6d622c7fba85b8975/appengine/cr-buildbucket/proto/Makefile
[add] https://crrev.com/c8f7479ef6a64c648ed882b6d622c7fba85b8975/appengine/cr-buildbucket/proto/rpc.proto
[add] https://crrev.com/c8f7479ef6a64c648ed882b6d622c7fba85b8975/appengine/cr-buildbucket/proto/rpc_pb2.py
[add] https://crrev.com/c8f7479ef6a64c648ed882b6d622c7fba85b8975/appengine/cr-buildbucket/proto/rpc_prpc_pb2.py

Comment 13 by no...@chromium.org, May 16 2018

Blockedon: 843453

Comment 14 by no...@chromium.org, May 16 2018

Blockedon: 843712

Comment 15 by no...@chromium.org, May 16 2018

Blockedon: 843714

Comment 16 by no...@chromium.org, May 16 2018

Labels: buildbucket-v2
Project Member

Comment 17 by bugdroid1@chromium.org, May 20 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/477a73dc0331c60acbabb7121e24369edf5a7e69

commit 477a73dc0331c60acbabb7121e24369edf5a7e69
Author: Nodir Turakulov <nodir@google.com>
Date: Sun May 20 19:33:56 2018

[buildbucket][v2] Add support for steps

This CL loads steps from BuildAnnotation entities.
They are currently updated only on build completion.
Later we add kitchen->buildbucket channel to update them as build runs.

Bug: 832733
Change-Id: Iacf41a13a2acdabaa46714a290fc171366e3faf0
Reviewed-on: https://chromium-review.googlesource.com/1054617
Reviewed-by: Jao-ke Chin-Lee <jchinlee@chromium.org>
Commit-Queue: Nodir Turakulov <nodir@chromium.org>

[modify] https://crrev.com/477a73dc0331c60acbabb7121e24369edf5a7e69/appengine/cr-buildbucket/v2/api.py
[modify] https://crrev.com/477a73dc0331c60acbabb7121e24369edf5a7e69/appengine/cr-buildbucket/v2/test/api_test.py
Project Member

Comment 18 by bugdroid1@chromium.org, May 22 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-py.git/+/b257accda5e53799fc157cbaea3a7f138749c6a1

commit b257accda5e53799fc157cbaea3a7f138749c6a1
Author: Nodir Turakulov <nodir@google.com>
Date: Tue May 22 17:49:58 2018

[protoutil] Add field path parsing

fieldmasks._parse_path parses a field path ("a.b.c") into tuple ("a", "b", "c").
It also supports advanced syntax, e.g. "a.`b.c`" is parsed as ("a", "b.c").

Bug: 832733
Change-Id: I9288ba93aaf51603bd27361a91de3e15110f768d
Reviewed-on: https://chromium-review.googlesource.com/1067028
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>

[add] https://crrev.com/b257accda5e53799fc157cbaea3a7f138749c6a1/appengine/components/components/protoutil/field_masks.py
[add] https://crrev.com/b257accda5e53799fc157cbaea3a7f138749c6a1/appengine/components/components/protoutil/field_masks_test.py
[modify] https://crrev.com/b257accda5e53799fc157cbaea3a7f138749c6a1/appengine/components/components/protoutil/test_proto.proto
[modify] https://crrev.com/b257accda5e53799fc157cbaea3a7f138749c6a1/appengine/components/components/protoutil/test_proto_pb2.py
Project Member

Comment 19 by bugdroid1@chromium.org, May 22 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-py.git/+/086d193c094327803e0e484919f7135bd0e4d28d

commit 086d193c094327803e0e484919f7135bd0e4d28d
Author: Nodir Turakulov <nodir@google.com>
Date: Tue May 22 18:34:38 2018

[protoutil] Add field tree parsing

Parse a proto FieldMask as a tree of fields, e.g.
['a', 'b.c'] -> {'a': {}, 'b': {'c': {}}}

Bug: 832733
Change-Id: I5be342d45cccb4b2aab9ff1bffb2f368f316ae60
Reviewed-on: https://chromium-review.googlesource.com/1066083
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>

[modify] https://crrev.com/086d193c094327803e0e484919f7135bd0e4d28d/appengine/components/components/protoutil/__init__.py
[modify] https://crrev.com/086d193c094327803e0e484919f7135bd0e4d28d/appengine/components/components/protoutil/field_masks.py
[modify] https://crrev.com/086d193c094327803e0e484919f7135bd0e4d28d/appengine/components/components/protoutil/field_masks_test.py
Project Member

Comment 20 by bugdroid1@chromium.org, May 22 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-py.git/+/13ab611cdd94d173e78ca464ead40ea51374b75c

commit 13ab611cdd94d173e78ca464ead40ea51374b75c
Author: Nodir Turakulov <nodir@google.com>
Date: Tue May 22 19:04:18 2018

[protoutil] Make _STAR_SEG public

parse_field_tree is public, but it may return an internal object _STAR_SEG.
Make _STAR_SEG public.

Bug: 832733
Change-Id: Id2cc0e6f0758bc97eb995356eec0e241fa83abf5
Reviewed-on: https://chromium-review.googlesource.com/1067955
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>

[modify] https://crrev.com/13ab611cdd94d173e78ca464ead40ea51374b75c/appengine/components/components/protoutil/__init__.py
[modify] https://crrev.com/13ab611cdd94d173e78ca464ead40ea51374b75c/appengine/components/components/protoutil/field_masks.py
[modify] https://crrev.com/13ab611cdd94d173e78ca464ead40ea51374b75c/appengine/components/components/protoutil/field_masks_test.py
Project Member

Comment 21 by bugdroid1@chromium.org, May 23 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-py.git/+/95215b9daee94d1f0aebc9fccae74b566a130eec

commit 95215b9daee94d1f0aebc9fccae74b566a130eec
Author: Nodir Turakulov <nodir@google.com>
Date: Wed May 23 21:20:05 2018

[protoutil] Rename parse_field_tree

Rename parse_field_tree to parse_segment_tree because it is more accurate.

Bug: 832733

Change-Id: Ibf21c49f7037c184a2a911254b72f43ec18f44e1
Reviewed-on: https://chromium-review.googlesource.com/1069806
Reviewed-by: smut <smut@google.com>
Commit-Queue: Nodir Turakulov <nodir@chromium.org>

[modify] https://crrev.com/95215b9daee94d1f0aebc9fccae74b566a130eec/appengine/components/components/protoutil/field_masks.py
[modify] https://crrev.com/95215b9daee94d1f0aebc9fccae74b566a130eec/appengine/components/components/protoutil/field_masks_test.py
Project Member

Comment 22 by bugdroid1@chromium.org, May 23 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-py.git/+/f9ae69a37c4bdd0e08a8b0f7e123f6e403e774eb

commit f9ae69a37c4bdd0e08a8b0f7e123f6e403e774eb
Author: Nodir Turakulov <nodir@google.com>
Date: Wed May 23 21:44:35 2018

[protoutil] Add field-mask-based msg trimming

Add trim_message(msg, field_mask) function. Useful for partial responses.
Supports advanced field mask semantics.
Will be used in Buildbucket API v2.

Bug: 832733
Change-Id: Ie07a00cfa28d5f09313f5d771efa30c4c911abaf
Reviewed-on: https://chromium-review.googlesource.com/1054218
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: smut <smut@google.com>

[modify] https://crrev.com/f9ae69a37c4bdd0e08a8b0f7e123f6e403e774eb/appengine/components/components/protoutil/field_masks.py
[modify] https://crrev.com/f9ae69a37c4bdd0e08a8b0f7e123f6e403e774eb/appengine/components/components/protoutil/field_masks_test.py
Project Member

Comment 23 by bugdroid1@chromium.org, May 23 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-go.git/+/dbea23e9694a96fd56425c8217f3475dd904144e

commit dbea23e9694a96fd56425c8217f3475dd904144e
Author: Nodir Turakulov <nodir@google.com>
Date: Wed May 23 22:17:48 2018

[buildbucket] Rename GetBuildRequest.build_fields

"fields" is a more standard name for a FieldMask field.

TBR=vadimsh@chromium.org
Bug: 832733
Change-Id: I034d3ab41597f4d0e8781f6c67eea43ca91a1fe1
Reviewed-on: https://chromium-review.googlesource.com/1070855
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Nodir Turakulov <nodir@chromium.org>

[modify] https://crrev.com/dbea23e9694a96fd56425c8217f3475dd904144e/buildbucket/proto/pb.discovery.go
[modify] https://crrev.com/dbea23e9694a96fd56425c8217f3475dd904144e/buildbucket/proto/rpc.pb.go
[modify] https://crrev.com/dbea23e9694a96fd56425c8217f3475dd904144e/buildbucket/proto/rpc.proto
Project Member

Comment 26 by bugdroid1@chromium.org, May 24 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-py.git/+/9ed10cfbc7deccf4c4398dd76526332dc09f1a83

commit 9ed10cfbc7deccf4c4398dd76526332dc09f1a83
Author: Nodir Turakulov <nodir@google.com>
Date: Thu May 24 21:56:21 2018

[protoutil] Rename Mask.include to includes

It is slightly more accurate.

R=smut@google.com

Bug: 832733
Change-Id: I203c6340f0ec056df22d223f31d24da813a05dcb
Reviewed-on: https://chromium-review.googlesource.com/1072688
Reviewed-by: smut <smut@google.com>
Commit-Queue: smut <smut@google.com>

[modify] https://crrev.com/9ed10cfbc7deccf4c4398dd76526332dc09f1a83/appengine/components/components/protoutil/field_masks.py
[modify] https://crrev.com/9ed10cfbc7deccf4c4398dd76526332dc09f1a83/appengine/components/components/protoutil/field_masks_test.py
Project Member

Comment 27 by bugdroid1@chromium.org, May 24 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/7c3eee03d0d1f29bc77878bc9107587c92b88b39

commit 7c3eee03d0d1f29bc77878bc9107587c92b88b39
Author: Nodir Turakulov <nodir@google.com>
Date: Thu May 24 22:23:34 2018

Roll infra/luci/ 4e29bf088..9ed10cfbc (2 commits)

https://chromium.googlesource.com/infra/luci/luci-py//+log/4e29bf0883fc..9ed10cfbc7de

$ git log 4e29bf088..9ed10cfbc --date=short --no-merges --format='%ad %ae %s'
2018-05-24 nodir [protoutil] Rename Mask.include to includes
2018-05-24 nodir [protoutil] Improve error message

Created with:
  roll-dep infra/luci

TBR=smut@google.com

Bug: 832733
Change-Id: I01756e8a6064268f28239b7a805d9b70829ce781
Reviewed-on: https://chromium-review.googlesource.com/1072734
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: smut <smut@google.com>
Commit-Queue: Nodir Turakulov <nodir@chromium.org>

[modify] https://crrev.com/7c3eee03d0d1f29bc77878bc9107587c92b88b39/DEPS
Project Member

Comment 28 by bugdroid1@chromium.org, May 24 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/0574f6dbcc2f4bd2ad60c6ea3193199534a15f54

commit 0574f6dbcc2f4bd2ad60c6ea3193199534a15f54
Author: Nodir Turakulov <nodir@google.com>
Date: Thu May 24 23:27:24 2018

[buildbucket][v2] Trim responses

Extend api_method decorator to parse and apply field mask.
Also pass it to the method implementation so it can decide which parts
of the response to compute.

Bug: 832733
Change-Id: I2cbbad5ea1c44320c41b77c2d9719a65fcbd5120
Reviewed-on: https://chromium-review.googlesource.com/1054338
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>

[modify] https://crrev.com/0574f6dbcc2f4bd2ad60c6ea3193199534a15f54/appengine/cr-buildbucket/v2/api.py
[modify] https://crrev.com/0574f6dbcc2f4bd2ad60c6ea3193199534a15f54/appengine/cr-buildbucket/v2/test/api_test.py

Comment 29 by no...@chromium.org, May 25 2018

Blockedon: 846935
Project Member

Comment 30 by bugdroid1@chromium.org, May 25 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/aa298b8fc65648d570a2f5b44424bd043baedfd9

commit aa298b8fc65648d570a2f5b44424bd043baedfd9
Author: Nodir Turakulov <nodir@google.com>
Date: Fri May 25 23:22:16 2018

[buildbucket][v2] add proto validation module

add v2/validation.py responsible for validation of v2 proto messages.
Validate GetBuildRequest and SearchBuildRequest messages.

Recompile protobufs to bring messages used for SearchBuilds RPC.

Bug: 832733
Change-Id: Icccade7bcab5fd8d9a053578a81345295dfe7456
Reviewed-on: https://chromium-review.googlesource.com/1073610
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>

[add] https://crrev.com/aa298b8fc65648d570a2f5b44424bd043baedfd9/appengine/cr-buildbucket/v2/test/validation_test.py
[modify] https://crrev.com/aa298b8fc65648d570a2f5b44424bd043baedfd9/appengine/cr-buildbucket/proto/common_pb2.py
[modify] https://crrev.com/aa298b8fc65648d570a2f5b44424bd043baedfd9/appengine/cr-buildbucket/v2/api.py
[modify] https://crrev.com/aa298b8fc65648d570a2f5b44424bd043baedfd9/appengine/cr-buildbucket/buildtags.py
[add] https://crrev.com/aa298b8fc65648d570a2f5b44424bd043baedfd9/appengine/cr-buildbucket/v2/validation.py
[modify] https://crrev.com/aa298b8fc65648d570a2f5b44424bd043baedfd9/appengine/cr-buildbucket/proto/rpc_pb2.py
[modify] https://crrev.com/aa298b8fc65648d570a2f5b44424bd043baedfd9/appengine/cr-buildbucket/proto/rpc_prpc_pb2.py
Project Member

Comment 31 by bugdroid1@chromium.org, Jun 1 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/668a8061d681ce71848aa2c711619b506c371cbf

commit 668a8061d681ce71848aa2c711619b506c371cbf
Author: Nodir Turakulov <nodir@google.com>
Date: Fri Jun 01 18:09:08 2018

Roll infra/luci/ bef6befbb..808904503 (2 commits)

Roll luci-py and recompile all prpc files.
prpc python generator changed:
https://chromium-review.googlesource.com/c/infra/luci/luci-py/+/1080281

https://chromium.googlesource.com/infra/luci/luci-py//+log/bef6befbbb90..808904503e14

$ git log bef6befbb..808904503 --date=short --no-merges --format='%ad %ae %s'
2018-05-31 nodir [config] Fix unicode conversion
2018-05-31 nodir [prpc] Include source code info in _prpc_pb2.py

Bug: 832733
Change-Id: If1f2aa3656bbcbdd2ea1c48b99c7038bcff6b51f
Reviewed-on: https://chromium-review.googlesource.com/1082002
Reviewed-by: Jeff Carpenter <jeffcarp@chromium.org>
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Commit-Queue: Nodir Turakulov <nodir@chromium.org>

[modify] https://crrev.com/668a8061d681ce71848aa2c711619b506c371cbf/appengine/cr-buildbucket/access/access_prpc_pb2.py
[modify] https://crrev.com/668a8061d681ce71848aa2c711619b506c371cbf/appengine/monorail/api/api_proto/projects_prpc_pb2.py
[modify] https://crrev.com/668a8061d681ce71848aa2c711619b506c371cbf/appengine/cr-buildbucket/v2/api.py
[modify] https://crrev.com/668a8061d681ce71848aa2c711619b506c371cbf/appengine/monorail/api/api_proto/issues_prpc_pb2.py
[modify] https://crrev.com/668a8061d681ce71848aa2c711619b506c371cbf/DEPS
[modify] https://crrev.com/668a8061d681ce71848aa2c711619b506c371cbf/appengine/monorail/api/api_proto/users_prpc_pb2.py
[modify] https://crrev.com/668a8061d681ce71848aa2c711619b506c371cbf/appengine/cr-buildbucket/proto/rpc_prpc_pb2.py
Project Member

Comment 32 by bugdroid1@chromium.org, Jun 1 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/6d52a39838ee655e32f6f50d630baa0e7628f9d2

commit 6d52a39838ee655e32f6f50d630baa0e7628f9d2
Author: Nodir Turakulov <nodir@google.com>
Date: Fri Jun 01 18:19:18 2018

[buildbucket][v2] Add RPC Explorer.

This just symlinks luci-go's vulcanized rpcexplorer into a subdir in
cr-buildbucket/ and included in the default service. This does not make
deployment much longer.

Bug: 832733
Change-Id: I9a565255ffc40bc9e5511e085a7b57a6611dcfe1
Reviewed-on: https://chromium-review.googlesource.com/1074207
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>

[add] https://crrev.com/6d52a39838ee655e32f6f50d630baa0e7628f9d2/appengine/cr-buildbucket/rpcexplorer
[modify] https://crrev.com/6d52a39838ee655e32f6f50d630baa0e7628f9d2/appengine/cr-buildbucket/app.yaml
[modify] https://crrev.com/6d52a39838ee655e32f6f50d630baa0e7628f9d2/appengine/cr-buildbucket/module-backend.yaml
Project Member

Comment 33 by bugdroid1@chromium.org, Jun 13 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-go.git/+/f0ba05a5c9381896718b0b99e1d3bfeda262201d

commit f0ba05a5c9381896718b0b99e1d3bfeda262201d
Author: Nodir Turakulov <nodir@google.com>
Date: Wed Jun 13 22:32:59 2018

[buildbucket][v2] Document Buildbot support

Actually, GetBuild and SearchBuilds v2 APIs do support Buildbot builds, to some extent.
Document it. This means CQ, git-cl-try and others can start the transition.

Bug: 832733
Change-Id: I3985fd888fd2b5a7e46acae7eaae476cfc6b0057
Reviewed-on: https://chromium-review.googlesource.com/1099258
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>

[modify] https://crrev.com/f0ba05a5c9381896718b0b99e1d3bfeda262201d/buildbucket/proto/pb.discovery.go
[modify] https://crrev.com/f0ba05a5c9381896718b0b99e1d3bfeda262201d/buildbucket/proto/rpc.pb.go
[modify] https://crrev.com/f0ba05a5c9381896718b0b99e1d3bfeda262201d/buildbucket/proto/rpc.proto

Comment 34 by no...@chromium.org, Jun 16 2018

Blockedon: 747322

Comment 35 by no...@chromium.org, Aug 16

Blockedon: 875056

Comment 37 by no...@chromium.org, Dec 26

Blockedon: 917851
►

Sign in to add a comment