WebAudio ConeEffect class is in the file cone.{h,cc} |
|||
Issue descriptionThe class ConeEffect that implements the cone effects for the panner node is in the file cone.h and cone.cc. It would be nice if it were in cone_effect.* instead because when I need to look for ConeEffect, I always look for cone_effect.* and can't find it, obviously.
,
Apr 16 2018
,
Apr 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bf6c8d4e1e7ea2bb938527cf0d7281ec0651d61f commit bf6c8d4e1e7ea2bb938527cf0d7281ec0651d61f Author: Raymond Toy <rtoy@chromium.org> Date: Mon Apr 16 17:15:28 2018 Rename file cone.* to cone_effect.* The class is named ConeEffect but the file was cone.h and cone.cc. Rename the files to cone_effect.h and cone_effect.cc Fix a blink style issue in cone_effects.cc too. Bug: 832708 Change-Id: I5acd880ba61cd1597c10e488aa318e939ac1c321 Reviewed-on: https://chromium-review.googlesource.com/1011455 Reviewed-by: Hongchan Choi <hongchan@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#551015} [modify] https://crrev.com/bf6c8d4e1e7ea2bb938527cf0d7281ec0651d61f/third_party/blink/renderer/modules/webaudio/panner_node.h [modify] https://crrev.com/bf6c8d4e1e7ea2bb938527cf0d7281ec0651d61f/third_party/blink/renderer/platform/BUILD.gn [rename] https://crrev.com/bf6c8d4e1e7ea2bb938527cf0d7281ec0651d61f/third_party/blink/renderer/platform/audio/cone_effect.cc [rename] https://crrev.com/bf6c8d4e1e7ea2bb938527cf0d7281ec0651d61f/third_party/blink/renderer/platform/audio/cone_effect.h |
|||
►
Sign in to add a comment |
|||
Comment 1 by bugdroid1@chromium.org
, Apr 16 2018