New issue
Advanced search Search tips

Issue 832696 link

Starred by 1 user
Status: WontFix
Owner:
pnoland@chromium.org
Closed: Apr 2018
Cc:
estevenson@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

24 kb regression in resource_sizes (MonochromePublic.apk) at 550267:550268

Project Member Reported by estevenson@chromium.org, Apr 13 2018 
Caused by “[EOC] Implement fetching of suggestions”

Commit: 393e49b63b87010c1867297e5c9a35de6a46342f

https://chromeperf.appspot.com/report?sid=e9a395446072c0ec9e8fb904774a84c07ad868b552721960a3e7097d7c009b7d&num_points=10&rev=550268

Debugging size regressions is documented at: https://chromium.googlesource.com/chromium/src/+/master/docs/speed/apk_size_regressions.md#Debugging-Apk-Size-Increase

Based on the graph: All native code growth.

It's not clear to me whether or not this increase was expected.
Please have a look and either:

1. Close as “Won't Fix” with a short justification, or
2. Land a revert / fix-up.
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, Apr 13 2018 

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=832696

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=f454f4c13607a0b62ffff89548baa23a6b9aef963e4a83c9f96f116f235a74d4


Bot(s) for this bug's original alert(s):

Android Builder Perf

Comment 3 by estevenson@chromium.org, Apr 13 2018

Labels: -Restrict-View-Google
See attached diff.
diff_results.txt
144 KB View Download

Comment 4 by pnoland@chromium.org, Apr 13 2018

Status: WontFix (was: Assigned)
I am pretty sure this is expected, since this change is using several new proto messages. They existed previously, but can no longer be proguarded out as they aren't dead code. Most of the size increase in the diff is from the generated proto files.
►

Sign in to add a comment