New issue
Advanced search Search tips

Issue 832695 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Apr 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Supersize paths show gn variables

Project Member Reported by estevenson@chromium.org, Apr 13 2018

Issue description

Just noticed this during size alert triage:

~ 0)       2104 (7.9%)  o@0x0        2104 (0->0)        {no path}
               Overhead: APK file
~ 1)       4096 (15.4%) o@0x0        1992 (1951244->1953236) MonochromePublic.apk/other/assets/unwind_cfi_32
               unwind_cfi_32
+ 2)       4956 (18.7%) t@0x270d944  860 (0->860)       components/ntp_snippets/contextual/contextual_suggestions_fetch.cc
               contextual_suggestions::ContextualSuggestionsFetch::OnURLLoaderComplete
~ 3)       4190 (15.8%) o@0x0        -766 (0->0)        {no path}
               Overhead: ELF file
+ 4)       4554 (17.2%) t@0x272205c  364 (0->364)       $root_gen_dir/components/ntp_snippets/contextual/proto/get_pivots_request.pb.cc
               contextual_suggestions::PivotDocumentParams::MergePartialFromCodedStream
+ 5)       4866 (18.3%) t@0x270dca0  312 (0->312)       components/ntp_snippets/contextual/contextual_suggestions_fetch.cc
               contextual_suggestions::ContextualSuggestionsFetch::MakeHeaders const
+ 6)       5146 (19.4%) t@0x2723fc0  280 (0->280)       $root_gen_dir/components/ntp_snippets/contextual/proto/get_pivots_response.pb.cc
               contextual_suggestions::AutoPeekConditions::MergePartialFromCodedStream
+ 7)       5416 (20.4%) t@0x2723764  270 (0->268)       $root_gen_dir/components/ntp_snippets/contextual/proto/get_pivots_response.pb.cc
               contextual_suggestions::PivotDocument::MergePartialFromCodedStream
+ 8)       5680 (21.4%) t@0x2722350  264 (0->264)       $root_gen_dir/components/ntp_snippets/contextual/proto/get_pivots_request.pb.cc
               contextual_suggestions::PivotClusteringParams::MergePartialFromCodedStream
+ 9)       5934 (22.3%) t@0x2721bf0  254 (0->252)       $root_gen_dir/components/ntp_snippets/contextual/proto/get_pivots_request.pb.cc
               contextual_suggestions::GetPivotsQuery::MergePartialFromCodedStream
+ 10)      6170 (23.2%) t@0x2723bfc  236 (0->236)       $root_gen_dir/components/ntp_snippets/contextual/proto/get_pivots_response.pb.cc
               contextual_suggestions::PivotCluster::MergePartialFromCodedStream

Pretty sure we used to omit this part of the path? Or was this changed on purpose?

 
Owner: estevenson@chromium.org
I added it last week:
https://chromium-review.googlesource.com/996909

Had two separate people say the were confused by diffs because they pointed to paths that didn't actually exist.

Sounds like maybe it's still confusing though :P. Other options I considere:

* $GENERATED/foo/bar/baz.cc
* foo/bar/baz.cc (generated)

Think either of these are better?
Status: WontFix (was: Untriaged)
Ahh I missed that one, just saw the change and didn't look into it yet :p. 

They're all fine with me so might as well leave it as-is!

Sign in to add a comment