New issue
Advanced search Search tips

Issue 832694 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug



Sign in to add a comment

When MachineLevelUserCloudPolicy failed to load the cache, Chrome won't fetch the policy from DM Server again.

Project Member Reported by zmin@chromium.org, Apr 13 2018

Issue description

1) Setup Enrollment token
2) Open Chrome to enroll
3) Close Chrome, remove policy cache. ($user_data_dir/policy/)
4) Open Chrome Chrome

Expected:
Chrome fetch policy from DMServer

Actuall:
Chrome does not fetch policy from DMServer
 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 13 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bcf5d8effb2a2a3c9e78ced4dfc1bfce53438399

commit bcf5d8effb2a2a3c9e78ced4dfc1bfce53438399
Author: Owen Min <zmin@chromium.org>
Date: Fri Apr 13 18:11:04 2018

Fix an issue when fetching policy without local cache of token policy.

Because the first policy cache will be loaded synchronously before local_state
creation. We'll miss its OnStoreLoaded/Error event as CloudPolicyService
has to be created after |local_state|. It means we won't know the result of
cache loading.

To resolve this, check the initialization status once the CloudPolicyService
has been created. Fetch policy from server if cache is not loaded properly.

Bug:  832694 
Change-Id: Idd0b9e35ea2afded586b73c765197b5574ba3900
Reviewed-on: https://chromium-review.googlesource.com/1011211
Commit-Queue: Owen Min <zmin@chromium.org>
Reviewed-by: Roger Tawa <rogerta@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550684}
[modify] https://crrev.com/bcf5d8effb2a2a3c9e78ced4dfc1bfce53438399/chrome/browser/policy/cloud/machine_level_user_cloud_policy_helper.cc
[modify] https://crrev.com/bcf5d8effb2a2a3c9e78ced4dfc1bfce53438399/chrome/browser/policy/cloud/machine_level_user_cloud_policy_helper.h

Comment 2 by zmin@chromium.org, Apr 13 2018

Cc: georgesak@chromium.org
Labels: Merge-Request-67
This fix an issue of fetching MachineLevelUserCloudPolicy during Chrome launch.
Project Member

Comment 3 by sheriffbot@chromium.org, Apr 14 2018

Labels: -Merge-Request-67 Merge-Approved-67 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M67. Please go ahead and merge the CL to branch 3396 manually. Please contact milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 15 2018

Labels: -merge-approved-67 merge-merged-3396
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4736c59b78559148101327c0b890a0502b5efa26

commit 4736c59b78559148101327c0b890a0502b5efa26
Author: Owen Min <zmin@chromium.org>
Date: Sun Apr 15 00:37:40 2018

Fix an issue when fetching policy without local cache of token policy.

Because the first policy cache will be loaded synchronously before local_state
creation. We'll miss its OnStoreLoaded/Error event as CloudPolicyService
has to be created after |local_state|. It means we won't know the result of
cache loading.

To resolve this, check the initialization status once the CloudPolicyService
has been created. Fetch policy from server if cache is not loaded properly.

Bug:  832694 
Change-Id: Idd0b9e35ea2afded586b73c765197b5574ba3900
Reviewed-on: https://chromium-review.googlesource.com/1011211
Commit-Queue: Owen Min <zmin@chromium.org>
Reviewed-by: Roger Tawa <rogerta@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#550684}(cherry picked from commit bcf5d8effb2a2a3c9e78ced4dfc1bfce53438399)
Reviewed-on: https://chromium-review.googlesource.com/1013342
Reviewed-by: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/branch-heads/3396@{#10}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}
[modify] https://crrev.com/4736c59b78559148101327c0b890a0502b5efa26/chrome/browser/policy/cloud/machine_level_user_cloud_policy_helper.cc
[modify] https://crrev.com/4736c59b78559148101327c0b890a0502b5efa26/chrome/browser/policy/cloud/machine_level_user_cloud_policy_helper.h

Project Member

Comment 5 by bugdroid1@chromium.org, Apr 17 2018

Labels: merge-merged-testbranch
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bcf5d8effb2a2a3c9e78ced4dfc1bfce53438399

commit bcf5d8effb2a2a3c9e78ced4dfc1bfce53438399
Author: Owen Min <zmin@chromium.org>
Date: Fri Apr 13 18:11:04 2018

Fix an issue when fetching policy without local cache of token policy.

Because the first policy cache will be loaded synchronously before local_state
creation. We'll miss its OnStoreLoaded/Error event as CloudPolicyService
has to be created after |local_state|. It means we won't know the result of
cache loading.

To resolve this, check the initialization status once the CloudPolicyService
has been created. Fetch policy from server if cache is not loaded properly.

Bug:  832694 
Change-Id: Idd0b9e35ea2afded586b73c765197b5574ba3900
Reviewed-on: https://chromium-review.googlesource.com/1011211
Commit-Queue: Owen Min <zmin@chromium.org>
Reviewed-by: Roger Tawa <rogerta@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550684}
[modify] https://crrev.com/bcf5d8effb2a2a3c9e78ced4dfc1bfce53438399/chrome/browser/policy/cloud/machine_level_user_cloud_policy_helper.cc
[modify] https://crrev.com/bcf5d8effb2a2a3c9e78ced4dfc1bfce53438399/chrome/browser/policy/cloud/machine_level_user_cloud_policy_helper.h

Comment 6 by zmin@chromium.org, May 11 2018

Status: Verified (was: Assigned)

Sign in to add a comment