New issue
Advanced search Search tips

Issue 832680 link

Starred by 2 users
Status: Fixed
Owner:
npm@chromium.org
Closed: Jul 4
Cc:
tdres...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Remove flag for forcing input non-blocking due to main thread responsiveness

Project Member Reported by tdres...@chromium.org, Apr 13 2018 
That's: enable_non_blocking_due_to_main_thread_responsiveness_flag_

https://cs.chromium.org/chromium/src/content/renderer/input/main_thread_event_queue.h?rcl=f7671756e8ff69e573ed2f86688343808c00f727&l=132

We've decided against this intervention.
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 29 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5d32e5baac25a09d120e0f5d8dd53d62265f8ae0

commit 5d32e5baac25a09d120e0f5d8dd53d62265f8ae0
Author: Nicolas Pena <npm@chromium.org>
Date: Sun Apr 29 01:26:58 2018

Remove MainThreadBusyScrollIntervention

Bug:  599609 ,  832680 
Change-Id: Ib8db17ca291203b6b676a6c74e16db20c14bf3d6
Reviewed-on: https://chromium-review.googlesource.com/1012934
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Reviewed-by: Rick Byers <rbyers@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554662}
[modify] https://crrev.com/5d32e5baac25a09d120e0f5d8dd53d62265f8ae0/content/browser/renderer_host/input/input_router_config_helper.cc
[modify] https://crrev.com/5d32e5baac25a09d120e0f5d8dd53d62265f8ae0/content/browser/renderer_host/input/render_widget_host_latency_tracker.cc
[modify] https://crrev.com/5d32e5baac25a09d120e0f5d8dd53d62265f8ae0/content/browser/renderer_host/input/render_widget_host_latency_tracker_unittest.cc
[modify] https://crrev.com/5d32e5baac25a09d120e0f5d8dd53d62265f8ae0/content/public/common/content_features.cc
[modify] https://crrev.com/5d32e5baac25a09d120e0f5d8dd53d62265f8ae0/content/public/common/content_features.h
[modify] https://crrev.com/5d32e5baac25a09d120e0f5d8dd53d62265f8ae0/content/renderer/input/main_thread_event_queue.cc
[modify] https://crrev.com/5d32e5baac25a09d120e0f5d8dd53d62265f8ae0/content/renderer/input/main_thread_event_queue.h
[modify] https://crrev.com/5d32e5baac25a09d120e0f5d8dd53d62265f8ae0/content/renderer/input/main_thread_event_queue_unittest.cc
[modify] https://crrev.com/5d32e5baac25a09d120e0f5d8dd53d62265f8ae0/content/renderer/input/render_widget_input_handler.cc
[modify] https://crrev.com/5d32e5baac25a09d120e0f5d8dd53d62265f8ae0/content/renderer/render_widget_unittest.cc
[modify] https://crrev.com/5d32e5baac25a09d120e0f5d8dd53d62265f8ae0/device/base/synchronization/one_writer_seqlock.cc
[modify] https://crrev.com/5d32e5baac25a09d120e0f5d8dd53d62265f8ae0/device/base/synchronization/one_writer_seqlock.h
[modify] https://crrev.com/5d32e5baac25a09d120e0f5d8dd53d62265f8ae0/device/base/synchronization/shared_memory_seqlock_buffer.h
[modify] https://crrev.com/5d32e5baac25a09d120e0f5d8dd53d62265f8ae0/third_party/blink/public/platform/scheduler/test/fake_renderer_scheduler.h
[modify] https://crrev.com/5d32e5baac25a09d120e0f5d8dd53d62265f8ae0/third_party/blink/public/platform/scheduler/test/mock_renderer_scheduler.h
[modify] https://crrev.com/5d32e5baac25a09d120e0f5d8dd53d62265f8ae0/third_party/blink/public/platform/scheduler/web_main_thread_scheduler.h
[modify] https://crrev.com/5d32e5baac25a09d120e0f5d8dd53d62265f8ae0/third_party/blink/public/platform/web_feature.mojom
[modify] https://crrev.com/5d32e5baac25a09d120e0f5d8dd53d62265f8ae0/third_party/blink/public/platform/web_input_event.h
[modify] https://crrev.com/5d32e5baac25a09d120e0f5d8dd53d62265f8ae0/third_party/blink/renderer/core/events/touch_event.cc
[modify] https://crrev.com/5d32e5baac25a09d120e0f5d8dd53d62265f8ae0/third_party/blink/renderer/core/events/touch_event_test.cc
[modify] https://crrev.com/5d32e5baac25a09d120e0f5d8dd53d62265f8ae0/third_party/blink/renderer/platform/BUILD.gn
[modify] https://crrev.com/5d32e5baac25a09d120e0f5d8dd53d62265f8ae0/third_party/blink/renderer/platform/scheduler/main_thread/main_thread_scheduler_impl.cc
[modify] https://crrev.com/5d32e5baac25a09d120e0f5d8dd53d62265f8ae0/third_party/blink/renderer/platform/scheduler/main_thread/main_thread_scheduler_impl.h
[modify] https://crrev.com/5d32e5baac25a09d120e0f5d8dd53d62265f8ae0/third_party/blink/renderer/platform/scheduler/main_thread/main_thread_scheduler_impl_unittest.cc
[modify] https://crrev.com/5d32e5baac25a09d120e0f5d8dd53d62265f8ae0/third_party/blink/renderer/platform/scheduler/renderer/queueing_time_estimator.cc
[modify] https://crrev.com/5d32e5baac25a09d120e0f5d8dd53d62265f8ae0/third_party/blink/renderer/platform/scheduler/renderer/queueing_time_estimator.h
[modify] https://crrev.com/5d32e5baac25a09d120e0f5d8dd53d62265f8ae0/third_party/blink/renderer/platform/scheduler/renderer/queueing_time_estimator_unittest.cc
[modify] https://crrev.com/5d32e5baac25a09d120e0f5d8dd53d62265f8ae0/third_party/blink/renderer/platform/scheduler/test/fake_renderer_scheduler.cc
[modify] https://crrev.com/5d32e5baac25a09d120e0f5d8dd53d62265f8ae0/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/5d32e5baac25a09d120e0f5d8dd53d62265f8ae0/tools/metrics/histograms/histograms.xml
[modify] https://crrev.com/5d32e5baac25a09d120e0f5d8dd53d62265f8ae0/ui/latency/ipc/latency_info_param_traits.cc
[modify] https://crrev.com/5d32e5baac25a09d120e0f5d8dd53d62265f8ae0/ui/latency/latency_info.cc
[modify] https://crrev.com/5d32e5baac25a09d120e0f5d8dd53d62265f8ae0/ui/latency/latency_info.h
[modify] https://crrev.com/5d32e5baac25a09d120e0f5d8dd53d62265f8ae0/ui/latency/mojo/latency_info.mojom
[modify] https://crrev.com/5d32e5baac25a09d120e0f5d8dd53d62265f8ae0/ui/latency/mojo/latency_info_struct_traits.cc
[modify] https://crrev.com/5d32e5baac25a09d120e0f5d8dd53d62265f8ae0/ui/latency/mojo/latency_info_struct_traits.h
Project Member

Comment 2 by bugdroid1@chromium.org, May 2 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cfc3637df44106a1c7401735799162db5472dbcd

commit cfc3637df44106a1c7401735799162db5472dbcd
Author: Nicolas Pena <npm@chromium.org>
Date: Wed May 02 16:03:10 2018

Remove QueueingTimeEstimator::State

This CL removes the State member of QueueingTimeEstimator since it is no
longer needed. This is the first step in the plan to report EQT by TTI.

https://docs.google.com/document/d/19D0f5VGFNmqJDcl5_AqkYOm1iUX24adPloCRO58aiH4/

Bug:  832680 , 830882
Change-Id: I571c75a15b51be1f8bff5b105257d6bb0d1092fc
Reviewed-on: https://chromium-review.googlesource.com/1035162
Reviewed-by: Alexander Timin <altimin@chromium.org>
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555409}
[modify] https://crrev.com/cfc3637df44106a1c7401735799162db5472dbcd/third_party/blink/renderer/platform/scheduler/renderer/queueing_time_estimator.cc
[modify] https://crrev.com/cfc3637df44106a1c7401735799162db5472dbcd/third_party/blink/renderer/platform/scheduler/renderer/queueing_time_estimator.h

Comment 3 by npm@chromium.org, Jul 4

Status: Fixed (was: Assigned)
I think I've removed everything.
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 11 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2b8f0454aedcf19ab395c7c4b87a52ea111202a7

commit 2b8f0454aedcf19ab395c7c4b87a52ea111202a7
Author: Nicolas Pena <npm@chromium.org>
Date: Wed Jul 11 14:58:01 2018

Remove RecordQueueingTimeClient

Bug:  832680 , 830882
Change-Id: I7fc5145f1b1ce9fee9bff6470cc55cda578e2c64
Reviewed-on: https://chromium-review.googlesource.com/1127259
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574161}
[modify] https://crrev.com/2b8f0454aedcf19ab395c7c4b87a52ea111202a7/third_party/blink/renderer/platform/scheduler/main_thread/queueing_time_estimator.cc
►

Sign in to add a comment