Issue 832676 link

Starred by 9 users

Issue metadata

Status:	Fixed
Owner:	ellyjo...@chromium.org
Closed:	Jan 9
Cc:	sdy@chromium.org viswa.karala@chromium.org tapted@chromium.org lgrey@chromium.org ellyjo...@chromium.org vasi...@chromium.org anthonyvd@chromium.org
EstimatedDays:	----
NextAction:	----
OS:	Mac
Pri:	2
Type:	Bug
Proj-MacViews MacViews-Cleanup Target-70 M-70 Group-Feature_Process

Blocked on:
issue 877493

macviews: remove cocoa browser UI code

Project Member Reported by ellyjo...@chromium.org, Apr 13 2018

Issue description

For M68 and onwards:

IsSecondaryUiMd() should always be true
ShowAllDialogsWithViewsToolkit() should always be true

And then we can remove all the code paths for either of these being false on Mac - i.e., all of the Cocoa secondary UI.

Showing comments 11 - 110 of 110 Older ›

Project Member

Comment 11 by bugdroid1@chromium.org, Jul 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/405b5e358ead69ae62ae81820d309492a36d4810

commit 405b5e358ead69ae62ae81820d309492a36d4810
Author: Elly Fong-Jones <ellyjones@chromium.org>
Date: Tue Jul 24 12:34:57 2018

mac: remove Cocoa PageInfo code

This code is dead since SecondaryUiMd has been on by default for several
releases now.

Bug: 832676
Change-Id: I5cfcdf8d1147dd3a788f0e8b57cf96a98d86f39e
Reviewed-on: https://chromium-review.googlesource.com/1148010
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577493}
[modify] https://crrev.com/405b5e358ead69ae62ae81820d309492a36d4810/chrome/browser/ui/BUILD.gn
[delete] https://crrev.com/1a5ca11895f29036c8b11c7ff1cf5490eb0e8837/chrome/browser/ui/cocoa/page_info/page_info_bubble_controller.h
[delete] https://crrev.com/1a5ca11895f29036c8b11c7ff1cf5490eb0e8837/chrome/browser/ui/cocoa/page_info/page_info_bubble_controller.mm
[delete] https://crrev.com/1a5ca11895f29036c8b11c7ff1cf5490eb0e8837/chrome/browser/ui/cocoa/page_info/page_info_bubble_controller_unittest.mm
[modify] https://crrev.com/405b5e358ead69ae62ae81820d309492a36d4810/chrome/browser/ui/cocoa/page_info/page_info_bubble_views_mac_browsertest.mm
[delete] https://crrev.com/1a5ca11895f29036c8b11c7ff1cf5490eb0e8837/chrome/browser/ui/cocoa/page_info/page_info_utils_cocoa.h
[delete] https://crrev.com/1a5ca11895f29036c8b11c7ff1cf5490eb0e8837/chrome/browser/ui/cocoa/page_info/page_info_utils_cocoa.mm
[delete] https://crrev.com/1a5ca11895f29036c8b11c7ff1cf5490eb0e8837/chrome/browser/ui/cocoa/page_info/permission_selector_button.h
[delete] https://crrev.com/1a5ca11895f29036c8b11c7ff1cf5490eb0e8837/chrome/browser/ui/cocoa/page_info/permission_selector_button.mm
[delete] https://crrev.com/1a5ca11895f29036c8b11c7ff1cf5490eb0e8837/chrome/browser/ui/cocoa/page_info/permission_selector_button_unittest.mm
[delete] https://crrev.com/1a5ca11895f29036c8b11c7ff1cf5490eb0e8837/chrome/browser/ui/cocoa/page_info/split_block_button.h
[delete] https://crrev.com/1a5ca11895f29036c8b11c7ff1cf5490eb0e8837/chrome/browser/ui/cocoa/page_info/split_block_button.mm
[modify] https://crrev.com/405b5e358ead69ae62ae81820d309492a36d4810/chrome/test/BUILD.gn

Project Member

Comment 12 by bugdroid1@chromium.org, Jul 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6ca636534ee4f00452f91ac0dd99b7067c253fb7

commit 6ca636534ee4f00452f91ac0dd99b7067c253fb7
Author: Elly Fong-Jones <ellyjones@chromium.org>
Date: Tue Jul 24 13:14:26 2018

macviews: don't try to use zero-size modals

The Mac window system doesn't support zero-size windows, so it's important that
DialogTestBrowserWindow not impose a 0x0 maximum size on constrained dialogs.

This fixes a slew of constrained window tests, like PrintPreviewUIUnitTest.*
and PrintPreviewDialogControllerUnitTest.*.

TBR=sky@chromium.org

Bug: 832676
Change-Id: I0708d20ef7e16468af6e13980994d063e3b7e87a
Reviewed-on: https://chromium-review.googlesource.com/1148011
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577502}
[modify] https://crrev.com/6ca636534ee4f00452f91ac0dd99b7067c253fb7/chrome/test/base/dialog_test_browser_window.cc

Project Member

Comment 13 by bugdroid1@chromium.org, Jul 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6cd75c790ea9b2f25ec4c0d72ad69a5a299c7afe

commit 6cd75c790ea9b2f25ec4c0d72ad69a5a299c7afe
Author: Elly Fong-Jones <ellyjones@chromium.org>
Date: Tue Jul 24 13:54:56 2018

mac: remove TranslateBubbleController

This piece of Cocoa secondary UI has been obsolete for several releases now
and its tests are broken in MacViews mode.

Bug: 832676
Change-Id: I2cf1fa087f29a288005913424396fc399eabf210
Reviewed-on: https://chromium-review.googlesource.com/1148012
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577514}
[modify] https://crrev.com/6cd75c790ea9b2f25ec4c0d72ad69a5a299c7afe/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/6cd75c790ea9b2f25ec4c0d72ad69a5a299c7afe/chrome/browser/ui/cocoa/browser_window_controller.h
[modify] https://crrev.com/6cd75c790ea9b2f25ec4c0d72ad69a5a299c7afe/chrome/browser/ui/cocoa/browser_window_controller.mm
[delete] https://crrev.com/44abf4c77a62b95544abd5a4d99d774ce70a3ec0/chrome/browser/ui/cocoa/translate/translate_bubble_controller.h
[delete] https://crrev.com/44abf4c77a62b95544abd5a4d99d774ce70a3ec0/chrome/browser/ui/cocoa/translate/translate_bubble_controller.mm
[delete] https://crrev.com/44abf4c77a62b95544abd5a4d99d774ce70a3ec0/chrome/browser/ui/cocoa/translate/translate_bubble_controller_unittest.mm
[delete] https://crrev.com/44abf4c77a62b95544abd5a4d99d774ce70a3ec0/chrome/browser/ui/cocoa/translate/translate_bubble_test_utils_views_cocoa.mm
[modify] https://crrev.com/6cd75c790ea9b2f25ec4c0d72ad69a5a299c7afe/chrome/test/BUILD.gn

Project Member

Comment 14 by bugdroid1@chromium.org, Jul 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/124f80f9c6f0935ed1369617346443d4321427bf

commit 124f80f9c6f0935ed1369617346443d4321427bf
Author: Robert Sesek <rsesek@chromium.org>
Date: Tue Jul 24 20:31:29 2018

[Mac] Replace MainMenu.xib with code to create the main menu bar.

This will eventually allow us to remove all XIB files after MacViewsBrowser
is fully launched.

This also now instantiates and leaks the AppController directly, rather
than it being a top-level object in the NIB.

Bug: 832676
Change-Id: I1c8ebdff45a92d4aee0f2a8b253274c03a76611c
Reviewed-on: https://chromium-review.googlesource.com/1147157
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577666}
[modify] https://crrev.com/124f80f9c6f0935ed1369617346443d4321427bf/chrome/app/chrome_command_ids.h
[modify] https://crrev.com/124f80f9c6f0935ed1369617346443d4321427bf/chrome/app/nibs/BUILD.gn
[delete] https://crrev.com/61c2840f00243135c7f22504ba0d8147db68b856/chrome/app/nibs/MainMenu.xib
[modify] https://crrev.com/124f80f9c6f0935ed1369617346443d4321427bf/chrome/app/nibs/PRESUBMIT.py
[modify] https://crrev.com/124f80f9c6f0935ed1369617346443d4321427bf/chrome/browser/app_controller_mac.h
[modify] https://crrev.com/124f80f9c6f0935ed1369617346443d4321427bf/chrome/browser/app_controller_mac.mm
[modify] https://crrev.com/124f80f9c6f0935ed1369617346443d4321427bf/chrome/browser/app_controller_mac_browsertest.mm
[modify] https://crrev.com/124f80f9c6f0935ed1369617346443d4321427bf/chrome/browser/chrome_browser_main_mac.mm
[modify] https://crrev.com/124f80f9c6f0935ed1369617346443d4321427bf/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/124f80f9c6f0935ed1369617346443d4321427bf/chrome/browser/ui/cocoa/accelerators_cocoa.mm
[add] https://crrev.com/124f80f9c6f0935ed1369617346443d4321427bf/chrome/browser/ui/cocoa/main_menu_builder.h
[add] https://crrev.com/124f80f9c6f0935ed1369617346443d4321427bf/chrome/browser/ui/cocoa/main_menu_builder.mm
[add] https://crrev.com/124f80f9c6f0935ed1369617346443d4321427bf/chrome/browser/ui/cocoa/main_menu_builder_unittest.mm
[modify] https://crrev.com/124f80f9c6f0935ed1369617346443d4321427bf/chrome/test/BUILD.gn

Project Member

Comment 15 by bugdroid1@chromium.org, Jul 30

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dcf17fe22170dd93e9df38e25f9da2c29df7855a

commit dcf17fe22170dd93e9df38e25f9da2c29df7855a
Author: Elly Fong-Jones <ellyjones@chromium.org>
Date: Mon Jul 30 13:59:26 2018

macviews: delete Cocoa bookmark secondary UI

This UI was only reachable in !mac_views_browser (last shipped in M66) with
!ShowAllDialogsUsingToolkitViews (last shipped in M65).

Bug: 832676
Change-Id: I3097f0de0b09c28e72c5e3a4c0977739cb0da2cc
Reviewed-on: https://chromium-review.googlesource.com/1151655
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579032}
[modify] https://crrev.com/dcf17fe22170dd93e9df38e25f9da2c29df7855a/chrome/app/nibs/BUILD.gn
[delete] https://crrev.com/ccb769372dc29e9ddd310ade124e2d675f6e9346/chrome/app/nibs/BookmarkAllTabs.xib
[delete] https://crrev.com/ccb769372dc29e9ddd310ade124e2d675f6e9346/chrome/app/nibs/BookmarkBubble.xib
[delete] https://crrev.com/ccb769372dc29e9ddd310ade124e2d675f6e9346/chrome/app/nibs/BookmarkEditor.xib
[delete] https://crrev.com/ccb769372dc29e9ddd310ade124e2d675f6e9346/chrome/app/nibs/BookmarkNameFolder.xib
[modify] https://crrev.com/dcf17fe22170dd93e9df38e25f9da2c29df7855a/chrome/browser/ui/BUILD.gn
[delete] https://crrev.com/ccb769372dc29e9ddd310ade124e2d675f6e9346/chrome/browser/ui/cocoa/bookmarks/bookmark_all_tabs_controller.h
[delete] https://crrev.com/ccb769372dc29e9ddd310ade124e2d675f6e9346/chrome/browser/ui/cocoa/bookmarks/bookmark_all_tabs_controller.mm
[delete] https://crrev.com/ccb769372dc29e9ddd310ade124e2d675f6e9346/chrome/browser/ui/cocoa/bookmarks/bookmark_all_tabs_controller_unittest.mm
[modify] https://crrev.com/dcf17fe22170dd93e9df38e25f9da2c29df7855a/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm
[delete] https://crrev.com/ccb769372dc29e9ddd310ade124e2d675f6e9346/chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller.h
[delete] https://crrev.com/ccb769372dc29e9ddd310ade124e2d675f6e9346/chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller.mm
[delete] https://crrev.com/ccb769372dc29e9ddd310ade124e2d675f6e9346/chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller_unittest.mm
[delete] https://crrev.com/ccb769372dc29e9ddd310ade124e2d675f6e9346/chrome/browser/ui/cocoa/bookmarks/bookmark_editor_base_controller.h
[delete] https://crrev.com/ccb769372dc29e9ddd310ade124e2d675f6e9346/chrome/browser/ui/cocoa/bookmarks/bookmark_editor_base_controller.mm
[delete] https://crrev.com/ccb769372dc29e9ddd310ade124e2d675f6e9346/chrome/browser/ui/cocoa/bookmarks/bookmark_editor_base_controller_unittest.mm
[delete] https://crrev.com/ccb769372dc29e9ddd310ade124e2d675f6e9346/chrome/browser/ui/cocoa/bookmarks/bookmark_editor_controller.h
[delete] https://crrev.com/ccb769372dc29e9ddd310ade124e2d675f6e9346/chrome/browser/ui/cocoa/bookmarks/bookmark_editor_controller.mm
[delete] https://crrev.com/ccb769372dc29e9ddd310ade124e2d675f6e9346/chrome/browser/ui/cocoa/bookmarks/bookmark_editor_controller_unittest.mm
[delete] https://crrev.com/ccb769372dc29e9ddd310ade124e2d675f6e9346/chrome/browser/ui/cocoa/bookmarks/bookmark_name_folder_controller.h
[delete] https://crrev.com/ccb769372dc29e9ddd310ade124e2d675f6e9346/chrome/browser/ui/cocoa/bookmarks/bookmark_name_folder_controller.mm
[delete] https://crrev.com/ccb769372dc29e9ddd310ade124e2d675f6e9346/chrome/browser/ui/cocoa/bookmarks/bookmark_name_folder_controller_unittest.mm
[modify] https://crrev.com/dcf17fe22170dd93e9df38e25f9da2c29df7855a/chrome/browser/ui/cocoa/browser_window_controller.h
[modify] https://crrev.com/dcf17fe22170dd93e9df38e25f9da2c29df7855a/chrome/browser/ui/cocoa/browser_window_controller.mm
[modify] https://crrev.com/dcf17fe22170dd93e9df38e25f9da2c29df7855a/chrome/browser/ui/cocoa/browser_window_controller_private.mm
[delete] https://crrev.com/ccb769372dc29e9ddd310ade124e2d675f6e9346/chrome/browser/ui/cocoa/dialog_text_field_editor.h
[delete] https://crrev.com/ccb769372dc29e9ddd310ade124e2d675f6e9346/chrome/browser/ui/cocoa/dialog_text_field_editor.mm
[modify] https://crrev.com/dcf17fe22170dd93e9df38e25f9da2c29df7855a/chrome/test/BUILD.gn

Comment 16 by ellyjo...@chromium.org, Aug 2

Labels: -M-69 -Target-69 Target-70 M-70

The bulk of this cleanup will happen in M70.

Project Member

Comment 17 by bugdroid1@chromium.org, Aug 14

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c5aa00de4ed3b7b045586efad6e316a1db7b9dde

commit c5aa00de4ed3b7b045586efad6e316a1db7b9dde
Author: Elly Fong-Jones <ellyjones@chromium.org>
Date: Tue Aug 14 17:55:43 2018

cocoa: remove all Cocoa content setting UI

This has been off by default since M67 and is actually dead in M69.

Tbr: thakis@chromium.org
Bug: 832676
Change-Id: Iba63da4b6c0d12fea4356bc5173b19ae46d4c510
Reviewed-on: https://chromium-review.googlesource.com/1172791
Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582971}
[modify] https://crrev.com/c5aa00de4ed3b7b045586efad6e316a1db7b9dde/BUILD.gn
[modify] https://crrev.com/c5aa00de4ed3b7b045586efad6e316a1db7b9dde/chrome/app/nibs/BUILD.gn
[delete] https://crrev.com/3dcaec6e30feebefc11ee6972a76d446257b28a6/chrome/app/nibs/CollectedCookies.xib
[delete] https://crrev.com/3dcaec6e30feebefc11ee6972a76d446257b28a6/chrome/app/nibs/ContentBlockedCookies.xib
[delete] https://crrev.com/3dcaec6e30feebefc11ee6972a76d446257b28a6/chrome/app/nibs/ContentBlockedDownloads.xib
[delete] https://crrev.com/3dcaec6e30feebefc11ee6972a76d446257b28a6/chrome/app/nibs/ContentBlockedGeolocation.xib
[delete] https://crrev.com/3dcaec6e30feebefc11ee6972a76d446257b28a6/chrome/app/nibs/ContentBlockedMIDISysEx.xib
[delete] https://crrev.com/3dcaec6e30feebefc11ee6972a76d446257b28a6/chrome/app/nibs/ContentBlockedMedia.xib
[delete] https://crrev.com/3dcaec6e30feebefc11ee6972a76d446257b28a6/chrome/app/nibs/ContentBlockedMixedScript.xib
[delete] https://crrev.com/3dcaec6e30feebefc11ee6972a76d446257b28a6/chrome/app/nibs/ContentBlockedPopups.xib
[delete] https://crrev.com/3dcaec6e30feebefc11ee6972a76d446257b28a6/chrome/app/nibs/ContentBlockedSimple.xib
[delete] https://crrev.com/3dcaec6e30feebefc11ee6972a76d446257b28a6/chrome/app/nibs/ContentProtocolHandlers.xib
[delete] https://crrev.com/3dcaec6e30feebefc11ee6972a76d446257b28a6/chrome/app/nibs/CookieDetailsView.xib
[modify] https://crrev.com/c5aa00de4ed3b7b045586efad6e316a1db7b9dde/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/c5aa00de4ed3b7b045586efad6e316a1db7b9dde/chrome/browser/ui/cocoa/DEPS
[delete] https://crrev.com/3dcaec6e30feebefc11ee6972a76d446257b28a6/chrome/browser/ui/cocoa/content_settings/OWNERS
[delete] https://crrev.com/3dcaec6e30feebefc11ee6972a76d446257b28a6/chrome/browser/ui/cocoa/content_settings/blocked_plugin_bubble_controller.h
[delete] https://crrev.com/3dcaec6e30feebefc11ee6972a76d446257b28a6/chrome/browser/ui/cocoa/content_settings/blocked_plugin_bubble_controller.mm
[delete] https://crrev.com/3dcaec6e30feebefc11ee6972a76d446257b28a6/chrome/browser/ui/cocoa/content_settings/collected_cookies_mac.h
[delete] https://crrev.com/3dcaec6e30feebefc11ee6972a76d446257b28a6/chrome/browser/ui/cocoa/content_settings/collected_cookies_mac.mm
[delete] https://crrev.com/3dcaec6e30feebefc11ee6972a76d446257b28a6/chrome/browser/ui/cocoa/content_settings/collected_cookies_mac_browsertest.mm
[delete] https://crrev.com/3dcaec6e30feebefc11ee6972a76d446257b28a6/chrome/browser/ui/cocoa/content_settings/collected_cookies_mac_unittest.mm
[delete] https://crrev.com/3dcaec6e30feebefc11ee6972a76d446257b28a6/chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa.h
[delete] https://crrev.com/3dcaec6e30feebefc11ee6972a76d446257b28a6/chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa.mm
[delete] https://crrev.com/3dcaec6e30feebefc11ee6972a76d446257b28a6/chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa_browsertest.mm
[delete] https://crrev.com/3dcaec6e30feebefc11ee6972a76d446257b28a6/chrome/browser/ui/cocoa/content_settings/cookie_details.h
[delete] https://crrev.com/3dcaec6e30feebefc11ee6972a76d446257b28a6/chrome/browser/ui/cocoa/content_settings/cookie_details.mm
[delete] https://crrev.com/3dcaec6e30feebefc11ee6972a76d446257b28a6/chrome/browser/ui/cocoa/content_settings/cookie_details_unittest.mm
[delete] https://crrev.com/3dcaec6e30feebefc11ee6972a76d446257b28a6/chrome/browser/ui/cocoa/content_settings/cookie_details_view_controller.h
[delete] https://crrev.com/3dcaec6e30feebefc11ee6972a76d446257b28a6/chrome/browser/ui/cocoa/content_settings/cookie_details_view_controller.mm
[delete] https://crrev.com/3dcaec6e30feebefc11ee6972a76d446257b28a6/chrome/browser/ui/cocoa/content_settings/cookie_details_view_controller_unittest.mm
[delete] https://crrev.com/3dcaec6e30feebefc11ee6972a76d446257b28a6/chrome/browser/ui/cocoa/content_settings/cookie_tree_node.h
[delete] https://crrev.com/3dcaec6e30feebefc11ee6972a76d446257b28a6/chrome/browser/ui/cocoa/content_settings/cookie_tree_node.mm
[delete] https://crrev.com/3dcaec6e30feebefc11ee6972a76d446257b28a6/chrome/browser/ui/cocoa/content_settings/cookies_tree_controller_bridge.h
[delete] https://crrev.com/3dcaec6e30feebefc11ee6972a76d446257b28a6/chrome/browser/ui/cocoa/content_settings/cookies_tree_controller_bridge.mm
[modify] https://crrev.com/c5aa00de4ed3b7b045586efad6e316a1db7b9dde/chrome/browser/ui/cocoa/location_bar/content_setting_decoration.mm
[modify] https://crrev.com/c5aa00de4ed3b7b045586efad6e316a1db7b9dde/chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm
[delete] https://crrev.com/3dcaec6e30feebefc11ee6972a76d446257b28a6/chrome/browser/ui/cocoa/subresource_filter/subresource_filter_bubble_controller.h
[delete] https://crrev.com/3dcaec6e30feebefc11ee6972a76d446257b28a6/chrome/browser/ui/cocoa/subresource_filter/subresource_filter_bubble_controller.mm
[modify] https://crrev.com/c5aa00de4ed3b7b045586efad6e316a1db7b9dde/chrome/browser/ui/cocoa/tab_dialogs_cocoa.mm
[delete] https://crrev.com/3dcaec6e30feebefc11ee6972a76d446257b28a6/chrome/browser/ui/cocoa/vertical_gradient_view.h
[delete] https://crrev.com/3dcaec6e30feebefc11ee6972a76d446257b28a6/chrome/browser/ui/cocoa/vertical_gradient_view.mm
[delete] https://crrev.com/3dcaec6e30feebefc11ee6972a76d446257b28a6/chrome/browser/ui/cocoa/vertical_gradient_view_unittest.mm
[modify] https://crrev.com/c5aa00de4ed3b7b045586efad6e316a1db7b9dde/chrome/test/BUILD.gn
[delete] https://crrev.com/3dcaec6e30feebefc11ee6972a76d446257b28a6/third_party/apple_sample_code/BUILD.gn
[delete] https://crrev.com/3dcaec6e30feebefc11ee6972a76d446257b28a6/third_party/apple_sample_code/ImageAndTextCell.h
[delete] https://crrev.com/3dcaec6e30feebefc11ee6972a76d446257b28a6/third_party/apple_sample_code/ImageAndTextCell.m
[delete] https://crrev.com/3dcaec6e30feebefc11ee6972a76d446257b28a6/third_party/apple_sample_code/LICENSE
[delete] https://crrev.com/3dcaec6e30feebefc11ee6972a76d446257b28a6/third_party/apple_sample_code/OWNERS
[delete] https://crrev.com/3dcaec6e30feebefc11ee6972a76d446257b28a6/third_party/apple_sample_code/README.chromium

Project Member

Comment 18 by bugdroid1@chromium.org, Aug 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/53f44e1864f8568a274225133ffffa5a271adf78

commit 53f44e1864f8568a274225133ffffa5a271adf78
Author: Elly Fong-Jones <ellyjones@chromium.org>
Date: Thu Aug 16 18:17:32 2018

cocoa: remove extension secondary UI

Bug: 832676
Change-Id: I1c5beaf588e62ee17220e605768c860692e92f53
Reviewed-on: https://chromium-review.googlesource.com/1177685
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583738}
[modify] https://crrev.com/53f44e1864f8568a274225133ffffa5a271adf78/chrome/app/nibs/BUILD.gn
[delete] https://crrev.com/2346503022b5df09043ea960ffd06b204510b83b/chrome/app/nibs/ExtensionInstallPrompt.xib
[delete] https://crrev.com/2346503022b5df09043ea960ffd06b204510b83b/chrome/app/nibs/ExtensionInstallPromptNoWarnings.xib
[delete] https://crrev.com/2346503022b5df09043ea960ffd06b204510b83b/chrome/app/nibs/ExtensionInstallPromptWebstoreData.xib
[delete] https://crrev.com/2346503022b5df09043ea960ffd06b204510b83b/chrome/app/nibs/ExtensionInstalledBubble.xib
[modify] https://crrev.com/53f44e1864f8568a274225133ffffa5a271adf78/chrome/browser/ui/BUILD.gn
[delete] https://crrev.com/2346503022b5df09043ea960ffd06b204510b83b/chrome/browser/ui/cocoa/bubble_sync_promo_controller.h
[delete] https://crrev.com/2346503022b5df09043ea960ffd06b204510b83b/chrome/browser/ui/cocoa/bubble_sync_promo_controller.mm
[delete] https://crrev.com/2346503022b5df09043ea960ffd06b204510b83b/chrome/browser/ui/cocoa/extensions/extension_install_dialog_controller.h
[delete] https://crrev.com/2346503022b5df09043ea960ffd06b204510b83b/chrome/browser/ui/cocoa/extensions/extension_install_dialog_controller.mm
[delete] https://crrev.com/2346503022b5df09043ea960ffd06b204510b83b/chrome/browser/ui/cocoa/extensions/extension_install_dialog_controller_browsertest.mm
[delete] https://crrev.com/2346503022b5df09043ea960ffd06b204510b83b/chrome/browser/ui/cocoa/extensions/extension_install_prompt_test_utils.h
[delete] https://crrev.com/2346503022b5df09043ea960ffd06b204510b83b/chrome/browser/ui/cocoa/extensions/extension_install_prompt_test_utils.mm
[delete] https://crrev.com/2346503022b5df09043ea960ffd06b204510b83b/chrome/browser/ui/cocoa/extensions/extension_install_view_controller.h
[delete] https://crrev.com/2346503022b5df09043ea960ffd06b204510b83b/chrome/browser/ui/cocoa/extensions/extension_install_view_controller.mm
[delete] https://crrev.com/2346503022b5df09043ea960ffd06b204510b83b/chrome/browser/ui/cocoa/extensions/extension_install_view_controller_unittest.mm
[delete] https://crrev.com/2346503022b5df09043ea960ffd06b204510b83b/chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.h
[delete] https://crrev.com/2346503022b5df09043ea960ffd06b204510b83b/chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.mm
[delete] https://crrev.com/2346503022b5df09043ea960ffd06b204510b83b/chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller_unittest.mm
[delete] https://crrev.com/2346503022b5df09043ea960ffd06b204510b83b/chrome/browser/ui/cocoa/extensions/windowed_install_dialog_controller.h
[delete] https://crrev.com/2346503022b5df09043ea960ffd06b204510b83b/chrome/browser/ui/cocoa/extensions/windowed_install_dialog_controller.mm
[delete] https://crrev.com/2346503022b5df09043ea960ffd06b204510b83b/chrome/browser/ui/cocoa/extensions/windowed_install_dialog_controller_browsertest.mm
[modify] https://crrev.com/53f44e1864f8568a274225133ffffa5a271adf78/chrome/test/BUILD.gn

Project Member

Comment 19 by bugdroid1@chromium.org, Aug 17

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3f6112ec29b64672d5ca79139baf8c290da6afae

commit 3f6112ec29b64672d5ca79139baf8c290da6afae
Author: Robert Sesek <rsesek@chromium.org>
Date: Fri Aug 17 16:46:00 2018

cocoa: Remove the unused OneClickSigninBubble.xib

Bug: 832676
Change-Id: I696021ef9b7db702eb3c7389f46dadf4cf264d4f
Reviewed-on: https://chromium-review.googlesource.com/1177961
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584100}
[modify] https://crrev.com/3f6112ec29b64672d5ca79139baf8c290da6afae/chrome/app/nibs/BUILD.gn
[delete] https://crrev.com/77bf1926a9d8e349b3b5f4d5f88bd9033ae8e4e8/chrome/app/nibs/OneClickSigninBubble.xib

Project Member

Comment 20 by bugdroid1@chromium.org, Aug 28

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6ffc06bf9e0ecbdbab1587819b9184bd377c1037

commit 6ffc06bf9e0ecbdbab1587819b9184bd377c1037
Author: Elly Fong-Jones <ellyjones@chromium.org>
Date: Tue Aug 28 11:38:06 2018

cocoa: remove cocoa extension popup support

Bug: 832676
Change-Id: I6b4358838170781d13f54c76b4d34715471757e6
Reviewed-on: https://chromium-review.googlesource.com/1185202
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586656}
[modify] https://crrev.com/6ffc06bf9e0ecbdbab1587819b9184bd377c1037/chrome/browser/extensions/extension_view_host.h
[modify] https://crrev.com/6ffc06bf9e0ecbdbab1587819b9184bd377c1037/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/6ffc06bf9e0ecbdbab1587819b9184bd377c1037/chrome/browser/ui/cocoa/apps/native_app_window_cocoa.mm
[modify] https://crrev.com/6ffc06bf9e0ecbdbab1587819b9184bd377c1037/chrome/browser/ui/cocoa/extensions/browser_action_test_util_views_cocoa.mm
[modify] https://crrev.com/6ffc06bf9e0ecbdbab1587819b9184bd377c1037/chrome/browser/ui/cocoa/extensions/extension_action_platform_delegate_cocoa.h
[modify] https://crrev.com/6ffc06bf9e0ecbdbab1587819b9184bd377c1037/chrome/browser/ui/cocoa/extensions/extension_action_platform_delegate_cocoa.mm
[delete] https://crrev.com/5553ca2e6331fd1ab63717dfe8b47cf39c1da005/chrome/browser/ui/cocoa/extensions/extension_popup_controller.h
[delete] https://crrev.com/5553ca2e6331fd1ab63717dfe8b47cf39c1da005/chrome/browser/ui/cocoa/extensions/extension_popup_controller.mm
[delete] https://crrev.com/5553ca2e6331fd1ab63717dfe8b47cf39c1da005/chrome/browser/ui/cocoa/extensions/extension_view_mac.h
[delete] https://crrev.com/5553ca2e6331fd1ab63717dfe8b47cf39c1da005/chrome/browser/ui/cocoa/extensions/extension_view_mac.mm
[modify] https://crrev.com/6ffc06bf9e0ecbdbab1587819b9184bd377c1037/chrome/browser/ui/views/extensions/extension_view_views.cc

Project Member

Comment 21 by bugdroid1@chromium.org, Aug 29

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/44c0cd81eeccb44431c1dd3bef8be3af4063b9b6

commit 44c0cd81eeccb44431c1dd3bef8be3af4063b9b6
Author: Elly Fong-Jones <ellyjones@chromium.org>
Date: Wed Aug 29 17:00:49 2018

mac: remove more Cocoa secondary UI

This change removes some of the extension secondary UI (there turns out to be
quite a lot...) and cleans up the build files.

Bug: 832676
Change-Id: Ie78071a8247f36f39839450a6cf50edda7294653
Reviewed-on: https://chromium-review.googlesource.com/1194957
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587162}
[modify] https://crrev.com/44c0cd81eeccb44431c1dd3bef8be3af4063b9b6/chrome/browser/ui/BUILD.gn
[delete] https://crrev.com/06c3ffcf258edf7524041a8909ad7eaa50c85a34/chrome/browser/ui/cocoa/extensions/chooser_dialog_cocoa.h
[delete] https://crrev.com/06c3ffcf258edf7524041a8909ad7eaa50c85a34/chrome/browser/ui/cocoa/extensions/chooser_dialog_cocoa.mm
[delete] https://crrev.com/06c3ffcf258edf7524041a8909ad7eaa50c85a34/chrome/browser/ui/cocoa/extensions/chooser_dialog_cocoa_controller.h
[delete] https://crrev.com/06c3ffcf258edf7524041a8909ad7eaa50c85a34/chrome/browser/ui/cocoa/extensions/chooser_dialog_cocoa_controller.mm
[delete] https://crrev.com/06c3ffcf258edf7524041a8909ad7eaa50c85a34/chrome/browser/ui/cocoa/extensions/chooser_dialog_cocoa_controller_unittest.mm
[delete] https://crrev.com/06c3ffcf258edf7524041a8909ad7eaa50c85a34/chrome/browser/ui/cocoa/extensions/extension_uninstall_dialog_cocoa.mm
[delete] https://crrev.com/06c3ffcf258edf7524041a8909ad7eaa50c85a34/chrome/browser/ui/cocoa/external_protocol_dialog.h
[delete] https://crrev.com/06c3ffcf258edf7524041a8909ad7eaa50c85a34/chrome/browser/ui/cocoa/external_protocol_dialog_cocoa.mm
[delete] https://crrev.com/06c3ffcf258edf7524041a8909ad7eaa50c85a34/chrome/browser/ui/cocoa/external_protocol_dialog_views_mac.mm
[modify] https://crrev.com/44c0cd81eeccb44431c1dd3bef8be3af4063b9b6/chrome/test/BUILD.gn

Project Member

Comment 22 by bugdroid1@chromium.org, Sep 6

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/17e80a426ec6973d9ba5086c57fcb12a80e73781

commit 17e80a426ec6973d9ba5086c57fcb12a80e73781
Author: Nico Weber <thakis@chromium.org>
Date: Thu Sep 06 14:39:21 2018

mac: Remove some uses of mac_views_browser.

Also move mac_views_browser out of declare_args so that it can no longer
be forced to false, and add a comment saying that this variable is supposed
to go away.

Bug: 832676
Change-Id: Ie2a6340715d45aa913db77595f0d578aea899ca4
Reviewed-on: https://chromium-review.googlesource.com/1209982
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589162}
[modify] https://crrev.com/17e80a426ec6973d9ba5086c57fcb12a80e73781/chrome/app/nibs/BUILD.gn
[delete] https://crrev.com/d08cd3b86f5dbf371f82eea0dfc7537dc45ecd13/chrome/app/nibs/HttpAuthLoginSheet.xib
[modify] https://crrev.com/17e80a426ec6973d9ba5086c57fcb12a80e73781/chrome/browser/BUILD.gn
[delete] https://crrev.com/d08cd3b86f5dbf371f82eea0dfc7537dc45ecd13/chrome/browser/chooser_controller/mock_chooser_controller.cc
[delete] https://crrev.com/d08cd3b86f5dbf371f82eea0dfc7537dc45ecd13/chrome/browser/chooser_controller/mock_chooser_controller.h
[modify] https://crrev.com/17e80a426ec6973d9ba5086c57fcb12a80e73781/chrome/browser/ui/BUILD.gn
[delete] https://crrev.com/d08cd3b86f5dbf371f82eea0dfc7537dc45ecd13/chrome/browser/ui/cocoa/constrained_web_dialog_delegate_mac.mm
[delete] https://crrev.com/d08cd3b86f5dbf371f82eea0dfc7537dc45ecd13/chrome/browser/ui/cocoa/importer/import_lock_dialog_cocoa.mm
[delete] https://crrev.com/d08cd3b86f5dbf371f82eea0dfc7537dc45ecd13/chrome/browser/ui/cocoa/login_handler_cocoa.h
[delete] https://crrev.com/d08cd3b86f5dbf371f82eea0dfc7537dc45ecd13/chrome/browser/ui/cocoa/login_handler_cocoa.mm
[delete] https://crrev.com/d08cd3b86f5dbf371f82eea0dfc7537dc45ecd13/chrome/browser/ui/cocoa/simple_message_box_bridge_views.mm
[delete] https://crrev.com/d08cd3b86f5dbf371f82eea0dfc7537dc45ecd13/chrome/browser/ui/media_router/presentation_receiver_window_factory_mac.cc
[modify] https://crrev.com/17e80a426ec6973d9ba5086c57fcb12a80e73781/ui/base/ui_features.gni

Project Member

Comment 23 by bugdroid1@chromium.org, Sep 7

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7cd351304c188bb686181ab15fd33943228f4955

commit 7cd351304c188bb686181ab15fd33943228f4955
Author: Nico Weber <thakis@chromium.org>
Date: Fri Sep 07 15:16:54 2018

Remove another use of mac_views_browser, consolidate gn file a bit.

Merges the contents of an always-true block with the contents one scope up.
There were several if (is_win) etc blocks at that scope; merge these too.

No intended behavior change.

Bug: 832676
Change-Id: I89ecdec3babec570c631714001edb71cfb1cca66
Reviewed-on: https://chromium-review.googlesource.com/1213522
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589519}
[modify] https://crrev.com/7cd351304c188bb686181ab15fd33943228f4955/chrome/browser/ui/BUILD.gn

Project Member

Comment 24 by bugdroid1@chromium.org, Sep 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e0612c7430e4ca1b604d398862ef7d20af05efc4

commit e0612c7430e4ca1b604d398862ef7d20af05efc4
Author: qinmin <qinmin@chromium.org>
Date: Wed Sep 19 22:36:26 2018

Remove chrome/browser/ui/cocoa/download/

The code under this dir is not being used. The only file left is
download_start_animation_mac.mm as it needs to provide mac specific
download start animation

BUG=881499,832676

Change-Id: I9f8e927da2487c519f329508a31816c5a5253415
Reviewed-on: https://chromium-review.googlesource.com/1234473
Commit-Queue: Min Qin <qinmin@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592581}
[modify] https://crrev.com/e0612c7430e4ca1b604d398862ef7d20af05efc4/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/e0612c7430e4ca1b604d398862ef7d20af05efc4/chrome/browser/ui/cocoa/browser/exclusive_access_controller_views.mm
[modify] https://crrev.com/e0612c7430e4ca1b604d398862ef7d20af05efc4/chrome/browser/ui/cocoa/browser_window_cocoa.mm
[modify] https://crrev.com/e0612c7430e4ca1b604d398862ef7d20af05efc4/chrome/browser/ui/cocoa/browser_window_controller.h
[modify] https://crrev.com/e0612c7430e4ca1b604d398862ef7d20af05efc4/chrome/browser/ui/cocoa/browser_window_controller.mm
[modify] https://crrev.com/e0612c7430e4ca1b604d398862ef7d20af05efc4/chrome/browser/ui/cocoa/browser_window_controller_private.mm
[modify] https://crrev.com/e0612c7430e4ca1b604d398862ef7d20af05efc4/chrome/browser/ui/cocoa/browser_window_controller_unittest.mm
[delete] https://crrev.com/7f6fac7d516212457e6c093b8db016423ba2f85f/chrome/browser/ui/cocoa/download/OWNERS
[delete] https://crrev.com/7f6fac7d516212457e6c093b8db016423ba2f85f/chrome/browser/ui/cocoa/download/background_theme.h
[delete] https://crrev.com/7f6fac7d516212457e6c093b8db016423ba2f85f/chrome/browser/ui/cocoa/download/background_theme.mm
[delete] https://crrev.com/7f6fac7d516212457e6c093b8db016423ba2f85f/chrome/browser/ui/cocoa/download/download_item_button.h
[delete] https://crrev.com/7f6fac7d516212457e6c093b8db016423ba2f85f/chrome/browser/ui/cocoa/download/download_item_button.mm
[delete] https://crrev.com/7f6fac7d516212457e6c093b8db016423ba2f85f/chrome/browser/ui/cocoa/download/download_item_button_unittest.mm
[delete] https://crrev.com/7f6fac7d516212457e6c093b8db016423ba2f85f/chrome/browser/ui/cocoa/download/download_item_cell.h
[delete] https://crrev.com/7f6fac7d516212457e6c093b8db016423ba2f85f/chrome/browser/ui/cocoa/download/download_item_cell.mm
[delete] https://crrev.com/7f6fac7d516212457e6c093b8db016423ba2f85f/chrome/browser/ui/cocoa/download/download_item_cell_unittest.mm
[delete] https://crrev.com/7f6fac7d516212457e6c093b8db016423ba2f85f/chrome/browser/ui/cocoa/download/download_item_controller.h
[delete] https://crrev.com/7f6fac7d516212457e6c093b8db016423ba2f85f/chrome/browser/ui/cocoa/download/download_item_controller.mm
[delete] https://crrev.com/7f6fac7d516212457e6c093b8db016423ba2f85f/chrome/browser/ui/cocoa/download/download_item_controller_unittest.mm
[delete] https://crrev.com/7f6fac7d516212457e6c093b8db016423ba2f85f/chrome/browser/ui/cocoa/download/download_item_mac.h
[delete] https://crrev.com/7f6fac7d516212457e6c093b8db016423ba2f85f/chrome/browser/ui/cocoa/download/download_item_mac.mm
[delete] https://crrev.com/7f6fac7d516212457e6c093b8db016423ba2f85f/chrome/browser/ui/cocoa/download/download_item_view_protocol.h
[delete] https://crrev.com/7f6fac7d516212457e6c093b8db016423ba2f85f/chrome/browser/ui/cocoa/download/download_shelf_context_menu_controller.h
[delete] https://crrev.com/7f6fac7d516212457e6c093b8db016423ba2f85f/chrome/browser/ui/cocoa/download/download_shelf_context_menu_controller.mm
[delete] https://crrev.com/7f6fac7d516212457e6c093b8db016423ba2f85f/chrome/browser/ui/cocoa/download/download_shelf_controller.h
[delete] https://crrev.com/7f6fac7d516212457e6c093b8db016423ba2f85f/chrome/browser/ui/cocoa/download/download_shelf_controller.mm
[delete] https://crrev.com/7f6fac7d516212457e6c093b8db016423ba2f85f/chrome/browser/ui/cocoa/download/download_shelf_controller_unittest.mm
[delete] https://crrev.com/7f6fac7d516212457e6c093b8db016423ba2f85f/chrome/browser/ui/cocoa/download/download_shelf_mac.h
[delete] https://crrev.com/7f6fac7d516212457e6c093b8db016423ba2f85f/chrome/browser/ui/cocoa/download/download_shelf_mac.mm
[delete] https://crrev.com/7f6fac7d516212457e6c093b8db016423ba2f85f/chrome/browser/ui/cocoa/download/download_shelf_mac_unittest.mm
[delete] https://crrev.com/7f6fac7d516212457e6c093b8db016423ba2f85f/chrome/browser/ui/cocoa/download/download_shelf_view_cocoa.h
[delete] https://crrev.com/7f6fac7d516212457e6c093b8db016423ba2f85f/chrome/browser/ui/cocoa/download/download_shelf_view_cocoa.mm
[delete] https://crrev.com/7f6fac7d516212457e6c093b8db016423ba2f85f/chrome/browser/ui/cocoa/download/download_shelf_view_cocoa_unittest.mm
[delete] https://crrev.com/7f6fac7d516212457e6c093b8db016423ba2f85f/chrome/browser/ui/cocoa/download/download_show_all_button.h
[delete] https://crrev.com/7f6fac7d516212457e6c093b8db016423ba2f85f/chrome/browser/ui/cocoa/download/download_show_all_button.mm
[delete] https://crrev.com/7f6fac7d516212457e6c093b8db016423ba2f85f/chrome/browser/ui/cocoa/download/download_show_all_cell.h
[delete] https://crrev.com/7f6fac7d516212457e6c093b8db016423ba2f85f/chrome/browser/ui/cocoa/download/download_show_all_cell.mm
[delete] https://crrev.com/7f6fac7d516212457e6c093b8db016423ba2f85f/chrome/browser/ui/cocoa/download/md_download_item_progress_indicator.h
[delete] https://crrev.com/7f6fac7d516212457e6c093b8db016423ba2f85f/chrome/browser/ui/cocoa/download/md_download_item_progress_indicator.mm
[delete] https://crrev.com/7f6fac7d516212457e6c093b8db016423ba2f85f/chrome/browser/ui/cocoa/download/md_download_item_view.h
[delete] https://crrev.com/7f6fac7d516212457e6c093b8db016423ba2f85f/chrome/browser/ui/cocoa/download/md_download_item_view.mm
[delete] https://crrev.com/7f6fac7d516212457e6c093b8db016423ba2f85f/chrome/browser/ui/cocoa/download/md_download_item_view_testing.h
[delete] https://crrev.com/7f6fac7d516212457e6c093b8db016423ba2f85f/chrome/browser/ui/cocoa/download/md_download_item_view_unittest.mm
[modify] https://crrev.com/e0612c7430e4ca1b604d398862ef7d20af05efc4/chrome/test/BUILD.gn

Project Member

Comment 25 by bugdroid1@chromium.org, Sep 20

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/78e25099e039827b0debcfd2754a48e038289041

commit 78e25099e039827b0debcfd2754a48e038289041
Author: Nico Weber <thakis@chromium.org>
Date: Thu Sep 20 14:45:55 2018

mac: Remove 2 xib files unused after cocoa download code removal.

These two files are unused after
https://chromium-review.googlesource.com/c/chromium/src/+/1234473

Bug: 832676
Change-Id: I216ee64cda26ba618a8b89bd8dc216aef6f567f5
Reviewed-on: https://chromium-review.googlesource.com/1236176
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592798}
[modify] https://crrev.com/78e25099e039827b0debcfd2754a48e038289041/chrome/app/nibs/BUILD.gn
[delete] https://crrev.com/0e41a65a2f1341254002b6099463bd3d0075994a/chrome/app/nibs/DownloadItem.xib
[delete] https://crrev.com/0e41a65a2f1341254002b6099463bd3d0075994a/chrome/app/nibs/DownloadShelf.xib

Project Member

Comment 26 by bugdroid1@chromium.org, Sep 20

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/50439b8800226bc90259e70f2ba276ed3368be82

commit 50439b8800226bc90259e70f2ba276ed3368be82
Author: Nico Weber <thakis@chromium.org>
Date: Thu Sep 20 15:57:28 2018

mac: Remove unused TabDialogsMac/TabDialogsCocoa.

Bug: 832676
Change-Id: I0fb8d4b1f0197dab0b988a52741724f63a18ee9f
Reviewed-on: https://chromium-review.googlesource.com/1236178
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592819}
[modify] https://crrev.com/50439b8800226bc90259e70f2ba276ed3368be82/chrome/app/nibs/BUILD.gn
[delete] https://crrev.com/fbe67a9526a8ada8ab37b2ce9e7b66dd5a39cdae/chrome/app/nibs/HungRendererDialog.xib
[modify] https://crrev.com/50439b8800226bc90259e70f2ba276ed3368be82/chrome/browser/ui/BUILD.gn
[delete] https://crrev.com/fbe67a9526a8ada8ab37b2ce9e7b66dd5a39cdae/chrome/browser/ui/cocoa/tab_dialogs_cocoa.h
[delete] https://crrev.com/fbe67a9526a8ada8ab37b2ce9e7b66dd5a39cdae/chrome/browser/ui/cocoa/tab_dialogs_cocoa.mm
[delete] https://crrev.com/fbe67a9526a8ada8ab37b2ce9e7b66dd5a39cdae/chrome/browser/ui/cocoa/tab_dialogs_views_mac.h
[delete] https://crrev.com/fbe67a9526a8ada8ab37b2ce9e7b66dd5a39cdae/chrome/browser/ui/cocoa/tab_dialogs_views_mac.mm
[modify] https://crrev.com/50439b8800226bc90259e70f2ba276ed3368be82/chrome/browser/ui/views/tab_dialogs_views.cc

Comment 27 by thakis@chromium.org, Sep 20

Blockedon: 877493

Project Member

Comment 28 by bugdroid1@chromium.org, Sep 20

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fce6f1f0b68a2a403962857e6d2ba700fd134688

commit fce6f1f0b68a2a403962857e6d2ba700fd134688
Author: Nico Weber <thakis@chromium.org>
Date: Thu Sep 20 21:01:29 2018

mac: Remove unused cocoa bookmarks code.

Bug: 832676
Change-Id: I7a307c33ad6daf44cc2c170829f03cfdc488da4b
Reviewed-on: https://chromium-review.googlesource.com/1236177
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592940}
[modify] https://crrev.com/fce6f1f0b68a2a403962857e6d2ba700fd134688/chrome/app/nibs/BUILD.gn
[delete] https://crrev.com/380c495c6833ae299647151b5a918ff49cef12bc/chrome/app/nibs/BookmarkBarFolderWindow.xib
[modify] https://crrev.com/fce6f1f0b68a2a403962857e6d2ba700fd134688/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/fce6f1f0b68a2a403962857e6d2ba700fd134688/chrome/browser/ui/bookmarks/bookmark_drag_drop.h
[delete] https://crrev.com/380c495c6833ae299647151b5a918ff49cef12bc/chrome/browser/ui/cocoa/bookmarks/OWNERS
[delete] https://crrev.com/380c495c6833ae299647151b5a918ff49cef12bc/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_bridge.h
[delete] https://crrev.com/380c495c6833ae299647151b5a918ff49cef12bc/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_bridge.mm
[delete] https://crrev.com/380c495c6833ae299647151b5a918ff49cef12bc/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_bridge_unittest.mm
[delete] https://crrev.com/380c495c6833ae299647151b5a918ff49cef12bc/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_constants.h
[delete] https://crrev.com/380c495c6833ae299647151b5a918ff49cef12bc/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.h
[delete] https://crrev.com/380c495c6833ae299647151b5a918ff49cef12bc/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm
[delete] https://crrev.com/380c495c6833ae299647151b5a918ff49cef12bc/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller_unittest.mm
[delete] https://crrev.com/380c495c6833ae299647151b5a918ff49cef12bc/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_button_cell.h
[delete] https://crrev.com/380c495c6833ae299647151b5a918ff49cef12bc/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_button_cell.mm
[delete] https://crrev.com/380c495c6833ae299647151b5a918ff49cef12bc/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_button_cell_unittest.mm
[delete] https://crrev.com/380c495c6833ae299647151b5a918ff49cef12bc/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller.h
[delete] https://crrev.com/380c495c6833ae299647151b5a918ff49cef12bc/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller.mm
[delete] https://crrev.com/380c495c6833ae299647151b5a918ff49cef12bc/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller_unittest.mm
[delete] https://crrev.com/380c495c6833ae299647151b5a918ff49cef12bc/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_hover_state.h
[delete] https://crrev.com/380c495c6833ae299647151b5a918ff49cef12bc/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_hover_state.mm
[delete] https://crrev.com/380c495c6833ae299647151b5a918ff49cef12bc/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_hover_state_unittest.mm
[delete] https://crrev.com/380c495c6833ae299647151b5a918ff49cef12bc/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_view.h
[delete] https://crrev.com/380c495c6833ae299647151b5a918ff49cef12bc/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_view.mm
[delete] https://crrev.com/380c495c6833ae299647151b5a918ff49cef12bc/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_view_unittest.mm
[delete] https://crrev.com/380c495c6833ae299647151b5a918ff49cef12bc/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_window.h
[delete] https://crrev.com/380c495c6833ae299647151b5a918ff49cef12bc/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_window.mm
[delete] https://crrev.com/380c495c6833ae299647151b5a918ff49cef12bc/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_window_unittest.mm
[delete] https://crrev.com/380c495c6833ae299647151b5a918ff49cef12bc/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_state.h
[delete] https://crrev.com/380c495c6833ae299647151b5a918ff49cef12bc/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_toolbar_view.h
[delete] https://crrev.com/380c495c6833ae299647151b5a918ff49cef12bc/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_toolbar_view.mm
[delete] https://crrev.com/380c495c6833ae299647151b5a918ff49cef12bc/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_toolbar_view_unittest.mm
[delete] https://crrev.com/380c495c6833ae299647151b5a918ff49cef12bc/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_unittest_helper.h
[delete] https://crrev.com/380c495c6833ae299647151b5a918ff49cef12bc/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_unittest_helper.mm
[delete] https://crrev.com/380c495c6833ae299647151b5a918ff49cef12bc/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_util.h
[delete] https://crrev.com/380c495c6833ae299647151b5a918ff49cef12bc/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_util.mm
[delete] https://crrev.com/380c495c6833ae299647151b5a918ff49cef12bc/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_view_cocoa.h
[delete] https://crrev.com/380c495c6833ae299647151b5a918ff49cef12bc/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_view_cocoa.mm
[delete] https://crrev.com/380c495c6833ae299647151b5a918ff49cef12bc/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_view_cocoa_unittest.mm
[delete] https://crrev.com/380c495c6833ae299647151b5a918ff49cef12bc/chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_observer_cocoa.h
[delete] https://crrev.com/380c495c6833ae299647151b5a918ff49cef12bc/chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_observer_cocoa.mm
[delete] https://crrev.com/380c495c6833ae299647151b5a918ff49cef12bc/chrome/browser/ui/cocoa/bookmarks/bookmark_button.h
[delete] https://crrev.com/380c495c6833ae299647151b5a918ff49cef12bc/chrome/browser/ui/cocoa/bookmarks/bookmark_button.mm
[delete] https://crrev.com/380c495c6833ae299647151b5a918ff49cef12bc/chrome/browser/ui/cocoa/bookmarks/bookmark_button_cell.h
[delete] https://crrev.com/380c495c6833ae299647151b5a918ff49cef12bc/chrome/browser/ui/cocoa/bookmarks/bookmark_button_cell.mm
[delete] https://crrev.com/380c495c6833ae299647151b5a918ff49cef12bc/chrome/browser/ui/cocoa/bookmarks/bookmark_button_cell_unittest.mm
[delete] https://crrev.com/380c495c6833ae299647151b5a918ff49cef12bc/chrome/browser/ui/cocoa/bookmarks/bookmark_button_unittest.mm
[delete] https://crrev.com/380c495c6833ae299647151b5a918ff49cef12bc/chrome/browser/ui/cocoa/bookmarks/bookmark_context_menu_cocoa_controller.h
[delete] https://crrev.com/380c495c6833ae299647151b5a918ff49cef12bc/chrome/browser/ui/cocoa/bookmarks/bookmark_context_menu_cocoa_controller.mm
[delete] https://crrev.com/380c495c6833ae299647151b5a918ff49cef12bc/chrome/browser/ui/cocoa/bookmarks/bookmark_drag_drop_cocoa.mm
[delete] https://crrev.com/380c495c6833ae299647151b5a918ff49cef12bc/chrome/browser/ui/cocoa/bookmarks/bookmark_folder_target.h
[delete] https://crrev.com/380c495c6833ae299647151b5a918ff49cef12bc/chrome/browser/ui/cocoa/bookmarks/bookmark_folder_target.mm
[delete] https://crrev.com/380c495c6833ae299647151b5a918ff49cef12bc/chrome/browser/ui/cocoa/bookmarks/bookmark_folder_target_unittest.mm
[delete] https://crrev.com/380c495c6833ae299647151b5a918ff49cef12bc/chrome/browser/ui/cocoa/bookmarks/bookmark_model_observer_for_cocoa.h
[delete] https://crrev.com/380c495c6833ae299647151b5a918ff49cef12bc/chrome/browser/ui/cocoa/bookmarks/bookmark_model_observer_for_cocoa.mm
[delete] https://crrev.com/380c495c6833ae299647151b5a918ff49cef12bc/chrome/browser/ui/cocoa/bookmarks/bookmark_model_observer_for_cocoa_unittest.mm
[delete] https://crrev.com/380c495c6833ae299647151b5a918ff49cef12bc/chrome/browser/ui/cocoa/bookmarks/bookmark_tree_browser_cell.h
[delete] https://crrev.com/380c495c6833ae299647151b5a918ff49cef12bc/chrome/browser/ui/cocoa/bookmarks/bookmark_tree_browser_cell.mm
[delete] https://crrev.com/380c495c6833ae299647151b5a918ff49cef12bc/chrome/browser/ui/cocoa/bookmarks/bookmark_tree_browser_cell_unittest.mm
[modify] https://crrev.com/fce6f1f0b68a2a403962857e6d2ba700fd134688/chrome/browser/ui/cocoa/browser_window_cocoa.h
[modify] https://crrev.com/fce6f1f0b68a2a403962857e6d2ba700fd134688/chrome/browser/ui/cocoa/browser_window_cocoa.mm
[modify] https://crrev.com/fce6f1f0b68a2a403962857e6d2ba700fd134688/chrome/browser/ui/cocoa/browser_window_cocoa_unittest.mm
[modify] https://crrev.com/fce6f1f0b68a2a403962857e6d2ba700fd134688/chrome/browser/ui/cocoa/browser_window_controller.h
[modify] https://crrev.com/fce6f1f0b68a2a403962857e6d2ba700fd134688/chrome/browser/ui/cocoa/browser_window_controller.mm
[modify] https://crrev.com/fce6f1f0b68a2a403962857e6d2ba700fd134688/chrome/browser/ui/cocoa/browser_window_controller_browsertest.mm
[modify] https://crrev.com/fce6f1f0b68a2a403962857e6d2ba700fd134688/chrome/browser/ui/cocoa/browser_window_controller_private.mm
[modify] https://crrev.com/fce6f1f0b68a2a403962857e6d2ba700fd134688/chrome/browser/ui/cocoa/browser_window_controller_unittest.mm
[modify] https://crrev.com/fce6f1f0b68a2a403962857e6d2ba700fd134688/chrome/browser/ui/cocoa/location_bar/page_info_bubble_decoration.mm
[modify] https://crrev.com/fce6f1f0b68a2a403962857e6d2ba700fd134688/chrome/browser/ui/cocoa/location_bar/zoom_decoration.mm
[modify] https://crrev.com/fce6f1f0b68a2a403962857e6d2ba700fd134688/chrome/browser/ui/cocoa/toolbar/toolbar_controller_unittest.mm
[modify] https://crrev.com/fce6f1f0b68a2a403962857e6d2ba700fd134688/chrome/browser/ui/views/bookmarks/bookmark_drag_drop_views.cc
[modify] https://crrev.com/fce6f1f0b68a2a403962857e6d2ba700fd134688/chrome/test/BUILD.gn

Project Member

Comment 29 by bugdroid1@chromium.org, Sep 21

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/71f80c9ee078aba47a06bfd032a88ced4f77db1f

commit 71f80c9ee078aba47a06bfd032a88ced4f77db1f
Author: Taiju Tsuiki <tzik@chromium.org>
Date: Fri Sep 21 04:56:45 2018

Revert "mac: Remove unused cocoa bookmarks code."

This reverts commit fce6f1f0b68a2a403962857e6d2ba700fd134688.

Reason for revert:
Mac bots start failing after this on ZoomDecorationTest.
Logs are:
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.12%20Tests/15388
https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8934822664204431200/+/steps/browser_tests_on__none__GPU_on_Mac_on_Mac-10.12.6/0/logs/ZoomDecorationTest.BubbleAtDefaultZoom__x2f_1/0

Original change's description:
> mac: Remove unused cocoa bookmarks code.
> 
> Bug: 832676
> Change-Id: I7a307c33ad6daf44cc2c170829f03cfdc488da4b
> Reviewed-on: https://chromium-review.googlesource.com/1236177
> Reviewed-by: Robert Sesek <rsesek@chromium.org>
> Commit-Queue: Nico Weber <thakis@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#592940}

TBR=ellyjones@chromium.org,thakis@chromium.org,rsesek@chromium.org

Change-Id: I5cee6336950065ba9ba0053334892092d2ebe308
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 832676
Reviewed-on: https://chromium-review.googlesource.com/1238033
Reviewed-by: Taiju Tsuiki <tzik@chromium.org>
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593079}
[modify] https://crrev.com/71f80c9ee078aba47a06bfd032a88ced4f77db1f/chrome/app/nibs/BUILD.gn
[add] https://crrev.com/71f80c9ee078aba47a06bfd032a88ced4f77db1f/chrome/app/nibs/BookmarkBarFolderWindow.xib
[modify] https://crrev.com/71f80c9ee078aba47a06bfd032a88ced4f77db1f/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/71f80c9ee078aba47a06bfd032a88ced4f77db1f/chrome/browser/ui/bookmarks/bookmark_drag_drop.h
[add] https://crrev.com/71f80c9ee078aba47a06bfd032a88ced4f77db1f/chrome/browser/ui/cocoa/bookmarks/OWNERS
[add] https://crrev.com/71f80c9ee078aba47a06bfd032a88ced4f77db1f/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_bridge.h
[add] https://crrev.com/71f80c9ee078aba47a06bfd032a88ced4f77db1f/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_bridge.mm
[add] https://crrev.com/71f80c9ee078aba47a06bfd032a88ced4f77db1f/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_bridge_unittest.mm
[add] https://crrev.com/71f80c9ee078aba47a06bfd032a88ced4f77db1f/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_constants.h
[add] https://crrev.com/71f80c9ee078aba47a06bfd032a88ced4f77db1f/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.h
[add] https://crrev.com/71f80c9ee078aba47a06bfd032a88ced4f77db1f/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm
[add] https://crrev.com/71f80c9ee078aba47a06bfd032a88ced4f77db1f/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller_unittest.mm
[add] https://crrev.com/71f80c9ee078aba47a06bfd032a88ced4f77db1f/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_button_cell.h
[add] https://crrev.com/71f80c9ee078aba47a06bfd032a88ced4f77db1f/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_button_cell.mm
[add] https://crrev.com/71f80c9ee078aba47a06bfd032a88ced4f77db1f/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_button_cell_unittest.mm
[add] https://crrev.com/71f80c9ee078aba47a06bfd032a88ced4f77db1f/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller.h
[add] https://crrev.com/71f80c9ee078aba47a06bfd032a88ced4f77db1f/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller.mm
[add] https://crrev.com/71f80c9ee078aba47a06bfd032a88ced4f77db1f/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller_unittest.mm
[add] https://crrev.com/71f80c9ee078aba47a06bfd032a88ced4f77db1f/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_hover_state.h
[add] https://crrev.com/71f80c9ee078aba47a06bfd032a88ced4f77db1f/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_hover_state.mm
[add] https://crrev.com/71f80c9ee078aba47a06bfd032a88ced4f77db1f/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_hover_state_unittest.mm
[add] https://crrev.com/71f80c9ee078aba47a06bfd032a88ced4f77db1f/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_view.h
[add] https://crrev.com/71f80c9ee078aba47a06bfd032a88ced4f77db1f/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_view.mm
[add] https://crrev.com/71f80c9ee078aba47a06bfd032a88ced4f77db1f/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_view_unittest.mm
[add] https://crrev.com/71f80c9ee078aba47a06bfd032a88ced4f77db1f/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_window.h
[add] https://crrev.com/71f80c9ee078aba47a06bfd032a88ced4f77db1f/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_window.mm
[add] https://crrev.com/71f80c9ee078aba47a06bfd032a88ced4f77db1f/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_window_unittest.mm
[add] https://crrev.com/71f80c9ee078aba47a06bfd032a88ced4f77db1f/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_state.h
[add] https://crrev.com/71f80c9ee078aba47a06bfd032a88ced4f77db1f/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_toolbar_view.h
[add] https://crrev.com/71f80c9ee078aba47a06bfd032a88ced4f77db1f/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_toolbar_view.mm
[add] https://crrev.com/71f80c9ee078aba47a06bfd032a88ced4f77db1f/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_toolbar_view_unittest.mm
[add] https://crrev.com/71f80c9ee078aba47a06bfd032a88ced4f77db1f/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_unittest_helper.h
[add] https://crrev.com/71f80c9ee078aba47a06bfd032a88ced4f77db1f/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_unittest_helper.mm
[add] https://crrev.com/71f80c9ee078aba47a06bfd032a88ced4f77db1f/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_util.h
[add] https://crrev.com/71f80c9ee078aba47a06bfd032a88ced4f77db1f/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_util.mm
[add] https://crrev.com/71f80c9ee078aba47a06bfd032a88ced4f77db1f/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_view_cocoa.h
[add] https://crrev.com/71f80c9ee078aba47a06bfd032a88ced4f77db1f/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_view_cocoa.mm
[add] https://crrev.com/71f80c9ee078aba47a06bfd032a88ced4f77db1f/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_view_cocoa_unittest.mm
[add] https://crrev.com/71f80c9ee078aba47a06bfd032a88ced4f77db1f/chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_observer_cocoa.h
[add] https://crrev.com/71f80c9ee078aba47a06bfd032a88ced4f77db1f/chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_observer_cocoa.mm
[add] https://crrev.com/71f80c9ee078aba47a06bfd032a88ced4f77db1f/chrome/browser/ui/cocoa/bookmarks/bookmark_button.h
[add] https://crrev.com/71f80c9ee078aba47a06bfd032a88ced4f77db1f/chrome/browser/ui/cocoa/bookmarks/bookmark_button.mm
[add] https://crrev.com/71f80c9ee078aba47a06bfd032a88ced4f77db1f/chrome/browser/ui/cocoa/bookmarks/bookmark_button_cell.h
[add] https://crrev.com/71f80c9ee078aba47a06bfd032a88ced4f77db1f/chrome/browser/ui/cocoa/bookmarks/bookmark_button_cell.mm
[add] https://crrev.com/71f80c9ee078aba47a06bfd032a88ced4f77db1f/chrome/browser/ui/cocoa/bookmarks/bookmark_button_cell_unittest.mm
[add] https://crrev.com/71f80c9ee078aba47a06bfd032a88ced4f77db1f/chrome/browser/ui/cocoa/bookmarks/bookmark_button_unittest.mm
[add] https://crrev.com/71f80c9ee078aba47a06bfd032a88ced4f77db1f/chrome/browser/ui/cocoa/bookmarks/bookmark_context_menu_cocoa_controller.h
[add] https://crrev.com/71f80c9ee078aba47a06bfd032a88ced4f77db1f/chrome/browser/ui/cocoa/bookmarks/bookmark_context_menu_cocoa_controller.mm
[add] https://crrev.com/71f80c9ee078aba47a06bfd032a88ced4f77db1f/chrome/browser/ui/cocoa/bookmarks/bookmark_drag_drop_cocoa.mm
[add] https://crrev.com/71f80c9ee078aba47a06bfd032a88ced4f77db1f/chrome/browser/ui/cocoa/bookmarks/bookmark_folder_target.h
[add] https://crrev.com/71f80c9ee078aba47a06bfd032a88ced4f77db1f/chrome/browser/ui/cocoa/bookmarks/bookmark_folder_target.mm
[add] https://crrev.com/71f80c9ee078aba47a06bfd032a88ced4f77db1f/chrome/browser/ui/cocoa/bookmarks/bookmark_folder_target_unittest.mm
[add] https://crrev.com/71f80c9ee078aba47a06bfd032a88ced4f77db1f/chrome/browser/ui/cocoa/bookmarks/bookmark_model_observer_for_cocoa.h
[add] https://crrev.com/71f80c9ee078aba47a06bfd032a88ced4f77db1f/chrome/browser/ui/cocoa/bookmarks/bookmark_model_observer_for_cocoa.mm
[add] https://crrev.com/71f80c9ee078aba47a06bfd032a88ced4f77db1f/chrome/browser/ui/cocoa/bookmarks/bookmark_model_observer_for_cocoa_unittest.mm
[add] https://crrev.com/71f80c9ee078aba47a06bfd032a88ced4f77db1f/chrome/browser/ui/cocoa/bookmarks/bookmark_tree_browser_cell.h
[add] https://crrev.com/71f80c9ee078aba47a06bfd032a88ced4f77db1f/chrome/browser/ui/cocoa/bookmarks/bookmark_tree_browser_cell.mm
[add] https://crrev.com/71f80c9ee078aba47a06bfd032a88ced4f77db1f/chrome/browser/ui/cocoa/bookmarks/bookmark_tree_browser_cell_unittest.mm
[modify] https://crrev.com/71f80c9ee078aba47a06bfd032a88ced4f77db1f/chrome/browser/ui/cocoa/browser_window_cocoa.h
[modify] https://crrev.com/71f80c9ee078aba47a06bfd032a88ced4f77db1f/chrome/browser/ui/cocoa/browser_window_cocoa.mm
[modify] https://crrev.com/71f80c9ee078aba47a06bfd032a88ced4f77db1f/chrome/browser/ui/cocoa/browser_window_cocoa_unittest.mm
[modify] https://crrev.com/71f80c9ee078aba47a06bfd032a88ced4f77db1f/chrome/browser/ui/cocoa/browser_window_controller.h
[modify] https://crrev.com/71f80c9ee078aba47a06bfd032a88ced4f77db1f/chrome/browser/ui/cocoa/browser_window_controller.mm
[modify] https://crrev.com/71f80c9ee078aba47a06bfd032a88ced4f77db1f/chrome/browser/ui/cocoa/browser_window_controller_browsertest.mm
[modify] https://crrev.com/71f80c9ee078aba47a06bfd032a88ced4f77db1f/chrome/browser/ui/cocoa/browser_window_controller_private.mm
[modify] https://crrev.com/71f80c9ee078aba47a06bfd032a88ced4f77db1f/chrome/browser/ui/cocoa/browser_window_controller_unittest.mm
[modify] https://crrev.com/71f80c9ee078aba47a06bfd032a88ced4f77db1f/chrome/browser/ui/cocoa/location_bar/page_info_bubble_decoration.mm
[modify] https://crrev.com/71f80c9ee078aba47a06bfd032a88ced4f77db1f/chrome/browser/ui/cocoa/location_bar/zoom_decoration.mm
[modify] https://crrev.com/71f80c9ee078aba47a06bfd032a88ced4f77db1f/chrome/browser/ui/cocoa/toolbar/toolbar_controller_unittest.mm
[modify] https://crrev.com/71f80c9ee078aba47a06bfd032a88ced4f77db1f/chrome/browser/ui/views/bookmarks/bookmark_drag_drop_views.cc
[modify] https://crrev.com/71f80c9ee078aba47a06bfd032a88ced4f77db1f/chrome/test/BUILD.gn

Project Member

Comment 30 by bugdroid1@chromium.org, Sep 21

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8e5ef2403719cfde60ed30e5078719813203661f

commit 8e5ef2403719cfde60ed30e5078719813203661f
Author: Taiju Tsuiki <tzik@chromium.org>
Date: Fri Sep 21 05:33:26 2018

Revert "mac: Remove unused TabDialogsMac/TabDialogsCocoa."

This reverts commit 50439b8800226bc90259e70f2ba276ed3368be82.

Reason for revert:
Mac bots start failing after this CL on HungRendererControllerTest.
The error logs are below.
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.11%20Tests/29038
https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8934838111834185888/+/steps/unit_tests_on__none__GPU_on_Mac_on_Mac-10.11/0/logs/HungRendererControllerTest.TestKillButton/0

Original change's description:
> mac: Remove unused TabDialogsMac/TabDialogsCocoa.
> 
> Bug: 832676
> Change-Id: I0fb8d4b1f0197dab0b988a52741724f63a18ee9f
> Reviewed-on: https://chromium-review.googlesource.com/1236178
> Commit-Queue: Nico Weber <thakis@chromium.org>
> Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#592819}

TBR=ellyjones@chromium.org,thakis@chromium.org

Change-Id: I6554e741ef31bc99da0c90e3c4fd2bb8826a741f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 832676
Reviewed-on: https://chromium-review.googlesource.com/1237797
Reviewed-by: Taiju Tsuiki <tzik@chromium.org>
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593085}
[modify] https://crrev.com/8e5ef2403719cfde60ed30e5078719813203661f/chrome/app/nibs/BUILD.gn
[add] https://crrev.com/8e5ef2403719cfde60ed30e5078719813203661f/chrome/app/nibs/HungRendererDialog.xib
[modify] https://crrev.com/8e5ef2403719cfde60ed30e5078719813203661f/chrome/browser/ui/BUILD.gn
[add] https://crrev.com/8e5ef2403719cfde60ed30e5078719813203661f/chrome/browser/ui/cocoa/tab_dialogs_cocoa.h
[add] https://crrev.com/8e5ef2403719cfde60ed30e5078719813203661f/chrome/browser/ui/cocoa/tab_dialogs_cocoa.mm
[add] https://crrev.com/8e5ef2403719cfde60ed30e5078719813203661f/chrome/browser/ui/cocoa/tab_dialogs_views_mac.h
[add] https://crrev.com/8e5ef2403719cfde60ed30e5078719813203661f/chrome/browser/ui/cocoa/tab_dialogs_views_mac.mm
[modify] https://crrev.com/8e5ef2403719cfde60ed30e5078719813203661f/chrome/browser/ui/views/tab_dialogs_views.cc

Project Member

Comment 31 by bugdroid1@chromium.org, Sep 21

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1c01cc7dde2502d943f02e95258b5487b3c7de34

commit 1c01cc7dde2502d943f02e95258b5487b3c7de34
Author: Nico Weber <thakis@chromium.org>
Date: Fri Sep 21 12:02:37 2018

Reland "mac: Remove unused cocoa bookmarks code."

This reverts commit 71f80c9ee078aba47a06bfd032a88ced4f77db1f.

Reason for revert: Relanding with failing test (which tests more
unused code) removed.

Original change's description:
> Revert "mac: Remove unused cocoa bookmarks code."
> 
> This reverts commit fce6f1f0b68a2a403962857e6d2ba700fd134688.
> 
> Reason for revert:
> Mac bots start failing after this on ZoomDecorationTest.
> Logs are:
> https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.12%20Tests/15388
> https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8934822664204431200/+/steps/browser_tests_on__none__GPU_on_Mac_on_Mac-10.12.6/0/logs/ZoomDecorationTest.BubbleAtDefaultZoom__x2f_1/0
> 
> Original change's description:
> > mac: Remove unused cocoa bookmarks code.
> > 
> > Bug: 832676
> > Change-Id: I7a307c33ad6daf44cc2c170829f03cfdc488da4b
> > Reviewed-on: https://chromium-review.googlesource.com/1236177
> > Reviewed-by: Robert Sesek <rsesek@chromium.org>
> > Commit-Queue: Nico Weber <thakis@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#592940}
> 
> TBR=ellyjones@chromium.org,thakis@chromium.org,rsesek@chromium.org
> 
> Change-Id: I5cee6336950065ba9ba0053334892092d2ebe308
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 832676
> Reviewed-on: https://chromium-review.googlesource.com/1238033
> Reviewed-by: Taiju Tsuiki <tzik@chromium.org>
> Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#593079}

TBR=ellyjones@chromium.org,thakis@chromium.org,rsesek@chromium.org,tzik@chromium.org

Change-Id: Iefa37fb9c3c4aec4d885ace2fd2053f803e27d33
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 832676
Reviewed-on: https://chromium-review.googlesource.com/1238593
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593152}
[modify] https://crrev.com/1c01cc7dde2502d943f02e95258b5487b3c7de34/chrome/app/nibs/BUILD.gn
[delete] https://crrev.com/8569fdafae0801419c94801fe96836744cfd1df1/chrome/app/nibs/BookmarkBarFolderWindow.xib
[modify] https://crrev.com/1c01cc7dde2502d943f02e95258b5487b3c7de34/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/1c01cc7dde2502d943f02e95258b5487b3c7de34/chrome/browser/ui/bookmarks/bookmark_drag_drop.h
[delete] https://crrev.com/8569fdafae0801419c94801fe96836744cfd1df1/chrome/browser/ui/cocoa/bookmarks/OWNERS
[delete] https://crrev.com/8569fdafae0801419c94801fe96836744cfd1df1/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_bridge.h
[delete] https://crrev.com/8569fdafae0801419c94801fe96836744cfd1df1/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_bridge.mm
[delete] https://crrev.com/8569fdafae0801419c94801fe96836744cfd1df1/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_bridge_unittest.mm
[delete] https://crrev.com/8569fdafae0801419c94801fe96836744cfd1df1/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_constants.h
[delete] https://crrev.com/8569fdafae0801419c94801fe96836744cfd1df1/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.h
[delete] https://crrev.com/8569fdafae0801419c94801fe96836744cfd1df1/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm
[delete] https://crrev.com/8569fdafae0801419c94801fe96836744cfd1df1/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller_unittest.mm
[delete] https://crrev.com/8569fdafae0801419c94801fe96836744cfd1df1/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_button_cell.h
[delete] https://crrev.com/8569fdafae0801419c94801fe96836744cfd1df1/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_button_cell.mm
[delete] https://crrev.com/8569fdafae0801419c94801fe96836744cfd1df1/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_button_cell_unittest.mm
[delete] https://crrev.com/8569fdafae0801419c94801fe96836744cfd1df1/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller.h
[delete] https://crrev.com/8569fdafae0801419c94801fe96836744cfd1df1/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller.mm
[delete] https://crrev.com/8569fdafae0801419c94801fe96836744cfd1df1/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller_unittest.mm
[delete] https://crrev.com/8569fdafae0801419c94801fe96836744cfd1df1/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_hover_state.h
[delete] https://crrev.com/8569fdafae0801419c94801fe96836744cfd1df1/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_hover_state.mm
[delete] https://crrev.com/8569fdafae0801419c94801fe96836744cfd1df1/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_hover_state_unittest.mm
[delete] https://crrev.com/8569fdafae0801419c94801fe96836744cfd1df1/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_view.h
[delete] https://crrev.com/8569fdafae0801419c94801fe96836744cfd1df1/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_view.mm
[delete] https://crrev.com/8569fdafae0801419c94801fe96836744cfd1df1/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_view_unittest.mm
[delete] https://crrev.com/8569fdafae0801419c94801fe96836744cfd1df1/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_window.h
[delete] https://crrev.com/8569fdafae0801419c94801fe96836744cfd1df1/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_window.mm
[delete] https://crrev.com/8569fdafae0801419c94801fe96836744cfd1df1/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_window_unittest.mm
[delete] https://crrev.com/8569fdafae0801419c94801fe96836744cfd1df1/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_state.h
[delete] https://crrev.com/8569fdafae0801419c94801fe96836744cfd1df1/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_toolbar_view.h
[delete] https://crrev.com/8569fdafae0801419c94801fe96836744cfd1df1/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_toolbar_view.mm
[delete] https://crrev.com/8569fdafae0801419c94801fe96836744cfd1df1/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_toolbar_view_unittest.mm
[delete] https://crrev.com/8569fdafae0801419c94801fe96836744cfd1df1/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_unittest_helper.h
[delete] https://crrev.com/8569fdafae0801419c94801fe96836744cfd1df1/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_unittest_helper.mm
[delete] https://crrev.com/8569fdafae0801419c94801fe96836744cfd1df1/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_util.h
[delete] https://crrev.com/8569fdafae0801419c94801fe96836744cfd1df1/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_util.mm
[delete] https://crrev.com/8569fdafae0801419c94801fe96836744cfd1df1/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_view_cocoa.h
[delete] https://crrev.com/8569fdafae0801419c94801fe96836744cfd1df1/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_view_cocoa.mm
[delete] https://crrev.com/8569fdafae0801419c94801fe96836744cfd1df1/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_view_cocoa_unittest.mm
[delete] https://crrev.com/8569fdafae0801419c94801fe96836744cfd1df1/chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_observer_cocoa.h
[delete] https://crrev.com/8569fdafae0801419c94801fe96836744cfd1df1/chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_observer_cocoa.mm
[delete] https://crrev.com/8569fdafae0801419c94801fe96836744cfd1df1/chrome/browser/ui/cocoa/bookmarks/bookmark_button.h
[delete] https://crrev.com/8569fdafae0801419c94801fe96836744cfd1df1/chrome/browser/ui/cocoa/bookmarks/bookmark_button.mm
[delete] https://crrev.com/8569fdafae0801419c94801fe96836744cfd1df1/chrome/browser/ui/cocoa/bookmarks/bookmark_button_cell.h
[delete] https://crrev.com/8569fdafae0801419c94801fe96836744cfd1df1/chrome/browser/ui/cocoa/bookmarks/bookmark_button_cell.mm
[delete] https://crrev.com/8569fdafae0801419c94801fe96836744cfd1df1/chrome/browser/ui/cocoa/bookmarks/bookmark_button_cell_unittest.mm
[delete] https://crrev.com/8569fdafae0801419c94801fe96836744cfd1df1/chrome/browser/ui/cocoa/bookmarks/bookmark_button_unittest.mm
[delete] https://crrev.com/8569fdafae0801419c94801fe96836744cfd1df1/chrome/browser/ui/cocoa/bookmarks/bookmark_context_menu_cocoa_controller.h
[delete] https://crrev.com/8569fdafae0801419c94801fe96836744cfd1df1/chrome/browser/ui/cocoa/bookmarks/bookmark_context_menu_cocoa_controller.mm
[delete] https://crrev.com/8569fdafae0801419c94801fe96836744cfd1df1/chrome/browser/ui/cocoa/bookmarks/bookmark_drag_drop_cocoa.mm
[delete] https://crrev.com/8569fdafae0801419c94801fe96836744cfd1df1/chrome/browser/ui/cocoa/bookmarks/bookmark_folder_target.h
[delete] https://crrev.com/8569fdafae0801419c94801fe96836744cfd1df1/chrome/browser/ui/cocoa/bookmarks/bookmark_folder_target.mm
[delete] https://crrev.com/8569fdafae0801419c94801fe96836744cfd1df1/chrome/browser/ui/cocoa/bookmarks/bookmark_folder_target_unittest.mm
[delete] https://crrev.com/8569fdafae0801419c94801fe96836744cfd1df1/chrome/browser/ui/cocoa/bookmarks/bookmark_model_observer_for_cocoa.h
[delete] https://crrev.com/8569fdafae0801419c94801fe96836744cfd1df1/chrome/browser/ui/cocoa/bookmarks/bookmark_model_observer_for_cocoa.mm
[delete] https://crrev.com/8569fdafae0801419c94801fe96836744cfd1df1/chrome/browser/ui/cocoa/bookmarks/bookmark_model_observer_for_cocoa_unittest.mm
[delete] https://crrev.com/8569fdafae0801419c94801fe96836744cfd1df1/chrome/browser/ui/cocoa/bookmarks/bookmark_tree_browser_cell.h
[delete] https://crrev.com/8569fdafae0801419c94801fe96836744cfd1df1/chrome/browser/ui/cocoa/bookmarks/bookmark_tree_browser_cell.mm
[delete] https://crrev.com/8569fdafae0801419c94801fe96836744cfd1df1/chrome/browser/ui/cocoa/bookmarks/bookmark_tree_browser_cell_unittest.mm
[modify] https://crrev.com/1c01cc7dde2502d943f02e95258b5487b3c7de34/chrome/browser/ui/cocoa/browser_window_cocoa.h
[modify] https://crrev.com/1c01cc7dde2502d943f02e95258b5487b3c7de34/chrome/browser/ui/cocoa/browser_window_cocoa.mm
[modify] https://crrev.com/1c01cc7dde2502d943f02e95258b5487b3c7de34/chrome/browser/ui/cocoa/browser_window_cocoa_unittest.mm
[modify] https://crrev.com/1c01cc7dde2502d943f02e95258b5487b3c7de34/chrome/browser/ui/cocoa/browser_window_controller.h
[modify] https://crrev.com/1c01cc7dde2502d943f02e95258b5487b3c7de34/chrome/browser/ui/cocoa/browser_window_controller.mm
[modify] https://crrev.com/1c01cc7dde2502d943f02e95258b5487b3c7de34/chrome/browser/ui/cocoa/browser_window_controller_browsertest.mm
[modify] https://crrev.com/1c01cc7dde2502d943f02e95258b5487b3c7de34/chrome/browser/ui/cocoa/browser_window_controller_private.mm
[modify] https://crrev.com/1c01cc7dde2502d943f02e95258b5487b3c7de34/chrome/browser/ui/cocoa/browser_window_controller_unittest.mm
[modify] https://crrev.com/1c01cc7dde2502d943f02e95258b5487b3c7de34/chrome/browser/ui/cocoa/location_bar/page_info_bubble_decoration.mm
[modify] https://crrev.com/1c01cc7dde2502d943f02e95258b5487b3c7de34/chrome/browser/ui/cocoa/location_bar/zoom_decoration.mm
[modify] https://crrev.com/1c01cc7dde2502d943f02e95258b5487b3c7de34/chrome/browser/ui/cocoa/location_bar/zoom_decoration_browsertest.mm
[modify] https://crrev.com/1c01cc7dde2502d943f02e95258b5487b3c7de34/chrome/browser/ui/cocoa/toolbar/toolbar_controller_unittest.mm
[modify] https://crrev.com/1c01cc7dde2502d943f02e95258b5487b3c7de34/chrome/browser/ui/views/bookmarks/bookmark_drag_drop_views.cc
[modify] https://crrev.com/1c01cc7dde2502d943f02e95258b5487b3c7de34/chrome/test/BUILD.gn

Project Member

Comment 32 by bugdroid1@chromium.org, Sep 21

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cd358850b2e954e8b1fc729376a9fb436053fc96

commit cd358850b2e954e8b1fc729376a9fb436053fc96
Author: Nico Weber <thakis@chromium.org>
Date: Fri Sep 21 18:51:01 2018

Reland "mac: Remove unused TabDialogsMac/TabDialogsCocoa."

This reverts commit 8e5ef2403719cfde60ed30e5078719813203661f.

Reason for revert: Relanding with HungRendererController removed as well.

Original change's description:
> Revert "mac: Remove unused TabDialogsMac/TabDialogsCocoa."
>
> This reverts commit 50439b8800226bc90259e70f2ba276ed3368be82.
>
> Reason for revert:
> Mac bots start failing after this CL on HungRendererControllerTest.
> The error logs are below.
> https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.11%20Tests/29038
> https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8934838111834185888/+/steps/unit_tests_on__none__GPU_on_Mac_on_Mac-10.11/0/logs/HungRendererControllerTest.TestKillButton/0
>
> Original change's description:
> > mac: Remove unused TabDialogsMac/TabDialogsCocoa.
> >
> > Bug: 832676
> > Change-Id: I0fb8d4b1f0197dab0b988a52741724f63a18ee9f
> > Reviewed-on: https://chromium-review.googlesource.com/1236178
> > Commit-Queue: Nico Weber <thakis@chromium.org>
> > Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#592819}
>
> TBR=ellyjones@chromium.org,thakis@chromium.org
>
> Change-Id: I6554e741ef31bc99da0c90e3c4fd2bb8826a741f
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 832676
> Reviewed-on: https://chromium-review.googlesource.com/1237797
> Reviewed-by: Taiju Tsuiki <tzik@chromium.org>
> Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#593085}

TBR=ellyjones@chromium.org,thakis@chromium.org,tzik@chromium.org

Change-Id: I5e076b202734c727608279952fad9d1b5657636b
Bug: 832676
Reviewed-on: https://chromium-review.googlesource.com/1238595
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593278}
[modify] https://crrev.com/cd358850b2e954e8b1fc729376a9fb436053fc96/chrome/app/nibs/BUILD.gn
[delete] https://crrev.com/a8d5a6706e1e653cecabe04a3c5373f270dd4257/chrome/app/nibs/HungRendererDialog.xib
[modify] https://crrev.com/cd358850b2e954e8b1fc729376a9fb436053fc96/chrome/browser/ui/BUILD.gn
[delete] https://crrev.com/a8d5a6706e1e653cecabe04a3c5373f270dd4257/chrome/browser/ui/cocoa/hung_renderer_controller.h
[delete] https://crrev.com/a8d5a6706e1e653cecabe04a3c5373f270dd4257/chrome/browser/ui/cocoa/hung_renderer_controller.mm
[delete] https://crrev.com/a8d5a6706e1e653cecabe04a3c5373f270dd4257/chrome/browser/ui/cocoa/hung_renderer_controller_unittest.mm
[delete] https://crrev.com/a8d5a6706e1e653cecabe04a3c5373f270dd4257/chrome/browser/ui/cocoa/tab_dialogs_cocoa.h
[delete] https://crrev.com/a8d5a6706e1e653cecabe04a3c5373f270dd4257/chrome/browser/ui/cocoa/tab_dialogs_cocoa.mm
[delete] https://crrev.com/a8d5a6706e1e653cecabe04a3c5373f270dd4257/chrome/browser/ui/cocoa/tab_dialogs_views_mac.h
[delete] https://crrev.com/a8d5a6706e1e653cecabe04a3c5373f270dd4257/chrome/browser/ui/cocoa/tab_dialogs_views_mac.mm
[modify] https://crrev.com/cd358850b2e954e8b1fc729376a9fb436053fc96/chrome/browser/ui/views/tab_dialogs_views.cc
[modify] https://crrev.com/cd358850b2e954e8b1fc729376a9fb436053fc96/chrome/test/BUILD.gn

Project Member

Comment 33 by bugdroid1@chromium.org, Sep 21

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dd3845f19e26297e67212ed27befde58b1b4419c

commit dd3845f19e26297e67212ed27befde58b1b4419c
Author: Nico Weber <thakis@chromium.org>
Date: Fri Sep 21 22:36:31 2018

mac: Remove unused cocoa find_bar code.

Bug: 832676
Change-Id: Ia5a1810b329d05e9357376cf00ac3f7d144ee96a
Reviewed-on: https://chromium-review.googlesource.com/1237454
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593359}
[modify] https://crrev.com/dd3845f19e26297e67212ed27befde58b1b4419c/chrome/app/nibs/BUILD.gn
[delete] https://crrev.com/cebf2f90188ece398542dca4da341d49da659398/chrome/app/nibs/FindBar.xib
[modify] https://crrev.com/dd3845f19e26297e67212ed27befde58b1b4419c/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/dd3845f19e26297e67212ed27befde58b1b4419c/chrome/browser/ui/cocoa/browser_window_cocoa.h
[modify] https://crrev.com/dd3845f19e26297e67212ed27befde58b1b4419c/chrome/browser/ui/cocoa/browser_window_cocoa.mm
[modify] https://crrev.com/dd3845f19e26297e67212ed27befde58b1b4419c/chrome/browser/ui/cocoa/browser_window_controller.h
[modify] https://crrev.com/dd3845f19e26297e67212ed27befde58b1b4419c/chrome/browser/ui/cocoa/browser_window_controller.mm
[modify] https://crrev.com/dd3845f19e26297e67212ed27befde58b1b4419c/chrome/browser/ui/cocoa/browser_window_controller_browsertest.mm
[modify] https://crrev.com/dd3845f19e26297e67212ed27befde58b1b4419c/chrome/browser/ui/cocoa/browser_window_controller_private.mm
[modify] https://crrev.com/dd3845f19e26297e67212ed27befde58b1b4419c/chrome/browser/ui/cocoa/browser_window_controller_unittest.mm
[delete] https://crrev.com/cebf2f90188ece398542dca4da341d49da659398/chrome/browser/ui/cocoa/find_bar/OWNERS
[delete] https://crrev.com/cebf2f90188ece398542dca4da341d49da659398/chrome/browser/ui/cocoa/find_bar/find_bar_bridge.h
[delete] https://crrev.com/cebf2f90188ece398542dca4da341d49da659398/chrome/browser/ui/cocoa/find_bar/find_bar_bridge.mm
[delete] https://crrev.com/cebf2f90188ece398542dca4da341d49da659398/chrome/browser/ui/cocoa/find_bar/find_bar_bridge_unittest.mm
[delete] https://crrev.com/cebf2f90188ece398542dca4da341d49da659398/chrome/browser/ui/cocoa/find_bar/find_bar_browsertest.mm
[delete] https://crrev.com/cebf2f90188ece398542dca4da341d49da659398/chrome/browser/ui/cocoa/find_bar/find_bar_cocoa_controller.h
[delete] https://crrev.com/cebf2f90188ece398542dca4da341d49da659398/chrome/browser/ui/cocoa/find_bar/find_bar_cocoa_controller.mm
[delete] https://crrev.com/cebf2f90188ece398542dca4da341d49da659398/chrome/browser/ui/cocoa/find_bar/find_bar_cocoa_controller_unittest.mm
[delete] https://crrev.com/cebf2f90188ece398542dca4da341d49da659398/chrome/browser/ui/cocoa/find_bar/find_bar_host_unittest_util_cocoa.mm
[delete] https://crrev.com/cebf2f90188ece398542dca4da341d49da659398/chrome/browser/ui/cocoa/find_bar/find_bar_text_field.h
[delete] https://crrev.com/cebf2f90188ece398542dca4da341d49da659398/chrome/browser/ui/cocoa/find_bar/find_bar_text_field.mm
[delete] https://crrev.com/cebf2f90188ece398542dca4da341d49da659398/chrome/browser/ui/cocoa/find_bar/find_bar_text_field_cell.h
[delete] https://crrev.com/cebf2f90188ece398542dca4da341d49da659398/chrome/browser/ui/cocoa/find_bar/find_bar_text_field_cell.mm
[delete] https://crrev.com/cebf2f90188ece398542dca4da341d49da659398/chrome/browser/ui/cocoa/find_bar/find_bar_text_field_cell_unittest.mm
[delete] https://crrev.com/cebf2f90188ece398542dca4da341d49da659398/chrome/browser/ui/cocoa/find_bar/find_bar_text_field_unittest.mm
[delete] https://crrev.com/cebf2f90188ece398542dca4da341d49da659398/chrome/browser/ui/cocoa/find_bar/find_bar_view_cocoa.h
[delete] https://crrev.com/cebf2f90188ece398542dca4da341d49da659398/chrome/browser/ui/cocoa/find_bar/find_bar_view_cocoa.mm
[delete] https://crrev.com/cebf2f90188ece398542dca4da341d49da659398/chrome/browser/ui/cocoa/find_bar/find_bar_view_unittest.mm
[modify] https://crrev.com/dd3845f19e26297e67212ed27befde58b1b4419c/chrome/browser/ui/find_bar/find_bar_host_unittest_util.h
[modify] https://crrev.com/dd3845f19e26297e67212ed27befde58b1b4419c/chrome/browser/ui/find_bar/find_bar_platform_helper_mac_interactive_uitest.mm
[modify] https://crrev.com/dd3845f19e26297e67212ed27befde58b1b4419c/chrome/browser/ui/views/find_bar_host_unittest_util_views.cc
[modify] https://crrev.com/dd3845f19e26297e67212ed27befde58b1b4419c/chrome/test/BUILD.gn

Project Member

Comment 34 by bugdroid1@chromium.org, Sep 22

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e2e7cd911060f081cec552e230701a2366b12d0d

commit e2e7cd911060f081cec552e230701a2366b12d0d
Author: Nico Weber <thakis@chromium.org>
Date: Sat Sep 22 18:42:46 2018

mac: Remove unused GradientButtonCell.

Unused now that the cocoa find_bar code is deleted.

Bug: 832676
Change-Id: I9a29167cde164656f6e51182e50ba300fd93419d
Reviewed-on: https://chromium-review.googlesource.com/1239633
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593445}
[modify] https://crrev.com/e2e7cd911060f081cec552e230701a2366b12d0d/chrome/browser/ui/BUILD.gn
[delete] https://crrev.com/516840902587453313f53e6b0b45442bebc5b8e8/chrome/browser/ui/cocoa/gradient_button_cell.h
[delete] https://crrev.com/516840902587453313f53e6b0b45442bebc5b8e8/chrome/browser/ui/cocoa/gradient_button_cell.mm
[delete] https://crrev.com/516840902587453313f53e6b0b45442bebc5b8e8/chrome/browser/ui/cocoa/gradient_button_cell_unittest.mm
[modify] https://crrev.com/e2e7cd911060f081cec552e230701a2366b12d0d/chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm
[modify] https://crrev.com/e2e7cd911060f081cec552e230701a2366b12d0d/chrome/test/BUILD.gn

Project Member

Comment 35 by bugdroid1@chromium.org, Sep 22

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a0dec4edc9814140818cc396eaf3c15484afbbfc

commit a0dec4edc9814140818cc396eaf3c15484afbbfc
Author: Nico Weber <thakis@chromium.org>
Date: Sat Sep 22 23:00:51 2018

mac: Remove unused cocoa infobars code.

(NOPRESUBMIT because crbug.com/875886)

NOPRESUBMIT=true
TBR=blundell

Bug: 832676
Change-Id: I94367d0813b7721c6bee355343f17b0f19073a74
Reviewed-on: https://chromium-review.googlesource.com/1239021
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593448}
[modify] https://crrev.com/a0dec4edc9814140818cc396eaf3c15484afbbfc/chrome/app/nibs/BUILD.gn
[delete] https://crrev.com/fdb137a1d0a59cbc66995ee5c20ca8b675e2ac96/chrome/app/nibs/InfoBar.xib
[modify] https://crrev.com/a0dec4edc9814140818cc396eaf3c15484afbbfc/chrome/browser/infobars/infobar_service.h
[modify] https://crrev.com/a0dec4edc9814140818cc396eaf3c15484afbbfc/chrome/browser/translate/chrome_translate_client.h
[modify] https://crrev.com/a0dec4edc9814140818cc396eaf3c15484afbbfc/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/a0dec4edc9814140818cc396eaf3c15484afbbfc/chrome/browser/ui/cocoa/browser_window_controller.h
[modify] https://crrev.com/a0dec4edc9814140818cc396eaf3c15484afbbfc/chrome/browser/ui/cocoa/browser_window_controller.mm
[modify] https://crrev.com/a0dec4edc9814140818cc396eaf3c15484afbbfc/chrome/browser/ui/cocoa/browser_window_controller_browsertest.mm
[modify] https://crrev.com/a0dec4edc9814140818cc396eaf3c15484afbbfc/chrome/browser/ui/cocoa/browser_window_controller_private.mm
[modify] https://crrev.com/a0dec4edc9814140818cc396eaf3c15484afbbfc/chrome/browser/ui/cocoa/browser_window_controller_unittest.mm
[delete] https://crrev.com/fdb137a1d0a59cbc66995ee5c20ca8b675e2ac96/chrome/browser/ui/cocoa/infobars/OWNERS
[delete] https://crrev.com/fdb137a1d0a59cbc66995ee5c20ca8b675e2ac96/chrome/browser/ui/cocoa/infobars/after_translate_infobar_controller.h
[delete] https://crrev.com/fdb137a1d0a59cbc66995ee5c20ca8b675e2ac96/chrome/browser/ui/cocoa/infobars/after_translate_infobar_controller.mm
[delete] https://crrev.com/fdb137a1d0a59cbc66995ee5c20ca8b675e2ac96/chrome/browser/ui/cocoa/infobars/alternate_nav_infobar_controller.h
[delete] https://crrev.com/fdb137a1d0a59cbc66995ee5c20ca8b675e2ac96/chrome/browser/ui/cocoa/infobars/alternate_nav_infobar_controller.mm
[delete] https://crrev.com/fdb137a1d0a59cbc66995ee5c20ca8b675e2ac96/chrome/browser/ui/cocoa/infobars/before_translate_infobar_controller.h
[delete] https://crrev.com/fdb137a1d0a59cbc66995ee5c20ca8b675e2ac96/chrome/browser/ui/cocoa/infobars/before_translate_infobar_controller.mm
[delete] https://crrev.com/fdb137a1d0a59cbc66995ee5c20ca8b675e2ac96/chrome/browser/ui/cocoa/infobars/confirm_infobar_controller.h
[delete] https://crrev.com/fdb137a1d0a59cbc66995ee5c20ca8b675e2ac96/chrome/browser/ui/cocoa/infobars/confirm_infobar_controller.mm
[delete] https://crrev.com/fdb137a1d0a59cbc66995ee5c20ca8b675e2ac96/chrome/browser/ui/cocoa/infobars/confirm_infobar_controller_unittest.mm
[delete] https://crrev.com/fdb137a1d0a59cbc66995ee5c20ca8b675e2ac96/chrome/browser/ui/cocoa/infobars/infobar_background_view.h
[delete] https://crrev.com/fdb137a1d0a59cbc66995ee5c20ca8b675e2ac96/chrome/browser/ui/cocoa/infobars/infobar_background_view.mm
[delete] https://crrev.com/fdb137a1d0a59cbc66995ee5c20ca8b675e2ac96/chrome/browser/ui/cocoa/infobars/infobar_background_view_unittest.mm
[delete] https://crrev.com/fdb137a1d0a59cbc66995ee5c20ca8b675e2ac96/chrome/browser/ui/cocoa/infobars/infobar_cocoa.h
[delete] https://crrev.com/fdb137a1d0a59cbc66995ee5c20ca8b675e2ac96/chrome/browser/ui/cocoa/infobars/infobar_cocoa.mm
[delete] https://crrev.com/fdb137a1d0a59cbc66995ee5c20ca8b675e2ac96/chrome/browser/ui/cocoa/infobars/infobar_container_cocoa.h
[delete] https://crrev.com/fdb137a1d0a59cbc66995ee5c20ca8b675e2ac96/chrome/browser/ui/cocoa/infobars/infobar_container_cocoa.mm
[delete] https://crrev.com/fdb137a1d0a59cbc66995ee5c20ca8b675e2ac96/chrome/browser/ui/cocoa/infobars/infobar_container_controller.h
[delete] https://crrev.com/fdb137a1d0a59cbc66995ee5c20ca8b675e2ac96/chrome/browser/ui/cocoa/infobars/infobar_container_controller.mm
[delete] https://crrev.com/fdb137a1d0a59cbc66995ee5c20ca8b675e2ac96/chrome/browser/ui/cocoa/infobars/infobar_container_controller_unittest.mm
[delete] https://crrev.com/fdb137a1d0a59cbc66995ee5c20ca8b675e2ac96/chrome/browser/ui/cocoa/infobars/infobar_controller.h
[delete] https://crrev.com/fdb137a1d0a59cbc66995ee5c20ca8b675e2ac96/chrome/browser/ui/cocoa/infobars/infobar_controller.mm
[delete] https://crrev.com/fdb137a1d0a59cbc66995ee5c20ca8b675e2ac96/chrome/browser/ui/cocoa/infobars/infobar_utilities.h
[delete] https://crrev.com/fdb137a1d0a59cbc66995ee5c20ca8b675e2ac96/chrome/browser/ui/cocoa/infobars/infobar_utilities.mm
[delete] https://crrev.com/fdb137a1d0a59cbc66995ee5c20ca8b675e2ac96/chrome/browser/ui/cocoa/infobars/mock_confirm_infobar_delegate.cc
[delete] https://crrev.com/fdb137a1d0a59cbc66995ee5c20ca8b675e2ac96/chrome/browser/ui/cocoa/infobars/mock_confirm_infobar_delegate.h
[delete] https://crrev.com/fdb137a1d0a59cbc66995ee5c20ca8b675e2ac96/chrome/browser/ui/cocoa/infobars/translate_infobar_base.h
[delete] https://crrev.com/fdb137a1d0a59cbc66995ee5c20ca8b675e2ac96/chrome/browser/ui/cocoa/infobars/translate_infobar_base.mm
[delete] https://crrev.com/fdb137a1d0a59cbc66995ee5c20ca8b675e2ac96/chrome/browser/ui/cocoa/infobars/translate_infobar_unittest.mm
[delete] https://crrev.com/fdb137a1d0a59cbc66995ee5c20ca8b675e2ac96/chrome/browser/ui/cocoa/infobars/translate_message_infobar_controller.h
[delete] https://crrev.com/fdb137a1d0a59cbc66995ee5c20ca8b675e2ac96/chrome/browser/ui/cocoa/infobars/translate_message_infobar_controller.mm
[modify] https://crrev.com/a0dec4edc9814140818cc396eaf3c15484afbbfc/chrome/browser/ui/omnibox/alternate_nav_infobar_delegate.h
[modify] https://crrev.com/a0dec4edc9814140818cc396eaf3c15484afbbfc/chrome/browser/ui/views/infobars/alternate_nav_infobar_view.cc
[modify] https://crrev.com/a0dec4edc9814140818cc396eaf3c15484afbbfc/chrome/browser/ui/views/infobars/confirm_infobar.cc
[modify] https://crrev.com/a0dec4edc9814140818cc396eaf3c15484afbbfc/chrome/browser/ui/views/infobars/legacy_infobars_mac.cc
[modify] https://crrev.com/a0dec4edc9814140818cc396eaf3c15484afbbfc/chrome/test/BUILD.gn
[modify] https://crrev.com/a0dec4edc9814140818cc396eaf3c15484afbbfc/components/translate_strings.grdp

Project Member

Comment 36 by bugdroid1@chromium.org, Sep 22

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/38a28c7ac9b791e34659161aadeb3669b9573798

commit 38a28c7ac9b791e34659161aadeb3669b9573798
Author: Nico Weber <thakis@chromium.org>
Date: Sat Sep 22 23:29:20 2018

mac: Delete cocoa version of FindBarPlatformHelperMacTest.

Like the uitest change in https://chromium-review.googlesource.com/c/chromium/src/+/1237454

For some reason the CQ didn't catch this issue.

TBR=rsesek

Bug: 832676
Change-Id: Ie58e701f0f7d231432c1636366545ee211c5e712
Reviewed-on: https://chromium-review.googlesource.com/1239761
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593450}
[modify] https://crrev.com/38a28c7ac9b791e34659161aadeb3669b9573798/chrome/browser/ui/find_bar/find_bar_platform_helper_mac_browsertest.mm

Project Member

Comment 37 by bugdroid1@chromium.org, Sep 23

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bde57febbd2f242decd807bcb869e0be0bf21069

commit bde57febbd2f242decd807bcb869e0be0bf21069
Author: Robert Sesek <rsesek@chromium.org>
Date: Sun Sep 23 01:28:57 2018

mac: Delete Cocoa version of the avatar menu and user manager.

Bug: 832676
Change-Id: I631e54fef31ed42828aabbe674cb67c1e2165763
Reviewed-on: https://chromium-review.googlesource.com/1239764
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593451}
[modify] https://crrev.com/bde57febbd2f242decd807bcb869e0be0bf21069/chrome/app/profiles_strings.grdp
[modify] https://crrev.com/bde57febbd2f242decd807bcb869e0be0bf21069/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/bde57febbd2f242decd807bcb869e0be0bf21069/chrome/browser/ui/cocoa/browser_window_cocoa.mm
[modify] https://crrev.com/bde57febbd2f242decd807bcb869e0be0bf21069/chrome/browser/ui/cocoa/browser_window_controller.h
[modify] https://crrev.com/bde57febbd2f242decd807bcb869e0be0bf21069/chrome/browser/ui/cocoa/browser_window_controller.mm
[modify] https://crrev.com/bde57febbd2f242decd807bcb869e0be0bf21069/chrome/browser/ui/cocoa/browser_window_controller_browsertest.mm
[modify] https://crrev.com/bde57febbd2f242decd807bcb869e0be0bf21069/chrome/browser/ui/cocoa/browser_window_controller_private.mm
[delete] https://crrev.com/38a28c7ac9b791e34659161aadeb3669b9573798/chrome/browser/ui/cocoa/profiles/avatar_base_controller.h
[delete] https://crrev.com/38a28c7ac9b791e34659161aadeb3669b9573798/chrome/browser/ui/cocoa/profiles/avatar_base_controller.mm
[delete] https://crrev.com/38a28c7ac9b791e34659161aadeb3669b9573798/chrome/browser/ui/cocoa/profiles/avatar_button.h
[delete] https://crrev.com/38a28c7ac9b791e34659161aadeb3669b9573798/chrome/browser/ui/cocoa/profiles/avatar_button_cocoa.mm
[delete] https://crrev.com/38a28c7ac9b791e34659161aadeb3669b9573798/chrome/browser/ui/cocoa/profiles/avatar_button_controller.h
[delete] https://crrev.com/38a28c7ac9b791e34659161aadeb3669b9573798/chrome/browser/ui/cocoa/profiles/avatar_button_controller.mm
[delete] https://crrev.com/38a28c7ac9b791e34659161aadeb3669b9573798/chrome/browser/ui/cocoa/profiles/avatar_button_controller_unittest.mm
[delete] https://crrev.com/38a28c7ac9b791e34659161aadeb3669b9573798/chrome/browser/ui/cocoa/profiles/avatar_button_unittest.mm
[delete] https://crrev.com/38a28c7ac9b791e34659161aadeb3669b9573798/chrome/browser/ui/cocoa/profiles/avatar_icon_controller.h
[delete] https://crrev.com/38a28c7ac9b791e34659161aadeb3669b9573798/chrome/browser/ui/cocoa/profiles/avatar_icon_controller.mm
[delete] https://crrev.com/38a28c7ac9b791e34659161aadeb3669b9573798/chrome/browser/ui/cocoa/profiles/avatar_icon_controller_unittest.mm
[delete] https://crrev.com/38a28c7ac9b791e34659161aadeb3669b9573798/chrome/browser/ui/cocoa/profiles/profile_chooser_bridge_views.h
[delete] https://crrev.com/38a28c7ac9b791e34659161aadeb3669b9573798/chrome/browser/ui/cocoa/profiles/profile_chooser_bridge_views.mm
[delete] https://crrev.com/38a28c7ac9b791e34659161aadeb3669b9573798/chrome/browser/ui/cocoa/profiles/profile_signin_confirmation_dialog_cocoa.h
[delete] https://crrev.com/38a28c7ac9b791e34659161aadeb3669b9573798/chrome/browser/ui/cocoa/profiles/profile_signin_confirmation_dialog_cocoa.mm
[delete] https://crrev.com/38a28c7ac9b791e34659161aadeb3669b9573798/chrome/browser/ui/cocoa/profiles/profile_signin_confirmation_view_controller.h
[delete] https://crrev.com/38a28c7ac9b791e34659161aadeb3669b9573798/chrome/browser/ui/cocoa/profiles/profile_signin_confirmation_view_controller.mm
[delete] https://crrev.com/38a28c7ac9b791e34659161aadeb3669b9573798/chrome/browser/ui/cocoa/profiles/profile_signin_confirmation_view_controller_browsertest.mm
[delete] https://crrev.com/38a28c7ac9b791e34659161aadeb3669b9573798/chrome/browser/ui/cocoa/profiles/signin_view_controller_delegate_mac.h
[delete] https://crrev.com/38a28c7ac9b791e34659161aadeb3669b9573798/chrome/browser/ui/cocoa/profiles/signin_view_controller_delegate_mac.mm
[delete] https://crrev.com/38a28c7ac9b791e34659161aadeb3669b9573798/chrome/browser/ui/cocoa/profiles/user_manager_mac.h
[delete] https://crrev.com/38a28c7ac9b791e34659161aadeb3669b9573798/chrome/browser/ui/cocoa/profiles/user_manager_mac.mm
[delete] https://crrev.com/38a28c7ac9b791e34659161aadeb3669b9573798/chrome/browser/ui/cocoa/profiles/user_manager_mac_unittest.mm
[modify] https://crrev.com/bde57febbd2f242decd807bcb869e0be0bf21069/chrome/browser/ui/cocoa/tabbed_browser_window.mm
[modify] https://crrev.com/bde57febbd2f242decd807bcb869e0be0bf21069/chrome/browser/ui/views/profiles/profile_chooser_view_browsertest.cc
[modify] https://crrev.com/bde57febbd2f242decd807bcb869e0be0bf21069/chrome/browser/ui/views/profiles/signin_view_controller_delegate_views.cc
[modify] https://crrev.com/bde57febbd2f242decd807bcb869e0be0bf21069/chrome/browser/ui/views/profiles/user_manager_view.cc
[modify] https://crrev.com/bde57febbd2f242decd807bcb869e0be0bf21069/chrome/test/BUILD.gn
[modify] https://crrev.com/bde57febbd2f242decd807bcb869e0be0bf21069/tools/gritsettings/startup_resources_mac.txt

Project Member

Comment 38 by bugdroid1@chromium.org, Sep 23

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4e220502beb4efa3a08b5bd1ef5397a14ac2f6d0

commit 4e220502beb4efa3a08b5bd1ef5397a14ac2f6d0
Author: Robert Sesek <rsesek@chromium.org>
Date: Sun Sep 23 02:01:38 2018

mac: Remove views-browser-windows from about:flags

The feature still exists beacuse tests toggle it, but this removes it
from the flags UI.

Bug: 832676
Change-Id: I6971276883e19792f962f9e17d4fa50e8265a1d0
Reviewed-on: https://chromium-review.googlesource.com/1239766
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593452}
[modify] https://crrev.com/4e220502beb4efa3a08b5bd1ef5397a14ac2f6d0/chrome/browser/about_flags.cc
[modify] https://crrev.com/4e220502beb4efa3a08b5bd1ef5397a14ac2f6d0/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/4e220502beb4efa3a08b5bd1ef5397a14ac2f6d0/chrome/browser/flag_descriptions.h

Project Member

Comment 39 by bugdroid1@chromium.org, Sep 23

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/70b8cabacc371939b88f0661edd2070ad60c2129

commit 70b8cabacc371939b88f0661edd2070ad60c2129
Author: Robert Sesek <rsesek@chromium.org>
Date: Sun Sep 23 19:25:02 2018

mac: Delete the Cocoa version of the one-click signin dialog.

Bug: 832676
Change-Id: I1c9874f3f0f80bdef3a6cd7351a0504e8c7ad36c
Reviewed-on: https://chromium-review.googlesource.com/1239634
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593457}
[modify] https://crrev.com/70b8cabacc371939b88f0661edd2070ad60c2129/chrome/app/nibs/BUILD.gn
[delete] https://crrev.com/336bc00667a7f428abf1bedb57b1729c1da34116/chrome/app/nibs/OneClickSigninDialog.xib
[modify] https://crrev.com/70b8cabacc371939b88f0661edd2070ad60c2129/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/70b8cabacc371939b88f0661edd2070ad60c2129/chrome/browser/ui/cocoa/browser_window_cocoa.mm
[delete] https://crrev.com/336bc00667a7f428abf1bedb57b1729c1da34116/chrome/browser/ui/cocoa/one_click_signin_dialog_controller.h
[delete] https://crrev.com/336bc00667a7f428abf1bedb57b1729c1da34116/chrome/browser/ui/cocoa/one_click_signin_dialog_controller.mm
[delete] https://crrev.com/336bc00667a7f428abf1bedb57b1729c1da34116/chrome/browser/ui/cocoa/one_click_signin_dialog_controller_browsertest.mm
[delete] https://crrev.com/336bc00667a7f428abf1bedb57b1729c1da34116/chrome/browser/ui/cocoa/one_click_signin_view_controller.h
[delete] https://crrev.com/336bc00667a7f428abf1bedb57b1729c1da34116/chrome/browser/ui/cocoa/one_click_signin_view_controller.mm
[modify] https://crrev.com/70b8cabacc371939b88f0661edd2070ad60c2129/chrome/test/BUILD.gn

Project Member

Comment 40 by bugdroid1@chromium.org, Sep 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/96c5cd3df32349562b9421696e8a3e5a061872ea

commit 96c5cd3df32349562b9421696e8a3e5a061872ea
Author: Nico Weber <thakis@chromium.org>
Date: Mon Sep 24 00:08:09 2018

mac: Remove unused cocoa SadTab and HoverImageMenuButton code.

Bug: 832676
Change-Id: I12724b2c0bd76aa86b598f5a23b8c20decf3ba92
Reviewed-on: https://chromium-review.googlesource.com/1239639
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593460}
[modify] https://crrev.com/96c5cd3df32349562b9421696e8a3e5a061872ea/chrome/browser/ui/BUILD.gn
[delete] https://crrev.com/c635c06ebe25e8376972fa36ee44642e79507629/chrome/browser/ui/cocoa/tab_contents/sad_tab_mac.mm
[delete] https://crrev.com/c635c06ebe25e8376972fa36ee44642e79507629/chrome/browser/ui/cocoa/tab_contents/sad_tab_mac_unittest.mm
[delete] https://crrev.com/c635c06ebe25e8376972fa36ee44642e79507629/chrome/browser/ui/cocoa/tab_contents/sad_tab_view_cocoa.h
[delete] https://crrev.com/c635c06ebe25e8376972fa36ee44642e79507629/chrome/browser/ui/cocoa/tab_contents/sad_tab_view_cocoa.mm
[modify] https://crrev.com/96c5cd3df32349562b9421696e8a3e5a061872ea/chrome/browser/ui/views/sad_tab_view.cc
[modify] https://crrev.com/96c5cd3df32349562b9421696e8a3e5a061872ea/chrome/test/BUILD.gn
[modify] https://crrev.com/96c5cd3df32349562b9421696e8a3e5a061872ea/components/resources/crash_scaled_resources.grdp
[modify] https://crrev.com/96c5cd3df32349562b9421696e8a3e5a061872ea/ui/base/BUILD.gn
[delete] https://crrev.com/c635c06ebe25e8376972fa36ee44642e79507629/ui/base/cocoa/controls/blue_label_button.h
[delete] https://crrev.com/c635c06ebe25e8376972fa36ee44642e79507629/ui/base/cocoa/controls/blue_label_button.mm
[delete] https://crrev.com/c635c06ebe25e8376972fa36ee44642e79507629/ui/base/cocoa/controls/blue_label_button_unittest.mm
[delete] https://crrev.com/c635c06ebe25e8376972fa36ee44642e79507629/ui/base/cocoa/controls/hover_image_menu_button.h
[delete] https://crrev.com/c635c06ebe25e8376972fa36ee44642e79507629/ui/base/cocoa/controls/hover_image_menu_button.mm
[delete] https://crrev.com/c635c06ebe25e8376972fa36ee44642e79507629/ui/base/cocoa/controls/hover_image_menu_button_cell.h
[delete] https://crrev.com/c635c06ebe25e8376972fa36ee44642e79507629/ui/base/cocoa/controls/hover_image_menu_button_cell.mm
[delete] https://crrev.com/c635c06ebe25e8376972fa36ee44642e79507629/ui/base/cocoa/controls/hover_image_menu_button_unittest.mm

Project Member

Comment 41 by bugdroid1@chromium.org, Sep 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a738bf5a7f9bb73fdcb4fff030f8b4069406c3fe

commit a738bf5a7f9bb73fdcb4fff030f8b4069406c3fe
Author: Robert Sesek <rsesek@chromium.org>
Date: Mon Sep 24 01:28:08 2018

mac: Delete the Cocoa app menu.

Bug: 832676
Change-Id: I2e98924794cb7165f1355aeeb66a419c82f4a82a
Reviewed-on: https://chromium-review.googlesource.com/1239640
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593467}
[delete] https://crrev.com/145d1ebac5a0ff716bb81bf893b16b013eb83b02/chrome/app/nibs/AppMenu.xib
[modify] https://crrev.com/a738bf5a7f9bb73fdcb4fff030f8b4069406c3fe/chrome/app/nibs/BUILD.gn
[modify] https://crrev.com/a738bf5a7f9bb73fdcb4fff030f8b4069406c3fe/chrome/browser/ui/BUILD.gn
[delete] https://crrev.com/145d1ebac5a0ff716bb81bf893b16b013eb83b02/chrome/browser/ui/cocoa/app_menu/OWNERS
[delete] https://crrev.com/145d1ebac5a0ff716bb81bf893b16b013eb83b02/chrome/browser/ui/cocoa/app_menu/app_menu_button_cell.h
[delete] https://crrev.com/145d1ebac5a0ff716bb81bf893b16b013eb83b02/chrome/browser/ui/cocoa/app_menu/app_menu_button_cell.mm
[delete] https://crrev.com/145d1ebac5a0ff716bb81bf893b16b013eb83b02/chrome/browser/ui/cocoa/app_menu/app_menu_button_cell_unittest.mm
[delete] https://crrev.com/145d1ebac5a0ff716bb81bf893b16b013eb83b02/chrome/browser/ui/cocoa/app_menu/app_menu_controller.h
[delete] https://crrev.com/145d1ebac5a0ff716bb81bf893b16b013eb83b02/chrome/browser/ui/cocoa/app_menu/app_menu_controller.mm
[delete] https://crrev.com/145d1ebac5a0ff716bb81bf893b16b013eb83b02/chrome/browser/ui/cocoa/app_menu/app_menu_controller_unittest.mm
[delete] https://crrev.com/145d1ebac5a0ff716bb81bf893b16b013eb83b02/chrome/browser/ui/cocoa/app_menu/menu_tracked_button.h
[delete] https://crrev.com/145d1ebac5a0ff716bb81bf893b16b013eb83b02/chrome/browser/ui/cocoa/app_menu/menu_tracked_button.mm
[delete] https://crrev.com/145d1ebac5a0ff716bb81bf893b16b013eb83b02/chrome/browser/ui/cocoa/app_menu/menu_tracked_root_view.h
[delete] https://crrev.com/145d1ebac5a0ff716bb81bf893b16b013eb83b02/chrome/browser/ui/cocoa/app_menu/menu_tracked_root_view.mm
[delete] https://crrev.com/145d1ebac5a0ff716bb81bf893b16b013eb83b02/chrome/browser/ui/cocoa/app_menu/menu_tracked_root_view_unittest.mm
[delete] https://crrev.com/145d1ebac5a0ff716bb81bf893b16b013eb83b02/chrome/browser/ui/cocoa/app_menu/recent_tabs_menu_model_delegate.h
[delete] https://crrev.com/145d1ebac5a0ff716bb81bf893b16b013eb83b02/chrome/browser/ui/cocoa/app_menu/recent_tabs_menu_model_delegate.mm
[modify] https://crrev.com/a738bf5a7f9bb73fdcb4fff030f8b4069406c3fe/chrome/browser/ui/cocoa/extensions/browser_action_button.mm
[delete] https://crrev.com/145d1ebac5a0ff716bb81bf893b16b013eb83b02/chrome/browser/ui/cocoa/extensions/browser_action_button_interactive_uitest.mm
[modify] https://crrev.com/a738bf5a7f9bb73fdcb4fff030f8b4069406c3fe/chrome/browser/ui/cocoa/extensions/browser_actions_controller.mm
[modify] https://crrev.com/a738bf5a7f9bb73fdcb4fff030f8b4069406c3fe/chrome/browser/ui/cocoa/toolbar/toolbar_controller.h
[modify] https://crrev.com/a738bf5a7f9bb73fdcb4fff030f8b4069406c3fe/chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm
[modify] https://crrev.com/a738bf5a7f9bb73fdcb4fff030f8b4069406c3fe/chrome/browser/ui/views/media_router/app_menu_test_api.h
[delete] https://crrev.com/145d1ebac5a0ff716bb81bf893b16b013eb83b02/chrome/browser/ui/views/media_router/app_menu_test_api_cocoa.mm
[modify] https://crrev.com/a738bf5a7f9bb73fdcb4fff030f8b4069406c3fe/chrome/browser/ui/views/media_router/app_menu_test_api_views.cc
[modify] https://crrev.com/a738bf5a7f9bb73fdcb4fff030f8b4069406c3fe/chrome/test/BUILD.gn

Project Member

Comment 42 by bugdroid1@chromium.org, Sep 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8452ee7206468ea948003d744d3c377200332386

commit 8452ee7206468ea948003d744d3c377200332386
Author: Nico Weber <thakis@chromium.org>
Date: Mon Sep 24 12:59:59 2018

mac: Remove unused cocoa new tab button.

Bug: 832676
Change-Id: I7b1fbbbc4cf83d470b81874e12fbda2b7a6a9194
Reviewed-on: https://chromium-review.googlesource.com/1240157
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593514}
[modify] https://crrev.com/8452ee7206468ea948003d744d3c377200332386/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/8452ee7206468ea948003d744d3c377200332386/chrome/browser/ui/cocoa/browser_window_controller.mm
[delete] https://crrev.com/25a467533b00c6a6e686f6a22ad3c994d5cdfb7c/chrome/browser/ui/cocoa/new_tab_button.h
[delete] https://crrev.com/25a467533b00c6a6e686f6a22ad3c994d5cdfb7c/chrome/browser/ui/cocoa/new_tab_button_cocoa.mm
[modify] https://crrev.com/8452ee7206468ea948003d744d3c377200332386/chrome/browser/ui/cocoa/tabs/tab_strip_controller.h
[modify] https://crrev.com/8452ee7206468ea948003d744d3c377200332386/chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm
[modify] https://crrev.com/8452ee7206468ea948003d744d3c377200332386/chrome/browser/ui/cocoa/tabs/tab_strip_controller_unittest.mm
[modify] https://crrev.com/8452ee7206468ea948003d744d3c377200332386/chrome/browser/ui/cocoa/tabs/tab_strip_view.h
[modify] https://crrev.com/8452ee7206468ea948003d744d3c377200332386/chrome/browser/ui/cocoa/tabs/tab_strip_view.mm

Project Member

Comment 43 by bugdroid1@chromium.org, Sep 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8f3cb30f77b4f4156a11e6ca3ab2ab3e7562edc2

commit 8f3cb30f77b4f4156a11e6ca3ab2ab3e7562edc2
Author: Nico Weber <thakis@chromium.org>
Date: Mon Sep 24 15:13:19 2018

mac: Remove a few unused cocoa location bar decorations.

Removes ContentSettingDecoration, KeywordHintDecoration,
SaveCreditCardDecoration, StarDecoration, TranslateDecoration.

Also removes c/b/ui/cocoa/translate/.

Bug: 832676
Change-Id: I82f5873091502c847e77efb2671d8cc5583f8ba4
Reviewed-on: https://chromium-review.googlesource.com/1240161
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593539}
[modify] https://crrev.com/8f3cb30f77b4f4156a11e6ca3ab2ab3e7562edc2/chrome/browser/ui/BUILD.gn
[delete] https://crrev.com/36a912c03b2729ff177e5589c731965e0d91eaff/chrome/browser/ui/cocoa/autofill/save_card_bubble_view_views.h
[delete] https://crrev.com/36a912c03b2729ff177e5589c731965e0d91eaff/chrome/browser/ui/cocoa/autofill/save_card_bubble_view_views.mm
[modify] https://crrev.com/8f3cb30f77b4f4156a11e6ca3ab2ab3e7562edc2/chrome/browser/ui/cocoa/browser_window_cocoa.mm
[modify] https://crrev.com/8f3cb30f77b4f4156a11e6ca3ab2ab3e7562edc2/chrome/browser/ui/cocoa/browser_window_controller.h
[modify] https://crrev.com/8f3cb30f77b4f4156a11e6ca3ab2ab3e7562edc2/chrome/browser/ui/cocoa/browser_window_controller.mm
[modify] https://crrev.com/8f3cb30f77b4f4156a11e6ca3ab2ab3e7562edc2/chrome/browser/ui/cocoa/bubble_anchor_helper_views.mm
[modify] https://crrev.com/8f3cb30f77b4f4156a11e6ca3ab2ab3e7562edc2/chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_cell_unittest.mm
[delete] https://crrev.com/36a912c03b2729ff177e5589c731965e0d91eaff/chrome/browser/ui/cocoa/location_bar/content_setting_decoration.h
[delete] https://crrev.com/36a912c03b2729ff177e5589c731965e0d91eaff/chrome/browser/ui/cocoa/location_bar/content_setting_decoration.mm
[delete] https://crrev.com/36a912c03b2729ff177e5589c731965e0d91eaff/chrome/browser/ui/cocoa/location_bar/content_setting_decoration_browsertest.mm
[delete] https://crrev.com/36a912c03b2729ff177e5589c731965e0d91eaff/chrome/browser/ui/cocoa/location_bar/keyword_hint_decoration.h
[delete] https://crrev.com/36a912c03b2729ff177e5589c731965e0d91eaff/chrome/browser/ui/cocoa/location_bar/keyword_hint_decoration.mm
[delete] https://crrev.com/36a912c03b2729ff177e5589c731965e0d91eaff/chrome/browser/ui/cocoa/location_bar/keyword_hint_decoration_unittest.mm
[modify] https://crrev.com/8f3cb30f77b4f4156a11e6ca3ab2ab3e7562edc2/chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.h
[modify] https://crrev.com/8f3cb30f77b4f4156a11e6ca3ab2ab3e7562edc2/chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm
[delete] https://crrev.com/36a912c03b2729ff177e5589c731965e0d91eaff/chrome/browser/ui/cocoa/location_bar/save_credit_card_decoration.h
[delete] https://crrev.com/36a912c03b2729ff177e5589c731965e0d91eaff/chrome/browser/ui/cocoa/location_bar/save_credit_card_decoration.mm
[delete] https://crrev.com/36a912c03b2729ff177e5589c731965e0d91eaff/chrome/browser/ui/cocoa/location_bar/star_decoration.h
[delete] https://crrev.com/36a912c03b2729ff177e5589c731965e0d91eaff/chrome/browser/ui/cocoa/location_bar/star_decoration.mm
[delete] https://crrev.com/36a912c03b2729ff177e5589c731965e0d91eaff/chrome/browser/ui/cocoa/location_bar/translate_decoration.h
[delete] https://crrev.com/36a912c03b2729ff177e5589c731965e0d91eaff/chrome/browser/ui/cocoa/location_bar/translate_decoration.mm
[modify] https://crrev.com/8f3cb30f77b4f4156a11e6ca3ab2ab3e7562edc2/chrome/browser/ui/cocoa/toolbar/toolbar_controller.h
[modify] https://crrev.com/8f3cb30f77b4f4156a11e6ca3ab2ab3e7562edc2/chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm
[modify] https://crrev.com/8f3cb30f77b4f4156a11e6ca3ab2ab3e7562edc2/chrome/browser/ui/cocoa/toolbar/toolbar_controller_unittest.mm
[delete] https://crrev.com/36a912c03b2729ff177e5589c731965e0d91eaff/chrome/browser/ui/cocoa/translate/translate_bubble_bridge_views.h
[delete] https://crrev.com/36a912c03b2729ff177e5589c731965e0d91eaff/chrome/browser/ui/cocoa/translate/translate_bubble_bridge_views.mm
[modify] https://crrev.com/8f3cb30f77b4f4156a11e6ca3ab2ab3e7562edc2/chrome/test/BUILD.gn

Project Member

Comment 44 by bugdroid1@chromium.org, Sep 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/81aafc73dd11b47799a57ab300f8d69bf42365e5

commit 81aafc73dd11b47799a57ab300f8d69bf42365e5
Author: Nico Weber <thakis@chromium.org>
Date: Mon Sep 24 15:25:38 2018

mac: Remove unused TabModalConfirmDialogMac.

Bug: 832676
Change-Id: I38359d01373d4bd237c6a0f7fe5ffc051a3318c5
Reviewed-on: https://chromium-review.googlesource.com/1240164
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593543}
[modify] https://crrev.com/81aafc73dd11b47799a57ab300f8d69bf42365e5/chrome/browser/ui/BUILD.gn
[delete] https://crrev.com/bb591d1f3a2df6fd8eaad80abefb0e19367d0c0b/chrome/browser/ui/cocoa/tab_modal_confirm_dialog_mac.h
[delete] https://crrev.com/bb591d1f3a2df6fd8eaad80abefb0e19367d0c0b/chrome/browser/ui/cocoa/tab_modal_confirm_dialog_mac.mm
[modify] https://crrev.com/81aafc73dd11b47799a57ab300f8d69bf42365e5/chrome/browser/ui/tab_modal_confirm_dialog.h
[modify] https://crrev.com/81aafc73dd11b47799a57ab300f8d69bf42365e5/chrome/browser/ui/views/tab_modal_confirm_dialog_views.cc

Project Member

Comment 45 by bugdroid1@chromium.org, Sep 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/98d260d4eb710678d2af88358268d9be0ba4e556

commit 98d260d4eb710678d2af88358268d9be0ba4e556
Author: Nico Weber <thakis@chromium.org>
Date: Mon Sep 24 16:32:30 2018

mac: Remove unused MediaGalleriesDialogCocoa.

Bug: 832676
Change-Id: If8b70eefc57a17b734c33a953b3c06a1a0dc2bd2
Reviewed-on: https://chromium-review.googlesource.com/1240165
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593563}
[modify] https://crrev.com/98d260d4eb710678d2af88358268d9be0ba4e556/chrome/browser/media_galleries/media_galleries_dialog_controller.h
[modify] https://crrev.com/98d260d4eb710678d2af88358268d9be0ba4e556/chrome/browser/ui/BUILD.gn
[delete] https://crrev.com/b63fffc7b5912b4f279317897f213337b8057f48/chrome/browser/ui/cocoa/extensions/media_galleries_dialog_cocoa.h
[delete] https://crrev.com/b63fffc7b5912b4f279317897f213337b8057f48/chrome/browser/ui/cocoa/extensions/media_galleries_dialog_cocoa.mm
[delete] https://crrev.com/b63fffc7b5912b4f279317897f213337b8057f48/chrome/browser/ui/cocoa/extensions/media_galleries_dialog_cocoa_browsertest.mm
[delete] https://crrev.com/b63fffc7b5912b4f279317897f213337b8057f48/chrome/browser/ui/cocoa/extensions/media_galleries_dialog_cocoa_unittest.mm
[delete] https://crrev.com/b63fffc7b5912b4f279317897f213337b8057f48/chrome/browser/ui/cocoa/extensions/media_gallery_list_entry_view.h
[delete] https://crrev.com/b63fffc7b5912b4f279317897f213337b8057f48/chrome/browser/ui/cocoa/extensions/media_gallery_list_entry_view.mm
[modify] https://crrev.com/98d260d4eb710678d2af88358268d9be0ba4e556/chrome/browser/ui/views/extensions/media_galleries_dialog_views.cc
[modify] https://crrev.com/98d260d4eb710678d2af88358268d9be0ba4e556/chrome/test/BUILD.gn

Project Member

Comment 46 by bugdroid1@chromium.org, Sep 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/732d346c64d780488523bfea6e0cc0d7418c1d7c

commit 732d346c64d780488523bfea6e0cc0d7418c1d7c
Author: Nico Weber <thakis@chromium.org>
Date: Mon Sep 24 16:36:32 2018

mac: Remove unused ManagePasswordsDecoration and SelectedKeywordDecoration.

Bug: 832676
Change-Id: I844589ee9726882c5a19b4d7e0ffd2543118d6a4
Reviewed-on: https://chromium-review.googlesource.com/1240167
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593564}
[modify] https://crrev.com/732d346c64d780488523bfea6e0cc0d7418c1d7c/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/732d346c64d780488523bfea6e0cc0d7418c1d7c/chrome/browser/ui/cocoa/bubble_anchor_helper_views.h
[modify] https://crrev.com/732d346c64d780488523bfea6e0cc0d7418c1d7c/chrome/browser/ui/cocoa/bubble_anchor_helper_views.mm
[modify] https://crrev.com/732d346c64d780488523bfea6e0cc0d7418c1d7c/chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_cell_unittest.mm
[modify] https://crrev.com/732d346c64d780488523bfea6e0cc0d7418c1d7c/chrome/browser/ui/cocoa/location_bar/bubble_decoration.h
[modify] https://crrev.com/732d346c64d780488523bfea6e0cc0d7418c1d7c/chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.h
[modify] https://crrev.com/732d346c64d780488523bfea6e0cc0d7418c1d7c/chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm
[delete] https://crrev.com/98d260d4eb710678d2af88358268d9be0ba4e556/chrome/browser/ui/cocoa/location_bar/manage_passwords_decoration.h
[delete] https://crrev.com/98d260d4eb710678d2af88358268d9be0ba4e556/chrome/browser/ui/cocoa/location_bar/manage_passwords_decoration.mm
[delete] https://crrev.com/98d260d4eb710678d2af88358268d9be0ba4e556/chrome/browser/ui/cocoa/location_bar/manage_passwords_decoration_unittest.mm
[delete] https://crrev.com/98d260d4eb710678d2af88358268d9be0ba4e556/chrome/browser/ui/cocoa/location_bar/selected_keyword_decoration.h
[delete] https://crrev.com/98d260d4eb710678d2af88358268d9be0ba4e556/chrome/browser/ui/cocoa/location_bar/selected_keyword_decoration.mm
[delete] https://crrev.com/98d260d4eb710678d2af88358268d9be0ba4e556/chrome/browser/ui/cocoa/location_bar/selected_keyword_decoration_unittest.mm
[modify] https://crrev.com/732d346c64d780488523bfea6e0cc0d7418c1d7c/chrome/test/BUILD.gn

Project Member

Comment 47 by bugdroid1@chromium.org, Sep 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/12a2ae7b291a0fb5facf8be2d15571fe183c6643

commit 12a2ae7b291a0fb5facf8be2d15571fe183c6643
Author: Robert Sesek <rsesek@chromium.org>
Date: Mon Sep 24 17:40:51 2018

mac: Delete the Cocoa autofill code.

Bug: 832676
Change-Id: I25fa2e314592f392a716bcb3b5dd3836bfb878cc
Reviewed-on: https://chromium-review.googlesource.com/1239636
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593586}
[modify] https://crrev.com/12a2ae7b291a0fb5facf8be2d15571fe183c6643/chrome/browser/about_flags.cc
[modify] https://crrev.com/12a2ae7b291a0fb5facf8be2d15571fe183c6643/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/12a2ae7b291a0fb5facf8be2d15571fe183c6643/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/12a2ae7b291a0fb5facf8be2d15571fe183c6643/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/12a2ae7b291a0fb5facf8be2d15571fe183c6643/chrome/browser/ui/autofill/autofill_popup_view.h
[delete] https://crrev.com/f7f31484d3850a08db564a44711ab1abc480c45c/chrome/browser/ui/cocoa/autofill/OWNERS
[delete] https://crrev.com/f7f31484d3850a08db564a44711ab1abc480c45c/chrome/browser/ui/cocoa/autofill/autofill_bubble_controller.h
[delete] https://crrev.com/f7f31484d3850a08db564a44711ab1abc480c45c/chrome/browser/ui/cocoa/autofill/autofill_bubble_controller.mm
[delete] https://crrev.com/f7f31484d3850a08db564a44711ab1abc480c45c/chrome/browser/ui/cocoa/autofill/autofill_bubble_controller_unittest.mm
[delete] https://crrev.com/f7f31484d3850a08db564a44711ab1abc480c45c/chrome/browser/ui/cocoa/autofill/autofill_dialog_constants.h
[delete] https://crrev.com/f7f31484d3850a08db564a44711ab1abc480c45c/chrome/browser/ui/cocoa/autofill/autofill_popup_base_view_cocoa.h
[delete] https://crrev.com/f7f31484d3850a08db564a44711ab1abc480c45c/chrome/browser/ui/cocoa/autofill/autofill_popup_base_view_cocoa.mm
[delete] https://crrev.com/f7f31484d3850a08db564a44711ab1abc480c45c/chrome/browser/ui/cocoa/autofill/autofill_popup_view_bridge.h
[delete] https://crrev.com/f7f31484d3850a08db564a44711ab1abc480c45c/chrome/browser/ui/cocoa/autofill/autofill_popup_view_bridge.mm
[delete] https://crrev.com/f7f31484d3850a08db564a44711ab1abc480c45c/chrome/browser/ui/cocoa/autofill/autofill_popup_view_cocoa.h
[delete] https://crrev.com/f7f31484d3850a08db564a44711ab1abc480c45c/chrome/browser/ui/cocoa/autofill/autofill_popup_view_cocoa.mm
[delete] https://crrev.com/f7f31484d3850a08db564a44711ab1abc480c45c/chrome/browser/ui/cocoa/autofill/autofill_tooltip_controller.h
[delete] https://crrev.com/f7f31484d3850a08db564a44711ab1abc480c45c/chrome/browser/ui/cocoa/autofill/autofill_tooltip_controller.mm
[delete] https://crrev.com/f7f31484d3850a08db564a44711ab1abc480c45c/chrome/browser/ui/cocoa/autofill/autofill_tooltip_controller_unittest.mm
[delete] https://crrev.com/f7f31484d3850a08db564a44711ab1abc480c45c/chrome/browser/ui/cocoa/autofill/layout_view_unittest.mm
[delete] https://crrev.com/f7f31484d3850a08db564a44711ab1abc480c45c/chrome/browser/ui/cocoa/autofill/save_card_bubble_view_unittest.mm
[modify] https://crrev.com/12a2ae7b291a0fb5facf8be2d15571fe183c6643/chrome/browser/ui/views/autofill/autofill_popup_view_views.cc
[modify] https://crrev.com/12a2ae7b291a0fb5facf8be2d15571fe183c6643/chrome/test/BUILD.gn
[modify] https://crrev.com/12a2ae7b291a0fb5facf8be2d15571fe183c6643/components/autofill/core/common/autofill_features.cc
[modify] https://crrev.com/12a2ae7b291a0fb5facf8be2d15571fe183c6643/components/autofill/core/common/autofill_features.h

Project Member

Comment 48 by bugdroid1@chromium.org, Sep 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4a2c18051774bbc3a59a2301938e28a11363d9b0

commit 4a2c18051774bbc3a59a2301938e28a11363d9b0
Author: Robert Sesek <rsesek@chromium.org>
Date: Mon Sep 24 18:40:39 2018

mac: Delete the Cocoa zoom bubble and the BaseBubbleController machinery.

Bug: 832676
Change-Id: If732ef321da1a440003906763d5c8c64b3d4ba5f
Reviewed-on: https://chromium-review.googlesource.com/1239637
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593608}
[modify] https://crrev.com/4a2c18051774bbc3a59a2301938e28a11363d9b0/chrome/browser/ui/BUILD.gn
[delete] https://crrev.com/525954c021bfdae0f91b53b67c67485189ef7892/chrome/browser/ui/cocoa/base_bubble_controller.h
[delete] https://crrev.com/525954c021bfdae0f91b53b67c67485189ef7892/chrome/browser/ui/cocoa/base_bubble_controller.mm
[delete] https://crrev.com/525954c021bfdae0f91b53b67c67485189ef7892/chrome/browser/ui/cocoa/base_bubble_controller_unittest.mm
[delete] https://crrev.com/525954c021bfdae0f91b53b67c67485189ef7892/chrome/browser/ui/cocoa/browser/zoom_bubble_controller.h
[delete] https://crrev.com/525954c021bfdae0f91b53b67c67485189ef7892/chrome/browser/ui/cocoa/browser/zoom_bubble_controller.mm
[delete] https://crrev.com/525954c021bfdae0f91b53b67c67485189ef7892/chrome/browser/ui/cocoa/browser/zoom_bubble_controller_unittest.mm
[modify] https://crrev.com/4a2c18051774bbc3a59a2301938e28a11363d9b0/chrome/browser/ui/cocoa/browser_window_cocoa.mm
[modify] https://crrev.com/4a2c18051774bbc3a59a2301938e28a11363d9b0/chrome/browser/ui/cocoa/extensions/browser_action_test_util_views_cocoa.mm
[delete] https://crrev.com/525954c021bfdae0f91b53b67c67485189ef7892/chrome/browser/ui/cocoa/info_bubble_view.h
[delete] https://crrev.com/525954c021bfdae0f91b53b67c67485189ef7892/chrome/browser/ui/cocoa/info_bubble_view.mm
[delete] https://crrev.com/525954c021bfdae0f91b53b67c67485189ef7892/chrome/browser/ui/cocoa/info_bubble_view_unittest.mm
[delete] https://crrev.com/525954c021bfdae0f91b53b67c67485189ef7892/chrome/browser/ui/cocoa/info_bubble_window.h
[delete] https://crrev.com/525954c021bfdae0f91b53b67c67485189ef7892/chrome/browser/ui/cocoa/info_bubble_window.mm
[delete] https://crrev.com/525954c021bfdae0f91b53b67c67485189ef7892/chrome/browser/ui/cocoa/info_bubble_window_unittest.mm
[modify] https://crrev.com/4a2c18051774bbc3a59a2301938e28a11363d9b0/chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm
[modify] https://crrev.com/4a2c18051774bbc3a59a2301938e28a11363d9b0/chrome/browser/ui/cocoa/location_bar/zoom_decoration.h
[modify] https://crrev.com/4a2c18051774bbc3a59a2301938e28a11363d9b0/chrome/browser/ui/cocoa/location_bar/zoom_decoration.mm
[modify] https://crrev.com/4a2c18051774bbc3a59a2301938e28a11363d9b0/chrome/browser/ui/cocoa/location_bar/zoom_decoration_browsertest.mm
[delete] https://crrev.com/525954c021bfdae0f91b53b67c67485189ef7892/chrome/browser/ui/cocoa/omnibox_decoration_bubble_controller.h
[delete] https://crrev.com/525954c021bfdae0f91b53b67c67485189ef7892/chrome/browser/ui/cocoa/omnibox_decoration_bubble_controller.mm
[modify] https://crrev.com/4a2c18051774bbc3a59a2301938e28a11363d9b0/chrome/test/BUILD.gn

Project Member

Comment 49 by bugdroid1@chromium.org, Sep 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/275f0f4c0560ccdb9fed8865313ecd41b6079eb3

commit 275f0f4c0560ccdb9fed8865313ecd41b6079eb3
Author: Nico Weber <thakis@chromium.org>
Date: Mon Sep 24 21:12:54 2018

mac: Remove unused PageInfoBubbleDecoration and permission bubble bits.

Bug: 832676
Change-Id: I4664d3052a0131ab591b166c1a725f042b55b6b0
Reviewed-on: https://chromium-review.googlesource.com/1240513
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593678}
[modify] https://crrev.com/275f0f4c0560ccdb9fed8865313ecd41b6079eb3/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/275f0f4c0560ccdb9fed8865313ecd41b6079eb3/chrome/browser/ui/bubble_anchor_util.h
[modify] https://crrev.com/275f0f4c0560ccdb9fed8865313ecd41b6079eb3/chrome/browser/ui/cocoa/browser_dialogs_views_mac.cc
[modify] https://crrev.com/275f0f4c0560ccdb9fed8865313ecd41b6079eb3/chrome/browser/ui/cocoa/browser_dialogs_views_mac.h
[modify] https://crrev.com/275f0f4c0560ccdb9fed8865313ecd41b6079eb3/chrome/browser/ui/cocoa/browser_window_cocoa.mm
[modify] https://crrev.com/275f0f4c0560ccdb9fed8865313ecd41b6079eb3/chrome/browser/ui/cocoa/bubble_anchor_helper.h
[modify] https://crrev.com/275f0f4c0560ccdb9fed8865313ecd41b6079eb3/chrome/browser/ui/cocoa/bubble_anchor_helper.mm
[modify] https://crrev.com/275f0f4c0560ccdb9fed8865313ecd41b6079eb3/chrome/browser/ui/cocoa/bubble_anchor_helper_views.h
[modify] https://crrev.com/275f0f4c0560ccdb9fed8865313ecd41b6079eb3/chrome/browser/ui/cocoa/bubble_anchor_helper_views.mm
[modify] https://crrev.com/275f0f4c0560ccdb9fed8865313ecd41b6079eb3/chrome/browser/ui/cocoa/bubble_anchor_util_views_mac.mm
[modify] https://crrev.com/275f0f4c0560ccdb9fed8865313ecd41b6079eb3/chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_cell_unittest.mm
[modify] https://crrev.com/275f0f4c0560ccdb9fed8865313ecd41b6079eb3/chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.h
[modify] https://crrev.com/275f0f4c0560ccdb9fed8865313ecd41b6079eb3/chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm
[delete] https://crrev.com/b7636abd91a88c54d81792dfafede02d7f09dcec/chrome/browser/ui/cocoa/location_bar/location_bar_view_mac_unittest.mm
[delete] https://crrev.com/b7636abd91a88c54d81792dfafede02d7f09dcec/chrome/browser/ui/cocoa/location_bar/page_info_bubble_decoration.h
[delete] https://crrev.com/b7636abd91a88c54d81792dfafede02d7f09dcec/chrome/browser/ui/cocoa/location_bar/page_info_bubble_decoration.mm
[delete] https://crrev.com/b7636abd91a88c54d81792dfafede02d7f09dcec/chrome/browser/ui/cocoa/location_bar/page_info_bubble_decoration_unittest.mm
[delete] https://crrev.com/b7636abd91a88c54d81792dfafede02d7f09dcec/chrome/browser/ui/cocoa/permission_bubble/chooser_bubble_ui_views_mac.mm
[modify] https://crrev.com/275f0f4c0560ccdb9fed8865313ecd41b6079eb3/chrome/browser/ui/cocoa/permission_bubble/permission_bubble_cocoa_interactive_uitest.mm
[delete] https://crrev.com/b7636abd91a88c54d81792dfafede02d7f09dcec/chrome/browser/ui/cocoa/permission_bubble/permission_prompt_impl_views_mac.mm
[modify] https://crrev.com/275f0f4c0560ccdb9fed8865313ecd41b6079eb3/chrome/browser/ui/views/bubble_anchor_util_views.cc
[modify] https://crrev.com/275f0f4c0560ccdb9fed8865313ecd41b6079eb3/chrome/browser/ui/views/content_setting_bubble_contents.h
[modify] https://crrev.com/275f0f4c0560ccdb9fed8865313ecd41b6079eb3/chrome/browser/ui/views/extensions/extension_installed_bubble_view.cc
[modify] https://crrev.com/275f0f4c0560ccdb9fed8865313ecd41b6079eb3/chrome/browser/ui/views/importer/import_lock_dialog_view.cc
[modify] https://crrev.com/275f0f4c0560ccdb9fed8865313ecd41b6079eb3/chrome/browser/ui/views/page_info/page_info_bubble_view.cc
[modify] https://crrev.com/275f0f4c0560ccdb9fed8865313ecd41b6079eb3/chrome/browser/ui/views/permission_bubble/chooser_bubble_ui.h
[modify] https://crrev.com/275f0f4c0560ccdb9fed8865313ecd41b6079eb3/chrome/browser/ui/views/permission_bubble/chooser_bubble_ui_views.cc
[modify] https://crrev.com/275f0f4c0560ccdb9fed8865313ecd41b6079eb3/chrome/test/BUILD.gn

Project Member

Comment 50 by bugdroid1@chromium.org, Sep 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5de70a38b3a3ad045911732045f585b70db6b198

commit 5de70a38b3a3ad045911732045f585b70db6b198
Author: Robert Sesek <rsesek@chromium.org>
Date: Mon Sep 24 22:50:01 2018

mac: Delete AlertIndicatorButtonCocoa.

Bug: 832676
Change-Id: Ib83450567e95f83f819980fccb2ea81c6be2a326
Reviewed-on: https://chromium-review.googlesource.com/1241496
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593725}
[modify] https://crrev.com/5de70a38b3a3ad045911732045f585b70db6b198/chrome/browser/ui/BUILD.gn
[delete] https://crrev.com/8d62c04a52d001bf62879a1b0b22e0ba030f9456/chrome/browser/ui/cocoa/tabs/alert_indicator_button_cocoa.h
[delete] https://crrev.com/8d62c04a52d001bf62879a1b0b22e0ba030f9456/chrome/browser/ui/cocoa/tabs/alert_indicator_button_cocoa.mm
[delete] https://crrev.com/8d62c04a52d001bf62879a1b0b22e0ba030f9456/chrome/browser/ui/cocoa/tabs/alert_indicator_button_cocoa_unittest.mm
[modify] https://crrev.com/5de70a38b3a3ad045911732045f585b70db6b198/chrome/browser/ui/cocoa/tabs/tab_controller.h
[modify] https://crrev.com/5de70a38b3a3ad045911732045f585b70db6b198/chrome/browser/ui/cocoa/tabs/tab_controller.mm
[modify] https://crrev.com/5de70a38b3a3ad045911732045f585b70db6b198/chrome/browser/ui/cocoa/tabs/tab_controller_unittest.mm
[modify] https://crrev.com/5de70a38b3a3ad045911732045f585b70db6b198/chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm
[modify] https://crrev.com/5de70a38b3a3ad045911732045f585b70db6b198/chrome/browser/ui/cocoa/tabs/tab_view.mm
[modify] https://crrev.com/5de70a38b3a3ad045911732045f585b70db6b198/chrome/test/BUILD.gn

Project Member

Comment 51 by bugdroid1@chromium.org, Sep 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bab140698dd2c254177dc920a599f5da296eef21

commit bab140698dd2c254177dc920a599f5da296eef21
Author: Robert Sesek <rsesek@chromium.org>
Date: Mon Sep 24 22:52:30 2018

mac: Delete Cocoa extensions.

Bug: 832676
Change-Id: I1a7c9f0834789bbf67692edcd5317d0487905b9f
Reviewed-on: https://chromium-review.googlesource.com/1241713
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593728}
[modify] https://crrev.com/bab140698dd2c254177dc920a599f5da296eef21/chrome/app/nibs/Toolbar.xib
[delete] https://crrev.com/e7aa5e57da6fc22a1afb06f2d3e5f435a2f63484/chrome/app/theme/default_100_percent/common/developer_mode_highlight_bottom.png
[delete] https://crrev.com/e7aa5e57da6fc22a1afb06f2d3e5f435a2f63484/chrome/app/theme/default_100_percent/common/developer_mode_highlight_bottom_left.png
[delete] https://crrev.com/e7aa5e57da6fc22a1afb06f2d3e5f435a2f63484/chrome/app/theme/default_100_percent/common/developer_mode_highlight_bottom_right.png
[delete] https://crrev.com/e7aa5e57da6fc22a1afb06f2d3e5f435a2f63484/chrome/app/theme/default_100_percent/common/developer_mode_highlight_center.png
[delete] https://crrev.com/e7aa5e57da6fc22a1afb06f2d3e5f435a2f63484/chrome/app/theme/default_100_percent/common/developer_mode_highlight_left.png
[delete] https://crrev.com/e7aa5e57da6fc22a1afb06f2d3e5f435a2f63484/chrome/app/theme/default_100_percent/common/developer_mode_highlight_right.png
[delete] https://crrev.com/e7aa5e57da6fc22a1afb06f2d3e5f435a2f63484/chrome/app/theme/default_100_percent/common/developer_mode_highlight_top.png
[delete] https://crrev.com/e7aa5e57da6fc22a1afb06f2d3e5f435a2f63484/chrome/app/theme/default_100_percent/common/developer_mode_highlight_top_left.png
[delete] https://crrev.com/e7aa5e57da6fc22a1afb06f2d3e5f435a2f63484/chrome/app/theme/default_100_percent/common/developer_mode_highlight_top_right.png
[delete] https://crrev.com/e7aa5e57da6fc22a1afb06f2d3e5f435a2f63484/chrome/app/theme/default_200_percent/common/developer_mode_highlight_bottom.png
[delete] https://crrev.com/e7aa5e57da6fc22a1afb06f2d3e5f435a2f63484/chrome/app/theme/default_200_percent/common/developer_mode_highlight_bottom_left.png
[delete] https://crrev.com/e7aa5e57da6fc22a1afb06f2d3e5f435a2f63484/chrome/app/theme/default_200_percent/common/developer_mode_highlight_bottom_right.png
[delete] https://crrev.com/e7aa5e57da6fc22a1afb06f2d3e5f435a2f63484/chrome/app/theme/default_200_percent/common/developer_mode_highlight_center.png
[delete] https://crrev.com/e7aa5e57da6fc22a1afb06f2d3e5f435a2f63484/chrome/app/theme/default_200_percent/common/developer_mode_highlight_left.png
[delete] https://crrev.com/e7aa5e57da6fc22a1afb06f2d3e5f435a2f63484/chrome/app/theme/default_200_percent/common/developer_mode_highlight_right.png
[delete] https://crrev.com/e7aa5e57da6fc22a1afb06f2d3e5f435a2f63484/chrome/app/theme/default_200_percent/common/developer_mode_highlight_top.png
[delete] https://crrev.com/e7aa5e57da6fc22a1afb06f2d3e5f435a2f63484/chrome/app/theme/default_200_percent/common/developer_mode_highlight_top_left.png
[delete] https://crrev.com/e7aa5e57da6fc22a1afb06f2d3e5f435a2f63484/chrome/app/theme/default_200_percent/common/developer_mode_highlight_top_right.png
[modify] https://crrev.com/bab140698dd2c254177dc920a599f5da296eef21/chrome/app/theme/theme_resources.grd
[modify] https://crrev.com/bab140698dd2c254177dc920a599f5da296eef21/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/bab140698dd2c254177dc920a599f5da296eef21/chrome/browser/ui/cocoa/browser_window_cocoa.mm
[modify] https://crrev.com/bab140698dd2c254177dc920a599f5da296eef21/chrome/browser/ui/cocoa/browser_window_controller.mm
[modify] https://crrev.com/bab140698dd2c254177dc920a599f5da296eef21/chrome/browser/ui/cocoa/bubble_anchor_util_views_mac.mm
[delete] https://crrev.com/e7aa5e57da6fc22a1afb06f2d3e5f435a2f63484/chrome/browser/ui/cocoa/extensions/browser_action_button.h
[delete] https://crrev.com/e7aa5e57da6fc22a1afb06f2d3e5f435a2f63484/chrome/browser/ui/cocoa/extensions/browser_action_button.mm
[delete] https://crrev.com/e7aa5e57da6fc22a1afb06f2d3e5f435a2f63484/chrome/browser/ui/cocoa/extensions/browser_action_test_util_views_cocoa.mm
[delete] https://crrev.com/e7aa5e57da6fc22a1afb06f2d3e5f435a2f63484/chrome/browser/ui/cocoa/extensions/browser_actions_container_view.h
[delete] https://crrev.com/e7aa5e57da6fc22a1afb06f2d3e5f435a2f63484/chrome/browser/ui/cocoa/extensions/browser_actions_container_view.mm
[delete] https://crrev.com/e7aa5e57da6fc22a1afb06f2d3e5f435a2f63484/chrome/browser/ui/cocoa/extensions/browser_actions_container_view_unittest.mm
[delete] https://crrev.com/e7aa5e57da6fc22a1afb06f2d3e5f435a2f63484/chrome/browser/ui/cocoa/extensions/browser_actions_controller.h
[delete] https://crrev.com/e7aa5e57da6fc22a1afb06f2d3e5f435a2f63484/chrome/browser/ui/cocoa/extensions/browser_actions_controller.mm
[delete] https://crrev.com/e7aa5e57da6fc22a1afb06f2d3e5f435a2f63484/chrome/browser/ui/cocoa/extensions/extension_action_platform_delegate_cocoa.h
[delete] https://crrev.com/e7aa5e57da6fc22a1afb06f2d3e5f435a2f63484/chrome/browser/ui/cocoa/extensions/extension_action_platform_delegate_cocoa.mm
[delete] https://crrev.com/e7aa5e57da6fc22a1afb06f2d3e5f435a2f63484/chrome/browser/ui/cocoa/extensions/extension_message_bubble_views_browsertest_mac.mm
[delete] https://crrev.com/e7aa5e57da6fc22a1afb06f2d3e5f435a2f63484/chrome/browser/ui/cocoa/extensions/extension_popup_views_mac.h
[delete] https://crrev.com/e7aa5e57da6fc22a1afb06f2d3e5f435a2f63484/chrome/browser/ui/cocoa/extensions/extension_popup_views_mac.mm
[delete] https://crrev.com/e7aa5e57da6fc22a1afb06f2d3e5f435a2f63484/chrome/browser/ui/cocoa/extensions/toolbar_actions_bar_bubble_views_presenter.h
[delete] https://crrev.com/e7aa5e57da6fc22a1afb06f2d3e5f435a2f63484/chrome/browser/ui/cocoa/extensions/toolbar_actions_bar_bubble_views_presenter.mm
[modify] https://crrev.com/bab140698dd2c254177dc920a599f5da296eef21/chrome/browser/ui/cocoa/toolbar/toolbar_controller.h
[modify] https://crrev.com/bab140698dd2c254177dc920a599f5da296eef21/chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm
[delete] https://crrev.com/e7aa5e57da6fc22a1afb06f2d3e5f435a2f63484/chrome/browser/ui/cocoa/toolbar/toolbar_controller_unittest.mm
[modify] https://crrev.com/bab140698dd2c254177dc920a599f5da296eef21/chrome/browser/ui/extensions/extension_action_platform_delegate.h
[modify] https://crrev.com/bab140698dd2c254177dc920a599f5da296eef21/chrome/browser/ui/views/extensions/extension_action_platform_delegate_views.cc
[modify] https://crrev.com/bab140698dd2c254177dc920a599f5da296eef21/chrome/browser/ui/views/extensions/extension_message_bubble_view_browsertest_views.cc
[modify] https://crrev.com/bab140698dd2c254177dc920a599f5da296eef21/chrome/browser/ui/views/toolbar/browser_action_test_util_views.cc
[modify] https://crrev.com/bab140698dd2c254177dc920a599f5da296eef21/chrome/test/BUILD.gn

Project Member

Comment 52 by bugdroid1@chromium.org, Sep 25

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/14f33a9d6d9c83a79ec2f3171d737ea888abfea3

commit 14f33a9d6d9c83a79ec2f3171d737ea888abfea3
Author: Nico Weber <thakis@chromium.org>
Date: Tue Sep 25 00:07:13 2018

mac: Remove GetAppMenuAnchorRectCocoa() and TrackBubbleState().

Bug: 832676
Change-Id: If227bcc8b17bb5bcd8563c921c41794d4c7e9dc0
Reviewed-on: https://chromium-review.googlesource.com/1241497
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593760}
[modify] https://crrev.com/14f33a9d6d9c83a79ec2f3171d737ea888abfea3/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/14f33a9d6d9c83a79ec2f3171d737ea888abfea3/chrome/browser/ui/bubble_anchor_util.h
[modify] https://crrev.com/14f33a9d6d9c83a79ec2f3171d737ea888abfea3/chrome/browser/ui/cocoa/bubble_anchor_helper_views.h
[modify] https://crrev.com/14f33a9d6d9c83a79ec2f3171d737ea888abfea3/chrome/browser/ui/cocoa/bubble_anchor_helper_views.mm
[delete] https://crrev.com/c7340785c74d3d7ea74b557244c46270ebd69b67/chrome/browser/ui/cocoa/bubble_anchor_util_views_mac.mm
[modify] https://crrev.com/14f33a9d6d9c83a79ec2f3171d737ea888abfea3/chrome/browser/ui/views/global_error_bubble_view.cc
[modify] https://crrev.com/14f33a9d6d9c83a79ec2f3171d737ea888abfea3/chrome/browser/ui/views/session_crashed_bubble_view.cc
[modify] https://crrev.com/14f33a9d6d9c83a79ec2f3171d737ea888abfea3/chrome/browser/ui/views/session_crashed_bubble_view_browsertest.cc

Project Member

Comment 53 by bugdroid1@chromium.org, Sep 25

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/404bbbd8c6d0e65d55a2b4c0ee7b2e17a1b7aa9e

commit 404bbbd8c6d0e65d55a2b4c0ee7b2e17a1b7aa9e
Author: Robert Sesek <rsesek@chromium.org>
Date: Tue Sep 25 00:10:48 2018

mac: Delete some unused Cocoa control types.

Bug: 832676
Change-Id: Ida8c7de8f6245e76d1f18928efa1929e642ed0b9
Reviewed-on: https://chromium-review.googlesource.com/1241714
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593763}
[modify] https://crrev.com/404bbbd8c6d0e65d55a2b4c0ee7b2e17a1b7aa9e/chrome/browser/ui/BUILD.gn
[delete] https://crrev.com/3e60c04292e92cc617937515f0c9a9df826bcc0f/chrome/browser/ui/cocoa/draggable_button.h
[delete] https://crrev.com/3e60c04292e92cc617937515f0c9a9df826bcc0f/chrome/browser/ui/cocoa/draggable_button.mm
[delete] https://crrev.com/3e60c04292e92cc617937515f0c9a9df826bcc0f/chrome/browser/ui/cocoa/draggable_button_mixin.h
[delete] https://crrev.com/3e60c04292e92cc617937515f0c9a9df826bcc0f/chrome/browser/ui/cocoa/draggable_button_mixin.mm
[delete] https://crrev.com/3e60c04292e92cc617937515f0c9a9df826bcc0f/chrome/browser/ui/cocoa/draggable_button_unittest.mm
[delete] https://crrev.com/3e60c04292e92cc617937515f0c9a9df826bcc0f/chrome/browser/ui/cocoa/harmony_button.h
[delete] https://crrev.com/3e60c04292e92cc617937515f0c9a9df826bcc0f/chrome/browser/ui/cocoa/harmony_button.mm
[delete] https://crrev.com/3e60c04292e92cc617937515f0c9a9df826bcc0f/chrome/browser/ui/cocoa/harmony_button_unittest.mm
[delete] https://crrev.com/3e60c04292e92cc617937515f0c9a9df826bcc0f/chrome/browser/ui/cocoa/md_hover_button.h
[delete] https://crrev.com/3e60c04292e92cc617937515f0c9a9df826bcc0f/chrome/browser/ui/cocoa/md_hover_button.mm
[delete] https://crrev.com/3e60c04292e92cc617937515f0c9a9df826bcc0f/chrome/browser/ui/cocoa/md_hover_button_unittest.mm
[delete] https://crrev.com/3e60c04292e92cc617937515f0c9a9df826bcc0f/chrome/browser/ui/cocoa/multi_key_equivalent_button.h
[delete] https://crrev.com/3e60c04292e92cc617937515f0c9a9df826bcc0f/chrome/browser/ui/cocoa/multi_key_equivalent_button.mm
[modify] https://crrev.com/404bbbd8c6d0e65d55a2b4c0ee7b2e17a1b7aa9e/chrome/test/BUILD.gn

Project Member

Comment 54 by bugdroid1@chromium.org, Sep 25

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a2bc20dada7e4fc28872bd8f9be842aa9a1af50e

commit a2bc20dada7e4fc28872bd8f9be842aa9a1af50e
Author: Nico Weber <thakis@chromium.org>
Date: Tue Sep 25 00:31:29 2018

mac: Remove remaining LocationBarDecoration subclasses.

Bug: 832676
Change-Id: Icacc8c67dea39708ff945ac564d39ed94727648c
Reviewed-on: https://chromium-review.googlesource.com/1241657
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593772}
[modify] https://crrev.com/a2bc20dada7e4fc28872bd8f9be842aa9a1af50e/chrome/browser/ui/BUILD.gn
[delete] https://crrev.com/a15736cafe8f12d7f691defaac7e2370d4eb5f8d/chrome/browser/ui/cocoa/location_bar/bubble_decoration.h
[delete] https://crrev.com/a15736cafe8f12d7f691defaac7e2370d4eb5f8d/chrome/browser/ui/cocoa/location_bar/bubble_decoration.mm
[delete] https://crrev.com/a15736cafe8f12d7f691defaac7e2370d4eb5f8d/chrome/browser/ui/cocoa/location_bar/image_decoration.h
[delete] https://crrev.com/a15736cafe8f12d7f691defaac7e2370d4eb5f8d/chrome/browser/ui/cocoa/location_bar/image_decoration.mm
[delete] https://crrev.com/a15736cafe8f12d7f691defaac7e2370d4eb5f8d/chrome/browser/ui/cocoa/location_bar/image_decoration_unittest.mm
[modify] https://crrev.com/a2bc20dada7e4fc28872bd8f9be842aa9a1af50e/chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.h
[modify] https://crrev.com/a2bc20dada7e4fc28872bd8f9be842aa9a1af50e/chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm
[delete] https://crrev.com/a15736cafe8f12d7f691defaac7e2370d4eb5f8d/chrome/browser/ui/cocoa/location_bar/zoom_decoration.h
[delete] https://crrev.com/a15736cafe8f12d7f691defaac7e2370d4eb5f8d/chrome/browser/ui/cocoa/location_bar/zoom_decoration.mm
[delete] https://crrev.com/a15736cafe8f12d7f691defaac7e2370d4eb5f8d/chrome/browser/ui/cocoa/location_bar/zoom_decoration_browsertest.mm
[delete] https://crrev.com/a15736cafe8f12d7f691defaac7e2370d4eb5f8d/chrome/browser/ui/cocoa/location_bar/zoom_decoration_unittest.mm
[modify] https://crrev.com/a2bc20dada7e4fc28872bd8f9be842aa9a1af50e/chrome/test/BUILD.gn

Comment 55 by tapted@chromium.org, Sep 25

Cc: anthonyvd@chromium.org tapted@chromium.org vasi...@chromium.org

Issue 887811 has been merged into this issue.

Project Member

Comment 56 by bugdroid1@chromium.org, Sep 25

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/563da2f9260d7662de656ef000a9f835f33c44b4

commit 563da2f9260d7662de656ef000a9f835f33c44b4
Author: Nico Weber <thakis@chromium.org>
Date: Tue Sep 25 13:23:30 2018

mac: Remove unused KeepBubbleAnchored().

Bug: 832676
Change-Id: I97bdc876134729f448a6f911980e63cebde9db6b
Reviewed-on: https://chromium-review.googlesource.com/1242336
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593911}
[modify] https://crrev.com/563da2f9260d7662de656ef000a9f835f33c44b4/chrome/browser/ui/BUILD.gn
[delete] https://crrev.com/ff82e68b55400a78614d3b6fd83c7f62e8a2c30f/chrome/browser/ui/cocoa/bubble_anchor_helper_views.h
[delete] https://crrev.com/ff82e68b55400a78614d3b6fd83c7f62e8a2c30f/chrome/browser/ui/cocoa/bubble_anchor_helper_views.mm
[delete] https://crrev.com/ff82e68b55400a78614d3b6fd83c7f62e8a2c30f/chrome/browser/ui/cocoa/bubble_anchor_helper_views_unittest.mm
[modify] https://crrev.com/563da2f9260d7662de656ef000a9f835f33c44b4/chrome/browser/ui/cocoa/permission_bubble/permission_bubble_cocoa_interactive_uitest.mm
[modify] https://crrev.com/563da2f9260d7662de656ef000a9f835f33c44b4/chrome/test/BUILD.gn

Project Member

Comment 57 by bugdroid1@chromium.org, Sep 25

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/edd51630cc3f320c1c60d71d59de57f714f01e0d

commit edd51630cc3f320c1c60d71d59de57f714f01e0d
Author: Nico Weber <thakis@chromium.org>
Date: Tue Sep 25 14:38:21 2018

mac: Remove DeviceChooserContentViewCocoa.

Bug: 832676
Change-Id: I8d2a3aa8b3c1b4e2fa5caa677b8f66cf94b07579
Reviewed-on: https://chromium-review.googlesource.com/1242337
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593924}
[modify] https://crrev.com/edd51630cc3f320c1c60d71d59de57f714f01e0d/chrome/browser/ui/BUILD.gn
[delete] https://crrev.com/1f63eb0820a9805d5dda2bf11ec986aa9f26c888/chrome/browser/ui/cocoa/device_chooser_content_view_cocoa.h
[delete] https://crrev.com/1f63eb0820a9805d5dda2bf11ec986aa9f26c888/chrome/browser/ui/cocoa/device_chooser_content_view_cocoa.mm

Project Member

Comment 58 by bugdroid1@chromium.org, Sep 25

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/76b43718d658e2daa1f49f06a1e57ec2137156f6

commit 76b43718d658e2daa1f49f06a1e57ec2137156f6
Author: Nico Weber <thakis@chromium.org>
Date: Tue Sep 25 15:02:06 2018

mac: Remove StatusBubbleMac.

Bug: 832676
Change-Id: I4eebf5172371c2e69feef32d9fed265716992020
Reviewed-on: https://chromium-review.googlesource.com/1242136
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593934}
[modify] https://crrev.com/76b43718d658e2daa1f49f06a1e57ec2137156f6/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/76b43718d658e2daa1f49f06a1e57ec2137156f6/chrome/browser/ui/cocoa/browser_window_cocoa.mm
[modify] https://crrev.com/76b43718d658e2daa1f49f06a1e57ec2137156f6/chrome/browser/ui/cocoa/browser_window_controller.h
[modify] https://crrev.com/76b43718d658e2daa1f49f06a1e57ec2137156f6/chrome/browser/ui/cocoa/browser_window_controller.mm
[modify] https://crrev.com/76b43718d658e2daa1f49f06a1e57ec2137156f6/chrome/browser/ui/cocoa/browser_window_controller_private.mm
[delete] https://crrev.com/9152d53ff4f0ed59c1d9e149c463e384dead73a1/chrome/browser/ui/cocoa/status_bubble_mac.h
[delete] https://crrev.com/9152d53ff4f0ed59c1d9e149c463e384dead73a1/chrome/browser/ui/cocoa/status_bubble_mac.mm
[delete] https://crrev.com/9152d53ff4f0ed59c1d9e149c463e384dead73a1/chrome/browser/ui/cocoa/status_bubble_mac_unittest.mm
[modify] https://crrev.com/76b43718d658e2daa1f49f06a1e57ec2137156f6/chrome/test/BUILD.gn

Project Member

Comment 59 by bugdroid1@chromium.org, Sep 25

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c663200d7f97d8caf68e39c0e1ef4ff5ffa6e852

commit c663200d7f97d8caf68e39c0e1ef4ff5ffa6e852
Author: Robert Sesek <rsesek@chromium.org>
Date: Tue Sep 25 17:49:07 2018

mac: Delete the Cocoa download started animation.

Bug: 832676
Change-Id: Ibeba925bbd23e5eb33aeaf748bc2f48161db6a96
Reviewed-on: https://chromium-review.googlesource.com/1243727
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593994}
[delete] https://crrev.com/189eca26a74224d31e302bf0075f99cb6b2873f0/chrome/app/theme/default_100_percent/legacy/download_animation_begin.png
[delete] https://crrev.com/189eca26a74224d31e302bf0075f99cb6b2873f0/chrome/app/theme/default_200_percent/legacy/download_animation_begin.png
[modify] https://crrev.com/c663200d7f97d8caf68e39c0e1ef4ff5ffa6e852/chrome/app/theme/theme_resources.grd
[modify] https://crrev.com/c663200d7f97d8caf68e39c0e1ef4ff5ffa6e852/chrome/browser/download/download_started_animation.h
[modify] https://crrev.com/c663200d7f97d8caf68e39c0e1ef4ff5ffa6e852/chrome/browser/ui/BUILD.gn
[delete] https://crrev.com/189eca26a74224d31e302bf0075f99cb6b2873f0/chrome/browser/ui/cocoa/download/download_started_animation_mac.mm
[modify] https://crrev.com/c663200d7f97d8caf68e39c0e1ef4ff5ffa6e852/chrome/browser/ui/views/download/download_started_animation_views.cc

Project Member

Comment 60 by bugdroid1@chromium.org, Sep 25

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d030b2ef7653a0558b2dbe05c6530c70b541fee4

commit d030b2ef7653a0558b2dbe05c6530c70b541fee4
Author: Nico Weber <thakis@chromium.org>
Date: Tue Sep 25 18:33:57 2018

mac: Remove cocoa location_bar and omnibox.

LocationBarViewMac is replaced with a stub for now, since a
bunch of tests need a non-null object.

Bug: 832676
Change-Id: I71a2baddb540c24bc129141a0f08a1dfc5856aff
Reviewed-on: https://chromium-review.googlesource.com/1242135
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594022}
[modify] https://crrev.com/d030b2ef7653a0558b2dbe05c6530c70b541fee4/chrome/app/nibs/Toolbar.xib
[modify] https://crrev.com/d030b2ef7653a0558b2dbe05c6530c70b541fee4/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/d030b2ef7653a0558b2dbe05c6530c70b541fee4/chrome/browser/ui/cocoa/browser_window_cocoa.mm
[modify] https://crrev.com/d030b2ef7653a0558b2dbe05c6530c70b541fee4/chrome/browser/ui/cocoa/browser_window_controller.h
[modify] https://crrev.com/d030b2ef7653a0558b2dbe05c6530c70b541fee4/chrome/browser/ui/cocoa/browser_window_controller.mm
[modify] https://crrev.com/d030b2ef7653a0558b2dbe05c6530c70b541fee4/chrome/browser/ui/cocoa/browser_window_controller_browsertest.mm
[modify] https://crrev.com/d030b2ef7653a0558b2dbe05c6530c70b541fee4/chrome/browser/ui/cocoa/browser_window_controller_private.mm
[modify] https://crrev.com/d030b2ef7653a0558b2dbe05c6530c70b541fee4/chrome/browser/ui/cocoa/bubble_anchor_helper.mm
[delete] https://crrev.com/6a81659772c595b077383df27ed5103f8aada84d/chrome/browser/ui/cocoa/location_bar/autocomplete_text_field.h
[delete] https://crrev.com/6a81659772c595b077383df27ed5103f8aada84d/chrome/browser/ui/cocoa/location_bar/autocomplete_text_field.mm
[delete] https://crrev.com/6a81659772c595b077383df27ed5103f8aada84d/chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_cell.h
[delete] https://crrev.com/6a81659772c595b077383df27ed5103f8aada84d/chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_cell.mm
[delete] https://crrev.com/6a81659772c595b077383df27ed5103f8aada84d/chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_cell_unittest.mm
[delete] https://crrev.com/6a81659772c595b077383df27ed5103f8aada84d/chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_editor.h
[delete] https://crrev.com/6a81659772c595b077383df27ed5103f8aada84d/chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_editor.mm
[delete] https://crrev.com/6a81659772c595b077383df27ed5103f8aada84d/chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_editor_unittest.mm
[delete] https://crrev.com/6a81659772c595b077383df27ed5103f8aada84d/chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_unittest.mm
[delete] https://crrev.com/6a81659772c595b077383df27ed5103f8aada84d/chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_unittest_helper.h
[delete] https://crrev.com/6a81659772c595b077383df27ed5103f8aada84d/chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_unittest_helper.mm
[delete] https://crrev.com/6a81659772c595b077383df27ed5103f8aada84d/chrome/browser/ui/cocoa/location_bar/location_bar_decoration.h
[delete] https://crrev.com/6a81659772c595b077383df27ed5103f8aada84d/chrome/browser/ui/cocoa/location_bar/location_bar_decoration.mm
[modify] https://crrev.com/d030b2ef7653a0558b2dbe05c6530c70b541fee4/chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.h
[modify] https://crrev.com/d030b2ef7653a0558b2dbe05c6530c70b541fee4/chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm
[delete] https://crrev.com/6a81659772c595b077383df27ed5103f8aada84d/chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell.h
[delete] https://crrev.com/6a81659772c595b077383df27ed5103f8aada84d/chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell.mm
[delete] https://crrev.com/6a81659772c595b077383df27ed5103f8aada84d/chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell_unittest.mm
[delete] https://crrev.com/6a81659772c595b077383df27ed5103f8aada84d/chrome/browser/ui/cocoa/omnibox/omnibox_popup_matrix.h
[delete] https://crrev.com/6a81659772c595b077383df27ed5103f8aada84d/chrome/browser/ui/cocoa/omnibox/omnibox_popup_matrix.mm
[delete] https://crrev.com/6a81659772c595b077383df27ed5103f8aada84d/chrome/browser/ui/cocoa/omnibox/omnibox_popup_matrix_unittest.mm
[delete] https://crrev.com/6a81659772c595b077383df27ed5103f8aada84d/chrome/browser/ui/cocoa/omnibox/omnibox_popup_separator_view.h
[delete] https://crrev.com/6a81659772c595b077383df27ed5103f8aada84d/chrome/browser/ui/cocoa/omnibox/omnibox_popup_separator_view.mm
[delete] https://crrev.com/6a81659772c595b077383df27ed5103f8aada84d/chrome/browser/ui/cocoa/omnibox/omnibox_popup_separator_view_unittest.mm
[delete] https://crrev.com/6a81659772c595b077383df27ed5103f8aada84d/chrome/browser/ui/cocoa/omnibox/omnibox_popup_view_mac.h
[delete] https://crrev.com/6a81659772c595b077383df27ed5103f8aada84d/chrome/browser/ui/cocoa/omnibox/omnibox_popup_view_mac.mm
[delete] https://crrev.com/6a81659772c595b077383df27ed5103f8aada84d/chrome/browser/ui/cocoa/omnibox/omnibox_popup_view_mac_unittest.mm
[delete] https://crrev.com/6a81659772c595b077383df27ed5103f8aada84d/chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.h
[delete] https://crrev.com/6a81659772c595b077383df27ed5103f8aada84d/chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm
[delete] https://crrev.com/6a81659772c595b077383df27ed5103f8aada84d/chrome/browser/ui/cocoa/omnibox/omnibox_view_mac_browsertest.mm
[delete] https://crrev.com/6a81659772c595b077383df27ed5103f8aada84d/chrome/browser/ui/cocoa/omnibox/omnibox_view_mac_unittest.mm
[modify] https://crrev.com/d030b2ef7653a0558b2dbe05c6530c70b541fee4/chrome/browser/ui/cocoa/permission_bubble/permission_bubble_cocoa_interactive_uitest.mm
[modify] https://crrev.com/d030b2ef7653a0558b2dbe05c6530c70b541fee4/chrome/browser/ui/cocoa/renderer_context_menu/render_view_context_menu_mac_cocoa_browsertest.mm
[modify] https://crrev.com/d030b2ef7653a0558b2dbe05c6530c70b541fee4/chrome/browser/ui/cocoa/toolbar/toolbar_controller.h
[modify] https://crrev.com/d030b2ef7653a0558b2dbe05c6530c70b541fee4/chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm
[modify] https://crrev.com/d030b2ef7653a0558b2dbe05c6530c70b541fee4/chrome/test/BUILD.gn

Project Member

Comment 61 by bugdroid1@chromium.org, Sep 25

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cbdf1155879f9bbaf1f78d97d09203b33bb2c202

commit cbdf1155879f9bbaf1f78d97d09203b33bb2c202
Author: Nico Weber <thakis@chromium.org>
Date: Tue Sep 25 18:58:57 2018

mac: Remove unused BubbleView and BubbleCombobox.

Bug: 832676
Change-Id: I5ea07707d3603cbe5ef88d098d96cdd41be05d0d
Reviewed-on: https://chromium-review.googlesource.com/1243976
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594033}
[modify] https://crrev.com/cbdf1155879f9bbaf1f78d97d09203b33bb2c202/chrome/browser/ui/BUILD.gn
[delete] https://crrev.com/fffa35f66e61818a4c84119157711ecbea109739/chrome/browser/ui/cocoa/bubble_combobox.h
[delete] https://crrev.com/fffa35f66e61818a4c84119157711ecbea109739/chrome/browser/ui/cocoa/bubble_combobox.mm
[delete] https://crrev.com/fffa35f66e61818a4c84119157711ecbea109739/chrome/browser/ui/cocoa/bubble_view.h
[delete] https://crrev.com/fffa35f66e61818a4c84119157711ecbea109739/chrome/browser/ui/cocoa/bubble_view.mm
[delete] https://crrev.com/fffa35f66e61818a4c84119157711ecbea109739/chrome/browser/ui/cocoa/bubble_view_unittest.mm
[modify] https://crrev.com/cbdf1155879f9bbaf1f78d97d09203b33bb2c202/chrome/test/BUILD.gn

Project Member

Comment 62 by bugdroid1@chromium.org, Sep 25

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/868144a82dea3169dece0c84b3dcedbb473f9d3f

commit 868144a82dea3169dece0c84b3dcedbb473f9d3f
Author: Robert Sesek <rsesek@chromium.org>
Date: Tue Sep 25 19:13:37 2018

mac: Delete DevToolsController.

Bug: 832676
Change-Id: I3d5d3db47c3a1e1ba3f8604ac6ab4ca7857887cf
Reviewed-on: https://chromium-review.googlesource.com/1243728
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594044}
[modify] https://crrev.com/868144a82dea3169dece0c84b3dcedbb473f9d3f/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/868144a82dea3169dece0c84b3dcedbb473f9d3f/chrome/browser/ui/cocoa/browser_window_controller.h
[modify] https://crrev.com/868144a82dea3169dece0c84b3dcedbb473f9d3f/chrome/browser/ui/cocoa/browser_window_controller.mm
[modify] https://crrev.com/868144a82dea3169dece0c84b3dcedbb473f9d3f/chrome/browser/ui/cocoa/browser_window_controller_private.mm
[delete] https://crrev.com/74c88cc194b8059c8bc5a9286eb89ff7646573ab/chrome/browser/ui/cocoa/dev_tools_controller.h
[delete] https://crrev.com/74c88cc194b8059c8bc5a9286eb89ff7646573ab/chrome/browser/ui/cocoa/dev_tools_controller.mm
[delete] https://crrev.com/74c88cc194b8059c8bc5a9286eb89ff7646573ab/chrome/browser/ui/cocoa/dev_tools_controller_browsertest.mm
[modify] https://crrev.com/868144a82dea3169dece0c84b3dcedbb473f9d3f/chrome/test/BUILD.gn

Project Member

Comment 63 by bugdroid1@chromium.org, Sep 25

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e890f893111ef2c9bdbbadc33461f9134b005c81

commit e890f893111ef2c9bdbbadc33461f9134b005c81
Author: Nico Weber <thakis@chromium.org>
Date: Tue Sep 25 20:04:46 2018

mac: Remove unused SingleWebContentsDialogManagerViewsMac.

Also removes a layering violation between components/ and chrome/.

Bug: 832676
Change-Id: Id894be95a9ac589da59b7a8f5587a3f4a09307cf
Reviewed-on: https://chromium-review.googlesource.com/1244017
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Mike Wittman <wittman@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594071}
[modify] https://crrev.com/e890f893111ef2c9bdbbadc33461f9134b005c81/chrome/browser/ui/BUILD.gn
[delete] https://crrev.com/3ce09fc0fbab401f6e5c9cbaaeac8ed88c4a54af/chrome/browser/ui/cocoa/create_native_web_modal_manager_cocoa.mm
[delete] https://crrev.com/3ce09fc0fbab401f6e5c9cbaaeac8ed88c4a54af/chrome/browser/ui/cocoa/web_contents_modal_dialog_manager_views_mac.h
[delete] https://crrev.com/3ce09fc0fbab401f6e5c9cbaaeac8ed88c4a54af/chrome/browser/ui/cocoa/web_contents_modal_dialog_manager_views_mac.mm
[delete] https://crrev.com/3ce09fc0fbab401f6e5c9cbaaeac8ed88c4a54af/chrome/browser/ui/cocoa/web_contents_modal_dialog_manager_views_mac_browsertest.mm
[modify] https://crrev.com/e890f893111ef2c9bdbbadc33461f9134b005c81/chrome/test/BUILD.gn
[modify] https://crrev.com/e890f893111ef2c9bdbbadc33461f9134b005c81/components/constrained_window/BUILD.gn
[delete] https://crrev.com/3ce09fc0fbab401f6e5c9cbaaeac8ed88c4a54af/components/constrained_window/show_modal_dialog_cocoa.cc
[modify] https://crrev.com/e890f893111ef2c9bdbbadc33461f9134b005c81/components/constrained_window/show_modal_dialog_views.cc
[delete] https://crrev.com/3ce09fc0fbab401f6e5c9cbaaeac8ed88c4a54af/components/constrained_window/test_create_native_web_modal_manager_cocoa.cc
[modify] https://crrev.com/e890f893111ef2c9bdbbadc33461f9134b005c81/components/web_modal/web_contents_modal_dialog_manager.h

Project Member

Comment 64 by bugdroid1@chromium.org, Sep 25

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/240cf0f47b7d1b7c02530d01f96e070b21f5ebb5

commit 240cf0f47b7d1b7c02530d01f96e070b21f5ebb5
Author: Nico Weber <thakis@chromium.org>
Date: Tue Sep 25 20:08:08 2018

mac: Remove some unused bits of constrained_windows, and molokocacao.

Bug: 832676
Change-Id: Iac4e3e7c9e959f65a5f113653af8122b1a212519
Reviewed-on: https://chromium-review.googlesource.com/1244020
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594073}
[modify] https://crrev.com/240cf0f47b7d1b7c02530d01f96e070b21f5ebb5/BUILD.gn
[modify] https://crrev.com/240cf0f47b7d1b7c02530d01f96e070b21f5ebb5/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/240cf0f47b7d1b7c02530d01f96e070b21f5ebb5/chrome/browser/ui/cocoa/DEPS
[delete] https://crrev.com/b3ef4d796d7d45f5f27e1bc6cb328a120afb57f7/chrome/browser/ui/cocoa/constrained_window/constrained_window_alert.h
[delete] https://crrev.com/b3ef4d796d7d45f5f27e1bc6cb328a120afb57f7/chrome/browser/ui/cocoa/constrained_window/constrained_window_alert.mm
[delete] https://crrev.com/b3ef4d796d7d45f5f27e1bc6cb328a120afb57f7/chrome/browser/ui/cocoa/constrained_window/constrained_window_alert_unittest.mm
[delete] https://crrev.com/b3ef4d796d7d45f5f27e1bc6cb328a120afb57f7/chrome/browser/ui/cocoa/constrained_window/constrained_window_button.h
[delete] https://crrev.com/b3ef4d796d7d45f5f27e1bc6cb328a120afb57f7/chrome/browser/ui/cocoa/constrained_window/constrained_window_button.mm
[delete] https://crrev.com/b3ef4d796d7d45f5f27e1bc6cb328a120afb57f7/chrome/browser/ui/cocoa/constrained_window/constrained_window_button_unittest.mm
[modify] https://crrev.com/240cf0f47b7d1b7c02530d01f96e070b21f5ebb5/chrome/test/BUILD.gn
[delete] https://crrev.com/b3ef4d796d7d45f5f27e1bc6cb328a120afb57f7/third_party/molokocacao/BUILD.gn
[delete] https://crrev.com/b3ef4d796d7d45f5f27e1bc6cb328a120afb57f7/third_party/molokocacao/LICENSE
[delete] https://crrev.com/b3ef4d796d7d45f5f27e1bc6cb328a120afb57f7/third_party/molokocacao/NSBezierPath+MCAdditions.h
[delete] https://crrev.com/b3ef4d796d7d45f5f27e1bc6cb328a120afb57f7/third_party/molokocacao/NSBezierPath+MCAdditions.m
[delete] https://crrev.com/b3ef4d796d7d45f5f27e1bc6cb328a120afb57f7/third_party/molokocacao/README.chromium
[modify] https://crrev.com/240cf0f47b7d1b7c02530d01f96e070b21f5ebb5/tools/licenses.py

Project Member

Comment 65 by bugdroid1@chromium.org, Sep 25

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fa870596bf375b013b3dfe4bac6d2afd83e5a5e1

commit fa870596bf375b013b3dfe4bac6d2afd83e5a5e1
Author: Robert Sesek <rsesek@chromium.org>
Date: Tue Sep 25 21:04:49 2018

mac: Delete the Cocoa toolbar.

Bug: 832676
Change-Id: I46fbf0fe83cd2317bf299cf204b39c79cacb1419
Reviewed-on: https://chromium-review.googlesource.com/1243224
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594096}
[modify] https://crrev.com/fa870596bf375b013b3dfe4bac6d2afd83e5a5e1/chrome/app/nibs/BUILD.gn
[delete] https://crrev.com/e2dfd3b0d5ca9602b4d76f1443e755404febabe8/chrome/app/nibs/Toolbar.xib
[modify] https://crrev.com/fa870596bf375b013b3dfe4bac6d2afd83e5a5e1/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/fa870596bf375b013b3dfe4bac6d2afd83e5a5e1/chrome/browser/ui/cocoa/browser_window_cocoa.mm
[modify] https://crrev.com/fa870596bf375b013b3dfe4bac6d2afd83e5a5e1/chrome/browser/ui/cocoa/browser_window_controller.h
[modify] https://crrev.com/fa870596bf375b013b3dfe4bac6d2afd83e5a5e1/chrome/browser/ui/cocoa/browser_window_controller.mm
[modify] https://crrev.com/fa870596bf375b013b3dfe4bac6d2afd83e5a5e1/chrome/browser/ui/cocoa/browser_window_controller_private.mm
[modify] https://crrev.com/fa870596bf375b013b3dfe4bac6d2afd83e5a5e1/chrome/browser/ui/cocoa/browser_window_controller_unittest.mm
[delete] https://crrev.com/e2dfd3b0d5ca9602b4d76f1443e755404febabe8/chrome/browser/ui/cocoa/clickhold_button_cell.h
[delete] https://crrev.com/e2dfd3b0d5ca9602b4d76f1443e755404febabe8/chrome/browser/ui/cocoa/clickhold_button_cell.mm
[delete] https://crrev.com/e2dfd3b0d5ca9602b4d76f1443e755404febabe8/chrome/browser/ui/cocoa/clickhold_button_cell_unittest.mm
[delete] https://crrev.com/e2dfd3b0d5ca9602b4d76f1443e755404febabe8/chrome/browser/ui/cocoa/image_button_cell.h
[delete] https://crrev.com/e2dfd3b0d5ca9602b4d76f1443e755404febabe8/chrome/browser/ui/cocoa/image_button_cell.mm
[delete] https://crrev.com/e2dfd3b0d5ca9602b4d76f1443e755404febabe8/chrome/browser/ui/cocoa/image_button_cell_unittest.mm
[delete] https://crrev.com/e2dfd3b0d5ca9602b4d76f1443e755404febabe8/chrome/browser/ui/cocoa/menu_button.h
[delete] https://crrev.com/e2dfd3b0d5ca9602b4d76f1443e755404febabe8/chrome/browser/ui/cocoa/menu_button.mm
[delete] https://crrev.com/e2dfd3b0d5ca9602b4d76f1443e755404febabe8/chrome/browser/ui/cocoa/menu_button_unittest.mm
[modify] https://crrev.com/fa870596bf375b013b3dfe4bac6d2afd83e5a5e1/chrome/browser/ui/cocoa/renderer_context_menu/render_view_context_menu_mac_cocoa_browsertest.mm
[modify] https://crrev.com/fa870596bf375b013b3dfe4bac6d2afd83e5a5e1/chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm
[delete] https://crrev.com/e2dfd3b0d5ca9602b4d76f1443e755404febabe8/chrome/browser/ui/cocoa/toolbar/OWNERS
[delete] https://crrev.com/e2dfd3b0d5ca9602b4d76f1443e755404febabe8/chrome/browser/ui/cocoa/toolbar/app_toolbar_button.h
[delete] https://crrev.com/e2dfd3b0d5ca9602b4d76f1443e755404febabe8/chrome/browser/ui/cocoa/toolbar/app_toolbar_button.mm
[delete] https://crrev.com/e2dfd3b0d5ca9602b4d76f1443e755404febabe8/chrome/browser/ui/cocoa/toolbar/app_toolbar_button_cell.h
[delete] https://crrev.com/e2dfd3b0d5ca9602b4d76f1443e755404febabe8/chrome/browser/ui/cocoa/toolbar/app_toolbar_button_cell.mm
[delete] https://crrev.com/e2dfd3b0d5ca9602b4d76f1443e755404febabe8/chrome/browser/ui/cocoa/toolbar/app_toolbar_button_cell_unittest.mm
[delete] https://crrev.com/e2dfd3b0d5ca9602b4d76f1443e755404febabe8/chrome/browser/ui/cocoa/toolbar/app_toolbar_button_unittest.mm
[delete] https://crrev.com/e2dfd3b0d5ca9602b4d76f1443e755404febabe8/chrome/browser/ui/cocoa/toolbar/back_forward_menu_controller.h
[delete] https://crrev.com/e2dfd3b0d5ca9602b4d76f1443e755404febabe8/chrome/browser/ui/cocoa/toolbar/back_forward_menu_controller.mm
[delete] https://crrev.com/e2dfd3b0d5ca9602b4d76f1443e755404febabe8/chrome/browser/ui/cocoa/toolbar/reload_button_cocoa.h
[delete] https://crrev.com/e2dfd3b0d5ca9602b4d76f1443e755404febabe8/chrome/browser/ui/cocoa/toolbar/reload_button_cocoa.mm
[delete] https://crrev.com/e2dfd3b0d5ca9602b4d76f1443e755404febabe8/chrome/browser/ui/cocoa/toolbar/reload_button_unittest_cocoa.mm
[delete] https://crrev.com/e2dfd3b0d5ca9602b4d76f1443e755404febabe8/chrome/browser/ui/cocoa/toolbar/toolbar_button_cocoa.h
[delete] https://crrev.com/e2dfd3b0d5ca9602b4d76f1443e755404febabe8/chrome/browser/ui/cocoa/toolbar/toolbar_button_cocoa.mm
[delete] https://crrev.com/e2dfd3b0d5ca9602b4d76f1443e755404febabe8/chrome/browser/ui/cocoa/toolbar/toolbar_button_unittest.mm
[delete] https://crrev.com/e2dfd3b0d5ca9602b4d76f1443e755404febabe8/chrome/browser/ui/cocoa/toolbar/toolbar_controller.h
[delete] https://crrev.com/e2dfd3b0d5ca9602b4d76f1443e755404febabe8/chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm
[delete] https://crrev.com/e2dfd3b0d5ca9602b4d76f1443e755404febabe8/chrome/browser/ui/cocoa/toolbar/toolbar_view_cocoa.h
[delete] https://crrev.com/e2dfd3b0d5ca9602b4d76f1443e755404febabe8/chrome/browser/ui/cocoa/toolbar/toolbar_view_cocoa.mm
[delete] https://crrev.com/e2dfd3b0d5ca9602b4d76f1443e755404febabe8/chrome/browser/ui/cocoa/toolbar/toolbar_view_unittest.mm
[delete] https://crrev.com/e2dfd3b0d5ca9602b4d76f1443e755404febabe8/chrome/browser/ui/views/relaunch_notification/get_app_menu_anchor_point.h
[delete] https://crrev.com/e2dfd3b0d5ca9602b4d76f1443e755404febabe8/chrome/browser/ui/views/relaunch_notification/get_app_menu_anchor_point.mm
[modify] https://crrev.com/fa870596bf375b013b3dfe4bac6d2afd83e5a5e1/chrome/browser/ui/views/relaunch_notification/relaunch_recommended_bubble_view.cc
[modify] https://crrev.com/fa870596bf375b013b3dfe4bac6d2afd83e5a5e1/chrome/test/BUILD.gn

Project Member

Comment 66 by bugdroid1@chromium.org, Sep 26

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/688e5dd82840a68b9da30df912a468f8485b0c31

commit 688e5dd82840a68b9da30df912a468f8485b0c31
Author: Robert Sesek <rsesek@chromium.org>
Date: Wed Sep 26 12:01:50 2018

mac: Delete the Cocoa tab strip.

This leaves TabWindowController, which is the superclass of
BrowserWindowController, but removes most of its functionality.

Bug: 832676
Change-Id: Ic33a42afed1c47cc3435bc17ea1178fe4cbd7589
Reviewed-on: https://chromium-review.googlesource.com/1244776
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594284}
[modify] https://crrev.com/688e5dd82840a68b9da30df912a468f8485b0c31/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/688e5dd82840a68b9da30df912a468f8485b0c31/chrome/browser/ui/cocoa/browser_window_controller.h
[modify] https://crrev.com/688e5dd82840a68b9da30df912a468f8485b0c31/chrome/browser/ui/cocoa/browser_window_controller.mm
[modify] https://crrev.com/688e5dd82840a68b9da30df912a468f8485b0c31/chrome/browser/ui/cocoa/browser_window_controller_browsertest.mm
[modify] https://crrev.com/688e5dd82840a68b9da30df912a468f8485b0c31/chrome/browser/ui/cocoa/browser_window_controller_private.h
[modify] https://crrev.com/688e5dd82840a68b9da30df912a468f8485b0c31/chrome/browser/ui/cocoa/browser_window_controller_private.mm
[modify] https://crrev.com/688e5dd82840a68b9da30df912a468f8485b0c31/chrome/browser/ui/cocoa/browser_window_controller_unittest.mm
[modify] https://crrev.com/688e5dd82840a68b9da30df912a468f8485b0c31/chrome/browser/ui/cocoa/browser_window_fullscreen_transition.mm
[modify] https://crrev.com/688e5dd82840a68b9da30df912a468f8485b0c31/chrome/browser/ui/cocoa/browser_window_layout.mm
[delete] https://crrev.com/172d0cd082939480cb1b0bfed3367c89dea547c6/chrome/browser/ui/cocoa/browser_window_layout_unittest.mm
[modify] https://crrev.com/688e5dd82840a68b9da30df912a468f8485b0c31/chrome/browser/ui/cocoa/browser_window_utils.mm
[modify] https://crrev.com/688e5dd82840a68b9da30df912a468f8485b0c31/chrome/browser/ui/cocoa/chrome_command_dispatcher_delegate.mm
[delete] https://crrev.com/172d0cd082939480cb1b0bfed3367c89dea547c6/chrome/browser/ui/cocoa/spinner_view.h
[delete] https://crrev.com/172d0cd082939480cb1b0bfed3367c89dea547c6/chrome/browser/ui/cocoa/spinner_view.mm
[delete] https://crrev.com/172d0cd082939480cb1b0bfed3367c89dea547c6/chrome/browser/ui/cocoa/spinner_view_unittest.mm
[delete] https://crrev.com/172d0cd082939480cb1b0bfed3367c89dea547c6/chrome/browser/ui/cocoa/tabs/tab_controller.h
[delete] https://crrev.com/172d0cd082939480cb1b0bfed3367c89dea547c6/chrome/browser/ui/cocoa/tabs/tab_controller.mm
[delete] https://crrev.com/172d0cd082939480cb1b0bfed3367c89dea547c6/chrome/browser/ui/cocoa/tabs/tab_controller_target.h
[delete] https://crrev.com/172d0cd082939480cb1b0bfed3367c89dea547c6/chrome/browser/ui/cocoa/tabs/tab_controller_unittest.mm
[delete] https://crrev.com/172d0cd082939480cb1b0bfed3367c89dea547c6/chrome/browser/ui/cocoa/tabs/tab_favicon_view.h
[delete] https://crrev.com/172d0cd082939480cb1b0bfed3367c89dea547c6/chrome/browser/ui/cocoa/tabs/tab_favicon_view.mm
[delete] https://crrev.com/172d0cd082939480cb1b0bfed3367c89dea547c6/chrome/browser/ui/cocoa/tabs/tab_spinner_view.h
[delete] https://crrev.com/172d0cd082939480cb1b0bfed3367c89dea547c6/chrome/browser/ui/cocoa/tabs/tab_spinner_view.mm
[delete] https://crrev.com/172d0cd082939480cb1b0bfed3367c89dea547c6/chrome/browser/ui/cocoa/tabs/tab_strip_background_view.h
[delete] https://crrev.com/172d0cd082939480cb1b0bfed3367c89dea547c6/chrome/browser/ui/cocoa/tabs/tab_strip_background_view.mm
[delete] https://crrev.com/172d0cd082939480cb1b0bfed3367c89dea547c6/chrome/browser/ui/cocoa/tabs/tab_strip_controller.h
[delete] https://crrev.com/172d0cd082939480cb1b0bfed3367c89dea547c6/chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm
[delete] https://crrev.com/172d0cd082939480cb1b0bfed3367c89dea547c6/chrome/browser/ui/cocoa/tabs/tab_strip_drag_controller.h
[delete] https://crrev.com/172d0cd082939480cb1b0bfed3367c89dea547c6/chrome/browser/ui/cocoa/tabs/tab_strip_drag_controller.mm
[delete] https://crrev.com/172d0cd082939480cb1b0bfed3367c89dea547c6/chrome/browser/ui/cocoa/tabs/tab_strip_model_observer_bridge.h
[delete] https://crrev.com/172d0cd082939480cb1b0bfed3367c89dea547c6/chrome/browser/ui/cocoa/tabs/tab_strip_model_observer_bridge.mm
[delete] https://crrev.com/172d0cd082939480cb1b0bfed3367c89dea547c6/chrome/browser/ui/cocoa/tabs/tab_strip_view.h
[delete] https://crrev.com/172d0cd082939480cb1b0bfed3367c89dea547c6/chrome/browser/ui/cocoa/tabs/tab_strip_view.mm
[delete] https://crrev.com/172d0cd082939480cb1b0bfed3367c89dea547c6/chrome/browser/ui/cocoa/tabs/tab_strip_view_unittest.mm
[delete] https://crrev.com/172d0cd082939480cb1b0bfed3367c89dea547c6/chrome/browser/ui/cocoa/tabs/tab_view.h
[delete] https://crrev.com/172d0cd082939480cb1b0bfed3367c89dea547c6/chrome/browser/ui/cocoa/tabs/tab_view.mm
[delete] https://crrev.com/172d0cd082939480cb1b0bfed3367c89dea547c6/chrome/browser/ui/cocoa/tabs/tab_view_unittest.mm
[modify] https://crrev.com/688e5dd82840a68b9da30df912a468f8485b0c31/chrome/browser/ui/cocoa/tabs/tab_window_controller.h
[modify] https://crrev.com/688e5dd82840a68b9da30df912a468f8485b0c31/chrome/browser/ui/cocoa/tabs/tab_window_controller.mm
[modify] https://crrev.com/688e5dd82840a68b9da30df912a468f8485b0c31/chrome/browser/ui/cocoa/view_id_util.mm
[delete] https://crrev.com/172d0cd082939480cb1b0bfed3367c89dea547c6/chrome/browser/ui/cocoa/view_id_util_browsertest.mm
[modify] https://crrev.com/688e5dd82840a68b9da30df912a468f8485b0c31/chrome/test/BUILD.gn

Project Member

Comment 67 by bugdroid1@chromium.org, Sep 26

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/445e706a97ad4e90cb32b66dcb4524794fbb36a8

commit 445e706a97ad4e90cb32b66dcb4524794fbb36a8
Author: Nico Weber <thakis@chromium.org>
Date: Wed Sep 26 15:09:29 2018

mac: Remove declarations of functions we removed earlier.

Namely, in https://chromium-review.googlesource.com/1239639
and https://chromium-review.googlesource.com/1239764
and https://chromium-review.googlesource.com/1244017

TBR=wittman

Bug: 832676
Change-Id: I6be39e2e84d7687517c12c213434ccd62ad3166a
Reviewed-on: https://chromium-review.googlesource.com/1246022
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594316}
[modify] https://crrev.com/445e706a97ad4e90cb32b66dcb4524794fbb36a8/chrome/browser/ui/sad_tab.h
[modify] https://crrev.com/445e706a97ad4e90cb32b66dcb4524794fbb36a8/chrome/browser/ui/signin_view_controller_delegate.h
[modify] https://crrev.com/445e706a97ad4e90cb32b66dcb4524794fbb36a8/chrome/browser/ui/user_manager.h
[modify] https://crrev.com/445e706a97ad4e90cb32b66dcb4524794fbb36a8/components/constrained_window/constrained_window_views.h

Project Member

Comment 68 by bugdroid1@chromium.org, Sep 26

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/be946bd53bf59676e743d537bd960c176c09dc65

commit be946bd53bf59676e743d537bd960c176c09dc65
Author: Nico Weber <thakis@chromium.org>
Date: Wed Sep 26 15:14:50 2018

mac: Remove unused NativeAppWindowCocoa and now-always-on kEnableMacViewsNativeAppWindows flag.

Bug: 832676
Change-Id: Id712b18f8ccb526d938ec0b63feb580fbaf7c738
Reviewed-on: https://chromium-review.googlesource.com/1245923
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594320}
[modify] https://crrev.com/be946bd53bf59676e743d537bd960c176c09dc65/chrome/browser/about_flags.cc
[modify] https://crrev.com/be946bd53bf59676e743d537bd960c176c09dc65/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/be946bd53bf59676e743d537bd960c176c09dc65/chrome/browser/ui/apps/chrome_app_window_client.h
[modify] https://crrev.com/be946bd53bf59676e743d537bd960c176c09dc65/chrome/browser/ui/cocoa/apps/app_shim_menu_controller_mac.mm
[delete] https://crrev.com/7bb351e8fd63a0727c768cce22a28597c127005a/chrome/browser/ui/cocoa/apps/chrome_app_window_client_views_cocoa.mm
[delete] https://crrev.com/7bb351e8fd63a0727c768cce22a28597c127005a/chrome/browser/ui/cocoa/apps/native_app_window_cocoa.h
[delete] https://crrev.com/7bb351e8fd63a0727c768cce22a28597c127005a/chrome/browser/ui/cocoa/apps/native_app_window_cocoa.mm
[modify] https://crrev.com/be946bd53bf59676e743d537bd960c176c09dc65/chrome/browser/ui/cocoa/apps/native_app_window_cocoa_browsertest.mm
[modify] https://crrev.com/be946bd53bf59676e743d537bd960c176c09dc65/chrome/browser/ui/cocoa/apps/quit_with_apps_controller_mac_interactive_uitest.mm
[modify] https://crrev.com/be946bd53bf59676e743d537bd960c176c09dc65/chrome/browser/ui/views/apps/chrome_app_window_client_views_mac.mm
[modify] https://crrev.com/be946bd53bf59676e743d537bd960c176c09dc65/chrome/common/chrome_switches.cc
[modify] https://crrev.com/be946bd53bf59676e743d537bd960c176c09dc65/chrome/common/chrome_switches.h
[modify] https://crrev.com/be946bd53bf59676e743d537bd960c176c09dc65/testing/buildbot/filters/mac_window_server_killers.browser_tests.filter

Project Member

Comment 69 by bugdroid1@chromium.org, Sep 26

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f0c42a950f60613d0a403a1ed05231bc0f2cc68c

commit f0c42a950f60613d0a403a1ed05231bc0f2cc68c
Author: Nico Weber <thakis@chromium.org>
Date: Wed Sep 26 15:22:53 2018

mac: Remove some calls to IsViewsBrowserCocoa() (now always false).

Bug: 832676
Change-Id: If2d837c94d1353ab2c8cd7de6a2958a261e8b01e
Reviewed-on: https://chromium-review.googlesource.com/1245921
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594322}
[modify] https://crrev.com/f0c42a950f60613d0a403a1ed05231bc0f2cc68c/chrome/browser/media/router/media_router_feature.cc
[modify] https://crrev.com/f0c42a950f60613d0a403a1ed05231bc0f2cc68c/chrome/browser/media/router/media_router_feature.h
[modify] https://crrev.com/f0c42a950f60613d0a403a1ed05231bc0f2cc68c/chrome/browser/media/router/providers/wired_display/wired_display_media_route_provider.cc
[modify] https://crrev.com/f0c42a950f60613d0a403a1ed05231bc0f2cc68c/chrome/browser/media/router/providers/wired_display/wired_display_presentation_receiver_factory.cc
[modify] https://crrev.com/f0c42a950f60613d0a403a1ed05231bc0f2cc68c/chrome/browser/ui/views/location_bar/zoom_bubble_view.cc
[modify] https://crrev.com/f0c42a950f60613d0a403a1ed05231bc0f2cc68c/chrome/browser/ui/views/translate/translate_bubble_view.cc

Project Member

Comment 70 by bugdroid1@chromium.org, Sep 26

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b9ad9db79f527c22d34a34deac65d518638d13c7

commit b9ad9db79f527c22d34a34deac65d518638d13c7
Author: Nico Weber <thakis@chromium.org>
Date: Wed Sep 26 15:46:57 2018

mac: Remove all uses of ScopedMacViewsBrowserMode that pass true as parameter.

Views mode is enabled by default now, so ScopedMacViewsBrowserMode{true} is
a no-op. No behavior change.

Bug: 832676
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I5e89efb62080dafd4340097e5f70af045e31c4c8
Reviewed-on: https://chromium-review.googlesource.com/1245924
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594327}
[modify] https://crrev.com/b9ad9db79f527c22d34a34deac65d518638d13c7/chrome/browser/extensions/api/extension_action/browser_action_interactive_test.cc
[modify] https://crrev.com/b9ad9db79f527c22d34a34deac65d518638d13c7/chrome/browser/password_manager/password_manager_test_base.h
[modify] https://crrev.com/b9ad9db79f527c22d34a34deac65d518638d13c7/chrome/browser/ui/browser_focus_uitest.cc
[modify] https://crrev.com/b9ad9db79f527c22d34a34deac65d518638d13c7/chrome/browser/ui/omnibox/omnibox_view_browsertest.cc
[modify] https://crrev.com/b9ad9db79f527c22d34a34deac65d518638d13c7/chrome/browser/ui/tabs/window_activity_watcher_interactive_uitest.cc
[modify] https://crrev.com/b9ad9db79f527c22d34a34deac65d518638d13c7/chrome/browser/ui/views/accelerator_table_unittest_mac.mm
[modify] https://crrev.com/b9ad9db79f527c22d34a34deac65d518638d13c7/chrome/browser/ui/views/autofill/autofill_popup_base_view_browsertest.cc
[modify] https://crrev.com/b9ad9db79f527c22d34a34deac65d518638d13c7/chrome/browser/ui/views/constrained_window_views_browsertest.cc
[modify] https://crrev.com/b9ad9db79f527c22d34a34deac65d518638d13c7/chrome/browser/ui/views/exclusive_access_bubble_views_interactive_uitest.cc
[modify] https://crrev.com/b9ad9db79f527c22d34a34deac65d518638d13c7/chrome/browser/ui/views/extensions/extension_dialog_interactive_uitest.cc
[modify] https://crrev.com/b9ad9db79f527c22d34a34deac65d518638d13c7/chrome/browser/ui/views/find_bar_views_interactive_uitest.cc
[modify] https://crrev.com/b9ad9db79f527c22d34a34deac65d518638d13c7/chrome/browser/ui/views/frame/browser_non_client_frame_view_browsertest.cc
[modify] https://crrev.com/b9ad9db79f527c22d34a34deac65d518638d13c7/chrome/browser/ui/views/frame/browser_root_view_browsertest.cc
[modify] https://crrev.com/b9ad9db79f527c22d34a34deac65d518638d13c7/chrome/browser/ui/views/frame/browser_view_browsertest.cc
[modify] https://crrev.com/b9ad9db79f527c22d34a34deac65d518638d13c7/chrome/browser/ui/views/frame/browser_view_focus_uitest.cc
[modify] https://crrev.com/b9ad9db79f527c22d34a34deac65d518638d13c7/chrome/browser/ui/views/frame/browser_view_interactive_uitest.cc
[modify] https://crrev.com/b9ad9db79f527c22d34a34deac65d518638d13c7/chrome/browser/ui/views/frame/opaque_browser_frame_view_browsertest.cc
[modify] https://crrev.com/b9ad9db79f527c22d34a34deac65d518638d13c7/chrome/browser/ui/views/frame/test_with_browser_view.h
[modify] https://crrev.com/b9ad9db79f527c22d34a34deac65d518638d13c7/chrome/browser/ui/views/fullscreen_control/fullscreen_control_view_interactive_uitest.cc
[modify] https://crrev.com/b9ad9db79f527c22d34a34deac65d518638d13c7/chrome/browser/ui/views/keyboard_access_browsertest.cc
[modify] https://crrev.com/b9ad9db79f527c22d34a34deac65d518638d13c7/chrome/browser/ui/views/location_bar/location_bar_view_browsertest.cc
[modify] https://crrev.com/b9ad9db79f527c22d34a34deac65d518638d13c7/chrome/browser/ui/views/location_bar/location_icon_view_browsertest.cc
[modify] https://crrev.com/b9ad9db79f527c22d34a34deac65d518638d13c7/chrome/browser/ui/views/location_bar/location_icon_view_interactive_uitest.cc
[modify] https://crrev.com/b9ad9db79f527c22d34a34deac65d518638d13c7/chrome/browser/ui/views/location_bar/selected_keyword_view_interactive_uitest.cc
[modify] https://crrev.com/b9ad9db79f527c22d34a34deac65d518638d13c7/chrome/browser/ui/views/location_bar/star_view_browsertest.cc
[modify] https://crrev.com/b9ad9db79f527c22d34a34deac65d518638d13c7/chrome/browser/ui/views/location_bar/zoom_bubble_view_browsertest.cc
[modify] https://crrev.com/b9ad9db79f527c22d34a34deac65d518638d13c7/chrome/browser/ui/views/omnibox/omnibox_popup_contents_view_browsertest.cc
[modify] https://crrev.com/b9ad9db79f527c22d34a34deac65d518638d13c7/chrome/browser/ui/views/omnibox/omnibox_view_views_browsertest.cc
[modify] https://crrev.com/b9ad9db79f527c22d34a34deac65d518638d13c7/chrome/browser/ui/views/omnibox/omnibox_view_views_unittest.cc
[modify] https://crrev.com/b9ad9db79f527c22d34a34deac65d518638d13c7/chrome/browser/ui/views/passwords/manage_passwords_icon_view_interactive_uitest.cc
[modify] https://crrev.com/b9ad9db79f527c22d34a34deac65d518638d13c7/chrome/browser/ui/views/passwords/password_bubble_interactive_uitest.cc
[modify] https://crrev.com/b9ad9db79f527c22d34a34deac65d518638d13c7/chrome/browser/ui/views/permission_bubble/permission_bubble_views_interactive_uitest_mac.mm
[modify] https://crrev.com/b9ad9db79f527c22d34a34deac65d518638d13c7/chrome/browser/ui/views/sad_tab_view_interactive_uitest.cc
[modify] https://crrev.com/b9ad9db79f527c22d34a34deac65d518638d13c7/chrome/browser/ui/views/ssl_client_certificate_selector_browsertest.cc
[modify] https://crrev.com/b9ad9db79f527c22d34a34deac65d518638d13c7/chrome/browser/ui/views/status_bubble_views_browsertest.cc
[modify] https://crrev.com/b9ad9db79f527c22d34a34deac65d518638d13c7/chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc
[modify] https://crrev.com/b9ad9db79f527c22d34a34deac65d518638d13c7/chrome/browser/ui/views/toolbar/browser_actions_container_browsertest.cc
[modify] https://crrev.com/b9ad9db79f527c22d34a34deac65d518638d13c7/chrome/browser/ui/views/toolbar/outdated_upgrade_bubble_view_browsertest.cc
[modify] https://crrev.com/b9ad9db79f527c22d34a34deac65d518638d13c7/chrome/browser/ui/views/toolbar/toolbar_action_view_interactive_uitest.cc
[modify] https://crrev.com/b9ad9db79f527c22d34a34deac65d518638d13c7/chrome/browser/ui/views/toolbar/toolbar_view_interactive_uitest.cc

Project Member

Comment 71 by bugdroid1@chromium.org, Sep 26

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/71e95f9803371f7e3e0044dac3a2f2e80dc9b710

commit 71e95f9803371f7e3e0044dac3a2f2e80dc9b710
Author: Nico Weber <thakis@chromium.org>
Date: Wed Sep 26 17:43:20 2018

mac: Remove some unused controls.

Bug: 832676
Change-Id: I9b56c47523765af4b33a997b65fe2a48a9da7f29
Reviewed-on: https://chromium-review.googlesource.com/1246324
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594375}
[modify] https://crrev.com/71e95f9803371f7e3e0044dac3a2f2e80dc9b710/chrome/browser/ui/BUILD.gn
[delete] https://crrev.com/9a5603c15f262230c33f31b74ce4f5c89f964620/chrome/browser/ui/cocoa/hover_close_button.h
[delete] https://crrev.com/9a5603c15f262230c33f31b74ce4f5c89f964620/chrome/browser/ui/cocoa/hover_close_button.mm
[delete] https://crrev.com/9a5603c15f262230c33f31b74ce4f5c89f964620/chrome/browser/ui/cocoa/hover_close_button_unittest.mm
[modify] https://crrev.com/71e95f9803371f7e3e0044dac3a2f2e80dc9b710/chrome/test/BUILD.gn
[modify] https://crrev.com/71e95f9803371f7e3e0044dac3a2f2e80dc9b710/ui/base/BUILD.gn
[delete] https://crrev.com/9a5603c15f262230c33f31b74ce4f5c89f964620/ui/base/cocoa/a11y_util.h
[delete] https://crrev.com/9a5603c15f262230c33f31b74ce4f5c89f964620/ui/base/cocoa/a11y_util.mm
[modify] https://crrev.com/71e95f9803371f7e3e0044dac3a2f2e80dc9b710/ui/base/cocoa/controls/button_utils.h
[modify] https://crrev.com/71e95f9803371f7e3e0044dac3a2f2e80dc9b710/ui/base/cocoa/controls/button_utils.mm
[delete] https://crrev.com/9a5603c15f262230c33f31b74ce4f5c89f964620/ui/base/cocoa/controls/hyperlink_button_cell.h
[delete] https://crrev.com/9a5603c15f262230c33f31b74ce4f5c89f964620/ui/base/cocoa/controls/hyperlink_button_cell.mm
[delete] https://crrev.com/9a5603c15f262230c33f31b74ce4f5c89f964620/ui/base/cocoa/controls/hyperlink_button_cell_unittest.mm
[delete] https://crrev.com/9a5603c15f262230c33f31b74ce4f5c89f964620/ui/base/cocoa/controls/hyperlink_text_view.h
[delete] https://crrev.com/9a5603c15f262230c33f31b74ce4f5c89f964620/ui/base/cocoa/controls/hyperlink_text_view.mm
[delete] https://crrev.com/9a5603c15f262230c33f31b74ce4f5c89f964620/ui/base/cocoa/controls/hyperlink_text_view_unittest.mm
[delete] https://crrev.com/9a5603c15f262230c33f31b74ce4f5c89f964620/ui/base/cocoa/controls/imageview_utils.h
[delete] https://crrev.com/9a5603c15f262230c33f31b74ce4f5c89f964620/ui/base/cocoa/controls/imageview_utils.mm

Project Member

Comment 72 by bugdroid1@chromium.org, Sep 26

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d9ee0c5b2498203037ecfce5ad87d0ddbd243d79

commit d9ee0c5b2498203037ecfce5ad87d0ddbd243d79
Author: Robert Sesek <rsesek@chromium.org>
Date: Wed Sep 26 19:59:27 2018

mac: Remove fullscreen support from BrowserWindowController.

A lot of c/b/u/cocoa/fullscreen is still used to implement views-mode
fullscreen.

Bug: 832676
Change-Id: I58ae4caff28d69c1be047c079b1ea95ae7a486e0
Reviewed-on: https://chromium-review.googlesource.com/1246601
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594444}
[modify] https://crrev.com/d9ee0c5b2498203037ecfce5ad87d0ddbd243d79/chrome/browser/ui/BUILD.gn
[delete] https://crrev.com/ddede7ee04902eaf70c912f9e30d7d4117b30f81/chrome/browser/ui/cocoa/browser/exclusive_access_controller_views.h
[delete] https://crrev.com/ddede7ee04902eaf70c912f9e30d7d4117b30f81/chrome/browser/ui/cocoa/browser/exclusive_access_controller_views.mm
[modify] https://crrev.com/d9ee0c5b2498203037ecfce5ad87d0ddbd243d79/chrome/browser/ui/cocoa/browser_window_cocoa.mm
[modify] https://crrev.com/d9ee0c5b2498203037ecfce5ad87d0ddbd243d79/chrome/browser/ui/cocoa/browser_window_command_handler.mm
[modify] https://crrev.com/d9ee0c5b2498203037ecfce5ad87d0ddbd243d79/chrome/browser/ui/cocoa/browser_window_controller.h
[modify] https://crrev.com/d9ee0c5b2498203037ecfce5ad87d0ddbd243d79/chrome/browser/ui/cocoa/browser_window_controller.mm
[delete] https://crrev.com/ddede7ee04902eaf70c912f9e30d7d4117b30f81/chrome/browser/ui/cocoa/browser_window_controller_browsertest.mm
[modify] https://crrev.com/d9ee0c5b2498203037ecfce5ad87d0ddbd243d79/chrome/browser/ui/cocoa/browser_window_controller_private.h
[modify] https://crrev.com/d9ee0c5b2498203037ecfce5ad87d0ddbd243d79/chrome/browser/ui/cocoa/browser_window_controller_private.mm
[modify] https://crrev.com/d9ee0c5b2498203037ecfce5ad87d0ddbd243d79/chrome/browser/ui/cocoa/browser_window_controller_unittest.mm
[delete] https://crrev.com/ddede7ee04902eaf70c912f9e30d7d4117b30f81/chrome/browser/ui/cocoa/browser_window_fullscreen_transition.h
[delete] https://crrev.com/ddede7ee04902eaf70c912f9e30d7d4117b30f81/chrome/browser/ui/cocoa/browser_window_fullscreen_transition.mm
[modify] https://crrev.com/d9ee0c5b2498203037ecfce5ad87d0ddbd243d79/chrome/browser/ui/cocoa/browser_window_layout.h
[modify] https://crrev.com/d9ee0c5b2498203037ecfce5ad87d0ddbd243d79/chrome/browser/ui/cocoa/browser_window_layout.mm
[modify] https://crrev.com/d9ee0c5b2498203037ecfce5ad87d0ddbd243d79/chrome/browser/ui/cocoa/bubble_anchor_helper.mm
[delete] https://crrev.com/ddede7ee04902eaf70c912f9e30d7d4117b30f81/chrome/browser/ui/cocoa/floating_bar_backing_view.h
[delete] https://crrev.com/ddede7ee04902eaf70c912f9e30d7d4117b30f81/chrome/browser/ui/cocoa/floating_bar_backing_view.mm
[delete] https://crrev.com/ddede7ee04902eaf70c912f9e30d7d4117b30f81/chrome/browser/ui/cocoa/floating_bar_backing_view_unittest.mm
[delete] https://crrev.com/ddede7ee04902eaf70c912f9e30d7d4117b30f81/chrome/browser/ui/cocoa/fullscreen_placeholder_view.h
[delete] https://crrev.com/ddede7ee04902eaf70c912f9e30d7d4117b30f81/chrome/browser/ui/cocoa/fullscreen_placeholder_view.mm
[delete] https://crrev.com/ddede7ee04902eaf70c912f9e30d7d4117b30f81/chrome/browser/ui/cocoa/fullscreen_window.h
[delete] https://crrev.com/ddede7ee04902eaf70c912f9e30d7d4117b30f81/chrome/browser/ui/cocoa/fullscreen_window.mm
[delete] https://crrev.com/ddede7ee04902eaf70c912f9e30d7d4117b30f81/chrome/browser/ui/cocoa/fullscreen_window_unittest.mm
[modify] https://crrev.com/d9ee0c5b2498203037ecfce5ad87d0ddbd243d79/chrome/browser/ui/cocoa/permission_bubble/permission_bubble_views_cocoa_browsertest.mm
[delete] https://crrev.com/ddede7ee04902eaf70c912f9e30d7d4117b30f81/chrome/browser/ui/cocoa/separate_fullscreen_window.h
[delete] https://crrev.com/ddede7ee04902eaf70c912f9e30d7d4117b30f81/chrome/browser/ui/cocoa/separate_fullscreen_window.mm
[modify] https://crrev.com/d9ee0c5b2498203037ecfce5ad87d0ddbd243d79/chrome/browser/ui/cocoa/tab_contents/tab_contents_controller.h
[modify] https://crrev.com/d9ee0c5b2498203037ecfce5ad87d0ddbd243d79/chrome/browser/ui/cocoa/tab_contents/tab_contents_controller.mm
[modify] https://crrev.com/d9ee0c5b2498203037ecfce5ad87d0ddbd243d79/chrome/test/BUILD.gn

Project Member

Comment 73 by bugdroid1@chromium.org, Sep 26

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cd2146dc53e77af8f384c6c31da2b633e2893b38

commit cd2146dc53e77af8f384c6c31da2b633e2893b38
Author: Nico Weber <thakis@chromium.org>
Date: Wed Sep 26 20:04:17 2018

mac: Remove legacy_infobars_mac.cc, reshuffle translate bubble code a bit.

From what I can tell, we changed the translate UI on desktop from an infobar
to a bubble; this transition is completed with macviews.

Try to make this a bit more explicit in the code.

Also rename SESSION_CRASHED_INFOBAR_DELEGATE_MAC_IOS to SESSION_CRASHED_INFOBAR_DELEGATE_IOS
since it's no longer used on Mac, and remove a browser_test for it
that was dead code.

Bug: 832676
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: Id979dc996a49dabe5a073e53d1b3f60616316878
Reviewed-on: https://chromium-review.googlesource.com/1246024
Reviewed-by: Rachel Blum <groby@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594448}
[delete] https://crrev.com/8d3028eeb49f5d888652b875d96f448ea78edfd5/chrome/app/theme/default_100_percent/common/infobar_translate.png
[delete] https://crrev.com/8d3028eeb49f5d888652b875d96f448ea78edfd5/chrome/app/theme/default_200_percent/common/infobar_translate.png
[modify] https://crrev.com/cd2146dc53e77af8f384c6c31da2b633e2893b38/chrome/app/theme/theme_resources.grd
[modify] https://crrev.com/cd2146dc53e77af8f384c6c31da2b633e2893b38/chrome/browser/android/resource_id.h
[modify] https://crrev.com/cd2146dc53e77af8f384c6c31da2b633e2893b38/chrome/browser/infobars/infobars_browsertest.cc
[modify] https://crrev.com/cd2146dc53e77af8f384c6c31da2b633e2893b38/chrome/browser/translate/chrome_translate_client.cc
[modify] https://crrev.com/cd2146dc53e77af8f384c6c31da2b633e2893b38/chrome/browser/translate/chrome_translate_client.h
[modify] https://crrev.com/cd2146dc53e77af8f384c6c31da2b633e2893b38/chrome/browser/translate/translate_manager_render_view_host_unittest.cc
[modify] https://crrev.com/cd2146dc53e77af8f384c6c31da2b633e2893b38/chrome/browser/ui/BUILD.gn
[delete] https://crrev.com/8d3028eeb49f5d888652b875d96f448ea78edfd5/chrome/browser/ui/views/infobars/legacy_infobars_mac.cc
[modify] https://crrev.com/cd2146dc53e77af8f384c6c31da2b633e2893b38/components/infobars/core/infobar_delegate.h
[modify] https://crrev.com/cd2146dc53e77af8f384c6c31da2b633e2893b38/components/translate/core/browser/BUILD.gn
[modify] https://crrev.com/cd2146dc53e77af8f384c6c31da2b633e2893b38/components/translate/core/browser/translate_client.h
[modify] https://crrev.com/cd2146dc53e77af8f384c6c31da2b633e2893b38/ios/chrome/browser/crash_report/crash_restore_helper.mm

Project Member

Comment 74 by bugdroid1@chromium.org, Sep 26

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2b1bcbafa5901e6a22f6c666f42230c73cd5a9b7

commit 2b1bcbafa5901e6a22f6c666f42230c73cd5a9b7
Author: Robert Sesek <rsesek@chromium.org>
Date: Wed Sep 26 20:27:03 2018

Sever BrowserWindowTouchBarControllerTest dependency on BrowserWindowController.

Bug: 832676
Change-Id: Ife9b271854db2b4379d9df1869cc51eb9c2dbaa0
Reviewed-on: https://chromium-review.googlesource.com/1246722
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Leonard Grey <lgrey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594458}
[modify] https://crrev.com/2b1bcbafa5901e6a22f6c666f42230c73cd5a9b7/chrome/browser/ui/cocoa/touchbar/browser_window_touch_bar_controller_browsertest.mm

Project Member

Comment 75 by bugdroid1@chromium.org, Sep 26

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/32e5d362e2f29891f00c3274a3621603a599153f

commit 32e5d362e2f29891f00c3274a3621603a599153f
Author: Robert Sesek <rsesek@chromium.org>
Date: Wed Sep 26 23:04:47 2018

mac: Delete more unused Cocoa controls and utilities.

Bug: 832676
Change-Id: I1e386194f2925fd6b8d5ce594bb2372c2a6422ff
Reviewed-on: https://chromium-review.googlesource.com/1246727
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594511}
[modify] https://crrev.com/32e5d362e2f29891f00c3274a3621603a599153f/chrome/browser/ui/BUILD.gn
[delete] https://crrev.com/952e8d59a5f5e1e6e2f61e7ef52d0a39652e5173/chrome/browser/ui/cocoa/animatable_image.h
[delete] https://crrev.com/952e8d59a5f5e1e6e2f61e7ef52d0a39652e5173/chrome/browser/ui/cocoa/animatable_image.mm
[delete] https://crrev.com/952e8d59a5f5e1e6e2f61e7ef52d0a39652e5173/chrome/browser/ui/cocoa/animatable_image_unittest.mm
[delete] https://crrev.com/952e8d59a5f5e1e6e2f61e7ef52d0a39652e5173/chrome/browser/ui/cocoa/animatable_view.h
[delete] https://crrev.com/952e8d59a5f5e1e6e2f61e7ef52d0a39652e5173/chrome/browser/ui/cocoa/animatable_view.mm
[delete] https://crrev.com/952e8d59a5f5e1e6e2f61e7ef52d0a39652e5173/chrome/browser/ui/cocoa/animatable_view_unittest.mm
[delete] https://crrev.com/952e8d59a5f5e1e6e2f61e7ef52d0a39652e5173/chrome/browser/ui/cocoa/background_gradient_view.h
[delete] https://crrev.com/952e8d59a5f5e1e6e2f61e7ef52d0a39652e5173/chrome/browser/ui/cocoa/background_gradient_view.mm
[delete] https://crrev.com/952e8d59a5f5e1e6e2f61e7ef52d0a39652e5173/chrome/browser/ui/cocoa/background_gradient_view_unittest.mm
[modify] https://crrev.com/32e5d362e2f29891f00c3274a3621603a599153f/chrome/browser/ui/cocoa/browser_window_controller.mm
[delete] https://crrev.com/952e8d59a5f5e1e6e2f61e7ef52d0a39652e5173/chrome/browser/ui/cocoa/cocoa_util.h
[delete] https://crrev.com/952e8d59a5f5e1e6e2f61e7ef52d0a39652e5173/chrome/browser/ui/cocoa/cocoa_util.mm
[delete] https://crrev.com/952e8d59a5f5e1e6e2f61e7ef52d0a39652e5173/chrome/browser/ui/cocoa/rect_path_utils.h
[delete] https://crrev.com/952e8d59a5f5e1e6e2f61e7ef52d0a39652e5173/chrome/browser/ui/cocoa/rect_path_utils.mm
[delete] https://crrev.com/952e8d59a5f5e1e6e2f61e7ef52d0a39652e5173/chrome/browser/ui/cocoa/spinner_util.h
[delete] https://crrev.com/952e8d59a5f5e1e6e2f61e7ef52d0a39652e5173/chrome/browser/ui/cocoa/styled_text_field.h
[delete] https://crrev.com/952e8d59a5f5e1e6e2f61e7ef52d0a39652e5173/chrome/browser/ui/cocoa/styled_text_field.mm
[delete] https://crrev.com/952e8d59a5f5e1e6e2f61e7ef52d0a39652e5173/chrome/browser/ui/cocoa/styled_text_field_cell.h
[delete] https://crrev.com/952e8d59a5f5e1e6e2f61e7ef52d0a39652e5173/chrome/browser/ui/cocoa/styled_text_field_cell.mm
[delete] https://crrev.com/952e8d59a5f5e1e6e2f61e7ef52d0a39652e5173/chrome/browser/ui/cocoa/styled_text_field_cell_unittest.mm
[delete] https://crrev.com/952e8d59a5f5e1e6e2f61e7ef52d0a39652e5173/chrome/browser/ui/cocoa/styled_text_field_unittest.mm
[delete] https://crrev.com/952e8d59a5f5e1e6e2f61e7ef52d0a39652e5173/chrome/browser/ui/cocoa/test/styled_text_field_test_helper.h
[delete] https://crrev.com/952e8d59a5f5e1e6e2f61e7ef52d0a39652e5173/chrome/browser/ui/cocoa/test/styled_text_field_test_helper.mm
[modify] https://crrev.com/32e5d362e2f29891f00c3274a3621603a599153f/chrome/test/BUILD.gn

Project Member

Comment 76 by bugdroid1@chromium.org, Sep 26

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d596020a1ab6c69ec626588eaa901b83e035a708

commit d596020a1ab6c69ec626588eaa901b83e035a708
Author: Robert Sesek <rsesek@chromium.org>
Date: Wed Sep 26 23:07:16 2018

mac: Delete unused theme resource images.

Most of these were referenced by Cocoa code that has now been deleted.

Bug: 832676
Change-Id: I96a54b283912b30455de753d2a689db464c35e64
Reviewed-on: https://chromium-review.googlesource.com/1246865
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594513}
[delete] https://crrev.com/534a77d736cc20e640ba713c5e5eca40bace6366/chrome/app/theme/default_100_percent/legacy/avatar_menu_auth_error.png
[delete] https://crrev.com/534a77d736cc20e640ba713c5e5eca40bace6366/chrome/app/theme/default_100_percent/legacy/info_small.png
[delete] https://crrev.com/534a77d736cc20e640ba713c5e5eca40bace6366/chrome/app/theme/default_100_percent/legacy/safebrowsing_warning.png
[delete] https://crrev.com/534a77d736cc20e640ba713c5e5eca40bace6366/chrome/app/theme/default_100_percent/legacy/translate.png
[delete] https://crrev.com/534a77d736cc20e640ba713c5e5eca40bace6366/chrome/app/theme/default_100_percent/mac/omnibox_keyword_hint_tab.png
[delete] https://crrev.com/534a77d736cc20e640ba713c5e5eca40bace6366/chrome/app/theme/default_100_percent/mac/overlay_drop_shadow.png
[delete] https://crrev.com/534a77d736cc20e640ba713c5e5eca40bace6366/chrome/app/theme/default_100_percent/mac/tab_active_center.png
[delete] https://crrev.com/534a77d736cc20e640ba713c5e5eca40bace6366/chrome/app/theme/default_100_percent/mac/tab_active_left.png
[delete] https://crrev.com/534a77d736cc20e640ba713c5e5eca40bace6366/chrome/app/theme/default_100_percent/mac/tab_active_right.png
[delete] https://crrev.com/534a77d736cc20e640ba713c5e5eca40bace6366/chrome/app/theme/default_100_percent/mac/tab_alpha_left.png
[delete] https://crrev.com/534a77d736cc20e640ba713c5e5eca40bace6366/chrome/app/theme/default_100_percent/mac/tab_alpha_right.png
[delete] https://crrev.com/534a77d736cc20e640ba713c5e5eca40bace6366/chrome/app/theme/default_100_percent/mac/toolbar_shade_top.png
[delete] https://crrev.com/534a77d736cc20e640ba713c5e5eca40bace6366/chrome/app/theme/default_200_percent/legacy/avatar_menu_auth_error.png
[delete] https://crrev.com/534a77d736cc20e640ba713c5e5eca40bace6366/chrome/app/theme/default_200_percent/legacy/info_small.png
[delete] https://crrev.com/534a77d736cc20e640ba713c5e5eca40bace6366/chrome/app/theme/default_200_percent/legacy/safebrowsing_warning.png
[delete] https://crrev.com/534a77d736cc20e640ba713c5e5eca40bace6366/chrome/app/theme/default_200_percent/legacy/translate.png
[delete] https://crrev.com/534a77d736cc20e640ba713c5e5eca40bace6366/chrome/app/theme/default_200_percent/mac/omnibox_keyword_hint_tab.png
[delete] https://crrev.com/534a77d736cc20e640ba713c5e5eca40bace6366/chrome/app/theme/default_200_percent/mac/overlay_drop_shadow.png
[delete] https://crrev.com/534a77d736cc20e640ba713c5e5eca40bace6366/chrome/app/theme/default_200_percent/mac/tab_active_center.png
[delete] https://crrev.com/534a77d736cc20e640ba713c5e5eca40bace6366/chrome/app/theme/default_200_percent/mac/tab_active_left.png
[delete] https://crrev.com/534a77d736cc20e640ba713c5e5eca40bace6366/chrome/app/theme/default_200_percent/mac/tab_active_right.png
[delete] https://crrev.com/534a77d736cc20e640ba713c5e5eca40bace6366/chrome/app/theme/default_200_percent/mac/tab_alpha_left.png
[delete] https://crrev.com/534a77d736cc20e640ba713c5e5eca40bace6366/chrome/app/theme/default_200_percent/mac/tab_alpha_right.png
[delete] https://crrev.com/534a77d736cc20e640ba713c5e5eca40bace6366/chrome/app/theme/default_200_percent/mac/toolbar_shade_top.png
[modify] https://crrev.com/d596020a1ab6c69ec626588eaa901b83e035a708/chrome/app/theme/theme_resources.grd

Project Member

Comment 77 by bugdroid1@chromium.org, Sep 27

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8c4cad73339261d5b56307f5d25c94a7f7206425

commit 8c4cad73339261d5b56307f5d25c94a7f7206425
Author: Robert Sesek <rsesek@chromium.org>
Date: Thu Sep 27 02:18:00 2018

mac: Delete ScopedMacViewsBrowserMode.

- BrowserWindowMacTest tested both modes, and now it only tests views.
- PermissionBubbleInteractiveUITest forced Cocoa, but all the tests are
  disabled, so it doesn't matter that it cannot force a mode.
- The ScopedMacViewsBrowserMode is removed from CocoaTest.
- In its place, CocoaProfileTest now brings up a ViewsDelegate so that
  it can properly create a views BrowserWindow. CocoaProfileTest should
  be removed in favor of TestWithBrowserView.

Bug: 832676
Change-Id: I4648d893a71794c2f0b3c108b0afb05d45dc84be
Reviewed-on: https://chromium-review.googlesource.com/1246731
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594566}
[modify] https://crrev.com/8c4cad73339261d5b56307f5d25c94a7f7206425/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/8c4cad73339261d5b56307f5d25c94a7f7206425/chrome/browser/ui/cocoa/browser_window_mac_browsertest.mm
[modify] https://crrev.com/8c4cad73339261d5b56307f5d25c94a7f7206425/chrome/browser/ui/cocoa/permission_bubble/permission_bubble_cocoa_interactive_uitest.mm
[modify] https://crrev.com/8c4cad73339261d5b56307f5d25c94a7f7206425/chrome/browser/ui/cocoa/test/cocoa_profile_test.h
[modify] https://crrev.com/8c4cad73339261d5b56307f5d25c94a7f7206425/chrome/browser/ui/cocoa/test/cocoa_profile_test.mm
[modify] https://crrev.com/8c4cad73339261d5b56307f5d25c94a7f7206425/chrome/browser/ui/cocoa/test/cocoa_test_helper.h
[modify] https://crrev.com/8c4cad73339261d5b56307f5d25c94a7f7206425/chrome/browser/ui/views/toolbar/browser_actions_container_browsertest.cc
[delete] https://crrev.com/eb2125e8b74949befede118256cba6e685cdcecd/chrome/test/views/scoped_macviews_browser_mode.cc
[delete] https://crrev.com/eb2125e8b74949befede118256cba6e685cdcecd/chrome/test/views/scoped_macviews_browser_mode.h

Project Member

Comment 78 by bugdroid1@chromium.org, Sep 27

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ed650615b2f954196ea7842e1c4951a3c8434411

commit ed650615b2f954196ea7842e1c4951a3c8434411
Author: Nico Weber <thakis@chromium.org>
Date: Thu Sep 27 04:03:26 2018

mac: Make IsViewsBrowserCocoa() always return false and remove features::kViewsBrowserWindows.

features::kViewsBrowserWindows was mainly used by ScopedMacViewsBrowserMode
to test code in cocoa mode. We've removed all references to that class,
and we removed the feature from about:flags, so the only effect
of this CL here is that it will disable chrome/mac/cocoa for folks
who get the feature through finch. In theory that should be nobody, but
we're seeing a handful folks run the cocoa browser still (which by now
no longer has a toolbar, tab strip, download shelf, bookmark bar, ...).

Bug: 832676, 887392
Change-Id: I0cb7f360616eabb2c96ecfdcb39d665206dcacb2
Reviewed-on: https://chromium-review.googlesource.com/1226299
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594587}
[modify] https://crrev.com/ed650615b2f954196ea7842e1c4951a3c8434411/chrome/browser/ui/extensions/icon_with_badge_image_source.cc
[modify] https://crrev.com/ed650615b2f954196ea7842e1c4951a3c8434411/chrome/browser/ui/toolbar/toolbar_actions_bar.cc
[modify] https://crrev.com/ed650615b2f954196ea7842e1c4951a3c8434411/ui/base/ui_base_features.cc
[modify] https://crrev.com/ed650615b2f954196ea7842e1c4951a3c8434411/ui/base/ui_base_features.h

Comment 79 by thakis@chromium.org, Sep 27

https://chromium-review.googlesource.com/1249446 had the wrong bug number and was supposed to refer to this bug. Manually copying over the commit note:

commit faa858bbf340c1562c6f94308a32dae1948588f7
Author: Nico Weber <thakis@chromium.org>
Date: Thu Sep 27 21:24:53 2018

mac: Remove some uses of IsViewsBrowserCocoa.

Bug:  887392 
Change-Id: I5de7b4d218cd31fe637d52d94f9ba888b88a4c1d
Reviewed-on: https://chromium-review.googlesource.com/1249446
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594869}
[modify] https://crrev.com/faa858bbf340c1562c6f94308a32dae1948588f7/chrome/browser/apps/guest_view/web_view_interactive_browsertest.cc
[modify] https://crrev.com/faa858bbf340c1562c6f94308a32dae1948588f7/chrome/browser/ui/blocked_content/popup_blocker_browsertest.cc
[modify] https://crrev.com/faa858bbf340c1562c6f94308a32dae1948588f7/chrome/browser/ui/cocoa/touchbar/web_textfield_touch_bar_controller.mm
[modify] https://crrev.com/faa858bbf340c1562c6f94308a32dae1948588f7/chrome/browser/ui/views/extensions/extension_installed_bubble_view.cc
[modify] https://crrev.com/faa858bbf340c1562c6f94308a32dae1948588f7/chrome/browser/ui/views/media_router/media_router_ui_browsertest.cc
[modify] https://crrev.com/faa858bbf340c1562c6f94308a32dae1948588f7/chrome/browser/ui/views/proximity_auth/proximity_auth_error_bubble_view.cc
[modify] https://crrev.com/faa858bbf340c1562c6f94308a32dae1948588f7/components/omnibox/browser/omnibox_field_trial.cc
[modify] https://crrev.com/faa858bbf340c1562c6f94308a32dae1948588f7/ui/base/material_design/material_design_controller.cc

Project Member

Comment 80 by bugdroid1@chromium.org, Sep 28

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5ff04060153dc5b6decd372e51903497db6c3099

commit 5ff04060153dc5b6decd372e51903497db6c3099
Author: Nico Weber <thakis@chromium.org>
Date: Fri Sep 28 16:06:53 2018

mac: Remove BrowserWindowControllerForWindow()

Bug: 832676
Change-Id: I08c741b57717e69d434d34b1ad73c132e3125d94
Reviewed-on: https://chromium-review.googlesource.com/1251329
Reviewed-by: Erik Chen <erikchen@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595108}
[modify] https://crrev.com/5ff04060153dc5b6decd372e51903497db6c3099/chrome/browser/ui/cocoa/browser_window_cocoa_views_mac.mm
[modify] https://crrev.com/5ff04060153dc5b6decd372e51903497db6c3099/chrome/browser/ui/cocoa/browser_window_views_mac.h
[modify] https://crrev.com/5ff04060153dc5b6decd372e51903497db6c3099/chrome/browser/ui/cocoa/chrome_command_dispatcher_delegate.mm

Project Member

Comment 81 by bugdroid1@chromium.org, Sep 28

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1fa2a88268b9e2305a4bc17b01787ade8d9061d2

commit 1fa2a88268b9e2305a4bc17b01787ade8d9061d2
Author: Nico Weber <thakis@chromium.org>
Date: Fri Sep 28 23:43:39 2018

mac: Remove features::IsViewsBrowserCocoa() and its last calls.

While here, also remove unused GetAllowOtherViews() / SetAllowOtherViews()
from WebContents and WebContentsView.

Bug: 832676
Change-Id: I18e6385b08599e12e0a8f2d85c06d429e92396c7
Reviewed-on: https://chromium-review.googlesource.com/1251323
Reviewed-by: ccameron <ccameron@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595253}
[modify] https://crrev.com/1fa2a88268b9e2305a4bc17b01787ade8d9061d2/chrome/browser/ui/views_mode_controller.cc
[modify] https://crrev.com/1fa2a88268b9e2305a4bc17b01787ade8d9061d2/chrome/browser/ui/views_mode_controller.h
[modify] https://crrev.com/1fa2a88268b9e2305a4bc17b01787ade8d9061d2/content/browser/renderer_host/render_widget_host_view_mac.h
[modify] https://crrev.com/1fa2a88268b9e2305a4bc17b01787ade8d9061d2/content/browser/renderer_host/render_widget_host_view_mac.mm
[modify] https://crrev.com/1fa2a88268b9e2305a4bc17b01787ade8d9061d2/content/browser/web_contents/web_contents_impl.cc
[modify] https://crrev.com/1fa2a88268b9e2305a4bc17b01787ade8d9061d2/content/browser/web_contents/web_contents_impl.h
[modify] https://crrev.com/1fa2a88268b9e2305a4bc17b01787ade8d9061d2/content/browser/web_contents/web_contents_view.h
[modify] https://crrev.com/1fa2a88268b9e2305a4bc17b01787ade8d9061d2/content/browser/web_contents/web_contents_view_child_frame.cc
[modify] https://crrev.com/1fa2a88268b9e2305a4bc17b01787ade8d9061d2/content/browser/web_contents/web_contents_view_child_frame.h
[modify] https://crrev.com/1fa2a88268b9e2305a4bc17b01787ade8d9061d2/content/browser/web_contents/web_contents_view_guest.cc
[modify] https://crrev.com/1fa2a88268b9e2305a4bc17b01787ade8d9061d2/content/browser/web_contents/web_contents_view_guest.h
[modify] https://crrev.com/1fa2a88268b9e2305a4bc17b01787ade8d9061d2/content/browser/web_contents/web_contents_view_mac.h
[modify] https://crrev.com/1fa2a88268b9e2305a4bc17b01787ade8d9061d2/content/browser/web_contents/web_contents_view_mac.mm
[modify] https://crrev.com/1fa2a88268b9e2305a4bc17b01787ade8d9061d2/content/public/browser/web_contents.h
[modify] https://crrev.com/1fa2a88268b9e2305a4bc17b01787ade8d9061d2/ui/base/ui_base_features.cc
[modify] https://crrev.com/1fa2a88268b9e2305a4bc17b01787ade8d9061d2/ui/base/ui_base_features.h

Project Member

Comment 82 by bugdroid1@chromium.org, Oct 1

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1574deae57d1f811a9be300474801bb344a30049

commit 1574deae57d1f811a9be300474801bb344a30049
Author: Nico Weber <thakis@chromium.org>
Date: Mon Oct 01 17:28:16 2018

mac: Remove interactive_test_utils_cocoa and two uses of IsViewsBrowserCocoa.

Bug: 832676
Change-Id: If5abb30902fdde9ec391c3a6fc8ed5808cf36476
Reviewed-on: https://chromium-review.googlesource.com/1253089
Reviewed-by: Robert Liao <robliao@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595476}
[modify] https://crrev.com/1574deae57d1f811a9be300474801bb344a30049/chrome/browser/ui/views/page_info/page_info_bubble_view_browsertest.cc
[modify] https://crrev.com/1574deae57d1f811a9be300474801bb344a30049/chrome/test/BUILD.gn
[delete] https://crrev.com/0c8daef006b8f8ce2c0805ca6dd1dde88cc5050c/chrome/test/base/interactive_test_utils_cocoa.h
[delete] https://crrev.com/0c8daef006b8f8ce2c0805ca6dd1dde88cc5050c/chrome/test/base/interactive_test_utils_cocoa.mm
[modify] https://crrev.com/1574deae57d1f811a9be300474801bb344a30049/chrome/test/base/interactive_test_utils_views.cc

Project Member

Comment 83 by bugdroid1@chromium.org, Oct 1

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/780e74401fd5918c80594238f815baea51b34d65

commit 780e74401fd5918c80594238f815baea51b34d65
Author: Nico Weber <thakis@chromium.org>
Date: Mon Oct 01 19:08:51 2018

mac: Remove browser_window_views_mac.h

Unused after https://chromium-review.googlesource.com/1252245

Bug: 832676
Change-Id: If22ce2914aab2cc4fe518ee10935830b53f6cbf7
Reviewed-on: https://chromium-review.googlesource.com/1255202
Reviewed-by: Leonard Grey <lgrey@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595495}
[modify] https://crrev.com/780e74401fd5918c80594238f815baea51b34d65/chrome/browser/ui/BUILD.gn
[delete] https://crrev.com/9b8eeaebeb1d5cbf42ff127da487a5a9a95d0ca3/chrome/browser/ui/cocoa/browser_window_cocoa_views_mac.mm
[modify] https://crrev.com/780e74401fd5918c80594238f815baea51b34d65/chrome/browser/ui/cocoa/browser_window_command_handler.mm
[delete] https://crrev.com/9b8eeaebeb1d5cbf42ff127da487a5a9a95d0ca3/chrome/browser/ui/cocoa/browser_window_views_mac.h
[modify] https://crrev.com/780e74401fd5918c80594238f815baea51b34d65/chrome/browser/ui/cocoa/chrome_command_dispatcher_delegate.mm

Project Member

Comment 84 by bugdroid1@chromium.org, Oct 1

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f1292212405758fcf3560616ad68ccb6706dc72a

commit f1292212405758fcf3560616ad68ccb6706dc72a
Author: Nico Weber <thakis@chromium.org>
Date: Mon Oct 01 19:36:11 2018

Remove PlatformAppBrowserTest.PrintPreviewShouldNotBeTooSmall.

When the test was added in https://codereview.chromium.org/26678004/
it only passed on macOS. Since macviews it no longer passes anywhere,
so just delete it.

Bug: 832676
Change-Id: Ie5b3f476f96d7f750612f58ac0c4f9016166ab11
Reviewed-on: https://chromium-review.googlesource.com/1255205
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595508}
[modify] https://crrev.com/f1292212405758fcf3560616ad68ccb6706dc72a/chrome/browser/apps/platform_apps/app_browsertest.cc

Comment 85 by thakis@chromium.org, Oct 1

Summary: macviews: remove cocoa browser UI code (was: macviews: remove cocoa secondary UI code)

(retitling since this moved into tracking removal of IsViewsBrowserCocoa , mac_views_browser in gn files, etc)

Project Member

Comment 86 by bugdroid1@chromium.org, Oct 1

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c598cda65683b79a417e73c4b8de1c56cde67412

commit c598cda65683b79a417e73c4b8de1c56cde67412
Author: Nico Weber <thakis@chromium.org>
Date: Mon Oct 01 20:00:54 2018

mac: Remove unused favicon_util_mac

Bug: 832676
Change-Id: I3088c0fa54d5b549f27dd158bbe46ec7834360a8
Reviewed-on: https://chromium-review.googlesource.com/1255207
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Wei Li <weili@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595524}
[modify] https://crrev.com/c598cda65683b79a417e73c4b8de1c56cde67412/chrome/browser/ui/BUILD.gn
[delete] https://crrev.com/4679a2dc1ed0db5c5a98e019880d4030181ca6f3/chrome/browser/ui/cocoa/tab_contents/favicon_util_mac.h
[delete] https://crrev.com/4679a2dc1ed0db5c5a98e019880d4030181ca6f3/chrome/browser/ui/cocoa/tab_contents/favicon_util_mac.mm
[modify] https://crrev.com/c598cda65683b79a417e73c4b8de1c56cde67412/chrome/browser/ui/tab_ui_helper.cc

Project Member

Comment 87 by bugdroid1@chromium.org, Oct 2

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f41f01a8a23c04f78a1600277507ede718a77163

commit f41f01a8a23c04f78a1600277507ede718a77163
Author: Nico Weber <thakis@chromium.org>
Date: Tue Oct 02 02:25:16 2018

mac: Remove some uses of now-always-on BUILDFLAG(MAC_VIEWS_BROWSER)

Bug: 832676
Change-Id: I1ca68200cd3555fe6ff77ca63eb5d5a61dccfdc3
Reviewed-on: https://chromium-review.googlesource.com/1255862
Commit-Queue: Trent Apted <tapted@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595699}
[modify] https://crrev.com/f41f01a8a23c04f78a1600277507ede718a77163/chrome/browser/ui/cocoa/browser_window_factory_cocoa.mm
[modify] https://crrev.com/f41f01a8a23c04f78a1600277507ede718a77163/chrome/browser/ui/cocoa/tab_contents/chrome_web_contents_view_delegate_mac.mm
[modify] https://crrev.com/f41f01a8a23c04f78a1600277507ede718a77163/chrome/browser/ui/find_bar/find_bar_host_browsertest.cc
[modify] https://crrev.com/f41f01a8a23c04f78a1600277507ede718a77163/chrome/browser/ui/media_router/media_router_ui_base.cc
[modify] https://crrev.com/f41f01a8a23c04f78a1600277507ede718a77163/chrome/browser/ui/media_router/media_router_ui_base.h
[modify] https://crrev.com/f41f01a8a23c04f78a1600277507ede718a77163/chrome/browser/ui/views/chrome_typography.cc
[modify] https://crrev.com/f41f01a8a23c04f78a1600277507ede718a77163/chrome/browser/ui/views/extensions/extension_uninstall_dialog_view.cc
[modify] https://crrev.com/f41f01a8a23c04f78a1600277507ede718a77163/chrome/browser/ui/views/external_protocol_dialog.cc
[modify] https://crrev.com/f41f01a8a23c04f78a1600277507ede718a77163/chrome/browser/ui/views/page_info/page_info_bubble_view.cc
[modify] https://crrev.com/f41f01a8a23c04f78a1600277507ede718a77163/chrome/browser/ui/views/passwords/account_chooser_dialog_view.cc
[modify] https://crrev.com/f41f01a8a23c04f78a1600277507ede718a77163/chrome/browser/ui/views/passwords/auto_signin_first_run_dialog_view.cc
[modify] https://crrev.com/f41f01a8a23c04f78a1600277507ede718a77163/chrome/browser/ui/views/passwords/password_auto_sign_in_view.cc
[modify] https://crrev.com/f41f01a8a23c04f78a1600277507ede718a77163/chrome/browser/ui/views/passwords/password_bubble_view_base.cc
[modify] https://crrev.com/f41f01a8a23c04f78a1600277507ede718a77163/chrome/browser/ui/views/passwords/password_bubble_view_base.h
[modify] https://crrev.com/f41f01a8a23c04f78a1600277507ede718a77163/chrome/browser/ui/views/simple_message_box_views.cc
[modify] https://crrev.com/f41f01a8a23c04f78a1600277507ede718a77163/chrome/browser/ui/views/sync/profile_signin_confirmation_dialog_views.cc
[modify] https://crrev.com/f41f01a8a23c04f78a1600277507ede718a77163/chrome/browser/ui/views/tab_contents/chrome_web_contents_view_delegate_views_mac.mm
[modify] https://crrev.com/f41f01a8a23c04f78a1600277507ede718a77163/chrome/browser/ui/views_mode_controller.cc
[modify] https://crrev.com/f41f01a8a23c04f78a1600277507ede718a77163/chrome/browser/ui/views_mode_controller.h
[modify] https://crrev.com/f41f01a8a23c04f78a1600277507ede718a77163/chrome/browser/ui/webui/media_router/media_router_ui.cc
[modify] https://crrev.com/f41f01a8a23c04f78a1600277507ede718a77163/chrome/browser/ui/webui/media_router/media_router_ui_unittest.cc

Project Member

Comment 88 by bugdroid1@chromium.org, Oct 2

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4a56f1eef016e40754e82f34e34dab999c4f53c4

commit 4a56f1eef016e40754e82f34e34dab999c4f53c4
Author: Trent Apted <tapted@chromium.org>
Date: Tue Oct 02 04:16:19 2018

Clean up menu_controller.mm a bit

Nothing inherits from the Mac MenuController, except its own tests.
It also sends out some notifications that were once used by a test,
which was recently deleted.

Bug: 832676
Change-Id: Ie95206a3a17461c41683422d61f5a18e4ae5c95a
Reviewed-on: https://chromium-review.googlesource.com/1250466
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595718}
[modify] https://crrev.com/4a56f1eef016e40754e82f34e34dab999c4f53c4/ui/base/cocoa/menu_controller.h
[modify] https://crrev.com/4a56f1eef016e40754e82f34e34dab999c4f53c4/ui/base/cocoa/menu_controller.mm

Project Member

Comment 89 by bugdroid1@chromium.org, Oct 2

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/686756be604172d3c39fe7aa91e2b4129eb3f1c5

commit 686756be604172d3c39fe7aa91e2b4129eb3f1c5
Author: Nico Weber <thakis@chromium.org>
Date: Tue Oct 02 14:52:18 2018

mac: Remove more uses of BUILDFLAG(MAC_VIEWS_BROWSER).

Bug: 832676
Change-Id: Iaac83b8248816993554baeefc03740d21f870370
Reviewed-on: https://chromium-review.googlesource.com/1256145
Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595832}
[modify] https://crrev.com/686756be604172d3c39fe7aa91e2b4129eb3f1c5/chrome/browser/infobars/infobars_browsertest.cc
[modify] https://crrev.com/686756be604172d3c39fe7aa91e2b4129eb3f1c5/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/686756be604172d3c39fe7aa91e2b4129eb3f1c5/chrome/browser/ui/browser_browsertest.cc
[modify] https://crrev.com/686756be604172d3c39fe7aa91e2b4129eb3f1c5/chrome/browser/ui/cocoa/ssl_client_certificate_selector_cocoa.mm
[modify] https://crrev.com/686756be604172d3c39fe7aa91e2b4129eb3f1c5/chrome/browser/ui/content_settings/content_setting_image_model.cc
[delete] https://crrev.com/eaacef69656c818e6e9c03186c9d7d55bd187e97/chrome/browser/ui/proximity_auth/proximity_auth_error_bubble_stub.cc
[modify] https://crrev.com/686756be604172d3c39fe7aa91e2b4129eb3f1c5/chrome/browser/ui/views/location_bar/zoom_bubble_view_browsertest.cc
[modify] https://crrev.com/686756be604172d3c39fe7aa91e2b4129eb3f1c5/chrome/browser/ui/views/passwords/password_bubble_interactive_uitest.cc
[modify] https://crrev.com/686756be604172d3c39fe7aa91e2b4129eb3f1c5/chrome/browser/ui/views/profiles/profile_chooser_view_browsertest.cc
[modify] https://crrev.com/686756be604172d3c39fe7aa91e2b4129eb3f1c5/chrome/browser/ui/webui/constrained_web_dialog_ui_browsertest.cc

Project Member

Comment 90 by bugdroid1@chromium.org, Oct 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b0f410894a4fae428a9bb2319f3095dc477b7094

commit b0f410894a4fae428a9bb2319f3095dc477b7094
Author: Nico Weber <thakis@chromium.org>
Date: Wed Oct 03 16:02:45 2018

Remove the mac_views_browser gn variable.

It's now redundant with is_mac.

The biggest use of it was that it set the buildflag MAC_VIEWS_BROWSER,
but I removed all references to that in the last few days:
https://cs.chromium.org/chromium/src/ui/base/BUILD.gn?q=%5CbMAC_VIEWS_BROWSER+case:yes

Bug: 832676
Change-Id: I9bd74e26a35ddb4dfec786e4b0a6ada24366c951
Reviewed-on: https://chromium-review.googlesource.com/c/1258295
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596238}
[modify] https://crrev.com/b0f410894a4fae428a9bb2319f3095dc477b7094/chrome/app/theme/theme_resources.grd
[modify] https://crrev.com/b0f410894a4fae428a9bb2319f3095dc477b7094/chrome/browser/ui/views/browser_dialogs_views.cc
[modify] https://crrev.com/b0f410894a4fae428a9bb2319f3095dc477b7094/chrome/common/features.gni
[modify] https://crrev.com/b0f410894a4fae428a9bb2319f3095dc477b7094/chrome/test/BUILD.gn
[modify] https://crrev.com/b0f410894a4fae428a9bb2319f3095dc477b7094/ui/base/BUILD.gn
[modify] https://crrev.com/b0f410894a4fae428a9bb2319f3095dc477b7094/ui/base/ui_features.gni

Project Member

Comment 91 by bugdroid1@chromium.org, Oct 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1515d1b6e029d3071b15ae2e89991de62db890e3

commit 1515d1b6e029d3071b15ae2e89991de62db890e3
Author: Robert Sesek <rsesek@chromium.org>
Date: Tue Oct 09 13:42:03 2018

mac: Delete BrowserWindowController and BrowserWindowCocoa.

Bug: 832676
Change-Id: Ice7a4043cb296e3e7ee03f86f7ce04b4a75746ec
Reviewed-on: https://chromium-review.googlesource.com/c/1270135
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597896}
[modify] https://crrev.com/1515d1b6e029d3071b15ae2e89991de62db890e3/chrome/browser/renderer_host/chrome_render_widget_host_view_mac_delegate.mm
[modify] https://crrev.com/1515d1b6e029d3071b15ae2e89991de62db890e3/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/1515d1b6e029d3071b15ae2e89991de62db890e3/chrome/browser/ui/browser_window.h
[delete] https://crrev.com/f21b037ba400d3a0e31540d4dcbae3570f782dc3/chrome/browser/ui/cocoa/browser_window_cocoa.h
[delete] https://crrev.com/f21b037ba400d3a0e31540d4dcbae3570f782dc3/chrome/browser/ui/cocoa/browser_window_cocoa.mm
[delete] https://crrev.com/f21b037ba400d3a0e31540d4dcbae3570f782dc3/chrome/browser/ui/cocoa/browser_window_cocoa_unittest.mm
[modify] https://crrev.com/1515d1b6e029d3071b15ae2e89991de62db890e3/chrome/browser/ui/cocoa/browser_window_command_handler.mm
[delete] https://crrev.com/f21b037ba400d3a0e31540d4dcbae3570f782dc3/chrome/browser/ui/cocoa/browser_window_controller.h
[delete] https://crrev.com/f21b037ba400d3a0e31540d4dcbae3570f782dc3/chrome/browser/ui/cocoa/browser_window_controller.mm
[delete] https://crrev.com/f21b037ba400d3a0e31540d4dcbae3570f782dc3/chrome/browser/ui/cocoa/browser_window_controller_private.h
[delete] https://crrev.com/f21b037ba400d3a0e31540d4dcbae3570f782dc3/chrome/browser/ui/cocoa/browser_window_controller_private.mm
[delete] https://crrev.com/f21b037ba400d3a0e31540d4dcbae3570f782dc3/chrome/browser/ui/cocoa/browser_window_controller_unittest.mm
[delete] https://crrev.com/f21b037ba400d3a0e31540d4dcbae3570f782dc3/chrome/browser/ui/cocoa/browser_window_factory_cocoa.mm
[modify] https://crrev.com/1515d1b6e029d3071b15ae2e89991de62db890e3/chrome/browser/ui/cocoa/bubble_anchor_helper.mm
[modify] https://crrev.com/1515d1b6e029d3071b15ae2e89991de62db890e3/chrome/browser/ui/cocoa/chrome_command_dispatcher_delegate.mm
[modify] https://crrev.com/1515d1b6e029d3071b15ae2e89991de62db890e3/chrome/browser/ui/cocoa/framed_browser_window.mm
[modify] https://crrev.com/1515d1b6e029d3071b15ae2e89991de62db890e3/chrome/browser/ui/cocoa/framed_browser_window_unittest.mm
[modify] https://crrev.com/1515d1b6e029d3071b15ae2e89991de62db890e3/chrome/browser/ui/cocoa/fullscreen/fullscreen_menubar_tracker.mm
[delete] https://crrev.com/f21b037ba400d3a0e31540d4dcbae3570f782dc3/chrome/browser/ui/cocoa/fullscreen/fullscreen_toolbar_controller_cocoa.h
[delete] https://crrev.com/f21b037ba400d3a0e31540d4dcbae3570f782dc3/chrome/browser/ui/cocoa/fullscreen/fullscreen_toolbar_controller_cocoa.mm
[delete] https://crrev.com/f21b037ba400d3a0e31540d4dcbae3570f782dc3/chrome/browser/ui/cocoa/fullscreen/fullscreen_toolbar_controller_unittest.mm
[modify] https://crrev.com/1515d1b6e029d3071b15ae2e89991de62db890e3/chrome/browser/ui/cocoa/fullscreen/fullscreen_toolbar_mouse_tracker.mm
[modify] https://crrev.com/1515d1b6e029d3071b15ae2e89991de62db890e3/chrome/browser/ui/cocoa/history_overlay_controller.mm
[modify] https://crrev.com/1515d1b6e029d3071b15ae2e89991de62db890e3/chrome/browser/ui/cocoa/permission_bubble/permission_bubble_views_cocoa_browsertest.mm
[modify] https://crrev.com/1515d1b6e029d3071b15ae2e89991de62db890e3/chrome/browser/ui/cocoa/renderer_context_menu/render_view_context_menu_mac_cocoa_browsertest.mm
[modify] https://crrev.com/1515d1b6e029d3071b15ae2e89991de62db890e3/chrome/browser/ui/cocoa/tabbed_browser_window.mm
[modify] https://crrev.com/1515d1b6e029d3071b15ae2e89991de62db890e3/chrome/browser/ui/cocoa/touchbar/browser_window_default_touch_bar_unittest.mm
[modify] https://crrev.com/1515d1b6e029d3071b15ae2e89991de62db890e3/chrome/browser/ui/cocoa/touchbar/web_textfield_touch_bar_controller.mm
[modify] https://crrev.com/1515d1b6e029d3071b15ae2e89991de62db890e3/chrome/browser/ui/cocoa/view_id_util.mm
[modify] https://crrev.com/1515d1b6e029d3071b15ae2e89991de62db890e3/chrome/browser/ui/views/frame/browser_window_factory.cc
[modify] https://crrev.com/1515d1b6e029d3071b15ae2e89991de62db890e3/chrome/test/BUILD.gn

Project Member

Comment 92 by bugdroid1@chromium.org, Oct 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e69cd879cb222386bf51e62fda6db3ebff7dda57

commit e69cd879cb222386bf51e62fda6db3ebff7dda57
Author: Robert Sesek <rsesek@chromium.org>
Date: Tue Oct 09 14:56:19 2018

mac: Delete some Cocoa view utilities.

Bug: 832676
Change-Id: I27e36d91333ed42db75e61864e2700355a93f349
Reviewed-on: https://chromium-review.googlesource.com/c/1269895
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Leonard Grey <lgrey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597913}
[modify] https://crrev.com/e69cd879cb222386bf51e62fda6db3ebff7dda57/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/e69cd879cb222386bf51e62fda6db3ebff7dda57/chrome/browser/ui/cocoa/drag_util.h
[modify] https://crrev.com/e69cd879cb222386bf51e62fda6db3ebff7dda57/chrome/browser/ui/cocoa/drag_util.mm
[delete] https://crrev.com/42776a4625e1aa02206a460934d4ce240386e2f6/chrome/browser/ui/cocoa/nsview_additions.h
[delete] https://crrev.com/42776a4625e1aa02206a460934d4ce240386e2f6/chrome/browser/ui/cocoa/nsview_additions.mm
[delete] https://crrev.com/42776a4625e1aa02206a460934d4ce240386e2f6/chrome/browser/ui/cocoa/nsview_additions_unittest.mm
[delete] https://crrev.com/42776a4625e1aa02206a460934d4ce240386e2f6/chrome/browser/ui/cocoa/test/scoped_force_rtl_mac.h
[delete] https://crrev.com/42776a4625e1aa02206a460934d4ce240386e2f6/chrome/browser/ui/cocoa/test/scoped_force_rtl_mac.mm
[delete] https://crrev.com/42776a4625e1aa02206a460934d4ce240386e2f6/chrome/browser/ui/cocoa/view_id_util.h
[delete] https://crrev.com/42776a4625e1aa02206a460934d4ce240386e2f6/chrome/browser/ui/cocoa/view_id_util.mm
[modify] https://crrev.com/e69cd879cb222386bf51e62fda6db3ebff7dda57/chrome/test/BUILD.gn

Project Member

Comment 93 by bugdroid1@chromium.org, Oct 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/05630780ff721346c0ccf3d3123a5715f9d266fc

commit 05630780ff721346c0ccf3d3123a5715f9d266fc
Author: Nico Weber <thakis@chromium.org>
Date: Tue Oct 09 15:39:36 2018

mac: Remove some now-unused cocoa files.

Bug: 832676
Change-Id: I0659094c067462b16d5f4397bcc2ba89f7500ce0
Reviewed-on: https://chromium-review.googlesource.com/c/1270350
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597924}
[modify] https://crrev.com/05630780ff721346c0ccf3d3123a5715f9d266fc/chrome/browser/ui/BUILD.gn
[delete] https://crrev.com/3c4ead6ae8347d602d32b2e419aed9490dce4abd/chrome/browser/ui/cocoa/tab_contents/overlayable_contents_controller.h
[delete] https://crrev.com/3c4ead6ae8347d602d32b2e419aed9490dce4abd/chrome/browser/ui/cocoa/tab_contents/overlayable_contents_controller.mm
[delete] https://crrev.com/3c4ead6ae8347d602d32b2e419aed9490dce4abd/chrome/browser/ui/cocoa/tab_contents/tab_contents_controller.h
[delete] https://crrev.com/3c4ead6ae8347d602d32b2e419aed9490dce4abd/chrome/browser/ui/cocoa/tab_contents/tab_contents_controller.mm
[modify] https://crrev.com/05630780ff721346c0ccf3d3123a5715f9d266fc/chrome/browser/ui/cocoa/touchbar/web_textfield_touch_bar_controller.h
[modify] https://crrev.com/05630780ff721346c0ccf3d3123a5715f9d266fc/chrome/browser/ui/cocoa/touchbar/web_textfield_touch_bar_controller.mm

Project Member

Comment 94 by bugdroid1@chromium.org, Oct 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/519c86044b6eae5e4f0595f4e49c77768a1650fd

commit 519c86044b6eae5e4f0595f4e49c77768a1650fd
Author: Nico Weber <thakis@chromium.org>
Date: Tue Oct 09 16:11:47 2018

mac: Remove now-unused manage_passwords_icon.h/cc

Bug: 832676
Cq-Include-Trybots: luci.chromium.try:linux_chromium_dbg_ng
Change-Id: Ibf08729ea9c9105fafe6c9769d41cc03afd011fe
Reviewed-on: https://chromium-review.googlesource.com/c/1270354
Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597934}
[modify] https://crrev.com/519c86044b6eae5e4f0595f4e49c77768a1650fd/build/check_gn_headers_whitelist.txt
[modify] https://crrev.com/519c86044b6eae5e4f0595f4e49c77768a1650fd/chrome/browser/ui/BUILD.gn
[delete] https://crrev.com/46a8d7b93e45cf9137f66aff39a63cccb0486e53/chrome/browser/ui/passwords/manage_passwords_icon.cc
[delete] https://crrev.com/46a8d7b93e45cf9137f66aff39a63cccb0486e53/chrome/browser/ui/passwords/manage_passwords_icon.h
[modify] https://crrev.com/519c86044b6eae5e4f0595f4e49c77768a1650fd/chrome/browser/ui/views/passwords/manage_passwords_icon_view_interactive_uitest.cc

Project Member

Comment 95 by bugdroid1@chromium.org, Oct 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/954fb8eae2823fc8d3a0b5c558c32dee66acab54

commit 954fb8eae2823fc8d3a0b5c558c32dee66acab54
Author: Robert Sesek <rsesek@chromium.org>
Date: Tue Oct 09 18:02:02 2018

mac: Delete the remnants of the Cocoa browser window.

Bug: 832676
Change-Id: I2ccdd72dba8b8b1bf468875df93498dfccd6ff26
Reviewed-on: https://chromium-review.googlesource.com/c/1271135
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597988}
[modify] https://crrev.com/954fb8eae2823fc8d3a0b5c558c32dee66acab54/chrome/browser/ui/BUILD.gn
[delete] https://crrev.com/d44daa00c9e3704579d15097bd9e3694b0064eb1/chrome/browser/ui/cocoa/animated_icon.h
[delete] https://crrev.com/d44daa00c9e3704579d15097bd9e3694b0064eb1/chrome/browser/ui/cocoa/animated_icon.mm
[delete] https://crrev.com/d44daa00c9e3704579d15097bd9e3694b0064eb1/chrome/browser/ui/cocoa/browser_window_layout.h
[delete] https://crrev.com/d44daa00c9e3704579d15097bd9e3694b0064eb1/chrome/browser/ui/cocoa/browser_window_layout.mm
[delete] https://crrev.com/d44daa00c9e3704579d15097bd9e3694b0064eb1/chrome/browser/ui/cocoa/browser_window_utils.h
[delete] https://crrev.com/d44daa00c9e3704579d15097bd9e3694b0064eb1/chrome/browser/ui/cocoa/browser_window_utils.mm
[delete] https://crrev.com/d44daa00c9e3704579d15097bd9e3694b0064eb1/chrome/browser/ui/cocoa/browser_window_utils_unittest.mm
[delete] https://crrev.com/d44daa00c9e3704579d15097bd9e3694b0064eb1/chrome/browser/ui/cocoa/chrome_browser_window.h
[delete] https://crrev.com/d44daa00c9e3704579d15097bd9e3694b0064eb1/chrome/browser/ui/cocoa/chrome_browser_window.mm
[delete] https://crrev.com/d44daa00c9e3704579d15097bd9e3694b0064eb1/chrome/browser/ui/cocoa/chrome_browser_window_unittest.mm
[delete] https://crrev.com/d44daa00c9e3704579d15097bd9e3694b0064eb1/chrome/browser/ui/cocoa/chrome_event_processing_window.h
[delete] https://crrev.com/d44daa00c9e3704579d15097bd9e3694b0064eb1/chrome/browser/ui/cocoa/chrome_event_processing_window.mm
[delete] https://crrev.com/d44daa00c9e3704579d15097bd9e3694b0064eb1/chrome/browser/ui/cocoa/chrome_style.cc
[delete] https://crrev.com/d44daa00c9e3704579d15097bd9e3694b0064eb1/chrome/browser/ui/cocoa/chrome_style.h
[delete] https://crrev.com/d44daa00c9e3704579d15097bd9e3694b0064eb1/chrome/browser/ui/cocoa/constrained_window/constrained_window_custom_window.h
[delete] https://crrev.com/d44daa00c9e3704579d15097bd9e3694b0064eb1/chrome/browser/ui/cocoa/constrained_window/constrained_window_custom_window.mm
[delete] https://crrev.com/d44daa00c9e3704579d15097bd9e3694b0064eb1/chrome/browser/ui/cocoa/constrained_window/constrained_window_custom_window_unittest.mm
[delete] https://crrev.com/d44daa00c9e3704579d15097bd9e3694b0064eb1/chrome/browser/ui/cocoa/fast_resize_view.h
[delete] https://crrev.com/d44daa00c9e3704579d15097bd9e3694b0064eb1/chrome/browser/ui/cocoa/fast_resize_view.mm
[delete] https://crrev.com/d44daa00c9e3704579d15097bd9e3694b0064eb1/chrome/browser/ui/cocoa/framed_browser_window.h
[delete] https://crrev.com/d44daa00c9e3704579d15097bd9e3694b0064eb1/chrome/browser/ui/cocoa/framed_browser_window.mm
[delete] https://crrev.com/d44daa00c9e3704579d15097bd9e3694b0064eb1/chrome/browser/ui/cocoa/framed_browser_window_unittest.mm
[delete] https://crrev.com/d44daa00c9e3704579d15097bd9e3694b0064eb1/chrome/browser/ui/cocoa/has_weak_browser_pointer.h
[delete] https://crrev.com/d44daa00c9e3704579d15097bd9e3694b0064eb1/chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.h
[delete] https://crrev.com/d44daa00c9e3704579d15097bd9e3694b0064eb1/chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm
[delete] https://crrev.com/d44daa00c9e3704579d15097bd9e3694b0064eb1/chrome/browser/ui/cocoa/md_util.h
[delete] https://crrev.com/d44daa00c9e3704579d15097bd9e3694b0064eb1/chrome/browser/ui/cocoa/md_util.mm
[delete] https://crrev.com/d44daa00c9e3704579d15097bd9e3694b0064eb1/chrome/browser/ui/cocoa/tabbed_browser_window.h
[delete] https://crrev.com/d44daa00c9e3704579d15097bd9e3694b0064eb1/chrome/browser/ui/cocoa/tabbed_browser_window.mm
[delete] https://crrev.com/d44daa00c9e3704579d15097bd9e3694b0064eb1/chrome/browser/ui/cocoa/tabbed_browser_window_unittest.mm
[delete] https://crrev.com/d44daa00c9e3704579d15097bd9e3694b0064eb1/chrome/browser/ui/cocoa/tabs/OWNERS
[delete] https://crrev.com/d44daa00c9e3704579d15097bd9e3694b0064eb1/chrome/browser/ui/cocoa/tabs/tab_strip_controller_unittest.mm
[delete] https://crrev.com/d44daa00c9e3704579d15097bd9e3694b0064eb1/chrome/browser/ui/cocoa/tabs/tab_window_controller.h
[delete] https://crrev.com/d44daa00c9e3704579d15097bd9e3694b0064eb1/chrome/browser/ui/cocoa/tabs/tab_window_controller.mm
[delete] https://crrev.com/d44daa00c9e3704579d15097bd9e3694b0064eb1/chrome/browser/ui/cocoa/themed_window.h
[delete] https://crrev.com/d44daa00c9e3704579d15097bd9e3694b0064eb1/chrome/browser/ui/cocoa/themed_window.mm
[delete] https://crrev.com/d44daa00c9e3704579d15097bd9e3694b0064eb1/chrome/browser/ui/cocoa/view_resizer.h
[delete] https://crrev.com/d44daa00c9e3704579d15097bd9e3694b0064eb1/chrome/browser/ui/cocoa/view_resizer_pong.h
[delete] https://crrev.com/d44daa00c9e3704579d15097bd9e3694b0064eb1/chrome/browser/ui/cocoa/view_resizer_pong.mm
[delete] https://crrev.com/d44daa00c9e3704579d15097bd9e3694b0064eb1/chrome/browser/ui/content_settings/content_setting_media_menu_model.cc
[delete] https://crrev.com/d44daa00c9e3704579d15097bd9e3694b0064eb1/chrome/browser/ui/content_settings/content_setting_media_menu_model.h
[modify] https://crrev.com/954fb8eae2823fc8d3a0b5c558c32dee66acab54/chrome/test/BUILD.gn

Project Member

Comment 96 by bugdroid1@chromium.org, Oct 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/83fb6485b4840683ae19f2be4a896a19436a1fbf

commit 83fb6485b4840683ae19f2be4a896a19436a1fbf
Author: Robert Sesek <rsesek@chromium.org>
Date: Tue Oct 09 19:49:31 2018

mac: Delete some unused code in //ui/base/cocoa

Bug: 832676
Change-Id: Iac825f73c9fecda667a9c0bd4730ec3404f837ca
Reviewed-on: https://chromium-review.googlesource.com/c/1271635
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598045}
[modify] https://crrev.com/83fb6485b4840683ae19f2be4a896a19436a1fbf/ui/base/BUILD.gn
[modify] https://crrev.com/83fb6485b4840683ae19f2be4a896a19436a1fbf/ui/base/cocoa/appkit_utils.h
[modify] https://crrev.com/83fb6485b4840683ae19f2be4a896a19436a1fbf/ui/base/cocoa/appkit_utils.mm
[delete] https://crrev.com/f1b50d828a8a017d363b655f619752fa698968eb/ui/base/cocoa/nsgraphics_context_additions.h
[delete] https://crrev.com/f1b50d828a8a017d363b655f619752fa698968eb/ui/base/cocoa/nsgraphics_context_additions.mm
[delete] https://crrev.com/f1b50d828a8a017d363b655f619752fa698968eb/ui/base/cocoa/nsgraphics_context_additions_unittest.mm
[delete] https://crrev.com/f1b50d828a8a017d363b655f619752fa698968eb/ui/base/cocoa/nsview_additions.h
[delete] https://crrev.com/f1b50d828a8a017d363b655f619752fa698968eb/ui/base/cocoa/nsview_additions.mm
[delete] https://crrev.com/f1b50d828a8a017d363b655f619752fa698968eb/ui/base/cocoa/nsview_additions_unittest.mm
[delete] https://crrev.com/f1b50d828a8a017d363b655f619752fa698968eb/ui/base/cocoa/scoped_cg_context_smooth_fonts.h
[delete] https://crrev.com/f1b50d828a8a017d363b655f619752fa698968eb/ui/base/cocoa/scoped_cg_context_smooth_fonts.mm
[delete] https://crrev.com/f1b50d828a8a017d363b655f619752fa698968eb/ui/base/cocoa/three_part_image.h
[delete] https://crrev.com/f1b50d828a8a017d363b655f619752fa698968eb/ui/base/cocoa/three_part_image.mm
[delete] https://crrev.com/f1b50d828a8a017d363b655f619752fa698968eb/ui/base/cocoa/three_part_image_unittest.mm
[delete] https://crrev.com/f1b50d828a8a017d363b655f619752fa698968eb/ui/base/cocoa/view_description.h
[delete] https://crrev.com/f1b50d828a8a017d363b655f619752fa698968eb/ui/base/cocoa/view_description.mm

Project Member

Comment 97 by bugdroid1@chromium.org, Oct 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e23b1444acffb4c657a46bb6fd819477a9c9b837

commit e23b1444acffb4c657a46bb6fd819477a9c9b837
Author: Robert Sesek <rsesek@chromium.org>
Date: Tue Oct 09 20:06:57 2018

mac: Delete Cocoa-specific ThemeProvider methods.

Bug: 832676
Change-Id: I184732fe97c42456085c8b3b2cf4885548ae7f8f
Reviewed-on: https://chromium-review.googlesource.com/c/1271695
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598056}
[modify] https://crrev.com/e23b1444acffb4c657a46bb6fd819477a9c9b837/chrome/browser/BUILD.gn
[modify] https://crrev.com/e23b1444acffb4c657a46bb6fd819477a9c9b837/chrome/browser/themes/theme_service.cc
[modify] https://crrev.com/e23b1444acffb4c657a46bb6fd819477a9c9b837/chrome/browser/themes/theme_service.h
[delete] https://crrev.com/81b08fd531af5e9ab4ca317067cceaeb4a0ddd29/chrome/browser/themes/theme_service_mac.mm
[modify] https://crrev.com/e23b1444acffb4c657a46bb6fd819477a9c9b837/chrome/browser/ui/views/frame/browser_non_client_frame_view_mac.mm
[modify] https://crrev.com/e23b1444acffb4c657a46bb6fd819477a9c9b837/ui/base/BUILD.gn
[modify] https://crrev.com/e23b1444acffb4c657a46bb6fd819477a9c9b837/ui/base/default_theme_provider.h
[delete] https://crrev.com/81b08fd531af5e9ab4ca317067cceaeb4a0ddd29/ui/base/default_theme_provider_mac.mm
[modify] https://crrev.com/e23b1444acffb4c657a46bb6fd819477a9c9b837/ui/base/theme_provider.h

Project Member

Comment 98 by bugdroid1@chromium.org, Oct 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/90775b9a06bb6782768f4b743aa9bf1e315193db

commit 90775b9a06bb6782768f4b743aa9bf1e315193db
Author: Nico Weber <thakis@chromium.org>
Date: Tue Oct 09 20:37:23 2018

mac: Inline cocoa_browser_sources.

These source files are all still used in the new views browser.

Bug: 832676,802257,804950
Change-Id: Ide348cda6322fcbcc1d17482d522fdfd0cc76cee
Reviewed-on: https://chromium-review.googlesource.com/c/1271715
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598068}
[modify] https://crrev.com/90775b9a06bb6782768f4b743aa9bf1e315193db/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/90775b9a06bb6782768f4b743aa9bf1e315193db/chrome/test/BUILD.gn

Project Member

Comment 99 by bugdroid1@chromium.org, Oct 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9b61ffcad52233521a77c765c251bf8c7ccc4d80

commit 9b61ffcad52233521a77c765c251bf8c7ccc4d80
Author: Robert Sesek <rsesek@chromium.org>
Date: Tue Oct 09 22:55:21 2018

mac: Trim down the list of sources in //third_party/google_toolbox_for_mac

Bug: 832676
Change-Id: I6deb6388f6bf1e1aa6861b28a8be305dc4702e30
Reviewed-on: https://chromium-review.googlesource.com/c/1271720
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598111}
[modify] https://crrev.com/9b61ffcad52233521a77c765c251bf8c7ccc4d80/third_party/google_toolbox_for_mac/BUILD.gn

Comment 100 by thakis@chromium.org, Oct 10

More ideas:

https://cs.chromium.org/search/?q=%22cocoa+browser%22&sq=package:chromium
https://cs.chromium.org/search/?q=%22views+browser%22&sq=package:chromium&type=cs

https://cs.chromium.org/search/?q=isviewsbrowsercocoa&sq=package:chromium <- this actually contains only tests that don't yet pass under macviews

Comment 101 by thakis@chromium.org, Oct 10

https://cs.chromium.org/search/?q=macviews&sq=package:chromium

Project Member

Comment 102 by bugdroid1@chromium.org, Oct 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9b19bc517883a866bd88012b821154fae04ffca7

commit 9b19bc517883a866bd88012b821154fae04ffca7
Author: Robert Sesek <rsesek@chromium.org>
Date: Wed Oct 10 16:18:25 2018

mac: Delete unused ExtensionKeybindingRegistryCocoa.

Bug: 832676
Change-Id: I5148be3574b5e9080ecd1e6f08484ce0ec5e9865
Reviewed-on: https://chromium-review.googlesource.com/c/1273561
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598355}
[modify] https://crrev.com/9b19bc517883a866bd88012b821154fae04ffca7/chrome/browser/ui/BUILD.gn
[delete] https://crrev.com/415957afca5de6495e2ddec0f58140c830fe82f7/chrome/browser/ui/cocoa/extensions/extension_keybinding_registry_cocoa.h
[delete] https://crrev.com/415957afca5de6495e2ddec0f58140c830fe82f7/chrome/browser/ui/cocoa/extensions/extension_keybinding_registry_cocoa.mm

Project Member

Comment 103 by bugdroid1@chromium.org, Oct 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c3efde098bd9568d11cdd526868df1607bdb613d

commit c3efde098bd9568d11cdd526868df1607bdb613d
Author: Robert Sesek <rsesek@chromium.org>
Date: Wed Oct 10 19:54:00 2018

mac: Delete unused browser_dialogs_views_mac and inline bubble_anchor_helper

There was only one caller of the latter, so just put the single function
in the test that uses it.

Bug: 832676
Change-Id: Ib53f4cca2ebc0dad049798f082f55175c5422f10
Reviewed-on: https://chromium-review.googlesource.com/c/1273813
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598460}
[modify] https://crrev.com/c3efde098bd9568d11cdd526868df1607bdb613d/chrome/browser/ui/BUILD.gn
[delete] https://crrev.com/5b98be91d96f0b653bafce146c9d1f036a34b688/chrome/browser/ui/cocoa/browser_dialogs_views_mac.cc
[delete] https://crrev.com/5b98be91d96f0b653bafce146c9d1f036a34b688/chrome/browser/ui/cocoa/browser_dialogs_views_mac.h
[delete] https://crrev.com/5b98be91d96f0b653bafce146c9d1f036a34b688/chrome/browser/ui/cocoa/bubble_anchor_helper.h
[delete] https://crrev.com/5b98be91d96f0b653bafce146c9d1f036a34b688/chrome/browser/ui/cocoa/bubble_anchor_helper.mm
[modify] https://crrev.com/c3efde098bd9568d11cdd526868df1607bdb613d/chrome/browser/ui/cocoa/permission_bubble/permission_bubble_views_cocoa_browsertest.mm
[modify] https://crrev.com/c3efde098bd9568d11cdd526868df1607bdb613d/chrome/browser/ui/views/extensions/extension_view_views.cc
[modify] https://crrev.com/c3efde098bd9568d11cdd526868df1607bdb613d/chrome/browser/ui/views/page_info/page_info_bubble_view.cc

Project Member

Comment 104 by bugdroid1@chromium.org, Oct 15

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a083f78a25d15c9e707ca472ee62b7a0a08c08a6

commit a083f78a25d15c9e707ca472ee62b7a0a08c08a6
Author: Robert Sesek <rsesek@chromium.org>
Date: Mon Oct 15 17:47:01 2018

mac: Delete more unused code in //chrome/browser/ui/cocoa

Bug: 832676
Change-Id: Ifbd5d17e8901a9e44f8ff2180459a950648d2fda
Reviewed-on: https://chromium-review.googlesource.com/c/1280791
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599671}
[modify] https://crrev.com/a083f78a25d15c9e707ca472ee62b7a0a08c08a6/chrome/browser/ui/BUILD.gn
[delete] https://crrev.com/23cac3367d72e4d392a755cb6cea19116799021b/chrome/browser/ui/cocoa/drag_util.h
[delete] https://crrev.com/23cac3367d72e4d392a755cb6cea19116799021b/chrome/browser/ui/cocoa/drag_util.mm
[delete] https://crrev.com/23cac3367d72e4d392a755cb6cea19116799021b/chrome/browser/ui/cocoa/renderer_context_menu/render_view_context_menu_mac_views.h
[delete] https://crrev.com/23cac3367d72e4d392a755cb6cea19116799021b/chrome/browser/ui/cocoa/renderer_context_menu/render_view_context_menu_mac_views.mm
[delete] https://crrev.com/23cac3367d72e4d392a755cb6cea19116799021b/chrome/browser/ui/cocoa/restart_browser.h
[delete] https://crrev.com/23cac3367d72e4d392a755cb6cea19116799021b/chrome/browser/ui/cocoa/restart_browser.mm
[modify] https://crrev.com/a083f78a25d15c9e707ca472ee62b7a0a08c08a6/chrome/browser/ui/cocoa/tab_contents/chrome_web_contents_view_delegate_mac.mm
[delete] https://crrev.com/23cac3367d72e4d392a755cb6cea19116799021b/chrome/browser/ui/cocoa/url_drop_target.h
[delete] https://crrev.com/23cac3367d72e4d392a755cb6cea19116799021b/chrome/browser/ui/cocoa/url_drop_target.mm
[delete] https://crrev.com/23cac3367d72e4d392a755cb6cea19116799021b/chrome/browser/ui/cocoa/url_drop_target_unittest.mm
[modify] https://crrev.com/a083f78a25d15c9e707ca472ee62b7a0a08c08a6/chrome/test/BUILD.gn

Project Member

Comment 105 by bugdroid1@chromium.org, Oct 25

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ef049b2d94ea696bdd94703320c93a897d9071a7

commit ef049b2d94ea696bdd94703320c93a897d9071a7
Author: Robert Sesek <rsesek@chromium.org>
Date: Thu Oct 25 17:47:16 2018

mac: Remove unneeded includes of views_mode_controller.h

Bug: 832676
Change-Id: I2323993d04202561a1c0c0ea92e1d974e1b5625f
Reviewed-on: https://chromium-review.googlesource.com/c/1299434
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602779}
[modify] https://crrev.com/ef049b2d94ea696bdd94703320c93a897d9071a7/chrome/browser/app_controller_mac_browsertest.mm
[modify] https://crrev.com/ef049b2d94ea696bdd94703320c93a897d9071a7/chrome/browser/apps/guest_view/web_view_interactive_browsertest.cc
[modify] https://crrev.com/ef049b2d94ea696bdd94703320c93a897d9071a7/chrome/browser/extensions/extension_keybinding_apitest.cc
[modify] https://crrev.com/ef049b2d94ea696bdd94703320c93a897d9071a7/chrome/browser/global_keyboard_shortcuts_mac.mm
[modify] https://crrev.com/ef049b2d94ea696bdd94703320c93a897d9071a7/chrome/browser/global_keyboard_shortcuts_mac_browsertest.mm
[modify] https://crrev.com/ef049b2d94ea696bdd94703320c93a897d9071a7/chrome/browser/infobars/infobars_browsertest.cc
[modify] https://crrev.com/ef049b2d94ea696bdd94703320c93a897d9071a7/chrome/browser/ui/blocked_content/popup_blocker_browsertest.cc
[modify] https://crrev.com/ef049b2d94ea696bdd94703320c93a897d9071a7/chrome/browser/ui/browser_browsertest.cc
[modify] https://crrev.com/ef049b2d94ea696bdd94703320c93a897d9071a7/chrome/browser/ui/cocoa/tab_contents/chrome_web_contents_view_delegate_mac.mm
[modify] https://crrev.com/ef049b2d94ea696bdd94703320c93a897d9071a7/chrome/browser/ui/cocoa/task_manager_mac.mm
[modify] https://crrev.com/ef049b2d94ea696bdd94703320c93a897d9071a7/chrome/browser/ui/views/bookmarks/bookmark_drag_drop_views.cc
[modify] https://crrev.com/ef049b2d94ea696bdd94703320c93a897d9071a7/chrome/browser/ui/views/browser_dialogs_views.cc
[modify] https://crrev.com/ef049b2d94ea696bdd94703320c93a897d9071a7/chrome/browser/ui/views/find_bar_host_unittest_util_views.cc
[modify] https://crrev.com/ef049b2d94ea696bdd94703320c93a897d9071a7/chrome/browser/ui/views/infobars/alternate_nav_infobar_view.cc
[modify] https://crrev.com/ef049b2d94ea696bdd94703320c93a897d9071a7/chrome/browser/ui/views/infobars/confirm_infobar.cc
[modify] https://crrev.com/ef049b2d94ea696bdd94703320c93a897d9071a7/chrome/browser/ui/views/screen_capture_notification_ui_views.cc
[modify] https://crrev.com/ef049b2d94ea696bdd94703320c93a897d9071a7/chrome/browser/ui/views/ssl_client_certificate_selector.cc
[modify] https://crrev.com/ef049b2d94ea696bdd94703320c93a897d9071a7/chrome/browser/ui/views/status_bubble_views_browsertest.cc

Project Member

Comment 106 by bugdroid1@chromium.org, Oct 25

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dd40a1738d858f0bab308422bf5c4b4c8c782c23

commit dd40a1738d858f0bab308422bf5c4b4c8c782c23
Author: Robert Sesek <rsesek@chromium.org>
Date: Thu Oct 25 19:04:20 2018

mac: Inline cocoa_test_sources in chrome/test/BUILD.gn

Also delete ui_gfx_image_unittest.{cc,mm} since the test doesn't verify
anything useful.

Bug: 832676
Change-Id: Ic486f5072b54abb60996ad351e042089cffffe4c
Reviewed-on: https://chromium-review.googlesource.com/c/1299433
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602818}
[delete] https://crrev.com/fdf87103b6d01dc8b7fa3d7120fa03a53e0b1864/chrome/browser/ui/tests/ui_gfx_image_unittest.cc
[delete] https://crrev.com/fdf87103b6d01dc8b7fa3d7120fa03a53e0b1864/chrome/browser/ui/tests/ui_gfx_image_unittest.mm
[modify] https://crrev.com/dd40a1738d858f0bab308422bf5c4b4c8c782c23/chrome/test/BUILD.gn

Comment 107 by thakis@google.com, Oct 26

We should probably go through the Hotlist-CocoaBrowser bugs and WontFix the ones that were actually fixed by macviews.

Project Member

Comment 108 by bugdroid1@chromium.org, Nov 20

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/85cd2a967787690bf93c9159734b9e94ad25e852

commit 85cd2a967787690bf93c9159734b9e94ad25e852
Author: Robert Sesek <rsesek@chromium.org>
Date: Tue Nov 20 21:27:15 2018

Delete Cocoa message_center and switch to the Views version.

This also removes some now-unused Cocoa control classes in //ui/base and
several unneeded resources.

Bug: 739386, 832676
Change-Id: I9289cc5613c4303521aaed9271ddc7574e2611a0
Reviewed-on: https://chromium-review.googlesource.com/c/1343055
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609810}
[modify] https://crrev.com/85cd2a967787690bf93c9159734b9e94ad25e852/chrome/browser/ui/BUILD.gn
[delete] https://crrev.com/0fc5f9d3864137ca0063ab9665f59644f93427fa/chrome/browser/ui/cocoa/notifications/message_center_bridge.h
[delete] https://crrev.com/0fc5f9d3864137ca0063ab9665f59644f93427fa/chrome/browser/ui/cocoa/notifications/message_center_bridge.mm
[modify] https://crrev.com/85cd2a967787690bf93c9159734b9e94ad25e852/ui/base/BUILD.gn
[delete] https://crrev.com/0fc5f9d3864137ca0063ab9665f59644f93427fa/ui/base/cocoa/hover_button.h
[delete] https://crrev.com/0fc5f9d3864137ca0063ab9665f59644f93427fa/ui/base/cocoa/hover_button.mm
[delete] https://crrev.com/0fc5f9d3864137ca0063ab9665f59644f93427fa/ui/base/cocoa/hover_button_unittest.mm
[delete] https://crrev.com/0fc5f9d3864137ca0063ab9665f59644f93427fa/ui/base/cocoa/hover_image_button.h
[delete] https://crrev.com/0fc5f9d3864137ca0063ab9665f59644f93427fa/ui/base/cocoa/hover_image_button.mm
[delete] https://crrev.com/0fc5f9d3864137ca0063ab9665f59644f93427fa/ui/base/cocoa/hover_image_button_unittest.mm
[modify] https://crrev.com/85cd2a967787690bf93c9159734b9e94ad25e852/ui/message_center/BUILD.gn
[delete] https://crrev.com/0fc5f9d3864137ca0063ab9665f59644f93427fa/ui/message_center/cocoa/notification_controller.h
[delete] https://crrev.com/0fc5f9d3864137ca0063ab9665f59644f93427fa/ui/message_center/cocoa/notification_controller.mm
[delete] https://crrev.com/0fc5f9d3864137ca0063ab9665f59644f93427fa/ui/message_center/cocoa/notification_controller_unittest.mm
[delete] https://crrev.com/0fc5f9d3864137ca0063ab9665f59644f93427fa/ui/message_center/cocoa/opaque_views.h
[delete] https://crrev.com/0fc5f9d3864137ca0063ab9665f59644f93427fa/ui/message_center/cocoa/opaque_views.mm
[delete] https://crrev.com/0fc5f9d3864137ca0063ab9665f59644f93427fa/ui/message_center/cocoa/popup_collection.h
[delete] https://crrev.com/0fc5f9d3864137ca0063ab9665f59644f93427fa/ui/message_center/cocoa/popup_collection.mm
[delete] https://crrev.com/0fc5f9d3864137ca0063ab9665f59644f93427fa/ui/message_center/cocoa/popup_collection_unittest.mm
[delete] https://crrev.com/0fc5f9d3864137ca0063ab9665f59644f93427fa/ui/message_center/cocoa/popup_controller.h
[delete] https://crrev.com/0fc5f9d3864137ca0063ab9665f59644f93427fa/ui/message_center/cocoa/popup_controller.mm
[delete] https://crrev.com/0fc5f9d3864137ca0063ab9665f59644f93427fa/ui/message_center/cocoa/popup_controller_unittest.mm
[modify] https://crrev.com/85cd2a967787690bf93c9159734b9e94ad25e852/ui/message_center/test/run_all_unittests.cc
[delete] https://crrev.com/0fc5f9d3864137ca0063ab9665f59644f93427fa/ui/resources/default_100_percent/common/notification_close.png
[delete] https://crrev.com/0fc5f9d3864137ca0063ab9665f59644f93427fa/ui/resources/default_100_percent/common/notification_close_hover.png
[delete] https://crrev.com/0fc5f9d3864137ca0063ab9665f59644f93427fa/ui/resources/default_100_percent/common/notification_close_pressed.png
[delete] https://crrev.com/0fc5f9d3864137ca0063ab9665f59644f93427fa/ui/resources/default_100_percent/common/notification_settings_button.png
[delete] https://crrev.com/0fc5f9d3864137ca0063ab9665f59644f93427fa/ui/resources/default_100_percent/common/notification_settings_button_hover.png
[delete] https://crrev.com/0fc5f9d3864137ca0063ab9665f59644f93427fa/ui/resources/default_100_percent/common/notification_settings_button_pressed.png
[delete] https://crrev.com/0fc5f9d3864137ca0063ab9665f59644f93427fa/ui/resources/default_100_percent/win/notification_close.png
[delete] https://crrev.com/0fc5f9d3864137ca0063ab9665f59644f93427fa/ui/resources/default_100_percent/win/notification_close_hover.png
[delete] https://crrev.com/0fc5f9d3864137ca0063ab9665f59644f93427fa/ui/resources/default_100_percent/win/notification_close_pressed.png
[delete] https://crrev.com/0fc5f9d3864137ca0063ab9665f59644f93427fa/ui/resources/default_200_percent/common/notification_close.png
[delete] https://crrev.com/0fc5f9d3864137ca0063ab9665f59644f93427fa/ui/resources/default_200_percent/common/notification_close_hover.png
[delete] https://crrev.com/0fc5f9d3864137ca0063ab9665f59644f93427fa/ui/resources/default_200_percent/common/notification_close_pressed.png
[delete] https://crrev.com/0fc5f9d3864137ca0063ab9665f59644f93427fa/ui/resources/default_200_percent/common/notification_settings_button.png
[delete] https://crrev.com/0fc5f9d3864137ca0063ab9665f59644f93427fa/ui/resources/default_200_percent/common/notification_settings_button_hover.png
[delete] https://crrev.com/0fc5f9d3864137ca0063ab9665f59644f93427fa/ui/resources/default_200_percent/common/notification_settings_button_pressed.png
[delete] https://crrev.com/0fc5f9d3864137ca0063ab9665f59644f93427fa/ui/resources/default_200_percent/win/notification_close.png
[delete] https://crrev.com/0fc5f9d3864137ca0063ab9665f59644f93427fa/ui/resources/default_200_percent/win/notification_close_hover.png
[delete] https://crrev.com/0fc5f9d3864137ca0063ab9665f59644f93427fa/ui/resources/default_200_percent/win/notification_close_pressed.png
[modify] https://crrev.com/85cd2a967787690bf93c9159734b9e94ad25e852/ui/resources/ui_resources.grd

Project Member

Comment 109 by bugdroid1@chromium.org, Nov 21

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1fee19551261812c133c3e7423ce5d8801b9a163

commit 1fee19551261812c133c3e7423ce5d8801b9a163
Author: Robert Sesek <rsesek@chromium.org>
Date: Wed Nov 21 15:00:00 2018

mac: Delete unused resources from //ui/resources

Bug: 832676
Change-Id: I2e7c0352514c3ba46b44f17b65dce370b945ac15
Reviewed-on: https://chromium-review.googlesource.com/c/1344995
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610052}
[modify] https://crrev.com/1fee19551261812c133c3e7423ce5d8801b9a163/ui/base/cocoa/menu_controller_unittest.mm
[delete] https://crrev.com/dda84a41a0fde29418aef182419a471ba6c3c7b6/ui/resources/default_100_percent/common/menu_hierarchy_arrow.png
[delete] https://crrev.com/dda84a41a0fde29418aef182419a471ba6c3c7b6/ui/resources/default_100_percent/common/menu_overflow_down.png
[delete] https://crrev.com/dda84a41a0fde29418aef182419a471ba6c3c7b6/ui/resources/default_100_percent/common/menu_overflow_up.png
[delete] https://crrev.com/dda84a41a0fde29418aef182419a471ba6c3c7b6/ui/resources/default_100_percent/legacy/throbber.png
[delete] https://crrev.com/dda84a41a0fde29418aef182419a471ba6c3c7b6/ui/resources/default_200_percent/common/menu_hierarchy_arrow.png
[delete] https://crrev.com/dda84a41a0fde29418aef182419a471ba6c3c7b6/ui/resources/default_200_percent/common/menu_overflow_down.png
[delete] https://crrev.com/dda84a41a0fde29418aef182419a471ba6c3c7b6/ui/resources/default_200_percent/common/menu_overflow_up.png
[delete] https://crrev.com/dda84a41a0fde29418aef182419a471ba6c3c7b6/ui/resources/default_200_percent/legacy/throbber.png
[modify] https://crrev.com/1fee19551261812c133c3e7423ce5d8801b9a163/ui/resources/ui_resources.grd

Comment 110 by ellyjo...@chromium.org, Jan 9

Status: Fixed (was: Assigned)

I'm calling this Fixed. There is ~25kloc left in c/b/ui/cocoa, but most of it is necessary platform integration stuff: AppleScript, various odds and ends of Cocoa UI that we want to keep in Cocoa (first run, task manager for now, renderer context menus), notifications, and share integration.

Showing comments 11 - 110 of 110 Older ›

►

Issue 832676 link

Issue metadata

macviews: remove cocoa browser UI code

Issue description

Comment 11 by bugdroid1@chromium.org, Jul 24

Comment 11 Deleted

Comment 12 by bugdroid1@chromium.org, Jul 24

Comment 12 Deleted

Comment 13 by bugdroid1@chromium.org, Jul 24

Comment 13 Deleted

Comment 14 by bugdroid1@chromium.org, Jul 24

Comment 14 Deleted

Comment 15 by bugdroid1@chromium.org, Jul 30

Comment 15 Deleted

Comment 16 by ellyjo...@chromium.org, Aug 2

Comment 16 Deleted

Comment 17 by bugdroid1@chromium.org, Aug 14

Comment 17 Deleted

Comment 18 by bugdroid1@chromium.org, Aug 16

Comment 18 Deleted

Comment 19 by bugdroid1@chromium.org, Aug 17

Comment 19 Deleted

Comment 20 by bugdroid1@chromium.org, Aug 28

Comment 20 Deleted

Comment 21 by bugdroid1@chromium.org, Aug 29

Comment 21 Deleted

Comment 22 by bugdroid1@chromium.org, Sep 6

Comment 22 Deleted

Comment 23 by bugdroid1@chromium.org, Sep 7

Comment 23 Deleted

Comment 24 by bugdroid1@chromium.org, Sep 19

Comment 24 Deleted

Comment 25 by bugdroid1@chromium.org, Sep 20

Comment 25 Deleted

Comment 26 by bugdroid1@chromium.org, Sep 20

Comment 26 Deleted

Comment 27 by thakis@chromium.org, Sep 20

Comment 27 Deleted

Comment 28 by bugdroid1@chromium.org, Sep 20

Comment 28 Deleted

Comment 29 by bugdroid1@chromium.org, Sep 21

Comment 29 Deleted

Comment 30 by bugdroid1@chromium.org, Sep 21

Comment 30 Deleted

Comment 31 by bugdroid1@chromium.org, Sep 21

Comment 31 Deleted

Comment 32 by bugdroid1@chromium.org, Sep 21

Comment 32 Deleted

Comment 33 by bugdroid1@chromium.org, Sep 21

Comment 33 Deleted

Comment 34 by bugdroid1@chromium.org, Sep 22

Comment 34 Deleted

Comment 35 by bugdroid1@chromium.org, Sep 22

Comment 35 Deleted

Comment 36 by bugdroid1@chromium.org, Sep 22

Comment 36 Deleted

Comment 37 by bugdroid1@chromium.org, Sep 23

Comment 37 Deleted

Comment 38 by bugdroid1@chromium.org, Sep 23

Comment 38 Deleted

Comment 39 by bugdroid1@chromium.org, Sep 23

Comment 39 Deleted

Comment 40 by bugdroid1@chromium.org, Sep 24

Comment 40 Deleted

Comment 41 by bugdroid1@chromium.org, Sep 24

Comment 41 Deleted

Comment 42 by bugdroid1@chromium.org, Sep 24

Comment 42 Deleted

Comment 43 by bugdroid1@chromium.org, Sep 24

Comment 43 Deleted

Comment 44 by bugdroid1@chromium.org, Sep 24

Comment 44 Deleted

Comment 45 by bugdroid1@chromium.org, Sep 24

Comment 45 Deleted

Comment 46 by bugdroid1@chromium.org, Sep 24

Comment 46 Deleted

Comment 47 by bugdroid1@chromium.org, Sep 24

Comment 47 Deleted

Comment 48 by bugdroid1@chromium.org, Sep 24

Comment 48 Deleted